ElyOffice/tasks/reviews/R3.1-r2.md

FAIL

1. [P2] apps/ely-pdf/src/tests/sign.rs:139 — `save_signed_as` expects the simplified path from `dunce::canonicalize`, but the round-2 fix deliberately restores `ely_files::save_as` to retain the extended path in `Saved.path` and the session, including after reopening. Its literal path comparison at line 144 therefore never succeeds for an ordinary Windows `copy.pdf`. Rebuilt and ran the tests: `a_signed_file_saved_as_a_copy_reopens_as_the_copy` and `signing_after_save_as_signs_the_copy` both time out in this helper; an isolated rerun confirms the same failure. A probe against the rebuilt library confirms path equality is false while `same_file` is true. Make the expected path use the same canonical representation as the session, or compare file identity, while retaining the reopen, content and signature assertions and the long-path I/O fix. Evidence: `.work/R3.1-r2-pdf-sign.log`, `.work/R3.1-r2-pdf-reopen.log`, `.work/R3.1-r2-probe.log`.
	`FAIL`

	1. [P2] apps/ely-pdf/src/tests/sign.rs:139 — `save_signed_as` expects the simplified path from `dunce::canonicalize`, but the round-2 fix deliberately restores `ely_files::save_as` to retain the extended path in `Saved.path` and the session, including after reopening. Its literal path comparison at line 144 therefore never succeeds for an ordinary Windows `copy.pdf`. Rebuilt and ran the tests: `a_signed_file_saved_as_a_copy_reopens_as_the_copy` and `signing_after_save_as_signs_the_copy` both time out in this helper; an isolated rerun confirms the same failure. A probe against the rebuilt library confirms path equality is false while `same_file` is true. Make the expected path use the same canonical representation as the session, or compare file identity, while retaining the reopen, content and signature assertions and the long-path I/O fix. Evidence: `.work/R3.1-r2-pdf-sign.log`, `.work/R3.1-r2-pdf-reopen.log`, `.work/R3.1-r2-probe.log`.