29 lines
3.1 KiB
Markdown
29 lines
3.1 KiB
Markdown
FAIL
|
|
|
|
Checked: `cargo check --workspace`, `cargo clippy --workspace --all-targets` (clean), `cargo test --workspace` (3 passed), `cargo fmt --check` (clean), `tests/scripts/apps-start.sh` (8 of 8 pass), `tests/scripts/agents_md.py` (pass). Every file is under 500 lines and every comment is within limits. All eight app manifests match and inherit the AGPL license from the workspace.
|
|
|
|
1. crates/ely-platform/src/logging.rs:10 (and Cargo.toml:21,25, crates/ely-platform/Cargo.toml:12-13)
|
|
What is wrong: logging is built on `log` + `env_logger`. agents.md:90 (rule 4) requires `tracing`.
|
|
Failing scenario: a later task follows rule 4 and writes `tracing::info!` or a `tracing` span on a critical path, such as a LOK worker start. No `tracing` subscriber is installed, so the record is dropped without any error. It reaches neither stderr nor `ely-<app>.log`.
|
|
Direction: install a `tracing-subscriber` filtered by `ELY_LOG` that writes to the same file and stderr, and bridge gpui's `log` records into it (`tracing-log`). The other option is to change rule 4 in agents.md to `log`. Code and rule must agree.
|
|
|
|
2. crates/ely-ui/src/shell.rs:25
|
|
What is wrong: the outer `div()` exists only to carry `debug_selector("shell")`. That call does nothing unless gpui is built with `test`/`test-support` (gpui div.rs:887-894), and nothing in the repo queries "shell". The result is dead code plus a box inside a box around the `FocusScope` root.
|
|
Failing scenario: a release or normal debug build gets an extra full-size layout node that does nothing. Searching `crates apps tests scripts` for "shell" turns up no reader of the selector.
|
|
Direction: remove the wrapper and the selector, and return the `FocusScope` root directly.
|
|
|
|
3. crates/ely-ui/src/shell.rs:34
|
|
What is wrong: the only content is an `h1` with the app name, which already appears in the window title (run.rs:28). agents.md rule 7 forbids useless titles and text.
|
|
Failing scenario: opening ElyDoc shows "ElyDoc" in the title bar and again as a large heading in the middle of the window. The heading adds no information.
|
|
Direction: drop the heading and leave the themed content area empty until a later task gives it real content.
|
|
|
|
4. Cargo.toml:28-29
|
|
What is wrong: `unexpected_cfgs` declares `check-cfg` for `feature = "cargo-clippy"`, but no crate in the workspace uses `cfg(feature = "cargo-clippy")`. This is dead configuration.
|
|
Failing scenario: removing the two lines leaves `cargo check` and `cargo clippy` output unchanged.
|
|
Direction: delete the `[workspace.lints.rust]` entry.
|
|
|
|
5. tests/scripts/apps-start.sh:17
|
|
What is wrong: the script sandboxes only `HOME`. `directories::BaseDirs::data_local_dir` uses `$XDG_DATA_HOME` first on Linux, which PRD §4.1 lists as a target.
|
|
Failing scenario: on a Linux machine or CI runner with `XDG_DATA_HOME` set, the eight apps append to the developer's real `$XDG_DATA_HOME/ElyOffice/logs`. `find "$work"` at line 20 finds nothing, so the script reports "wrote no log file" even though logging works.
|
|
Direction: point `XDG_DATA_HOME` at the temp dir (or unset it) for each app run, as is done for `HOME`.
|