Files
ElyOffice/tasks/reviews/C05.2-r2.md
T

6 lines
1.2 KiB
Markdown
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
FAIL
tests/scripts/shell.sh:24:上一轮第 2 项的布局验证仍有缺口。新增探针用 `is_focused` 判断区域显隐,缺少侧栏和内容区的实际宽度断言。已在临时副本验证:删除左右侧栏的变异会使脚本失败;将 `crates/ely-ui/src/shell/panel.rs:100` 的空视图分支改为 `return div().flex_none().w(cx.theme().sidebar_width(false)).h_full().into_any_element();`,使 page two 收起属性内容后仍保留完整空栏,重跑脚本却以退出码 0 输出成功。这使 PRD §5.2“无内容的侧栏不占位”的核心回归继续漏检。修复方向:断言左右侧栏有/无内容时的实际布局边界,以及 one → two → one 转场结束后的侧栏宽度和内容区宽度,确保空栏占位变异触发失败。
crates/ely-ui/src/shell/mod.rs:24:上一轮第 3 项的多行注释仍保留。第 24–25 行组成两行文档注释,`crates/ely-ui/src/run.rs:13–14` 同样如此,违反 agents.md 的单行注释规则。当前 `python3 tests/scripts/comments.py` 返回退出码 0,因为它只统计每行词数,漏掉连续文档注释。修复方向:将这两处必要注释各压缩为一行且最多十词,并补充多行文档注释的检查。