Files
ElyOffice/tasks/reviews/C19.1-r3.md
T

8 lines
2.4 KiB
Markdown

FAIL
tests/scripts/ooxml.py:107 — The comment-anchor check verifies text before the reference while ignoring the comment's range markers. In the DOCX generated by `a_docx_keeps_text_comments_and_tracking_across_sessions`, insert `<w:commentRangeStart w:id="0"/>` immediately before the insertion containing `Gamma `, and `<w:commentRangeEnd w:id="0"/>` immediately before the existing reference run after `Alpha 甲 `. Both `ooxml.py contract` and `ooxml.py selftest contract` exit 0. Reopening with the freshly built worker and exporting FODT confirms that the original point comment after `Alpha 甲` becomes a range spanning `Gamma Alpha 甲`: the annotation starts before Gamma and ends after Alpha. This misses changed comment attachment under PRD §19.2. Fix direction: resolve reference and range markers together by comment ID, assert this fixture retains its point anchor, and add the range mutation to rejection selftests.
tests/scripts/ooxml.py:98 — Revision verification covers Beta while Gamma from the second editing session is checked only as ordinary document text. In the generated DOCX, remove the opening and closing `w:ins` tags around the run containing `Gamma `, retaining that run, Beta's insertion and the enabled tracking setting. Both `ooxml.py contract` and `ooxml.py selftest contract` exit 0. Worker reopen and FODT export confirm that the revision count falls from two to one and Gamma becomes ordinary text. The test therefore accepts lost second-session revision metadata covered by PRD §19.2 and the documented tracked-insertion preservation claim. Fix direction: verify the expected tracked text from both editing sessions and require the Gamma-wrapper removal to fail.
tests/scripts/ooxml.py:200 — Notes verification concatenates every DrawingML text node in the notes part, accepting speaker text in a footer as preserved editable notes. In the generated PPTX, change `<p:ph type="body"/>` to `<p:ph type="ftr"/>` in `ppt/notesSlides/notesSlide1.xml`, leaving the text and relationships intact. Both `ooxml.py deck` and `ooxml.py selftest deck` exit 0. Reopening with the freshly built worker reports first-slide `.uno:SlideNotes` as `editable: false, text: ""`; the original reports `editable: true, text: "Speaker 甲"`. This misses loss of the actual notes body and its editability under PRD §19.2. Fix direction: check speaker text in the owning slide's notes-body placeholder and add this placeholder mutation to rejection selftests.