Files
ElyOffice/tasks/reviews/R7.7-r2.md
T
ZacharyZhang-NYandClaude Opus 5.5 aae000247d R7.7: one source archive pair per release
Windows checks out symlinks as files, so only Linux (CI) and macOS
(release.sh) write source archives. ci.sh skips names already on
the release; the first platform's copy stays.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-16 18:34:27 -04:00

6 lines
1.2 KiB
Markdown

FAIL
scripts/ci.sh:94 — Rerunning a partially uploaded macOS release can publish update manifests with incorrect hashes. The script deletes `dist` and rebuilds before this name-only skip. If the first run uploads the DMGs but fails before uploading `ely-doc.json`, the rerun retains the first build's DMGs and uploads manifests hashing the rebuilt, newly signed DMGs. A WSL probe using unchanged `ci.sh` and `packaging/macos/release.sh`, with local packaging-tool and curl stubs, reproduced an initial exit 22 followed by exit 0 and six mismatched manifest hashes (`.work/R7.7-r2/ci-resume-real-release.log`). Update downloads then fail hash verification, breaking PRD §4.2. Resume the original artifacts or generate missing manifests from the retained release artifacts, and add a regression for an interrupted upload followed by a rebuild with different bytes.
tests/scripts/ci-upload.sh:34 — The new comment “A clone whose packaging writes one package and the source pair.” contains eleven words, violating the explicit ten-word rule. Running `tests/scripts/comments.py` against this tree exits 1 and identifies this line (`.work/R7.7-r2/comments.log`). Shorten the comment to ten words or fewer.