Files
ElyOffice/tasks/reviews/C12.8-r2.md
T

4 lines
1009 B
Markdown

FAIL
- [P1] apps/ely-mail/src/syncing.rs:56 — Sync invocation numbers repeat after `stop_sync` removes the entry. During an account's first sync, a synchronous credential read can block; removing the account aborts that task and discards its `Syncing`, but a refused credential deletion restarts syncing with `run = 1` again. If the original credential read subsequently returns an error, its already-running poll completes normally despite the abort. Its completion passes the generation check, clears the replacement task's handle, and makes Pause leave that network task running. A probe through the actual `remove` failure path reproduced `retained=false, cancelled=false` (.work/C12.8-r2-removal-probe.log); allocating invocation numbers across entry recreation made the same probe pass. Keep invocation numbers unique across `stop_sync` and entry recreation, and add a regression covering a late completion after failed removal. The new pause/resume test retains the same entry and misses this case.