ZacharyZhang-NYandClaude Opus 5.5
4183f729d1
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
12 lines
2.5 KiB
Markdown
12 lines
2.5 KiB
Markdown
FAIL
|
|
|
|
1. ../Ely-GPUI-Components/src/documents/tree.rs:70 — Reference definitions are collected only from root children, although markdown-rs resolves references against definitions nested anywhere. Rendering `[site]\n\n> [site]: https://ely.dev\n` (also with a list instead of the quote) panics at `Reader::url` with “a reference names a definition”; `outline` also calls this parser. Recursively collect definitions in document order before reading blocks, keeping the first definition, and test nested link/image definitions. Both probes fail at fcad0ff and pass at its parent; see `.work/c14.1-probes.log` and `.work/c14.1-baseline-probes.log`.
|
|
|
|
2. ../Ely-GPUI-Components/src/documents/tree.rs:213 — Images inside inline containers silently become their alt text. For `**`, parsing returns an emphasized paragraph containing `alt` and no image, whereas the parent commit produces an image. This breaks CommonMark image rendering (MARK-03); linked images have the same loss. Handle images recursively through emphasis, strong and link containers instead of replacing them with text, with regression tests.
|
|
|
|
3. ../Ely-GPUI-Components/src/documents/tree.rs:205 — Soft breaks replace only LF, leaving CR from Windows line endings in displayed text. `one\r\ntwo` becomes `one\r two`, and `one\rtwo` remains unchanged, instead of the CommonMark soft-break result `one two`. Normalize CRLF and standalone CR soft breaks as well, preserving hard-break and code semantics, and test all three line-ending forms. Both probes pass on the parent and fail at fcad0ff (`.work/c14.1-probes.log`), contradicting the documented soft-break behavior and PRD §14.3.
|
|
|
|
4. ../Ely-GPUI-Components/src/documents/markdown.rs:96 — The highlighter handles `Link` but omits markdown-rs `LinkReference`, regressing reference-link styling. For `[site]\n\n[site]: https://ely.dev\n`, `marks` now returns no link mark; the parent styles `[site]` as a link. Handle full, collapsed and shortcut reference links and their syntax spans, and add assertions for them. The reference-link probe fails only at fcad0ff; the existing 1731 library tests all pass and miss this case (`.work/c14.1-tests-retry.log`).
|
|
|
|
5. ../Ely-GPUI-Components/src/documents/markdown.rs:9 — Four added comments exceed the explicit ten-word limit: this line has 11 words, markdown.rs:188 has 13, tree.rs:98 has 12, and tree.rs:159 has 15. Counting the added comments reproduces the rule violation (`.work/c14.1-comments.log`). Shorten or remove these comments.
|