6 lines
1.8 KiB
Markdown
6 lines
1.8 KiB
Markdown
FAIL
|
|
|
|
apps/ely-doc/src/review.rs:372 — The unreadable-note line omits the author and parsing reason required by D-04, and collapses all affected notes into the first raw timestamp. `threads()` stores `(note.at, error)` at line 400; rendering discards `error` and uses only `.first()`. Reproduced in the built native app with a DOCX containing a dated ValidAuthor note, undated MissingDateAuthor and OtherMissingAuthor notes, and one tracked insertion: the normal note and change remain, but the entire error display is `Comments with unreadable times: 2, first 0-00-00`. Neither affected author nor either reason appears. Preserve each failed note's author and reason and render its required InlineMessage line; keep the missing time explicit. Extend the regression to assert those displayed values and retention of changes through the refresh path: both existing review tests pass despite this failure. Builds of ely-lok workers and ely-doc passed; five i18n tests also passed. Native evidence: /tmp/ely-d04-r1-logs/verification.log.
|
|
|
|
apps/ely-doc/src/review.rs:374 — The new error display is absent from the system accessibility tree, violating PRD UX-12. In the same native fixture, `tests/scripts/ax-values.swift` exposes `ValidAuthor: Valid note body`, the tracked insertion, ChangeAuthor, and Accept/Reject controls, while the visibly rendered unreadable-time line and its `0-00-00` text are entirely absent. The pinned InlineMessage implementation renders plain div/text children without accessibility semantics, and this call supplies no accessible wrapper. Expose the line through a stable element id, an alert role, and its full localized accessible name, and verify the actual AX text with an unreadable-note fixture. Evidence: /tmp/ely-d04-r1-logs/ax-comments.log and /tmp/ely-d04-r1-logs/ax-changes.log.
|