Files
ElyOffice/tasks/reviews/C14.6-r1.md
T

6 lines
1.3 KiB
Markdown

FAIL
1. `reference/Ely-GPUI-Components/src/documents/document/mod.rs:171` — Entering visual mode does not open the empty document's input when its focus handle is already focused. Preview and visual share that handle, so `window.focus` triggers no new focus callback. Create an empty document, press Ctrl+3 then Ctrl+1, and type `Hi`: the document remains empty. The same GPUI probe fails on Windows and WSL (`.work/C14.6-r1-windows-probes.log`, `.work/C14.6-r1-probes.log`). Ensure mode entry opens the empty visual input even when focus does not change, and test this round trip.
2. `reference/Ely-GPUI-Components/src/documents/document/visual.rs:161` — The shared document's undo/redo handlers do not receive the open block input's undo/redo actions. The new empty-document focus behavior immediately opens a `TextInput`, whose local history consumes Ctrl+Z even when it has no undo entry. Open `Seed`, switch to source, select all and delete, switch to visual, then undo: the document stays empty instead of restoring `Seed`, violating cross-mode undo (§14.3, C14.6). This fails on both Windows and WSL in the same probe logs. Route undo/redo from the open input to the shared document history at the appropriate history boundary, and add this regression to the cross-mode tests.