Files
ElyOffice/tasks/reviews/C14.16-r1.md
T

6 lines
1.9 KiB
Markdown
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
FAIL
- reference/Ely-GPUI-Components/src/typography/math.rs:183 (50a59d2; shared options in documents/diagram.rs) — Loading system fonts does not make the sizing parser resolve fonts like GPUI's SVG renderer. On WSL, installed Droid Sans Fallback can draw `\text{中文}`, but the sizing parser cannot resolve `sans-serif` and omits its ink. The formula succeeds with a 32 × 14.72 frame that clips the displayed text: the exact-source raster probe retains 7,488 ink pixels, versus 8,169 with an expanded viewport. The existing Chinese outline/export test also incorrectly reports unavailable glyphs. Configuring installed generic families in the probe copy produces a 41.42 × 21.71 frame, retains all 8,169 pixels, and passes the export test. Align measurement and export font resolution with rendering, and test fallback text using resolved fonts or raster pixels; `every_glyph_lies_inside_the_picture` currently reparses with fontless default options and misses this clipping. Evidence: `.work/C14.16-r1/library-frame-probe.log`, `library-frame-generic-probe.log`, `library-tests.log`, `linux-chinese-fonts.log`, and `probe-source.log`.
- apps/ely-mark/src/vcs.rs:200 (also :217) — Both new fixtures inherit the user's commit-signing configuration. With `commit.gpgsign=true` and no available signing program/key, their initial commits fail before any status assertion. Native Windows reproduces both failures because bundled MinGit cannot spawn `gpg`; Linux reproduces the same failure with signing enabled and an unavailable `gpg.program`, so this is independent of W-02's checkout/path failures. Disable signing explicitly for fixture commits or isolate their Git configuration. With signing disabled in the test process, all 94 Windows tests pass; isolated Linux tests pass 96/96. Evidence: `.work/C14.16-r1/windows-tests.log`, `signing-probe.log`, `linux-signing.log`, `windows-isolated.log`, and `linux-isolated.log`.