Files
ElyOffice/tasks/reviews/R6.7-r2.md
T
ZacharyZhang-NYandClaude Opus 5.5 16a6390eeb R6.7 round 2 fix: a kept CRLF reads back char for char
Pins component 26af4be.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-15 13:28:25 -04:00

4 lines
940 B
Markdown

FAIL
- C:/Users/zhang/Documents/Github/Ely-GPUI-Components/src/documents/tree/sources.rs:325: The new mapping consumes both source CRLF characters when matching LF even when the drawn text retains both characters, as multiline inline code does. Open `` `one\r\ntwo`\n `` in visual mode, click before `n` in `one`, type `X`, then press Escape: the caret lands at byte 1 and saves `` `Xone\r\ntwo`\n `` instead of byte 2 and `` `oXne\r\ntwo`\n ``. After consuming CR with LF, the remaining drawn CR cannot align, so earlier characters fall back to the piece's start. The GPUI click/type/commit probe fails on c31d092 and passes with only sources.rs restored from its parent. Coalesce CRLF only when the drawn text collapses that pair; preserve character mapping when both characters remain, and add this regression case alongside the fixed plain-paragraph case. Evidence: `.work/R6.7-r2-review/probes.log`, `inline-code-parent-control.log`.