Files
ElyOffice/tasks/reviews/R6.9-r1.md
T
2026-10-15 14:57:19 -04:00

6 lines
1.3 KiB
Markdown

FAIL
C:/Users/zhang/Documents/Github/Ely-GPUI-Components/src/documents/render.rs:248 — The new heading weight BOLD (700) is overridden by `Draw::inline`'s `Style::Strong`, which still forces SEMIBOLD (600) at line 141. Rendering `### Plain **Strong** Plain` with Segoe UI on Windows produces weights 700/600/700: applying bold inside a heading makes that text lighter, violating R6.9's requirement that headings be bold throughout. Make Strong preserve or increase the inherited heading weight and cover mixed plain/strong headings with a regression test. Reproduced with native DirectWrite shaping in `.work/R6.9-r1-review/review_strong_headings_keep_bold-refined.log`.
C:/Users/zhang/Documents/Github/Ely-GPUI-Components/src/documents/render/tests.rs:77 — The regression test checks only container heights, which vary independently through `line_height(size * 1.3)`. Deleting the heading's `.text_size(size)` makes every level inherit the body font size, including identical H3/H4 text, yet this test still passes. The independent native font-size probe fails on that mutation. Assert the actual shaped font sizes against the required ratios for all six levels, including changed body size and zoom. Evidence: `.work/R6.9-r1-review/mutant-existing-test.log` and `mutant-shape-probe.log`.