Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
cb4c2eaad9 | ||
|
|
cfde4e91a1 | ||
|
|
5082bd47ee | ||
|
|
5d70140d62 | ||
|
|
299c6bcfcb | ||
|
|
6be9ab0aea | ||
|
|
0e4e446fe4 | ||
|
|
008b6623f6 | ||
|
|
f8cd33d19d | ||
|
|
2e40ebb08b | ||
|
|
fcb7588312 | ||
|
|
9ab038f573 | ||
|
|
dd5711f24f | ||
|
|
a690987ea2 | ||
|
|
95d4f19650 | ||
|
|
99e09cfaf5 | ||
|
|
0c580afb5f | ||
|
|
c61977cb70 | ||
|
|
781fb44659 | ||
|
|
a640816c38 | ||
|
|
256ff2528e | ||
|
|
2820dd5f2b | ||
|
|
11b5a47ef0 | ||
|
|
bc93b540cd | ||
|
|
0189009822 | ||
|
|
206711bed5 | ||
|
|
443de79e2f | ||
|
|
be0983237e | ||
|
|
3ccb6e5e91 | ||
|
|
0fb971e9aa | ||
|
|
a2ad08fb52 | ||
|
|
b9ca80e801 | ||
|
|
5f249ba6ca | ||
|
|
d331b0b2a3 | ||
|
|
09867915ef | ||
|
|
edce333620 | ||
|
|
d1c29a576c | ||
|
|
17d4ba08f9 | ||
|
|
901203c2b2 | ||
|
|
d8609267a1 | ||
|
|
a7b8438881 | ||
|
|
584d0fb77e | ||
|
|
4512df79e6 | ||
|
|
91f14112bf | ||
|
|
fc7113ba3c | ||
|
|
00a5e318bb | ||
|
|
017a570d7d | ||
|
|
63d26d4a3e | ||
|
|
5f7416f3ef | ||
|
|
fb3fe89d33 | ||
|
|
aa9a5dbe72 | ||
|
|
7a60cd42ac | ||
|
|
97c934a647 | ||
|
|
cadc46f5dc | ||
|
|
b957e12370 | ||
|
|
ff92a00fea |
No files matched your search
@@ -17,11 +17,37 @@ import) or any `KIMI_*` env var.
|
|||||||
Upstream sync record (update on every sync): fork baseline is upstream
|
Upstream sync record (update on every sync): fork baseline is upstream
|
||||||
snapshot `8adf901` (2026-07-16, ≈v0.2.102); bug fixes evaluated and
|
snapshot `8adf901` (2026-07-16, ≈v0.2.102); bug fixes evaluated and
|
||||||
selectively ported through upstream `77cd7eb` (2026-08-25, ≈v1.0.10) in
|
selectively ported through upstream `77cd7eb` (2026-08-25, ≈v1.0.10) in
|
||||||
the 0.1.13 cycle. Upstream is daily "Synced from monorepo" snapshots —
|
the 0.1.13 cycle, through `3794978` (2026-09-09, ≈v1.0.24) in the 0.1.15
|
||||||
|
cycle, and through `a28ee2b` (2026-09-17, ≈v1.0.35) in the 0.1.16 cycle.
|
||||||
|
Upstream is daily "Synced from monorepo" snapshots —
|
||||||
the commit BODIES carry per-change bullet lists, and
|
the commit BODIES carry per-change bullet lists, and
|
||||||
`crates/codegen/xai-grok-shell/changelogs/` maps releases to dates;
|
`crates/codegen/xai-grok-shell/changelogs/` maps releases to dates;
|
||||||
start any future sync from those two, not from raw diffs.
|
start any future sync from those two, not from raw diffs.
|
||||||
|
|
||||||
|
Known limitations left by the 0.1.15 sync (fix before relying on them):
|
||||||
|
the Windows frame writer writes through `std::io::stderr`, so a console
|
||||||
|
that stops reading still blocks exit-path prints behind std's stderr lock
|
||||||
|
(unix silences fd 2 after a timed-out writer join); the bwrap command
|
||||||
|
builder re-checks `Path::exists("/data")` and can omit the devbox bind on
|
||||||
|
a stat error that the profile classification treated as present.
|
||||||
|
|
||||||
|
Known limitation left by the 0.1.16 sync: `notifications/cancelled` for a
|
||||||
|
timed-out MCP call cannot reach a streamable-HTTP server that answers
|
||||||
|
`tools/call` with a plain JSON body. rmcp 2.2.0's HTTP worker awaits each
|
||||||
|
POST in turn, so the cancel queues behind the hung call;
|
||||||
|
`servers/cancel_aware.rs` waits 500 ms, warns, and the transport reset
|
||||||
|
then drops the connection. stdio and SSE-mode servers get the cancel.
|
||||||
|
The cure is rmcp 3.x (upstream runs 3.2), a major bump not yet taken.
|
||||||
|
|
||||||
|
Evaluated in the 0.1.16 window and left for a later cycle: MCP qualified
|
||||||
|
tool names past 64 chars (first prove the name never reaches a provider
|
||||||
|
function list), the auto-update guard for a binary still in use (needs
|
||||||
|
per-OS process scans), the DA1 fence around the kitty keyboard pop (needs
|
||||||
|
a design against the 0.1.15 teardown), MCP servers on protocol 2026-07-28
|
||||||
|
(rmcp 3.x again), and `pager.toml`, whose writer in
|
||||||
|
`kigi-pager-render/src/appearance/config.rs` still ends in a bare
|
||||||
|
`fs::rename` and replaces a symlink.
|
||||||
|
|
||||||
## Hard constraints
|
## Hard constraints
|
||||||
|
|
||||||
- **Zero egress**: only `auth.kimi.com`, `api.kimi.com`, `api.moonshot.cn`,
|
- **Zero egress**: only `auth.kimi.com`, `api.kimi.com`, `api.moonshot.cn`,
|
||||||
@@ -48,6 +74,15 @@ start any future sync from those two, not from raw diffs.
|
|||||||
switch that never stuck). Plain rename stays correct only for true moves
|
switch that never stuck). Plain rename stays correct only for true moves
|
||||||
whose destination doesn't pre-exist (worktree-pool markers, corrupt-file
|
whose destination doesn't pre-exist (worktree-pool markers, corrupt-file
|
||||||
backups). Write failures must at least `warn!` — never `let _ =`.
|
backups). Write failures must at least `warn!` — never `let _ =`.
|
||||||
|
- **config.toml writers resolve their destination through
|
||||||
|
`util::config::config_write_dest` before they name the tmp file.** A
|
||||||
|
symlinked `~/.kigi/config.toml` (dotfiles) keeps its link: the tmp sits
|
||||||
|
beside the referent and replaces it. Only that one path is followed, and
|
||||||
|
only while `user_kigi_home()` resolves (with no home, `kigi_home()` is the
|
||||||
|
project's own `./.kigi`). A project `.kigi/config.toml` is
|
||||||
|
repo-controlled, and following its symlink would overwrite whatever file
|
||||||
|
a hostile repo points it at; there the link itself is replaced.
|
||||||
|
Credential and managed stores never follow symlinks.
|
||||||
- The root `Cargo.toml` is hand-maintained (upstream's generator is not in
|
- The root `Cargo.toml` is hand-maintained (upstream's generator is not in
|
||||||
this repo). Members sorted; versions inherited from
|
this repo). Members sorted; versions inherited from
|
||||||
`workspace.package.version` — the single source of truth for the release
|
`workspace.package.version` — the single source of truth for the release
|
||||||
@@ -81,6 +116,24 @@ start any future sync from those two, not from raw diffs.
|
|||||||
- Graph node worktrees are removed right after a successful merge-back;
|
- Graph node worktrees are removed right after a successful merge-back;
|
||||||
only FAILED nodes keep theirs for postmortem.
|
only FAILED nodes keep theirs for postmortem.
|
||||||
|
|
||||||
|
## Terminal keyboard
|
||||||
|
|
||||||
|
`Shift+Enter` inserts a newline in the prompt wherever the terminal can
|
||||||
|
report the modifier, and `kitty_skip_reason` decides where that is —
|
||||||
|
`shift_enter_unavailable` matches on it rather than keeping a second brand
|
||||||
|
list, because the two drifted once and the UI advertised a chord that never
|
||||||
|
arrived. Two skips still deliver the modifier: Apple Terminal, where
|
||||||
|
`route_enter` polls CoreGraphics, and Windows Terminal, where the console
|
||||||
|
key record carries SHIFT with no protocol at all (a bare ConHost is only
|
||||||
|
optimistically refined to Windows Terminal, so it keeps advertising
|
||||||
|
Alt+Enter). Everywhere else — VTE, xterm.js, JediTerm, screen, tmux below
|
||||||
|
3.3, tmux with `extended-keys off` — the byte on the wire is a plain CR and
|
||||||
|
no client-side trick recovers it: crossterm 0.28 parses kitty `CSI 13;2u`
|
||||||
|
but not xterm's `CSI 27;2;13~`, so `modifyOtherKeys` buys nothing. NO VTE
|
||||||
|
release carries the protocol (checked at tag 0.82.0:
|
||||||
|
`_vte_keymap_GDK_Return` encodes only Alt); a version cutoff for it is a
|
||||||
|
bug, not a feature. `/terminal-setup` owns the per-terminal recipe.
|
||||||
|
|
||||||
## Test seams
|
## Test seams
|
||||||
|
|
||||||
Cross-crate test hooks are behind the `test-support` cargo feature
|
Cross-crate test hooks are behind the `test-support` cargo feature
|
||||||
@@ -347,15 +400,18 @@ client-side, no backend surface.
|
|||||||
reasoning replay requires `include:["reasoning.encrypted_content"]`.
|
reasoning replay requires `include:["reasoning.encrypted_content"]`.
|
||||||
API-key `openai` Responses requests carry NONE of this
|
API-key `openai` Responses requests carry NONE of this
|
||||||
(byte-identical, pinned by a control wire test). `reasoning.effort`
|
(byte-identical, pinned by a control wire test). `reasoning.effort`
|
||||||
carries the thinking level (incl. the codex-only `ultra`). NO
|
carries the thinking level. NO websocket, NO base_instructions.
|
||||||
websocket, NO base_instructions.
|
|
||||||
CATALOG is HARDCODED (`PlatformId::hardcoded_catalog` →
|
CATALOG is HARDCODED (`PlatformId::hardcoded_catalog` →
|
||||||
`openai_codex_wire_models`, mapped through the SAME
|
`openai_codex_wire_models`, mapped through the SAME
|
||||||
`platform_wire_model_to_entry` output): exactly the 4 `visibility=list` &&
|
`platform_wire_model_to_entry` output): the 7 `visibility=list` &&
|
||||||
`supported_in_api=true` models (`gpt-5.6-sol/terra/luna`, `gpt-5.5`, ctx
|
`supported_in_api=true` models the backend served on 2026-09-22
|
||||||
272000, per-model efforts) — NO live `/models` fetch, NO codex-CLI /
|
(`gpt-6-astra/sol/luna`, `gpt-5.6-sol/terra/luna`, `gpt-5.5`, ctx 272000,
|
||||||
`~/.codex` dependency; `gpt-5.3-codex-spark` (api=false) and
|
per-model efforts) — NO live `/models` fetch, NO codex-CLI / `~/.codex`
|
||||||
`gpt-5.4`/`gpt-5.4-mini`/`codex-auto-review` (hidden) are EXCLUDED.
|
dependency; the hidden `gpt-reserve` and `codex-auto-review` are
|
||||||
|
EXCLUDED. Refresh the table by reading
|
||||||
|
`GET {base}/models?client_version=<a current codex release>` with a
|
||||||
|
ChatGPT bearer: an old `client_version` is answered with a truncated
|
||||||
|
list, so a stale version reads as "the model does not exist".
|
||||||
- `OAuthFlow::GithubDeviceCopilot` → `auth::github_copilot` (TWO-STAGE).
|
- `OAuthFlow::GithubDeviceCopilot` → `auth::github_copilot` (TWO-STAGE).
|
||||||
Provider: `github-copilot` (`scope_key oauth/github-copilot`, base
|
Provider: `github-copilot` (`scope_key oauth/github-copilot`, base
|
||||||
`api.individual.githubcopilot.com`, ChatCompletions wire). Stage 1 is an
|
`api.individual.githubcopilot.com`, ChatCompletions wire). Stage 1 is an
|
||||||
@@ -497,10 +553,11 @@ client-side, no backend surface.
|
|||||||
`parse_api_json` for bundled + runtime refresh; 24h cache
|
`parse_api_json` for bundled + runtime refresh; 24h cache
|
||||||
`~/.kigi/models_dev_cache.json`). Wire values always win; enrichment
|
`~/.kigi/models_dev_cache.json`). Wire values always win; enrichment
|
||||||
never invents model availability. Canonical reasoning efforts:
|
never invents model availability. Canonical reasoning efforts:
|
||||||
none/minimal/low/medium/high/xhigh/max/ultra (`max` split from `xhigh`
|
none/minimal/low/medium/high/xhigh/max (`max` split from `xhigh` 2026-07;
|
||||||
2026-07; `ultra` is codex-only, above `max`, surfaced only via a model's
|
the Codex backend advertises an `ultra` tier above `max` that kigi has no
|
||||||
server-declared effort menu; Kimi wire spells its top tier `max`, kimi_compat
|
level for; Kimi wire spells its top tier `max`, kimi_compat renames).
|
||||||
renames).
|
config.toml accepts any letter case: `ReasoningEffort` deserializes
|
||||||
|
through `FromStr`.
|
||||||
|
|
||||||
## Milestones (PRD §8.3)
|
## Milestones (PRD §8.3)
|
||||||
|
|
||||||
|
|||||||
Generated
+75
-72
@@ -720,9 +720,9 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "aws-lc-rs"
|
name = "aws-lc-rs"
|
||||||
version = "1.17.1"
|
version = "1.18.1"
|
||||||
source = "registry+https://github.com/rust-lang/crates.io-index"
|
source = "registry+https://github.com/rust-lang/crates.io-index"
|
||||||
checksum = "4342d8937fc7e5dd9b1c60292261c0670c882a2cd1719cfc11b1af41731e32ad"
|
checksum = "b281d307588d634de920874890732659e2e7672f72b5e10e81badc1a8a83621e"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"aws-lc-sys",
|
"aws-lc-sys",
|
||||||
"untrusted 0.7.1",
|
"untrusted 0.7.1",
|
||||||
@@ -731,9 +731,9 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "aws-lc-sys"
|
name = "aws-lc-sys"
|
||||||
version = "0.42.0"
|
version = "0.45.0"
|
||||||
source = "registry+https://github.com/rust-lang/crates.io-index"
|
source = "registry+https://github.com/rust-lang/crates.io-index"
|
||||||
checksum = "6d9ceb1da931507a12f4fccea479dccd00da1943e1b4ae72d8e502d707361444"
|
checksum = "9bff6c3b54fad79a2e60b8102caf565819711497c1f5f092f49508e2f5c31b27"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"cc",
|
"cc",
|
||||||
"cmake",
|
"cmake",
|
||||||
@@ -1626,9 +1626,9 @@ checksum = "f079e83a288787bcd14a6aea84cee5c87a67c5a3e660c30f557a3d24761b3527"
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "chacha20"
|
name = "chacha20"
|
||||||
version = "0.10.1"
|
version = "0.10.2"
|
||||||
source = "registry+https://github.com/rust-lang/crates.io-index"
|
source = "registry+https://github.com/rust-lang/crates.io-index"
|
||||||
checksum = "d524456ba66e72eb8b115ff89e01e497f8e6d11d78b70b1aa13c0fbd97540a81"
|
checksum = "65c35e4b699c7e15ccbe7ee35c005e4fc0a278d22238a2857e6ce2dadeda1b06"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"cfg-if",
|
"cfg-if",
|
||||||
"cpufeatures 0.3.0",
|
"cpufeatures 0.3.0",
|
||||||
@@ -5442,7 +5442,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-acp-lib"
|
name = "kigi-acp-lib"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"agent-client-protocol",
|
"agent-client-protocol",
|
||||||
"async-trait",
|
"async-trait",
|
||||||
@@ -5456,7 +5456,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-agent"
|
name = "kigi-agent"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"chrono",
|
"chrono",
|
||||||
"dirs 6.0.0",
|
"dirs 6.0.0",
|
||||||
@@ -5486,7 +5486,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-agent-lifecycle"
|
name = "kigi-agent-lifecycle"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"async-trait",
|
"async-trait",
|
||||||
"tokio",
|
"tokio",
|
||||||
@@ -5495,7 +5495,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-auth"
|
name = "kigi-auth"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"async-trait",
|
"async-trait",
|
||||||
"http 1.4.2",
|
"http 1.4.2",
|
||||||
@@ -5508,7 +5508,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-bin"
|
name = "kigi-bin"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"clap",
|
"clap",
|
||||||
@@ -5543,7 +5543,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-chat-state"
|
name = "kigi-chat-state"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"indexmap",
|
"indexmap",
|
||||||
"kigi-compaction",
|
"kigi-compaction",
|
||||||
@@ -5560,7 +5560,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-codebase-graph"
|
name = "kigi-codebase-graph"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"ahash",
|
"ahash",
|
||||||
"clap",
|
"clap",
|
||||||
@@ -5596,7 +5596,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-compaction"
|
name = "kigi-compaction"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"async-trait",
|
"async-trait",
|
||||||
@@ -5609,7 +5609,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-config"
|
name = "kigi-config"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"base64",
|
"base64",
|
||||||
"blake3",
|
"blake3",
|
||||||
@@ -5632,7 +5632,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-config-types"
|
name = "kigi-config-types"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"agent-client-protocol",
|
"agent-client-protocol",
|
||||||
"indexmap",
|
"indexmap",
|
||||||
@@ -5646,7 +5646,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-crash-handler"
|
name = "kigi-crash-handler"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"backtrace",
|
"backtrace",
|
||||||
"libc",
|
"libc",
|
||||||
@@ -5657,7 +5657,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-env"
|
name = "kigi-env"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"tracing",
|
"tracing",
|
||||||
"url",
|
"url",
|
||||||
@@ -5665,7 +5665,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-fast-worktree"
|
name = "kigi-fast-worktree"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"bytes",
|
"bytes",
|
||||||
@@ -5697,7 +5697,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-file-utils"
|
name = "kigi-file-utils"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"aws-config",
|
"aws-config",
|
||||||
@@ -5721,7 +5721,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-fsnotify"
|
name = "kigi-fsnotify"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"criterion",
|
"criterion",
|
||||||
"dunce",
|
"dunce",
|
||||||
@@ -5742,7 +5742,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-gix-status"
|
name = "kigi-gix-status"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"gix",
|
"gix",
|
||||||
"kigi-test-utils",
|
"kigi-test-utils",
|
||||||
@@ -5752,7 +5752,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-hooks"
|
name = "kigi-hooks"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"fastrand",
|
"fastrand",
|
||||||
"kigi-config",
|
"kigi-config",
|
||||||
@@ -5771,7 +5771,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-hooks-plugins-types"
|
name = "kigi-hooks-plugins-types"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"serde",
|
"serde",
|
||||||
"serde_json",
|
"serde_json",
|
||||||
@@ -5779,7 +5779,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-http"
|
name = "kigi-http"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"kigi-auth",
|
"kigi-auth",
|
||||||
"kigi-log",
|
"kigi-log",
|
||||||
@@ -5794,7 +5794,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-hunk-tracker"
|
name = "kigi-hunk-tracker"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"chrono",
|
"chrono",
|
||||||
"dunce",
|
"dunce",
|
||||||
@@ -5815,14 +5815,14 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-interjection-core"
|
name = "kigi-interjection-core"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"serde",
|
"serde",
|
||||||
]
|
]
|
||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-log"
|
name = "kigi-log"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"chrono",
|
"chrono",
|
||||||
@@ -5840,7 +5840,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-markdown"
|
name = "kigi-markdown"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anstyle",
|
"anstyle",
|
||||||
"anstyle-lossy",
|
"anstyle-lossy",
|
||||||
@@ -5864,14 +5864,14 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-markdown-core"
|
name = "kigi-markdown-core"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"pulldown-cmark",
|
"pulldown-cmark",
|
||||||
]
|
]
|
||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-mcp"
|
name = "kigi-mcp"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"agent-client-protocol",
|
"agent-client-protocol",
|
||||||
"async-trait",
|
"async-trait",
|
||||||
@@ -5908,7 +5908,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-memory"
|
name = "kigi-memory"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"arc-swap",
|
"arc-swap",
|
||||||
@@ -5942,7 +5942,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-mermaid"
|
name = "kigi-mermaid"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"fontdb",
|
"fontdb",
|
||||||
"image",
|
"image",
|
||||||
@@ -5960,7 +5960,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-models"
|
name = "kigi-models"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"kigi-env",
|
"kigi-env",
|
||||||
"serde",
|
"serde",
|
||||||
@@ -5970,7 +5970,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-pager-minimal"
|
name = "kigi-pager-minimal"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"chrono",
|
"chrono",
|
||||||
"crossterm",
|
"crossterm",
|
||||||
@@ -5987,7 +5987,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-pager-pty-harness"
|
name = "kigi-pager-pty-harness"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"alacritty_terminal",
|
"alacritty_terminal",
|
||||||
"anyhow",
|
"anyhow",
|
||||||
@@ -6012,7 +6012,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-pager-render"
|
name = "kigi-pager-render"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"agent-client-protocol",
|
"agent-client-protocol",
|
||||||
"anstyle",
|
"anstyle",
|
||||||
@@ -6064,7 +6064,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-paths"
|
name = "kigi-paths"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"camino",
|
"camino",
|
||||||
"serde",
|
"serde",
|
||||||
@@ -6074,7 +6074,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-prompt-queue"
|
name = "kigi-prompt-queue"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"serde",
|
"serde",
|
||||||
"serde_json",
|
"serde_json",
|
||||||
@@ -6082,7 +6082,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-proto-build"
|
name = "kigi-proto-build"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"pbjson-build",
|
"pbjson-build",
|
||||||
@@ -6093,7 +6093,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-ratatui-inline"
|
name = "kigi-ratatui-inline"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"ansi-width",
|
"ansi-width",
|
||||||
"anstyle-parse 0.2.7",
|
"anstyle-parse 0.2.7",
|
||||||
@@ -6110,7 +6110,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-ratatui-textarea"
|
name = "kigi-ratatui-textarea"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"arboard",
|
"arboard",
|
||||||
"chrono",
|
"chrono",
|
||||||
@@ -6131,7 +6131,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-sampler"
|
name = "kigi-sampler"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"async-openai",
|
"async-openai",
|
||||||
"async-stream",
|
"async-stream",
|
||||||
@@ -6141,6 +6141,7 @@ dependencies = [
|
|||||||
"futures-util",
|
"futures-util",
|
||||||
"indexmap",
|
"indexmap",
|
||||||
"kigi-sampling-types",
|
"kigi-sampling-types",
|
||||||
|
"kigi-secrets",
|
||||||
"kigi-test-support",
|
"kigi-test-support",
|
||||||
"kigi-version",
|
"kigi-version",
|
||||||
"reqwest 0.12.28",
|
"reqwest 0.12.28",
|
||||||
@@ -6154,7 +6155,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-sampling-types"
|
name = "kigi-sampling-types"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"assert_matches",
|
"assert_matches",
|
||||||
"async-openai",
|
"async-openai",
|
||||||
@@ -6171,7 +6172,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-sandbox"
|
name = "kigi-sandbox"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"chrono",
|
"chrono",
|
||||||
@@ -6186,13 +6187,14 @@ dependencies = [
|
|||||||
"serde",
|
"serde",
|
||||||
"serde_json",
|
"serde_json",
|
||||||
"serial_test",
|
"serial_test",
|
||||||
|
"tempfile",
|
||||||
"toml",
|
"toml",
|
||||||
"tracing",
|
"tracing",
|
||||||
]
|
]
|
||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-secrets"
|
name = "kigi-secrets"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"regex",
|
"regex",
|
||||||
"serde_json",
|
"serde_json",
|
||||||
@@ -6230,7 +6232,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-shell"
|
name = "kigi-shell"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"agent-client-protocol",
|
"agent-client-protocol",
|
||||||
"anyhow",
|
"anyhow",
|
||||||
@@ -6293,6 +6295,7 @@ dependencies = [
|
|||||||
"kigi-sampler",
|
"kigi-sampler",
|
||||||
"kigi-sampling-types",
|
"kigi-sampling-types",
|
||||||
"kigi-sandbox",
|
"kigi-sandbox",
|
||||||
|
"kigi-secrets",
|
||||||
"kigi-shared",
|
"kigi-shared",
|
||||||
"kigi-shell-base",
|
"kigi-shell-base",
|
||||||
"kigi-sqlite-journal",
|
"kigi-sqlite-journal",
|
||||||
@@ -6367,7 +6370,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-shell-base"
|
name = "kigi-shell-base"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"chrono",
|
"chrono",
|
||||||
@@ -6392,7 +6395,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-sqlite-journal"
|
name = "kigi-sqlite-journal"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"libc",
|
"libc",
|
||||||
"rusqlite",
|
"rusqlite",
|
||||||
@@ -6403,7 +6406,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-subagent-resolution"
|
name = "kigi-subagent-resolution"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"kigi-sampling-types",
|
"kigi-sampling-types",
|
||||||
"kigi-tool-types",
|
"kigi-tool-types",
|
||||||
@@ -6418,7 +6421,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-system-power"
|
name = "kigi-system-power"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"windows-sys 0.59.0",
|
"windows-sys 0.59.0",
|
||||||
"zbus",
|
"zbus",
|
||||||
@@ -6426,7 +6429,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-test-support"
|
name = "kigi-test-support"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"agent-client-protocol",
|
"agent-client-protocol",
|
||||||
"anyhow",
|
"anyhow",
|
||||||
@@ -6448,7 +6451,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-test-utils"
|
name = "kigi-test-utils"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"runfiles",
|
"runfiles",
|
||||||
"tracing",
|
"tracing",
|
||||||
@@ -6457,11 +6460,11 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-token-estimation"
|
name = "kigi-token-estimation"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-tool-protocol"
|
name = "kigi-tool-protocol"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"kigi-tool-types",
|
"kigi-tool-types",
|
||||||
"serde",
|
"serde",
|
||||||
@@ -6472,7 +6475,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-tool-runtime"
|
name = "kigi-tool-runtime"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"async-trait",
|
"async-trait",
|
||||||
@@ -6490,7 +6493,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-tool-types"
|
name = "kigi-tool-types"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"minijinja",
|
"minijinja",
|
||||||
"schemars 1.2.1",
|
"schemars 1.2.1",
|
||||||
@@ -6500,7 +6503,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-tools"
|
name = "kigi-tools"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"arc-swap",
|
"arc-swap",
|
||||||
@@ -6577,7 +6580,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-tools-api"
|
name = "kigi-tools-api"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"kigi-proto-build",
|
"kigi-proto-build",
|
||||||
"kigi-tool-protocol",
|
"kigi-tool-protocol",
|
||||||
@@ -6590,11 +6593,11 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-tracing-macros"
|
name = "kigi-tracing-macros"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-tty-utils"
|
name = "kigi-tty-utils"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"libc",
|
"libc",
|
||||||
"nix 0.30.1",
|
"nix 0.30.1",
|
||||||
@@ -6604,7 +6607,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-tui"
|
name = "kigi-tui"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"agent-client-protocol",
|
"agent-client-protocol",
|
||||||
"ansi-to-tui",
|
"ansi-to-tui",
|
||||||
@@ -6691,7 +6694,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-update"
|
name = "kigi-update"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"dunce",
|
"dunce",
|
||||||
@@ -6720,14 +6723,14 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-version"
|
name = "kigi-version"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"semver",
|
"semver",
|
||||||
]
|
]
|
||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-workspace"
|
name = "kigi-workspace"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"agent-client-protocol",
|
"agent-client-protocol",
|
||||||
"anyhow",
|
"anyhow",
|
||||||
@@ -6806,7 +6809,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "kigi-workspace-types"
|
name = "kigi-workspace-types"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"base64",
|
"base64",
|
||||||
"chrono",
|
"chrono",
|
||||||
@@ -8840,7 +8843,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "ptyctl"
|
name = "ptyctl"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"alacritty_terminal",
|
"alacritty_terminal",
|
||||||
"anyhow",
|
"anyhow",
|
||||||
@@ -8858,7 +8861,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "ptyctl-cli"
|
name = "ptyctl-cli"
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"axum",
|
"axum",
|
||||||
@@ -9633,9 +9636,9 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "rustls"
|
name = "rustls"
|
||||||
version = "0.23.42"
|
version = "0.23.45"
|
||||||
source = "registry+https://github.com/rust-lang/crates.io-index"
|
source = "registry+https://github.com/rust-lang/crates.io-index"
|
||||||
checksum = "3c54fcab019b409d04215d3a17cb438fd7fbf192ee61461f20f4fe18704bc138"
|
checksum = "0d41d731c7d2f962d1ccc364cec258de3c0e93b38c2fb3ba97ac74513048d634"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"aws-lc-rs",
|
"aws-lc-rs",
|
||||||
"log",
|
"log",
|
||||||
@@ -9698,9 +9701,9 @@ checksum = "f87165f0995f63a9fbeea62b64d10b4d9d8e78ec6d7d51fb2125fda7bb36788f"
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "rustls-webpki"
|
name = "rustls-webpki"
|
||||||
version = "0.103.13"
|
version = "0.103.15"
|
||||||
source = "registry+https://github.com/rust-lang/crates.io-index"
|
source = "registry+https://github.com/rust-lang/crates.io-index"
|
||||||
checksum = "61c429a8649f110dddef65e2a5ad240f747e85f7758a6bccc7e5777bd33f756e"
|
checksum = "f3c3cf1d8b1e7d4927e2d154c3fcb02979afb9939629c62cd9048d4f07b60ac2"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"aws-lc-rs",
|
"aws-lc-rs",
|
||||||
"ring",
|
"ring",
|
||||||
|
|||||||
+1
-1
@@ -76,7 +76,7 @@ members = [
|
|||||||
]
|
]
|
||||||
|
|
||||||
[workspace.package]
|
[workspace.package]
|
||||||
version = "0.1.14"
|
version = "0.1.18"
|
||||||
edition = "2024"
|
edition = "2024"
|
||||||
license = "Apache-2.0"
|
license = "Apache-2.0"
|
||||||
|
|
||||||
|
|||||||
+5029
-5028
File diff suppressed because it is too large.
Load diff
@@ -252,11 +252,20 @@ pub fn by_name(name: &str) -> Option<AgentDefinition> {
|
|||||||
by_name_with_home(name, dirs::home_dir().as_deref(), kigi.as_deref())
|
by_name_with_home(name, dirs::home_dir().as_deref(), kigi.as_deref())
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// An agent name is one file stem: a separator or `..` would resolve a file outside the searched directory with that directory's trust scope.
|
||||||
|
fn is_single_path_component(name: &str) -> bool {
|
||||||
|
!name.is_empty() && name != "." && name != ".." && !name.contains(['/', '\\'])
|
||||||
|
}
|
||||||
|
|
||||||
fn by_name_with_home(
|
fn by_name_with_home(
|
||||||
name: &str,
|
name: &str,
|
||||||
home: Option<&Path>,
|
home: Option<&Path>,
|
||||||
kigi_home: Option<&Path>,
|
kigi_home: Option<&Path>,
|
||||||
) -> Option<AgentDefinition> {
|
) -> Option<AgentDefinition> {
|
||||||
|
if !is_single_path_component(name) {
|
||||||
|
tracing::warn!(name, "rejected agent name: not a single path component");
|
||||||
|
return None;
|
||||||
|
}
|
||||||
// Check built-ins first — type-safe via BuiltinAgentName strum enum.
|
// Check built-ins first — type-safe via BuiltinAgentName strum enum.
|
||||||
// Legacy pre-rebrand agent types (persisted in old session files) are
|
// Legacy pre-rebrand agent types (persisted in old session files) are
|
||||||
// mapped onto their current names first; see `canonical_agent_type`.
|
// mapped onto their current names first; see `canonical_agent_type`.
|
||||||
@@ -298,6 +307,10 @@ fn by_name_in_cwd_with_home(
|
|||||||
home: Option<&Path>,
|
home: Option<&Path>,
|
||||||
kigi_home: Option<&Path>,
|
kigi_home: Option<&Path>,
|
||||||
) -> Option<AgentDefinition> {
|
) -> Option<AgentDefinition> {
|
||||||
|
if !is_single_path_component(name) {
|
||||||
|
tracing::warn!(name, "rejected agent name: not a single path component");
|
||||||
|
return None;
|
||||||
|
}
|
||||||
if let Some(def) = load_project_definition_by_name(name, cwd) {
|
if let Some(def) = load_project_definition_by_name(name, cwd) {
|
||||||
return Some(def);
|
return Some(def);
|
||||||
}
|
}
|
||||||
@@ -827,6 +840,30 @@ mod tests {
|
|||||||
assert!(def.is_none());
|
assert!(def.is_none());
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// `../outside` must not load a file beyond the agents directory under that directory's scope.
|
||||||
|
#[test]
|
||||||
|
fn by_name_rejects_names_that_leave_the_agents_directory() {
|
||||||
|
let tmp = tempfile::tempdir().unwrap();
|
||||||
|
let project = tmp.path().join("project");
|
||||||
|
let agents_dir = project.join(".kigi").join("agents");
|
||||||
|
fs::create_dir_all(&agents_dir).unwrap();
|
||||||
|
write_agent_file(
|
||||||
|
&project,
|
||||||
|
"outside.md",
|
||||||
|
"outside",
|
||||||
|
"Lives outside the agents dir",
|
||||||
|
);
|
||||||
|
write_agent_file(&agents_dir, "inside.md", "inside", "Lives inside");
|
||||||
|
assert!(by_name_in_cwd_with_home("../../outside", &project, None, None).is_none());
|
||||||
|
assert!(by_name_in_cwd_with_home("..", &project, None, None).is_none());
|
||||||
|
assert!(by_name_in_cwd_with_home("a/b", &project, None, None).is_none());
|
||||||
|
assert!(by_name_with_home("../../outside", None, None).is_none());
|
||||||
|
assert_eq!(
|
||||||
|
by_name_in_cwd_with_home("inside", &project, None, None).map(|d| d.name),
|
||||||
|
Some("inside".to_string())
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn test_discover_finds_md_files() {
|
fn test_discover_finds_md_files() {
|
||||||
let tmp = tempfile::tempdir().unwrap();
|
let tmp = tempfile::tempdir().unwrap();
|
||||||
|
|||||||
@@ -146,27 +146,33 @@ async fn run_setup_command(json: bool) {
|
|||||||
.expect("setup report has no non-serializable values");
|
.expect("setup report has no non-serializable values");
|
||||||
println!("{out}");
|
println!("{out}");
|
||||||
if !report.configured {
|
if !report.configured {
|
||||||
eprintln!(
|
kigi_tui::best_effort_stderr::eprint_line(
|
||||||
"Your team doesn't have a managed configuration yet. Ask a team admin to provision one."
|
"Your team doesn't have a managed configuration yet. Ask a team admin to provision one.",
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
Err(e) => {
|
Err(e) => {
|
||||||
eprintln!("Couldn't fetch managed configuration. {e}");
|
kigi_tui::best_effort_stderr::eprint_line(&format!(
|
||||||
|
"Couldn't fetch managed configuration. {e}"
|
||||||
|
));
|
||||||
std::process::exit(1);
|
std::process::exit(1);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
match managed_config::run_setup().await {
|
match managed_config::run_setup().await {
|
||||||
SetupOutcome::Installed => eprintln!("Applied managed configuration."),
|
SetupOutcome::Installed => {
|
||||||
|
kigi_tui::best_effort_stderr::eprint_line("Applied managed configuration.")
|
||||||
|
}
|
||||||
SetupOutcome::NothingConfigured => {
|
SetupOutcome::NothingConfigured => {
|
||||||
eprintln!(
|
kigi_tui::best_effort_stderr::eprint_line(
|
||||||
"Your team doesn't have a managed configuration yet. Ask a team admin to provision one."
|
"Your team doesn't have a managed configuration yet. Ask a team admin to provision one.",
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
SetupOutcome::Failed(e) => {
|
SetupOutcome::Failed(e) => {
|
||||||
eprintln!("Couldn't apply managed configuration. {e}");
|
kigi_tui::best_effort_stderr::eprint_line(&format!(
|
||||||
|
"Couldn't apply managed configuration. {e}"
|
||||||
|
));
|
||||||
std::process::exit(1);
|
std::process::exit(1);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -208,8 +214,8 @@ async fn run_leader_mgmt(args: LeaderMgmtArgs) -> Result<()> {
|
|||||||
println!("{info:#?}");
|
println!("{info:#?}");
|
||||||
} else {
|
} else {
|
||||||
print_leader_descriptor(&descriptor);
|
print_leader_descriptor(&descriptor);
|
||||||
eprintln!(
|
kigi_tui::best_effort_stderr::eprint_line(
|
||||||
" (detailed info unavailable — leader does not advertise control capabilities)"
|
" (detailed info unavailable — leader does not advertise control capabilities)",
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
client.cancel();
|
client.cancel();
|
||||||
@@ -220,7 +226,7 @@ async fn run_leader_mgmt(args: LeaderMgmtArgs) -> Result<()> {
|
|||||||
async fn kill_leaders() -> Result<()> {
|
async fn kill_leaders() -> Result<()> {
|
||||||
let leaders = kigi_shell::leader::discover_leaders().await;
|
let leaders = kigi_shell::leader::discover_leaders().await;
|
||||||
if leaders.is_empty() {
|
if leaders.is_empty() {
|
||||||
eprintln!("No leader candidates found.");
|
kigi_tui::best_effort_stderr::eprint_line("No leader candidates found.");
|
||||||
return Ok(());
|
return Ok(());
|
||||||
}
|
}
|
||||||
let mut killed = 0u32;
|
let mut killed = 0u32;
|
||||||
@@ -231,7 +237,9 @@ async fn kill_leaders() -> Result<()> {
|
|||||||
};
|
};
|
||||||
if !kigi_shell::util::is_kigi_process(pid) {
|
if !kigi_shell::util::is_kigi_process(pid) {
|
||||||
if let Some(ref lock) = d.lock_path {
|
if let Some(ref lock) = d.lock_path {
|
||||||
eprintln!(" PID {pid} is not a kigi process, removing stale lock");
|
kigi_tui::best_effort_stderr::eprint_line(&format!(
|
||||||
|
" PID {pid} is not a kigi process, removing stale lock"
|
||||||
|
));
|
||||||
let _ = std::fs::remove_file(lock);
|
let _ = std::fs::remove_file(lock);
|
||||||
cleaned += 1;
|
cleaned += 1;
|
||||||
}
|
}
|
||||||
@@ -240,19 +248,23 @@ async fn kill_leaders() -> Result<()> {
|
|||||||
}
|
}
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
eprintln!(" Killing leader PID {pid}");
|
kigi_tui::best_effort_stderr::eprint_line(&format!(" Killing leader PID {pid}"));
|
||||||
if let Err(e) = kigi_shell::util::kill_process_by_pid(pid) {
|
if let Err(e) = kigi_shell::util::kill_process_by_pid(pid) {
|
||||||
eprintln!(" warning: failed to terminate PID {pid}: {e}");
|
kigi_tui::best_effort_stderr::eprint_line(&format!(
|
||||||
|
" warning: failed to terminate PID {pid}: {e}"
|
||||||
|
));
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
killed += 1;
|
killed += 1;
|
||||||
}
|
}
|
||||||
if killed > 0 {
|
if killed > 0 {
|
||||||
eprintln!("Killed {killed} leader process(es).");
|
kigi_tui::best_effort_stderr::eprint_line(&format!("Killed {killed} leader process(es)."));
|
||||||
} else if cleaned > 0 {
|
} else if cleaned > 0 {
|
||||||
eprintln!("No live leader processes found (cleaned up {cleaned} stale lock(s)).");
|
kigi_tui::best_effort_stderr::eprint_line(&format!(
|
||||||
|
"No live leader processes found (cleaned up {cleaned} stale lock(s))."
|
||||||
|
));
|
||||||
} else {
|
} else {
|
||||||
eprintln!("No live leader processes found.");
|
kigi_tui::best_effort_stderr::eprint_line("No live leader processes found.");
|
||||||
}
|
}
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
@@ -295,7 +307,7 @@ fn print_leader_descriptor(d: &LeaderDescriptor) {
|
|||||||
.map(|p| p.display().to_string())
|
.map(|p| p.display().to_string())
|
||||||
.unwrap_or_else(|| "?".into());
|
.unwrap_or_else(|| "?".into());
|
||||||
let state = format!("{:?}", d.classification);
|
let state = format!("{:?}", d.classification);
|
||||||
eprintln!(" PID {pid} ({state}) -- {sock}");
|
kigi_tui::best_effort_stderr::eprint_line(&format!(" PID {pid} ({state}) -- {sock}"));
|
||||||
}
|
}
|
||||||
fn leader_descriptor_json(d: &LeaderDescriptor) -> serde_json::Value {
|
fn leader_descriptor_json(d: &LeaderDescriptor) -> serde_json::Value {
|
||||||
serde_json::json!(
|
serde_json::json!(
|
||||||
@@ -1233,10 +1245,12 @@ fn main() {
|
|||||||
// A host out of threads (RLIMIT_NPROC / pids.max) is an
|
// A host out of threads (RLIMIT_NPROC / pids.max) is an
|
||||||
// environment problem, not a bug — report it, don't panic.
|
// environment problem, not a bug — report it, don't panic.
|
||||||
kigi_tty_utils::restore_native_stderr();
|
kigi_tty_utils::restore_native_stderr();
|
||||||
eprintln!("Error: failed to start the async runtime: {e}");
|
kigi_tui::best_effort_stderr::eprint_line(&format!(
|
||||||
eprintln!(
|
"Error: failed to start the async runtime: {e}"
|
||||||
|
));
|
||||||
|
kigi_tui::best_effort_stderr::eprint_line(
|
||||||
"The host may be out of threads (RLIMIT_NPROC or the cgroup pids ceiling); \
|
"The host may be out of threads (RLIMIT_NPROC or the cgroup pids ceiling); \
|
||||||
close other processes or raise the limit, then retry."
|
close other processes or raise the limit, then retry.",
|
||||||
);
|
);
|
||||||
std::process::exit(1);
|
std::process::exit(1);
|
||||||
}
|
}
|
||||||
@@ -1245,7 +1259,8 @@ fn main() {
|
|||||||
kigi_log::debug_log::flush();
|
kigi_log::debug_log::flush();
|
||||||
if let Err(e) = result {
|
if let Err(e) = result {
|
||||||
kigi_tty_utils::restore_native_stderr();
|
kigi_tty_utils::restore_native_stderr();
|
||||||
eprintln!("Error: {e:#}");
|
// fd 2 may be a closed pane: one attempt, never a panic under panic = "abort".
|
||||||
|
kigi_tui::best_effort_stderr::eprint_line(&format!("Error: {e:#}"));
|
||||||
std::process::exit(1);
|
std::process::exit(1);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -1596,16 +1611,25 @@ async fn async_main() -> Result<()> {
|
|||||||
let result = kigi_tui::app::run(args, bg_update_rx).await;
|
let result = kigi_tui::app::run(args, bg_update_rx).await;
|
||||||
kigi_sandbox::flush();
|
kigi_sandbox::flush();
|
||||||
match result {
|
match result {
|
||||||
Ok(true) => {
|
Ok(exit) if exit.quit_for_update => {
|
||||||
let adopted = bg_update_wait.lock().await.take();
|
let adopted = bg_update_wait.lock().await.take();
|
||||||
if finish_update_on_exit(adopted, &update_config).await {
|
let installed =
|
||||||
eprintln!("Update installed. Run `kigi` to start.");
|
finish_update_on_exit(adopted, &update_config, exit.terminal_reading).await;
|
||||||
} else {
|
// A terminal that stopped reading at teardown would block these prints.
|
||||||
eprintln!("Update did not complete. Run `kigi update` to retry.");
|
if exit.terminal_reading {
|
||||||
|
if installed {
|
||||||
|
kigi_tui::best_effort_stderr::eprint_line(
|
||||||
|
"Update installed. Run `kigi` to start.",
|
||||||
|
);
|
||||||
|
} else {
|
||||||
|
kigi_tui::best_effort_stderr::eprint_line(
|
||||||
|
"Update did not complete. Run `kigi update` to retry.",
|
||||||
|
);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
Ok(false) => Ok(()),
|
Ok(_) => Ok(()),
|
||||||
Err(e) => Err(e),
|
Err(e) => Err(e),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -1621,10 +1645,15 @@ async fn async_main() -> Result<()> {
|
|||||||
async fn finish_update_on_exit(
|
async fn finish_update_on_exit(
|
||||||
adopted: Option<tokio::task::JoinHandle<std::io::Result<std::process::ExitStatus>>>,
|
adopted: Option<tokio::task::JoinHandle<std::io::Result<std::process::ExitStatus>>>,
|
||||||
update_config: &UpdateConfig,
|
update_config: &UpdateConfig,
|
||||||
|
terminal_reading: bool,
|
||||||
) -> bool {
|
) -> bool {
|
||||||
let run_blocking = |reason: Option<String>| async move {
|
let run_blocking = |reason: Option<String>| async move {
|
||||||
|
// The blocking updater prints and its child inherits stderr: not on a stalled terminal.
|
||||||
|
if !terminal_reading {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
if let Some(reason) = reason {
|
if let Some(reason) = reason {
|
||||||
eprintln!("{reason}");
|
kigi_tui::best_effort_stderr::eprint_line(&reason);
|
||||||
}
|
}
|
||||||
auto_update::run_update_if_available(
|
auto_update::run_update_if_available(
|
||||||
auto_update::UpdateRunMode::Blocking,
|
auto_update::UpdateRunMode::Blocking,
|
||||||
@@ -1636,7 +1665,11 @@ async fn finish_update_on_exit(
|
|||||||
};
|
};
|
||||||
match adopted {
|
match adopted {
|
||||||
Some(handle) => {
|
Some(handle) => {
|
||||||
eprintln!("Waiting for the update download to finish...");
|
if terminal_reading {
|
||||||
|
kigi_tui::best_effort_stderr::eprint_line(
|
||||||
|
"Waiting for the update download to finish...",
|
||||||
|
);
|
||||||
|
}
|
||||||
match handle.await {
|
match handle.await {
|
||||||
Ok(Ok(status)) if status.success() => true,
|
Ok(Ok(status)) if status.success() => true,
|
||||||
Ok(Ok(status)) => {
|
Ok(Ok(status)) => {
|
||||||
@@ -1809,7 +1842,9 @@ async fn signal_leaders_to_relaunch(installed_version: &str) {
|
|||||||
to_version,
|
to_version,
|
||||||
..
|
..
|
||||||
})) => {
|
})) => {
|
||||||
eprintln!(" ↻ Relaunching shared session (leader {from_version} → {to_version})…");
|
kigi_tui::best_effort_stderr::eprint_line(&format!(
|
||||||
|
" ↻ Relaunching shared session (leader {from_version} → {to_version})…"
|
||||||
|
));
|
||||||
}
|
}
|
||||||
Ok(Ok(kigi_shell::leader::ControlPayload::RelaunchDeclined { reason })) => {
|
Ok(Ok(kigi_shell::leader::ControlPayload::RelaunchDeclined { reason })) => {
|
||||||
tracing::debug!(% reason, "Leader declined relaunch");
|
tracing::debug!(% reason, "Leader declined relaunch");
|
||||||
|
|||||||
@@ -390,14 +390,24 @@ impl ChatStateActor {
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Replace the entire conversation, persist, re-estimate `total_tokens`,
|
/// Reseed after a rewrite: the raw estimate scaled by the provider-confirmed ratio, capped at the pre-rewrite total (see COMPACTION.md).
|
||||||
/// and emit reset + token-update events.
|
pub(super) fn reseed_total_tokens(&self, base_estimate: u64) -> u64 {
|
||||||
///
|
let pre_replace_total = self.state.total_tokens;
|
||||||
/// Compaction replaces carry the provider-side overhead forward as a
|
let mut estimated_tokens =
|
||||||
/// *ratio* (`base_estimate × provider_total ÷ estimate_at_last_response`,
|
if pre_replace_total > 0 && self.state.estimate_at_last_response > 0 {
|
||||||
/// capped at the pre-compaction total; `base_estimate` when that estimate is
|
let ratio = pre_replace_total as f64 / self.state.estimate_at_last_response as f64;
|
||||||
/// 0) so the reseed neither springs back nor over-counts (see
|
(base_estimate as f64 * ratio).round() as u64
|
||||||
/// `COMPACTION.md`).
|
} else {
|
||||||
|
base_estimate
|
||||||
|
};
|
||||||
|
// Over-counting fires premature compaction; an under-count self-heals on the next response.
|
||||||
|
if pre_replace_total > 0 {
|
||||||
|
estimated_tokens = estimated_tokens.min(pre_replace_total);
|
||||||
|
}
|
||||||
|
estimated_tokens
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Replace the conversation, persist, reseed `total_tokens` and emit reset + token events; `is_compaction` only marks the turn capture.
|
||||||
pub(super) fn replace_conversation(
|
pub(super) fn replace_conversation(
|
||||||
&mut self,
|
&mut self,
|
||||||
items: Vec<ConversationItem>,
|
items: Vec<ConversationItem>,
|
||||||
@@ -407,28 +417,16 @@ impl ChatStateActor {
|
|||||||
if is_compaction && let Some(cap) = &mut self.state.turn_capture {
|
if is_compaction && let Some(cap) = &mut self.state.turn_capture {
|
||||||
cap.compaction_occurred = true;
|
cap.compaction_occurred = true;
|
||||||
}
|
}
|
||||||
let pre_replace_total = self.state.total_tokens;
|
|
||||||
// `harness_trace_buffer` / `harness_trace_turns` intentionally untouched:
|
// `harness_trace_buffer` / `harness_trace_turns` intentionally untouched:
|
||||||
// the planner/verifier subagents ran, so their sealed trace turns survive
|
// the planner/verifier subagents ran, so their sealed trace turns survive
|
||||||
// a conversation replace (same intent as the `TruncateToPromptIndex` arm).
|
// a conversation replace (same intent as the `TruncateToPromptIndex` arm).
|
||||||
self.persistence.replace_history(&items);
|
self.persistence.replace_history(&items);
|
||||||
let base_estimate = super::state::estimate_conversation_tokens(&items);
|
let base_estimate = super::state::estimate_conversation_tokens(&items);
|
||||||
let mut estimated_tokens =
|
let estimated_tokens = self.reseed_total_tokens(base_estimate);
|
||||||
if is_compaction && pre_replace_total > 0 && self.state.estimate_at_last_response > 0 {
|
|
||||||
let ratio = pre_replace_total as f64 / self.state.estimate_at_last_response as f64;
|
|
||||||
(base_estimate as f64 * ratio).round() as u64
|
|
||||||
} else {
|
|
||||||
base_estimate
|
|
||||||
};
|
|
||||||
// Compaction must never appear to increase usage.
|
|
||||||
if is_compaction && pre_replace_total > 0 {
|
|
||||||
estimated_tokens = estimated_tokens.min(pre_replace_total);
|
|
||||||
}
|
|
||||||
self.state.conversation = items;
|
self.state.conversation = items;
|
||||||
self.state.estimated_tokens_since_model = 0;
|
self.state.estimated_tokens_since_model = 0;
|
||||||
self.state.total_tokens = estimated_tokens;
|
self.state.total_tokens = estimated_tokens;
|
||||||
self.state.estimate_at_last_response =
|
self.state.estimate_at_last_response = base_estimate;
|
||||||
super::state::estimate_conversation_tokens(&self.state.conversation);
|
|
||||||
self.rebase_turn_capture_offset();
|
self.rebase_turn_capture_offset();
|
||||||
self.send_event(ChatStateEvent::ConversationReset {
|
self.send_event(ChatStateEvent::ConversationReset {
|
||||||
new_len: self.state.conversation.len(),
|
new_len: self.state.conversation.len(),
|
||||||
|
|||||||
@@ -68,10 +68,10 @@ impl ChatStateActor {
|
|||||||
self.state.conversation.truncate(truncate_at);
|
self.state.conversation.truncate(truncate_at);
|
||||||
self.state.prompt_texts.truncate(target_prompt_index);
|
self.state.prompt_texts.truncate(target_prompt_index);
|
||||||
self.state.prompt_index = target_prompt_index;
|
self.state.prompt_index = target_prompt_index;
|
||||||
self.state.total_tokens =
|
let base_estimate = super::state::estimate_conversation_tokens(&self.state.conversation);
|
||||||
super::state::estimate_conversation_tokens(&self.state.conversation);
|
self.state.total_tokens = self.reseed_total_tokens(base_estimate);
|
||||||
self.state.estimated_tokens_since_model = 0;
|
self.state.estimated_tokens_since_model = 0;
|
||||||
self.state.estimate_at_last_response = self.state.total_tokens;
|
self.state.estimate_at_last_response = base_estimate;
|
||||||
|
|
||||||
self.persistence.replace_history(&self.state.conversation);
|
self.persistence.replace_history(&self.state.conversation);
|
||||||
|
|
||||||
|
|||||||
@@ -68,12 +68,10 @@ pub fn estimate_item_tokens(item: &ConversationItem) -> u64 {
|
|||||||
kigi_token_estimation::estimate_tokens(&b.text_summary())
|
kigi_token_estimation::estimate_tokens(&b.text_summary())
|
||||||
}
|
}
|
||||||
ConversationItem::Reasoning(r) => {
|
ConversationItem::Reasoning(r) => {
|
||||||
// Summary + content text follow the standard bytes-per-token
|
// Text and ciphertext are the same reasoning twice: the larger wins (base64 is 4/3 over raw).
|
||||||
// estimate; encrypted blobs are base64 and don't survive
|
|
||||||
// tokenization 1:1, so estimate at len/4 as well.
|
|
||||||
let text_bytes = kigi_sampling_types::reasoning_item_text(r).len();
|
let text_bytes = kigi_sampling_types::reasoning_item_text(r).len();
|
||||||
let enc_bytes = r.encrypted_content.as_deref().map(str::len).unwrap_or(0);
|
let enc_bytes = r.encrypted_content.as_deref().map(str::len).unwrap_or(0);
|
||||||
((text_bytes + enc_bytes) as u64) / kigi_token_estimation::BYTES_PER_TOKEN
|
(text_bytes.max(enc_bytes * 3 / 4) as u64) / kigi_token_estimation::BYTES_PER_TOKEN
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -658,22 +658,66 @@ async fn compaction_reseed_without_provider_count_matches_plain_estimate() {
|
|||||||
}
|
}
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn non_compaction_replace_does_not_carry_overhead() {
|
async fn non_compaction_replace_carries_confirmed_total() {
|
||||||
|
// A rewind/mode-switch replace scales from the provider-confirmed count, not the raw estimate.
|
||||||
let h = TestHarness::new();
|
let h = TestHarness::new();
|
||||||
h.handle
|
h.handle
|
||||||
.push_user_message(ConversationItem::user("x".repeat(4000)));
|
.push_user_message(ConversationItem::user("x".repeat(4000)));
|
||||||
h.handle.record_token_usage(51_000);
|
h.handle.record_token_usage(500);
|
||||||
|
// Estimate at last response = 1_000, confirmed = 500 → ratio 0.5.
|
||||||
|
|
||||||
h.handle
|
h.handle
|
||||||
.replace_conversation(vec![ConversationItem::user("q".repeat(4000))]);
|
.replace_conversation(vec![ConversationItem::user("q".repeat(4000))]);
|
||||||
|
|
||||||
let total = h.handle.get_total_tokens().await;
|
let total = h.handle.get_total_tokens().await;
|
||||||
assert_eq!(
|
assert_eq!(
|
||||||
total, 1_000,
|
total, 500,
|
||||||
"non-compaction replace (e.g. rewind) keeps the plain estimate"
|
"same-size replace carries the provider-confirmed count"
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[tokio::test]
|
||||||
|
async fn replace_never_increases_total_tokens() {
|
||||||
|
// A growing replace is capped at the confirmed total; the under-count self-heals on the next usage.
|
||||||
|
let h = TestHarness::new();
|
||||||
|
h.handle
|
||||||
|
.push_user_message(ConversationItem::user("x".repeat(4000)));
|
||||||
|
h.handle.record_token_usage(1_500);
|
||||||
|
|
||||||
|
h.handle
|
||||||
|
.replace_conversation(vec![ConversationItem::user("q".repeat(40_000))]);
|
||||||
|
|
||||||
|
assert_eq!(h.handle.get_total_tokens().await, 1_500);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[tokio::test]
|
||||||
|
async fn truncate_scales_from_confirmed_total() {
|
||||||
|
// Rewind path: TruncateToPromptIndex must use the same carry as replace_conversation.
|
||||||
|
let h = TestHarness::new();
|
||||||
|
h.handle
|
||||||
|
.push_user_message(ConversationItem::user("x".repeat(4000)));
|
||||||
|
h.handle.increment_prompt_index();
|
||||||
|
h.handle
|
||||||
|
.push_user_message(ConversationItem::user("y".repeat(4000)));
|
||||||
|
h.handle.increment_prompt_index();
|
||||||
|
h.handle.record_token_usage(1_000);
|
||||||
|
// Estimate at last response = 2_000, confirmed = 1_000 → ratio 0.5.
|
||||||
|
|
||||||
|
h.handle.truncate_to_prompt_index(1).await;
|
||||||
|
|
||||||
|
// Keeps the first user item (raw estimate 1_000) → scaled to 500.
|
||||||
|
assert_eq!(h.handle.get_total_tokens().await, 500);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn reasoning_estimate_takes_the_larger_of_text_and_ciphertext() {
|
||||||
|
// "thinking for r1" is 15 bytes; 800 base64 bytes are ~600 raw bytes.
|
||||||
|
let encrypted = reasoning_sibling("r1", Some(&"A".repeat(800)));
|
||||||
|
assert_eq!(crate::estimate_conversation_tokens(&[encrypted]), 150);
|
||||||
|
let plain = reasoning_sibling("r1", None);
|
||||||
|
assert_eq!(crate::estimate_conversation_tokens(&[plain]), 3);
|
||||||
|
}
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn flush_calls_persistence_flush() {
|
async fn flush_calls_persistence_flush() {
|
||||||
let mut h = TestHarness::new();
|
let mut h = TestHarness::new();
|
||||||
|
|||||||
@@ -32,6 +32,9 @@ use rmcp::{
|
|||||||
|
|
||||||
use crate::oauth_config::McpOAuthConfig;
|
use crate::oauth_config::McpOAuthConfig;
|
||||||
|
|
||||||
|
mod cancel_aware;
|
||||||
|
use cancel_aware::call_tool_cancel_aware;
|
||||||
|
|
||||||
use kigi_tools::types::{
|
use kigi_tools::types::{
|
||||||
output::{MCPOutput, MCPOutputDetails, ToolOutput},
|
output::{MCPOutput, MCPOutputDetails, ToolOutput},
|
||||||
tool::{ToolKind, ToolNamespace},
|
tool::{ToolKind, ToolNamespace},
|
||||||
@@ -1599,12 +1602,24 @@ impl McpErasedTool {
|
|||||||
let mut params = CallToolRequestParams::new(self.tool.name.clone());
|
let mut params = CallToolRequestParams::new(self.tool.name.clone());
|
||||||
params.arguments = raw.as_object().cloned();
|
params.arguments = raw.as_object().cloned();
|
||||||
|
|
||||||
let result =
|
match call_tool_cancel_aware(&mcp_service, params.clone(), timeout_duration).await {
|
||||||
tokio::time::timeout(timeout_duration, mcp_service.call_tool(params.clone())).await;
|
Ok(call_result) => Ok(call_result),
|
||||||
|
Err(ServiceError::Timeout { .. }) => {
|
||||||
match result {
|
*is_timeout = true;
|
||||||
Ok(Ok(call_result)) => Ok(call_result),
|
// Reset for the next call but don't retry — a slow side-effecting tool must not run twice.
|
||||||
Ok(Err(service_err))
|
if client.is_http() && !*reconnect_attempted {
|
||||||
|
client.reset_transport().await;
|
||||||
|
*reconnect_attempted = true;
|
||||||
|
}
|
||||||
|
Err(kigi_tool_runtime::ToolError::custom(
|
||||||
|
"process_manager",
|
||||||
|
format!(
|
||||||
|
"MCP tool '{}' timed out after {} seconds",
|
||||||
|
self.tool.name, tool_timeout
|
||||||
|
),
|
||||||
|
))
|
||||||
|
}
|
||||||
|
Err(service_err)
|
||||||
if should_recover_service_error(
|
if should_recover_service_error(
|
||||||
&service_err,
|
&service_err,
|
||||||
client.is_http(),
|
client.is_http(),
|
||||||
@@ -1623,25 +1638,10 @@ impl McpErasedTool {
|
|||||||
)
|
)
|
||||||
.await
|
.await
|
||||||
}
|
}
|
||||||
Ok(Err(e)) => Err(kigi_tool_runtime::ToolError::custom(
|
Err(e) => Err(kigi_tool_runtime::ToolError::custom(
|
||||||
"process_manager",
|
"process_manager",
|
||||||
e.to_string(),
|
e.to_string(),
|
||||||
)),
|
)),
|
||||||
Err(_) => {
|
|
||||||
*is_timeout = true;
|
|
||||||
// Reset for the next call but don't retry — a slow side-effecting tool must not run twice.
|
|
||||||
if client.is_http() && !*reconnect_attempted {
|
|
||||||
client.reset_transport().await;
|
|
||||||
*reconnect_attempted = true;
|
|
||||||
}
|
|
||||||
Err(kigi_tool_runtime::ToolError::custom(
|
|
||||||
"process_manager",
|
|
||||||
format!(
|
|
||||||
"MCP tool '{}' timed out after {} seconds",
|
|
||||||
self.tool.name, tool_timeout
|
|
||||||
),
|
|
||||||
))
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1692,13 +1692,9 @@ impl McpErasedTool {
|
|||||||
));
|
));
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
match tokio::time::timeout(timeout_duration, mcp_service.call_tool(params)).await {
|
match call_tool_cancel_aware(&mcp_service, params, timeout_duration).await {
|
||||||
Ok(Ok(call_result)) => Ok(call_result),
|
Ok(call_result) => Ok(call_result),
|
||||||
Ok(Err(retry_err)) => Err(kigi_tool_runtime::ToolError::custom(
|
Err(ServiceError::Timeout { .. }) => {
|
||||||
"process_manager",
|
|
||||||
retry_err.to_string(),
|
|
||||||
)),
|
|
||||||
Err(_) => {
|
|
||||||
*is_timeout = true;
|
*is_timeout = true;
|
||||||
Err(kigi_tool_runtime::ToolError::custom(
|
Err(kigi_tool_runtime::ToolError::custom(
|
||||||
"process_manager",
|
"process_manager",
|
||||||
@@ -1708,6 +1704,10 @@ impl McpErasedTool {
|
|||||||
),
|
),
|
||||||
))
|
))
|
||||||
}
|
}
|
||||||
|
Err(retry_err) => Err(kigi_tool_runtime::ToolError::custom(
|
||||||
|
"process_manager",
|
||||||
|
retry_err.to_string(),
|
||||||
|
)),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -6223,11 +6223,17 @@ mod tests {
|
|||||||
let mut reconnect = false;
|
let mut reconnect = false;
|
||||||
let mut is_timeout = false;
|
let mut is_timeout = false;
|
||||||
let raw = serde_json::json!({});
|
let raw = serde_json::json!({});
|
||||||
|
let started = std::time::Instant::now();
|
||||||
let err = tool
|
let err = tool
|
||||||
.try_call_tool(&client, &raw, &mut reconnect, &mut is_timeout, &ew)
|
.try_call_tool(&client, &raw, &mut reconnect, &mut is_timeout, &ew)
|
||||||
.await
|
.await
|
||||||
.expect_err("call must time out");
|
.expect_err("call must time out");
|
||||||
|
|
||||||
|
assert!(
|
||||||
|
started.elapsed() < std::time::Duration::from_millis(2500),
|
||||||
|
"cancel must not wait out the 3s hang: {:?}",
|
||||||
|
started.elapsed()
|
||||||
|
);
|
||||||
assert!(err.to_string().contains("timed out"), "got: {err}");
|
assert!(err.to_string().contains("timed out"), "got: {err}");
|
||||||
assert!(is_timeout, "is_timeout must be set");
|
assert!(is_timeout, "is_timeout must be set");
|
||||||
assert!(reconnect, "timeout arm flags the reconnect after resetting");
|
assert!(reconnect, "timeout arm flags the reconnect after resetting");
|
||||||
|
|||||||
@@ -0,0 +1,224 @@
|
|||||||
|
//! `tools/call` that tells the server when the host stops waiting.
|
||||||
|
|
||||||
|
use rmcp::model::{
|
||||||
|
CallToolRequest, CallToolRequestParams, CallToolResult, CancelledNotificationParam,
|
||||||
|
ClientRequest, RequestId, ServerResult,
|
||||||
|
};
|
||||||
|
use rmcp::service::{Peer, PeerRequestOptions};
|
||||||
|
use rmcp::{RoleClient, ServiceError};
|
||||||
|
|
||||||
|
use super::McpService;
|
||||||
|
|
||||||
|
/// rmcp 2.2.0's HTTP worker queues the cancel behind a hung POST, so the wait is bounded.
|
||||||
|
const CANCEL_DELIVERY_BUDGET: std::time::Duration = std::time::Duration::from_millis(500);
|
||||||
|
|
||||||
|
/// A timeout cancels inline, before the caller can reset the transport; a drop cancels from a task.
|
||||||
|
pub(super) async fn call_tool_cancel_aware(
|
||||||
|
service: &McpService,
|
||||||
|
params: CallToolRequestParams,
|
||||||
|
timeout: std::time::Duration,
|
||||||
|
) -> Result<CallToolResult, ServiceError> {
|
||||||
|
let handle = service
|
||||||
|
.peer()
|
||||||
|
.send_cancellable_request(
|
||||||
|
ClientRequest::CallToolRequest(CallToolRequest::new(params)),
|
||||||
|
PeerRequestOptions::no_options(),
|
||||||
|
)
|
||||||
|
.await?;
|
||||||
|
let mut guard = CancelOnDrop {
|
||||||
|
peer: service.peer().clone(),
|
||||||
|
request_id: Some(handle.id.clone()),
|
||||||
|
};
|
||||||
|
let Ok(response) = tokio::time::timeout(timeout, handle.await_response()).await else {
|
||||||
|
guard.cancel_within_budget().await;
|
||||||
|
return Err(ServiceError::Timeout { timeout });
|
||||||
|
};
|
||||||
|
guard.request_id = None;
|
||||||
|
match response? {
|
||||||
|
ServerResult::CallToolResult(result) => Ok(result),
|
||||||
|
_ => Err(ServiceError::UnexpectedResponse),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Armed while the request is in flight; disarmed once it settles.
|
||||||
|
struct CancelOnDrop {
|
||||||
|
peer: Peer<RoleClient>,
|
||||||
|
request_id: Option<RequestId>,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl CancelOnDrop {
|
||||||
|
async fn cancel_within_budget(&mut self) {
|
||||||
|
let Some(request_id) = self.request_id.clone() else {
|
||||||
|
return;
|
||||||
|
};
|
||||||
|
let delivery = notify_cancelled(self.peer.clone(), request_id.clone());
|
||||||
|
if tokio::time::timeout(CANCEL_DELIVERY_BUDGET, delivery)
|
||||||
|
.await
|
||||||
|
.is_err()
|
||||||
|
{
|
||||||
|
tracing::warn!(
|
||||||
|
?request_id,
|
||||||
|
"notifications/cancelled still queued after budget"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
self.request_id = None;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
impl Drop for CancelOnDrop {
|
||||||
|
fn drop(&mut self) {
|
||||||
|
let Some(request_id) = self.request_id.take() else {
|
||||||
|
return;
|
||||||
|
};
|
||||||
|
let Ok(runtime) = tokio::runtime::Handle::try_current() else {
|
||||||
|
tracing::warn!(
|
||||||
|
?request_id,
|
||||||
|
"MCP call dropped outside a runtime; cancel not sent"
|
||||||
|
);
|
||||||
|
return;
|
||||||
|
};
|
||||||
|
runtime.spawn(notify_cancelled(self.peer.clone(), request_id));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
async fn notify_cancelled(peer: Peer<RoleClient>, request_id: RequestId) {
|
||||||
|
let params = CancelledNotificationParam::new(
|
||||||
|
Some(request_id.clone()),
|
||||||
|
Some("client cancelled".to_owned()),
|
||||||
|
);
|
||||||
|
if let Err(e) = peer.notify_cancelled(params).await {
|
||||||
|
tracing::warn!(?request_id, error = %e, "notifications/cancelled not delivered");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(test)]
|
||||||
|
mod tests {
|
||||||
|
use std::sync::Arc;
|
||||||
|
use std::time::Duration;
|
||||||
|
|
||||||
|
use rmcp::ServiceExt;
|
||||||
|
use serde_json::Value;
|
||||||
|
use tokio::io::{AsyncBufReadExt, AsyncWriteExt, BufReader};
|
||||||
|
|
||||||
|
use super::super::{KigiClientHandler, McpClient};
|
||||||
|
use super::*;
|
||||||
|
|
||||||
|
type Received = Arc<parking_lot::Mutex<Vec<Value>>>;
|
||||||
|
|
||||||
|
/// Duplex MCP server: answers `initialize`, records all, answers `tools/call` only when `reply`.
|
||||||
|
async fn recording_service(reply: bool) -> (McpService, Received) {
|
||||||
|
let received = Received::default();
|
||||||
|
let (client_read, mut server_write) = tokio::io::duplex(64 * 1024);
|
||||||
|
let (server_read, client_write) = tokio::io::duplex(64 * 1024);
|
||||||
|
let sink = received.clone();
|
||||||
|
tokio::spawn(async move {
|
||||||
|
let mut lines = BufReader::new(server_read).lines();
|
||||||
|
while let Ok(Some(line)) = lines.next_line().await {
|
||||||
|
let msg: Value = serde_json::from_str(&line).expect("client sends JSON");
|
||||||
|
sink.lock().push(msg.clone());
|
||||||
|
let result = match msg["method"].as_str() {
|
||||||
|
Some("initialize") => serde_json::json!({
|
||||||
|
"protocolVersion": msg["params"]["protocolVersion"],
|
||||||
|
"capabilities": { "tools": {} },
|
||||||
|
"serverInfo": { "name": "recording", "version": "0.0.0" },
|
||||||
|
}),
|
||||||
|
Some("tools/call") if reply => serde_json::json!({
|
||||||
|
"content": [{ "type": "text", "text": "done" }],
|
||||||
|
"isError": false,
|
||||||
|
}),
|
||||||
|
_ => continue,
|
||||||
|
};
|
||||||
|
let response =
|
||||||
|
serde_json::json!({ "jsonrpc": "2.0", "id": msg["id"], "result": result });
|
||||||
|
let encoded = format!("{response}\n");
|
||||||
|
server_write
|
||||||
|
.write_all(encoded.as_bytes())
|
||||||
|
.await
|
||||||
|
.expect("client reads replies");
|
||||||
|
}
|
||||||
|
});
|
||||||
|
let handler = KigiClientHandler {
|
||||||
|
info: McpClient::make_client_info("recording"),
|
||||||
|
server_name: "recording".to_string(),
|
||||||
|
notify_tx: Arc::default(),
|
||||||
|
};
|
||||||
|
let transport = rmcp::transport::async_rw::AsyncRwTransport::<RoleClient, _, _>::new(
|
||||||
|
client_read,
|
||||||
|
client_write,
|
||||||
|
);
|
||||||
|
let service = Arc::new(handler.serve(transport).await.expect("handshake"));
|
||||||
|
(service, received)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn values_at(received: &Received, method: &str, pointer: &str) -> Vec<Value> {
|
||||||
|
received
|
||||||
|
.lock()
|
||||||
|
.iter()
|
||||||
|
.filter(|m| m["method"] == method)
|
||||||
|
.map(|m| m.pointer(pointer).cloned().unwrap_or(Value::Null))
|
||||||
|
.collect()
|
||||||
|
}
|
||||||
|
|
||||||
|
fn call_ids(received: &Received) -> Vec<Value> {
|
||||||
|
values_at(received, "tools/call", "/id")
|
||||||
|
}
|
||||||
|
|
||||||
|
fn cancelled_ids(received: &Received) -> Vec<Value> {
|
||||||
|
values_at(received, "notifications/cancelled", "/params/requestId")
|
||||||
|
}
|
||||||
|
|
||||||
|
#[tokio::test]
|
||||||
|
async fn dropped_call_cancels_its_request() {
|
||||||
|
let (service, received) = recording_service(false).await;
|
||||||
|
let mut call = Box::pin(call_tool_cancel_aware(
|
||||||
|
&service,
|
||||||
|
CallToolRequestParams::new("slow"),
|
||||||
|
Duration::from_secs(30),
|
||||||
|
));
|
||||||
|
let pending = tokio::time::timeout(Duration::from_millis(100), &mut call).await;
|
||||||
|
assert!(pending.is_err(), "server never replies");
|
||||||
|
drop(call);
|
||||||
|
tokio::time::sleep(Duration::from_millis(100)).await;
|
||||||
|
|
||||||
|
let ids = call_ids(&received);
|
||||||
|
assert_eq!(ids.len(), 1, "{ids:?}");
|
||||||
|
assert_eq!(cancelled_ids(&received), ids);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[tokio::test]
|
||||||
|
async fn timed_out_call_cancels_its_request_once() {
|
||||||
|
let (service, received) = recording_service(false).await;
|
||||||
|
let round = call_tool_cancel_aware(
|
||||||
|
&service,
|
||||||
|
CallToolRequestParams::new("slow"),
|
||||||
|
Duration::from_millis(50),
|
||||||
|
)
|
||||||
|
.await;
|
||||||
|
assert!(
|
||||||
|
matches!(round, Err(ServiceError::Timeout { .. })),
|
||||||
|
"{round:?}"
|
||||||
|
);
|
||||||
|
// The HTTP timeout arm resets the transport, which drops the last service handle.
|
||||||
|
drop(service);
|
||||||
|
tokio::time::sleep(Duration::from_millis(100)).await;
|
||||||
|
|
||||||
|
let ids = call_ids(&received);
|
||||||
|
assert_eq!(ids.len(), 1, "{ids:?}");
|
||||||
|
assert_eq!(cancelled_ids(&received), ids);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[tokio::test]
|
||||||
|
async fn completed_call_sends_no_cancellation() {
|
||||||
|
let (service, received) = recording_service(true).await;
|
||||||
|
let result = call_tool_cancel_aware(
|
||||||
|
&service,
|
||||||
|
CallToolRequestParams::new("fast"),
|
||||||
|
Duration::from_secs(5),
|
||||||
|
)
|
||||||
|
.await
|
||||||
|
.expect("server replies");
|
||||||
|
assert_eq!(result.is_error, Some(false));
|
||||||
|
tokio::time::sleep(Duration::from_millis(50)).await;
|
||||||
|
assert_eq!(cancelled_ids(&received), Vec::<Value>::new());
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -1 +1 @@
|
|||||||
{"_meta":{"note":"filtered snapshot for kigi model-metadata enrichment; regenerate via scripts/gen_enrichment_snapshot.py","source":"https://models.dev/api.json (github.com/sst/models.dev, MIT)"},"alibaba-token-plan":{"models":{"MiniMax-M2.5":{"limit":{"context":196608,"input":196601,"output":24576},"modalities":{"input":["text"],"output":["text"]},"name":"MiniMax-M2.5","reasoning":true,"reasoning_options":[],"tool_call":true},"deepseek-v3.2":{"limit":{"context":131072,"output":65536},"modalities":{"input":["text"],"output":["text"]},"name":"DeepSeek V3.2","reasoning":true,"reasoning_options":[{"type":"toggle"}],"tool_call":true},"deepseek-v4-flash":{"limit":{"context":1000000,"output":384000},"modalities":{"input":["text"],"output":["text"]},"name":"DeepSeek V4 Flash","reasoning":true,"reasoning_options":[{"type":"toggle"},{"type":"effort","values":["high","max"]}],"tool_call":true},"deepseek-v4-pro":{"limit":{"context":1000000,"output":384000},"modalities":{"input":["text"],"output":["text"]},"name":"DeepSeek V4 Pro","reasoning":true,"reasoning_options":[{"type":"toggle"},{"type":"effort","values":["high","max"]}],"tool_call":true},"glm-5":{"limit":{"context":202752,"output":16384},"modalities":{"input":["text"],"output":["text"]},"name":"GLM-5","reasoning":true,"reasoning_options":[{"type":"toggle"}],"tool_call":true},"glm-5.1":{"limit":{"context":202752,"output":128000},"modalities":{"input":["text"],"output":["text"]},"name":"GLM-5.1","reasoning":true,"reasoning_options":[{"type":"toggle"}],"tool_call":true},"glm-5.2":{"limit":{"context":1000000,"output":131072},"modalities":{"input":["text"],"output":["text"]},"name":"GLM-5.2","reasoning":true,"reasoning_options":[{"type":"effort","values":["high","max"]}],"tool_call":true},"kimi-k2.5":{"limit":{"context":262144,"output":32768},"modalities":{"input":["text","image","video"],"output":["text"]},"name":"Kimi K2.5","reasoning":true,"reasoning_options":[{"type":"toggle"},{"type":"budget_tokens"}],"tool_call":true},"kimi-k2.6":{"limit":{"context":262144,"output":16384},"modalities":{"input":["text","image","video"],"output":["text"]},"name":"Kimi K2.6","reasoning":true,"reasoning_options":[{"type":"toggle"},{"type":"budget_tokens"}],"tool_call":true},"kimi-k2.7-code":{"limit":{"context":262144,"output":262144},"modalities":{"input":["text","image","video"],"output":["text"]},"name":"Kimi K2.7 Code","reasoning":true,"reasoning_options":[{"type":"toggle"},{"type":"budget_tokens"}],"tool_call":true},"qwen-image-2.0":{"limit":{"context":8192,"output":0},"modalities":{"input":["text"],"output":["image"]},"name":"Qwen Image 2.0","reasoning":false,"tool_call":false},"qwen-image-2.0-pro":{"limit":{"context":8192,"output":0},"modalities":{"input":["text"],"output":["image"]},"name":"Qwen Image 2.0 Pro","reasoning":false,"tool_call":false},"qwen3.6-flash":{"limit":{"context":1000000,"output":65536},"modalities":{"input":["text","image","video"],"output":["text"]},"name":"Qwen3.6 Flash","reasoning":true,"reasoning_options":[{"type":"toggle"},{"max":81920,"type":"budget_tokens"}],"tool_call":true},"qwen3.6-plus":{"limit":{"context":1000000,"output":65536},"modalities":{"input":["text","image","video"],"output":["text"]},"name":"Qwen3.6 Plus","reasoning":true,"reasoning_options":[{"type":"toggle"},{"max":81920,"type":"budget_tokens"}],"tool_call":true},"qwen3.7-max":{"limit":{"context":1000000,"output":65536},"modalities":{"input":["text"],"output":["text"]},"name":"Qwen3.7 Max","reasoning":true,"reasoning_options":[{"type":"toggle"},{"max":262144,"type":"budget_tokens"}],"tool_call":true},"qwen3.7-plus":{"limit":{"context":1000000,"output":64000},"modalities":{"input":["text","image"],"output":["text"]},"name":"Qwen3.7 Plus","reasoning":true,"reasoning_options":[{"type":"toggle"},{"max":262144,"type":"budget_tokens"}],"tool_call":true},"qwen3.8-max-preview":{"limit":{"context":1000000,"output":131072},"modalities":{"input":["text","image","video"],"output":["text"]},"name":"Qwen3.8 Max Preview","reasoning":true,"reasoning_options":[{"type":"effort","values":["low","medium","xhigh"]},{"max":262144,"min":0,"type":"budget_tokens"}],"tool_call":true},"wan2.7-image":{"limit":{"context":8192,"output":0},"modalities":{"input":["text"],"output":["image"]},"name":"Wan2.7 Image","reasoning":false,"tool_call":false},"wan2.7-image-pro":{"limit":{"context":8192,"output":0},"modalities":{"input":["text"],"output":["image"]},"name":"Wan2.7 Image Pro","reasoning":false,"tool_call":false}}},"alibaba-token-plan-cn":{"models":{"MiniMax-M2.5":{"limit":{"context":196608,"input":196601,"output":24576},"modalities":{"input":["text"],"output":["text"]},"name":"MiniMax-M2.5","reasoning":true,"reasoning_options":[],"tool_call":true},"deepseek-v3.2":{"limit":{"context":131072,"output":65536},"modalities":{"input":["text"],"output":["text"]},"name":"DeepSeek V3.2","reasoning":true,"reasoning_options":[{"type":"toggle"}],"tool_call":true},"deepseek-v4-flash":{"limit":{"context":1000000,"output":3Line truncated
|
{"_meta":{"note":"filtered snapshot for kigi model-metadata enrichment; regenerate via scripts/gen_enrichment_snapshot.py","source":"https://models.dev/api.json (github.com/sst/models.dev, MIT)"},"alibaba-token-plan":{"models":{"MiniMax-M2.5":{"limit":{"context":196608,"input":196601,"output":32768},"modalities":{"input":["text"],"output":["text"]},"name":"MiniMax-M2.5","reasoning":true,"reasoning_options":[],"tool_call":true},"deepseek-v3.2":{"limit":{"context":131072,"output":65536},"modalities":{"input":["text"],"output":["text"]},"name":"DeepSeek V3.2","reasoning":true,"reasoning_options":[{"type":"toggle"}],"tool_call":true},"deepseek-v4-flash":{"limit":{"context":1000000,"output":384000},"modalities":{"input":["text"],"output":["text"]},"name":"DeepSeek V4 Flash","reasoning":true,"reasoning_options":[{"type":"toggle"},{"type":"effort","values":["high","max"]}],"tool_call":true},"deepseek-v4-flash-0731":{"limit":{"context":1000000,"output":384000},"modalities":{"input":["text"],"output":["text"]},"name":"DeepSeek V4 Flash 0731","reasoning":true,"reasoning_options":[{"type":"toggle"},{"type":"effort","values":["high","max"]}],"tool_call":true},"deepseek-v4-pro":{"limit":{"context":1000000,"output":384000},"modalities":{"input":["text"],"output":["text"]},"name":"DeepSeek V4 Pro","reasoning":true,"reasoning_options":[{"type":"toggle"},{"type":"effort","values":["high","max"]}],"tool_call":true},"deepseek-v4-pro-0813":{"limit":{"context":1000000,"output":384000},"modalities":{"input":["text"],"output":["text"]},"name":"DeepSeek V4 Pro 0813","reasoning":true,"reasoning_options":[{"type":"toggle"},{"type":"effort","values":["high","max"]}],"tool_call":true},"deepseek-v4.1-flash":{"limit":{"context":1000000,"output":384000},"modalities":{"input":["text","image"],"output":["text"]},"name":"DeepSeek V4.1 Flash","reasoning":true,"reasoning_options":[{"type":"toggle"},{"type":"effort","values":["low","high","max"]}],"tool_call":true},"glm-5":{"limit":{"context":202752,"output":16384},"modalities":{"input":["text"],"output":["text"]},"name":"GLM-5","reasoning":true,"reasoning_options":[{"type":"toggle"}],"tool_call":true},"glm-5.1":{"limit":{"context":202752,"output":128000},"modalities":{"input":["text"],"output":["text"]},"name":"GLM-5.1","reasoning":true,"reasoning_options":[{"type":"toggle"}],"tool_call":true},"glm-5.2":{"limit":{"context":1000000,"output":131072},"modalities":{"input":["text"],"output":["text"]},"name":"GLM-5.2","reasoning":true,"reasoning_options":[{"type":"effort","values":["high","max"]}],"tool_call":true},"glm-5.3":{"limit":{"context":1000000,"output":131072},"modalities":{"input":["text"],"output":["text"]},"name":"GLM-5.3","reasoning":true,"reasoning_options":[{"type":"effort","values":["low","high","max"]}],"tool_call":true},"happyhorse-1.1-i2v":{"limit":{"context":0,"output":0},"modalities":{"input":["image","text"],"output":["video"]},"name":"HappyHorse 1.1 Image-to-Video","reasoning":false,"tool_call":false},"happyhorse-1.1-r2v":{"limit":{"context":0,"output":0},"modalities":{"input":["image","text"],"output":["video"]},"name":"HappyHorse 1.1 Reference-to-Video","reasoning":false,"tool_call":false},"happyhorse-1.1-t2v":{"limit":{"context":0,"output":0},"modalities":{"input":["text"],"output":["video"]},"name":"HappyHorse 1.1 Text-to-Video","reasoning":false,"tool_call":false},"kimi-k2.5":{"limit":{"context":262144,"output":98304},"modalities":{"input":["text","image","video"],"output":["text"]},"name":"Kimi K2.5","reasoning":true,"reasoning_options":[{"type":"toggle"},{"type":"budget_tokens"}],"tool_call":true},"kimi-k2.6":{"limit":{"context":262144,"output":262144},"modalities":{"input":["text","image","video"],"output":["text"]},"name":"Kimi K2.6","reasoning":true,"reasoning_options":[{"type":"toggle"},{"type":"budget_tokens"}],"tool_call":true},"kimi-k2.7-code":{"limit":{"context":262144,"output":262144},"modalities":{"input":["text","image","video"],"output":["text"]},"name":"Kimi K2.7 Code","reasoning":true,"reasoning_options":[{"type":"toggle"},{"type":"budget_tokens"}],"tool_call":true},"qwen-image-2.0":{"limit":{"context":8192,"output":0},"modalities":{"input":["text"],"output":["image"]},"name":"Qwen Image 2.0","reasoning":false,"tool_call":false},"qwen-image-2.0-pro":{"limit":{"context":8192,"output":0},"modalities":{"input":["text"],"output":["image"]},"name":"Qwen Image 2.0 Pro","reasoning":false,"tool_call":false},"qwen3.6-flash":{"limit":{"context":1000000,"output":65536},"modalities":{"input":["text","image","video"],"output":["text"]},"name":"Qwen3.6 Flash","reasoning":true,"reasoning_options":[{"type":"toggle"},{"max":131072,"type":"budget_tokens"}],"tool_call":true},"qwen3.6-plus":{"limit":{"context":1000000,"output":65536},"modalities":{"input":["text","image","video"],"output":["text"]},"name":"Qwen3.6 Plus","reasoning":true,"reasoning_options":[{"type":"toggle"},{"max":131072,"type":"budget_tokens"}],"tool_call":true},"qwen3.7-max":{"limit":{"context":1000000,Line truncated
|
||||||
@@ -223,7 +223,7 @@ mod tests {
|
|||||||
"snapshot lost providers: {}",
|
"snapshot lost providers: {}",
|
||||||
catalog.len()
|
catalog.len()
|
||||||
);
|
);
|
||||||
let k3 = lookup(catalog, "kimi-for-coding", "k3").expect("k3 present");
|
let k3 = lookup(catalog, "kimi-code-plan-cn", "k3").expect("k3 present");
|
||||||
assert_eq!(k3.context, 1_048_576, "k3 context must match the live wire");
|
assert_eq!(k3.context, 1_048_576, "k3 context must match the live wire");
|
||||||
assert_eq!(k3.efforts, ["low", "high", "max"]);
|
assert_eq!(k3.efforts, ["low", "high", "max"]);
|
||||||
assert!(k3.reasoning);
|
assert!(k3.reasoning);
|
||||||
@@ -232,6 +232,21 @@ mod tests {
|
|||||||
assert_eq!(opus.efforts, ["low", "medium", "high", "xhigh", "max"]);
|
assert_eq!(opus.efforts, ["low", "medium", "high", "xhigh", "max"]);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// `restrict_to_enriched` drops a live listing id the enrichment catalog
|
||||||
|
/// does not know, so the bundled snapshot must admit the current flagship
|
||||||
|
/// models offline: grok-4.7 on xai (the `xai`/`xai-grok` rows) and
|
||||||
|
/// gpt-6-astra on the API-key `openai` row.
|
||||||
|
#[test]
|
||||||
|
fn bundled_snapshot_admits_the_current_flagship_models() {
|
||||||
|
let catalog = bundled_enrichment();
|
||||||
|
let grok = lookup(catalog, "xai", "grok-4.7").expect("grok-4.7 present");
|
||||||
|
assert!(grok.tool_call, "a non-tool-calling model is dropped");
|
||||||
|
assert_eq!(grok.context, 500_000);
|
||||||
|
let astra = lookup(catalog, "openai", "gpt-6-astra").expect("gpt-6-astra present");
|
||||||
|
assert!(astra.tool_call);
|
||||||
|
assert_eq!(astra.context, 1_050_000);
|
||||||
|
}
|
||||||
|
|
||||||
/// Wire-served fields are never overwritten; absent fields are filled.
|
/// Wire-served fields are never overwritten; absent fields are filled.
|
||||||
#[test]
|
#[test]
|
||||||
fn enrich_fills_gaps_and_never_overwrites_wire() {
|
fn enrich_fills_gaps_and_never_overwrites_wire() {
|
||||||
|
|||||||
@@ -400,7 +400,7 @@ const KIMI_CODE_SPEC: PlatformSpec = PlatformSpec {
|
|||||||
vendor: "Kimi",
|
vendor: "Kimi",
|
||||||
console_host: None,
|
console_host: None,
|
||||||
login_label: None,
|
login_label: None,
|
||||||
models_dev_id: Some("kimi-for-coding"),
|
models_dev_id: Some("kimi-code-plan-cn"),
|
||||||
wire_serves_metadata: true,
|
wire_serves_metadata: true,
|
||||||
wire_api: PlatformWireApi::ChatCompletions,
|
wire_api: PlatformWireApi::ChatCompletions,
|
||||||
listing: ListingDialect::OpenAi,
|
listing: ListingDialect::OpenAi,
|
||||||
@@ -987,7 +987,7 @@ const KIMI_CODING_SPEC: PlatformSpec = PlatformSpec {
|
|||||||
vendor: "Kimi",
|
vendor: "Kimi",
|
||||||
console_host: Some("www.kimi.com"),
|
console_host: Some("www.kimi.com"),
|
||||||
login_label: Some("Kimi For Coding (API key)"),
|
login_label: Some("Kimi For Coding (API key)"),
|
||||||
models_dev_id: Some("kimi-for-coding"),
|
models_dev_id: Some("kimi-code-plan-cn"),
|
||||||
wire_serves_metadata: true,
|
wire_serves_metadata: true,
|
||||||
wire_api: PlatformWireApi::ChatCompletions,
|
wire_api: PlatformWireApi::ChatCompletions,
|
||||||
listing: ListingDialect::OpenAi,
|
listing: ListingDialect::OpenAi,
|
||||||
@@ -1570,9 +1570,10 @@ impl PlatformId {
|
|||||||
/// The compiled-in catalog for a platform that serves NO live `/models`
|
/// The compiled-in catalog for a platform that serves NO live `/models`
|
||||||
/// listing (openai-codex), or `None` when the catalog comes from the wire.
|
/// listing (openai-codex), or `None` when the catalog comes from the wire.
|
||||||
///
|
///
|
||||||
/// openai-codex's 4 models are HARDCODED (read from the official Codex CLI's
|
/// openai-codex's 7 models are HARDCODED (read from the Codex backend
|
||||||
/// `models_cache.json`, the `visibility=="list"` AND `supported_in_api==true`
|
/// catalog on 2026-09-22, the `visibility=="list"` AND
|
||||||
/// set) because OpenAI exposes no stable public models endpoint for the
|
/// `supported_in_api==true` set) because OpenAI exposes no stable public
|
||||||
|
/// models endpoint for the
|
||||||
/// ChatGPT Codex backend. Each entry carries context window + per-model
|
/// ChatGPT Codex backend. Each entry carries context window + per-model
|
||||||
/// selectable reasoning efforts (incl. the codex-only `xhigh`/`max`
|
/// selectable reasoning efforts (incl. the codex-only `xhigh`/`max`
|
||||||
/// tiers), so the fetch path maps them through the SAME
|
/// tiers), so the fetch path maps them through the SAME
|
||||||
@@ -1606,14 +1607,33 @@ fn codex_wire_model(slug: &str, display_name: &str, efforts: &[&str], default: &
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// The HARDCODED openai-codex catalog: exactly the 4 `visibility=="list"` AND
|
/// The HARDCODED openai-codex catalog: exactly the 7 `visibility=="list"` AND
|
||||||
/// `supported_in_api==true` models from the Codex CLI model cache. The
|
/// `supported_in_api==true` models the Codex backend served on 2026-09-22, in
|
||||||
/// `gpt-5.3-codex-spark` (supported_in_api=false → not served by /responses),
|
/// its own priority order. `gpt-reserve` and `codex-auto-review`
|
||||||
/// `gpt-5.4`, `gpt-5.4-mini`, and `codex-auto-review` (visibility="hide") models
|
/// (visibility="hide") are deliberately EXCLUDED — they are not user-facing
|
||||||
/// are deliberately EXCLUDED — they would list-but-not-work or are not
|
/// (fail-fast: never advertise a model the backend rejects). Several models
|
||||||
/// user-facing (fail-fast: never advertise a model the backend rejects).
|
/// also advertise an `ultra` tier above `max`; kigi has no such level, so it
|
||||||
|
/// is not listed here.
|
||||||
fn openai_codex_wire_models() -> Vec<WireModel> {
|
fn openai_codex_wire_models() -> Vec<WireModel> {
|
||||||
vec![
|
vec![
|
||||||
|
codex_wire_model(
|
||||||
|
"gpt-6-astra",
|
||||||
|
"GPT-6-Astra",
|
||||||
|
&["low", "medium", "high", "xhigh", "max"],
|
||||||
|
"medium",
|
||||||
|
),
|
||||||
|
codex_wire_model(
|
||||||
|
"gpt-6-sol",
|
||||||
|
"GPT-6-Sol",
|
||||||
|
&["low", "medium", "high", "xhigh", "max"],
|
||||||
|
"medium",
|
||||||
|
),
|
||||||
|
codex_wire_model(
|
||||||
|
"gpt-6-luna",
|
||||||
|
"GPT-6-Luna",
|
||||||
|
&["low", "medium", "high", "xhigh", "max"],
|
||||||
|
"medium",
|
||||||
|
),
|
||||||
codex_wire_model(
|
codex_wire_model(
|
||||||
"gpt-5.6-sol",
|
"gpt-5.6-sol",
|
||||||
"GPT-5.6-Sol",
|
"GPT-5.6-Sol",
|
||||||
@@ -2653,29 +2673,32 @@ mod tests {
|
|||||||
assert_eq!(c.base_url(), "https://mock.codex/codex");
|
assert_eq!(c.base_url(), "https://mock.codex/codex");
|
||||||
}
|
}
|
||||||
|
|
||||||
/// The HARDCODED openai-codex catalog is exactly the 4 supported+listed
|
/// The HARDCODED openai-codex catalog is exactly the 7 supported+listed
|
||||||
/// models, keyed by slug, ctx 272000, each exposing its exact supported
|
/// models, keyed by slug, ctx 272000, each exposing its exact supported
|
||||||
/// efforts (incl. the codex-only `xhigh`/`max` tiers). The
|
/// efforts (incl. the codex-only `xhigh`/`max` tiers). The hidden models
|
||||||
/// list-but-broken / hidden models are absent. Every other platform serves
|
/// are absent. Every other platform serves NO hardcoded catalog (its
|
||||||
/// NO hardcoded catalog (its models come from the live wire).
|
/// models come from the live wire).
|
||||||
#[test]
|
#[test]
|
||||||
fn openai_codex_hardcoded_catalog_is_the_four_supported_models() {
|
fn openai_codex_hardcoded_catalog_is_the_seven_supported_models() {
|
||||||
let catalog = PlatformId::OpenaiCodex
|
let catalog = PlatformId::OpenaiCodex
|
||||||
.hardcoded_catalog()
|
.hardcoded_catalog()
|
||||||
.expect("openai-codex serves a hardcoded catalog");
|
.expect("openai-codex serves a hardcoded catalog");
|
||||||
let ids: Vec<&str> = catalog.iter().map(|m| m.id.as_str()).collect();
|
let ids: Vec<&str> = catalog.iter().map(|m| m.id.as_str()).collect();
|
||||||
assert_eq!(
|
assert_eq!(
|
||||||
ids,
|
ids,
|
||||||
vec!["gpt-5.6-sol", "gpt-5.6-terra", "gpt-5.6-luna", "gpt-5.5"],
|
vec![
|
||||||
"exactly the 4 visibility=list AND supported_in_api=true models"
|
"gpt-6-astra",
|
||||||
|
"gpt-6-sol",
|
||||||
|
"gpt-6-luna",
|
||||||
|
"gpt-5.6-sol",
|
||||||
|
"gpt-5.6-terra",
|
||||||
|
"gpt-5.6-luna",
|
||||||
|
"gpt-5.5"
|
||||||
|
],
|
||||||
|
"exactly the 7 visibility=list AND supported_in_api=true models"
|
||||||
);
|
);
|
||||||
// Excluded: list-but-not-served + hidden models never appear.
|
// Excluded: hidden models never appear.
|
||||||
for absent in [
|
for absent in ["gpt-reserve", "codex-auto-review"] {
|
||||||
"gpt-5.3-codex-spark",
|
|
||||||
"gpt-5.4",
|
|
||||||
"gpt-5.4-mini",
|
|
||||||
"codex-auto-review",
|
|
||||||
] {
|
|
||||||
assert!(
|
assert!(
|
||||||
!ids.contains(&absent),
|
!ids.contains(&absent),
|
||||||
"{absent} must be excluded from the hardcoded catalog"
|
"{absent} must be excluded from the hardcoded catalog"
|
||||||
@@ -2700,6 +2723,19 @@ mod tests {
|
|||||||
.valid_efforts
|
.valid_efforts
|
||||||
.clone()
|
.clone()
|
||||||
};
|
};
|
||||||
|
assert_eq!(
|
||||||
|
efforts("gpt-6-astra"),
|
||||||
|
["low", "medium", "high", "xhigh", "max"],
|
||||||
|
"`ultra` is advertised above `max` but kigi has no such level"
|
||||||
|
);
|
||||||
|
assert_eq!(
|
||||||
|
efforts("gpt-6-sol"),
|
||||||
|
["low", "medium", "high", "xhigh", "max"]
|
||||||
|
);
|
||||||
|
assert_eq!(
|
||||||
|
efforts("gpt-6-luna"),
|
||||||
|
["low", "medium", "high", "xhigh", "max"]
|
||||||
|
);
|
||||||
assert_eq!(
|
assert_eq!(
|
||||||
efforts("gpt-5.6-sol"),
|
efforts("gpt-5.6-sol"),
|
||||||
["low", "medium", "high", "xhigh", "max"]
|
["low", "medium", "high", "xhigh", "max"]
|
||||||
@@ -2725,6 +2761,9 @@ mod tests {
|
|||||||
.default_effort
|
.default_effort
|
||||||
.clone()
|
.clone()
|
||||||
};
|
};
|
||||||
|
assert_eq!(default("gpt-6-astra").as_deref(), Some("medium"));
|
||||||
|
assert_eq!(default("gpt-6-sol").as_deref(), Some("medium"));
|
||||||
|
assert_eq!(default("gpt-6-luna").as_deref(), Some("medium"));
|
||||||
assert_eq!(default("gpt-5.6-sol").as_deref(), Some("low"));
|
assert_eq!(default("gpt-5.6-sol").as_deref(), Some("low"));
|
||||||
assert_eq!(default("gpt-5.6-terra").as_deref(), Some("medium"));
|
assert_eq!(default("gpt-5.6-terra").as_deref(), Some("medium"));
|
||||||
// Only openai-codex has a hardcoded catalog; every wire platform is None.
|
// Only openai-codex has a hardcoded catalog; every wire platform is None.
|
||||||
|
|||||||
@@ -146,6 +146,10 @@ impl TermWriter {
|
|||||||
pub fn writer_sync(&self) -> &WriterSync {
|
pub fn writer_sync(&self) -> &WriterSync {
|
||||||
&self.sync
|
&self.sync
|
||||||
}
|
}
|
||||||
|
/// A cloneable handle onto this writer's queue for out-of-band escapes.
|
||||||
|
pub fn escape_writer(&self) -> EscapeWriter {
|
||||||
|
EscapeWriter::new(self.tx.clone(), self.sync.clone())
|
||||||
|
}
|
||||||
}
|
}
|
||||||
impl Write for TermWriter {
|
impl Write for TermWriter {
|
||||||
fn write(&mut self, data: &[u8]) -> std::io::Result<usize> {
|
fn write(&mut self, data: &[u8]) -> std::io::Result<usize> {
|
||||||
@@ -166,6 +170,56 @@ impl Drop for TermWriter {
|
|||||||
let _ = self.flush();
|
let _ = self.flush();
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
/// Out-of-band escapes ride the frame queue (an inline stderr write deadlocks on a stalled tty); drop every clone before `join_within`.
|
||||||
|
#[derive(Clone)]
|
||||||
|
pub struct EscapeWriter {
|
||||||
|
tx: mpsc::Sender<Vec<u8>>,
|
||||||
|
sync: WriterSync,
|
||||||
|
}
|
||||||
|
impl EscapeWriter {
|
||||||
|
pub fn new(tx: mpsc::Sender<Vec<u8>>, sync: WriterSync) -> Self {
|
||||||
|
Self { tx, sync }
|
||||||
|
}
|
||||||
|
/// No writer thread behind it: sends are dropped. For tests and views built before the terminal exists.
|
||||||
|
pub fn disconnected() -> Self {
|
||||||
|
let (tx, _rx) = mpsc::channel::<Vec<u8>>();
|
||||||
|
Self {
|
||||||
|
tx,
|
||||||
|
sync: WriterSync::new(),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
/// Never blocks; covered by [`WriterSync::wait_drained`].
|
||||||
|
pub fn emit(&self, bytes: impl Into<Vec<u8>>) {
|
||||||
|
let data: Vec<u8> = bytes.into();
|
||||||
|
if data.is_empty() {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
self.sync.mark_queued();
|
||||||
|
let _ = self.tx.send(data);
|
||||||
|
}
|
||||||
|
/// Winapi-only commands run synchronously: a console API call, not a tty write.
|
||||||
|
pub fn emit_command(&self, command: impl crossterm::Command) {
|
||||||
|
#[cfg(windows)]
|
||||||
|
if !command.is_ansi_code_supported() {
|
||||||
|
let _ = command.execute_winapi();
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
let mut ansi = String::new();
|
||||||
|
if command.write_ansi(&mut ansi).is_ok() {
|
||||||
|
self.emit(ansi);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
/// Outcome of [`WriterThread::join_within`].
|
||||||
|
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
||||||
|
pub enum WriterJoin {
|
||||||
|
/// The thread drained its queue and exited.
|
||||||
|
Joined,
|
||||||
|
/// Still running at the deadline (tty blocked, or a sender alive); detached.
|
||||||
|
TimedOut,
|
||||||
|
}
|
||||||
|
/// Teardown waits this long for the writer thread before detaching it, so a stalled tty cannot hang `/quit`.
|
||||||
|
pub const WRITER_JOIN_GRACE: Duration = Duration::from_secs(2);
|
||||||
/// Handle for the background writer thread.
|
/// Handle for the background writer thread.
|
||||||
///
|
///
|
||||||
/// Joining ensures all queued frames have been written to the terminal
|
/// Joining ensures all queued frames have been written to the terminal
|
||||||
@@ -174,19 +228,45 @@ pub struct WriterThread {
|
|||||||
handle: Option<std::thread::JoinHandle<()>>,
|
handle: Option<std::thread::JoinHandle<()>>,
|
||||||
}
|
}
|
||||||
impl WriterThread {
|
impl WriterThread {
|
||||||
/// Block until the writer thread has processed all pending frames and
|
/// Wait up to `grace` for the thread to drain and exit, else detach it; every sender (`EscapeWriter` clones too) must be dropped first.
|
||||||
/// exited. The [`mpsc::Sender`] must be dropped *before* calling this,
|
pub fn join_within(mut self, grace: Duration) -> WriterJoin {
|
||||||
/// otherwise the thread will never see the channel close.
|
let Some(handle) = self.handle.take() else {
|
||||||
pub fn join(mut self) {
|
return WriterJoin::Joined;
|
||||||
if let Some(h) = self.handle.take() {
|
};
|
||||||
let _ = h.join();
|
if wait_finished(&handle, grace) {
|
||||||
|
let _ = handle.join();
|
||||||
|
WriterJoin::Joined
|
||||||
|
} else {
|
||||||
|
tracing::warn!(
|
||||||
|
grace_ms = grace.as_millis() as u64,
|
||||||
|
"term-writer thread still running at teardown; detaching"
|
||||||
|
);
|
||||||
|
WriterJoin::TimedOut
|
||||||
|
}
|
||||||
|
}
|
||||||
|
#[cfg(test)]
|
||||||
|
fn for_test(handle: std::thread::JoinHandle<()>) -> Self {
|
||||||
|
Self {
|
||||||
|
handle: Some(handle),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
fn wait_finished(handle: &std::thread::JoinHandle<()>, grace: Duration) -> bool {
|
||||||
|
let deadline = Instant::now() + grace;
|
||||||
|
while !handle.is_finished() {
|
||||||
|
if Instant::now() >= deadline {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
std::thread::sleep(Duration::from_millis(1));
|
||||||
|
}
|
||||||
|
true
|
||||||
|
}
|
||||||
impl Drop for WriterThread {
|
impl Drop for WriterThread {
|
||||||
fn drop(&mut self) {
|
fn drop(&mut self) {
|
||||||
if let Some(h) = self.handle.take() {
|
if let Some(handle) = self.handle.take()
|
||||||
let _ = h.join();
|
&& wait_finished(&handle, WRITER_JOIN_GRACE)
|
||||||
|
{
|
||||||
|
let _ = handle.join();
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -197,7 +277,7 @@ impl Drop for WriterThread {
|
|||||||
/// `BufWriter`. The [`WriterSync`] must be shared with every [`TermWriter`]
|
/// `BufWriter`. The [`WriterSync`] must be shared with every [`TermWriter`]
|
||||||
/// built on the sender so [`WriterSync::wait_drained`] tracks the queue.
|
/// built on the sender so [`WriterSync::wait_drained`] tracks the queue.
|
||||||
/// Drop the sender to signal the thread to exit, then call
|
/// Drop the sender to signal the thread to exit, then call
|
||||||
/// [`WriterThread::join`] to wait for it.
|
/// [`WriterThread::join_within`] to wait for it.
|
||||||
pub fn spawn_writer_thread() -> (mpsc::Sender<Vec<u8>>, WriterSync, WriterThread) {
|
pub fn spawn_writer_thread() -> (mpsc::Sender<Vec<u8>>, WriterSync, WriterThread) {
|
||||||
let (tx, rx) = mpsc::channel::<Vec<u8>>();
|
let (tx, rx) = mpsc::channel::<Vec<u8>>();
|
||||||
let sync = WriterSync::new();
|
let sync = WriterSync::new();
|
||||||
@@ -570,4 +650,47 @@ mod tests {
|
|||||||
"Round-tripped bytes do not decode to original UTF-8 string"
|
"Round-tripped bytes do not decode to original UTF-8 string"
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
/// Frames and escapes share one queue, so the writer sees them in call order.
|
||||||
|
#[test]
|
||||||
|
#[cfg(not(windows))]
|
||||||
|
fn escapes_share_the_frame_queue_in_call_order() {
|
||||||
|
let (tx, rx) = mpsc::channel::<Vec<u8>>();
|
||||||
|
let sync = WriterSync::new();
|
||||||
|
let mut frames = TermWriter::new(tx, sync.clone());
|
||||||
|
let escapes = frames.escape_writer();
|
||||||
|
frames.write_all(b"frame-1").unwrap();
|
||||||
|
frames.flush().unwrap();
|
||||||
|
escapes.emit("\x1b[?1000h");
|
||||||
|
frames.write_all(b"frame-2").unwrap();
|
||||||
|
frames.flush().unwrap();
|
||||||
|
escapes.emit_command(crossterm::event::DisableMouseCapture);
|
||||||
|
let payloads: Vec<Vec<u8>> = std::iter::from_fn(|| rx.try_recv().ok()).collect();
|
||||||
|
assert_eq!(payloads.len(), 4);
|
||||||
|
assert_eq!(payloads[0], b"frame-1");
|
||||||
|
assert_eq!(payloads[1], b"\x1b[?1000h");
|
||||||
|
assert_eq!(payloads[2], b"frame-2");
|
||||||
|
assert!(payloads[3].starts_with(b"\x1b["), "{:?}", payloads[3]);
|
||||||
|
assert!(!sync.is_drained(), "four payloads queued, none written");
|
||||||
|
}
|
||||||
|
/// A writer thread parked in a blocked tty write must not hang teardown.
|
||||||
|
#[test]
|
||||||
|
fn join_within_times_out_on_a_stuck_writer_thread() {
|
||||||
|
let (release_tx, release_rx) = mpsc::channel::<()>();
|
||||||
|
let handle = std::thread::spawn(move || {
|
||||||
|
let _ = release_rx.recv();
|
||||||
|
});
|
||||||
|
let started = Instant::now();
|
||||||
|
let outcome = WriterThread::for_test(handle).join_within(Duration::from_millis(50));
|
||||||
|
assert_eq!(outcome, WriterJoin::TimedOut);
|
||||||
|
assert!(started.elapsed() < Duration::from_secs(2));
|
||||||
|
let _ = release_tx.send(());
|
||||||
|
}
|
||||||
|
#[test]
|
||||||
|
fn join_within_joins_a_finished_writer_thread() {
|
||||||
|
let handle = std::thread::spawn(|| {});
|
||||||
|
assert_eq!(
|
||||||
|
WriterThread::for_test(handle).join_within(Duration::from_secs(5)),
|
||||||
|
WriterJoin::Joined
|
||||||
|
);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
@@ -375,7 +375,6 @@ impl TerminalContext {
|
|||||||
return Some("apple_terminal");
|
return Some("apple_terminal");
|
||||||
}
|
}
|
||||||
if self.is_vte_based() {
|
if self.is_vte_based() {
|
||||||
// WHY: central helper replaces VTE duplication
|
|
||||||
return Some("vte");
|
return Some("vte");
|
||||||
}
|
}
|
||||||
if self.brand == TerminalName::WindowsTerminal {
|
if self.brand == TerminalName::WindowsTerminal {
|
||||||
@@ -429,74 +428,29 @@ impl TerminalContext {
|
|||||||
}
|
}
|
||||||
|
|
||||||
/// Whether the running terminal cannot distinguish `Shift+Enter` from
|
/// Whether the running terminal cannot distinguish `Shift+Enter` from
|
||||||
/// bare `Enter` at the byte level, so the UI should advertise
|
/// bare `Enter`, so the UI should advertise `Alt+Enter` (delivered as
|
||||||
/// `Alt+Enter` for newline insertion instead.
|
/// `ESC`+`CR`) for newline insertion instead.
|
||||||
///
|
///
|
||||||
/// Distinguishing `Shift+Enter` requires the Kitty keyboard protocol
|
/// Follows [`Self::kitty_skip_reason`] rather than a second brand list:
|
||||||
/// (KKP) to be negotiated. This returns `true` for the environments
|
/// when the protocol is not negotiated the modifier is lost, and the two
|
||||||
/// where the pager cannot rely on KKP for a usable `Shift+Enter`:
|
/// drifted once already (VTE advertised a chord that never arrived — its
|
||||||
|
/// `Return` keymap encodes only Alt, through 0.82.0 at least, and no VTE
|
||||||
|
/// release carries the protocol). Two skips still deliver it — Apple
|
||||||
|
/// Terminal drops the flags but `route_enter` polls CoreGraphics, and
|
||||||
|
/// Windows console key records carry SHIFT with no protocol at all.
|
||||||
///
|
///
|
||||||
/// 1. **Legacy VTE** (GNOME Terminal, Ptyxis, kgx, Tilix, etc.) whose
|
/// KNOWN GAP: WezTerm inside screen or an old tmux gets Alt+Enter as the
|
||||||
/// `VTE_VERSION` is below `8200` (VTE 0.82.0, the first release with
|
/// advice while its own default binding spends that chord on
|
||||||
/// KKP, merged in
|
/// ToggleFullScreen. Neither chord reaches kigi there; the multiplexer
|
||||||
/// [MR !14](https://gitlab.gnome.org/GNOME/vte/-/merge_requests/14)).
|
/// warning carries the real fix, and `\`+Enter still inserts a newline.
|
||||||
/// Also true when the brand is detected as VTE but `VTE_VERSION` is
|
|
||||||
/// missing or unparseable — we conservatively assume old.
|
|
||||||
/// 2. **VS Code's integrated terminal (xterm.js) and VS Code-family /
|
|
||||||
/// xterm.js IDE forks**. xterm.js only partially implements KKP —
|
|
||||||
/// it mis-encodes shifted printable keys — so the pager deliberately
|
|
||||||
/// never negotiates KKP for them (see [`Self::kitty_skip_reason`]
|
|
||||||
/// `== "vscode"` and [xterm.js#5823](https://github.com/xtermjs/xterm.js/issues/5823)).
|
|
||||||
/// Without KKP, xterm.js sends a bare `CR` for `Shift+Enter`,
|
|
||||||
/// byte-for-byte identical to `Enter`.
|
|
||||||
/// 3. **Unidentified terminals with no multiplexer**, where the pager
|
|
||||||
/// also skips KKP (no positive evidence of support — typically
|
|
||||||
/// VS Code's xterm.js reached over SSH, where `TERM_PROGRAM` isn't
|
|
||||||
/// forwarded and the brand falls back to `Unknown`).
|
|
||||||
///
|
|
||||||
/// In every case `Alt+Enter` (delivered as `ESC`+`CR`) is the reliable
|
|
||||||
/// newline chord and is what the UI advertises.
|
|
||||||
pub fn shift_enter_unavailable(&self) -> bool {
|
pub fn shift_enter_unavailable(&self) -> bool {
|
||||||
// WHY: central helper + version gating
|
match self.kitty_skip_reason() {
|
||||||
let is_vte = self.is_vte_based();
|
None | Some("apple_terminal") => false,
|
||||||
if is_vte {
|
// A bare ConHost is only optimistically refined to Windows
|
||||||
return match self
|
// Terminal; it still advertises Alt+Enter.
|
||||||
.vte_version
|
Some("windows_terminal") => self.env_brand.is_capability_unclassified(),
|
||||||
.as_deref()
|
Some(_) => true,
|
||||||
.and_then(|v| v.parse::<u32>().ok())
|
|
||||||
{
|
|
||||||
Some(ver) => ver < 8200,
|
|
||||||
// Brand=Vte but no parseable version — conservative: assume old.
|
|
||||||
None => true,
|
|
||||||
};
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// VS Code / xterm.js and its forks: KKP is never negotiated, so
|
|
||||||
// Shift+Enter arrives as a bare CR indistinguishable from Enter.
|
|
||||||
if matches!(
|
|
||||||
self.brand,
|
|
||||||
TerminalName::VsCode
|
|
||||||
| TerminalName::Cursor
|
|
||||||
| TerminalName::Windsurf
|
|
||||||
| TerminalName::Zed
|
|
||||||
) {
|
|
||||||
return true;
|
|
||||||
}
|
|
||||||
|
|
||||||
// Unidentified / unclassified brand with no multiplexer: KKP is
|
|
||||||
// skipped (see `kitty_skip_reason`). This is the common
|
|
||||||
// VS Code-over-SSH shape (brand falls back to Unknown). On native
|
|
||||||
// Windows the effective `brand` is refined to WindowsTerminal, so
|
|
||||||
// consult `env_brand` — a bare ConHost is still env-Unknown and
|
|
||||||
// must advertise Alt+Enter even though we optimistically treat it
|
|
||||||
// as WT for capabilities.
|
|
||||||
if self.env_brand.is_capability_unclassified()
|
|
||||||
&& self.multiplexer == MultiplexerKind::Undetected
|
|
||||||
{
|
|
||||||
return true;
|
|
||||||
}
|
|
||||||
|
|
||||||
false
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/// True when `Ctrl+.` cannot be delivered reliably as a shortcuts primary.
|
/// True when `Ctrl+.` cannot be delivered reliably as a shortcuts primary.
|
||||||
|
|||||||
@@ -1443,7 +1443,7 @@ fn kitty_skip_vscode_over_tmux() {
|
|||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn kitty_skip_vte_version() {
|
fn kitty_skip_vte_version() {
|
||||||
// VTE does not support Kitty keyboard protocol and crossterm's probe
|
// No VTE release has the Kitty keyboard protocol and crossterm's probe
|
||||||
// can false-positive on it. https://gitlab.gnome.org/GNOME/vte/-/issues/2601
|
// can false-positive on it. https://gitlab.gnome.org/GNOME/vte/-/issues/2601
|
||||||
let ctx = TerminalContext {
|
let ctx = TerminalContext {
|
||||||
vte_version: Some("7402".to_owned()),
|
vte_version: Some("7402".to_owned()),
|
||||||
@@ -1461,73 +1461,68 @@ fn kitty_skip_vte_brand() {
|
|||||||
assert_eq!(ctx.kitty_skip_reason(), Some("vte"));
|
assert_eq!(ctx.kitty_skip_reason(), Some("vte"));
|
||||||
}
|
}
|
||||||
|
|
||||||
// shift_enter_unavailable: VTE version gating for Shift+Enter
|
// shift_enter_unavailable: VTE never delivers Shift+Enter
|
||||||
//
|
//
|
||||||
// VTE 0.82.0 (= VTE_VERSION 8200) is the first release containing the
|
// No VTE release carries the Kitty keyboard protocol: at 0.82.0 the word
|
||||||
// Kitty keyboard protocol; earlier versions cannot distinguish
|
// "kitty" appears nowhere in the parser or widget, and
|
||||||
// Shift+Enter from bare Enter, so the UI should advertise Alt+Enter
|
// `_vte_keymap_GDK_Return` encodes only Alt (`ESC CR`), so Shift+Enter is
|
||||||
// for newline insertion instead.
|
// the same bare CR as Enter. The UI advertises Alt+Enter instead.
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn shift_enter_unavailable_legacy_vte_version() {
|
fn shift_enter_unavailable_on_every_vte() {
|
||||||
// VTE 0.64.2 (real user report) — well below the KKP cutoff.
|
for version in [Some("6402"), Some("8200"), Some("8401"), None] {
|
||||||
let ctx = TerminalContext {
|
let ctx = TerminalContext {
|
||||||
vte_version: Some("6402".to_owned()),
|
brand: TerminalName::Vte,
|
||||||
..Default::default()
|
env_brand: TerminalName::Vte,
|
||||||
};
|
vte_version: version.map(str::to_owned),
|
||||||
assert!(ctx.shift_enter_unavailable());
|
..Default::default()
|
||||||
|
};
|
||||||
|
assert_eq!(ctx.kitty_skip_reason(), Some("vte"), "VTE {version:?}");
|
||||||
|
assert!(ctx.shift_enter_unavailable(), "VTE {version:?}");
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn shift_enter_unavailable_just_below_cutoff() {
|
fn shift_enter_unavailable_follows_every_kitty_skip() {
|
||||||
// VTE 0.81.99 — anything below 8200 must return true.
|
// A skipped protocol means the modifier never arrives, whatever the
|
||||||
let ctx = TerminalContext {
|
// reason — JediTerm, screen and a multiplexer that eats extended keys
|
||||||
vte_version: Some("8199".to_owned()),
|
// included. Apple Terminal and Windows Terminal are the two skips with
|
||||||
..Default::default()
|
// another way in.
|
||||||
};
|
for ctx in [
|
||||||
assert!(ctx.shift_enter_unavailable());
|
TerminalContext {
|
||||||
}
|
brand: TerminalName::JetBrains,
|
||||||
|
env_brand: TerminalName::JetBrains,
|
||||||
#[test]
|
..Default::default()
|
||||||
fn shift_enter_available_modern_vte() {
|
},
|
||||||
// VTE 0.82.0 — first release with KKP.
|
TerminalContext {
|
||||||
let ctx = TerminalContext {
|
brand: TerminalName::Kitty,
|
||||||
vte_version: Some("8200".to_owned()),
|
env_brand: TerminalName::Kitty,
|
||||||
..Default::default()
|
multiplexer: MultiplexerKind::Screen,
|
||||||
};
|
..Default::default()
|
||||||
assert!(!ctx.shift_enter_unavailable());
|
},
|
||||||
}
|
TerminalContext {
|
||||||
|
brand: TerminalName::Kitty,
|
||||||
#[test]
|
env_brand: TerminalName::Kitty,
|
||||||
fn shift_enter_available_future_vte() {
|
multiplexer: MultiplexerKind::Tmux,
|
||||||
// VTE 0.84.1 — well above the cutoff.
|
tmux_version: Some("3.2".to_owned()),
|
||||||
let ctx = TerminalContext {
|
..Default::default()
|
||||||
vte_version: Some("8401".to_owned()),
|
},
|
||||||
..Default::default()
|
// A VTE carrying a recent VTE_VERSION is no different.
|
||||||
};
|
TerminalContext {
|
||||||
assert!(!ctx.shift_enter_unavailable());
|
brand: TerminalName::Vte,
|
||||||
}
|
env_brand: TerminalName::Vte,
|
||||||
|
vte_version: Some("8200".to_owned()),
|
||||||
#[test]
|
multiplexer: MultiplexerKind::Screen,
|
||||||
fn shift_enter_unavailable_vte_brand_no_version() {
|
..Default::default()
|
||||||
// Brand detected as VTE but VTE_VERSION missing — conservative: old.
|
},
|
||||||
let ctx = TerminalContext {
|
] {
|
||||||
brand: TerminalName::Vte,
|
assert!(ctx.kitty_skip_reason().is_some());
|
||||||
vte_version: None,
|
assert!(
|
||||||
..Default::default()
|
ctx.shift_enter_unavailable(),
|
||||||
};
|
"{:?} skips the protocol, so Shift+Enter cannot arrive",
|
||||||
assert!(ctx.shift_enter_unavailable());
|
ctx.brand
|
||||||
}
|
);
|
||||||
|
}
|
||||||
#[test]
|
|
||||||
fn shift_enter_unavailable_unparseable_version() {
|
|
||||||
// Garbage in VTE_VERSION — conservative: old.
|
|
||||||
let ctx = TerminalContext {
|
|
||||||
brand: TerminalName::Vte,
|
|
||||||
vte_version: Some("not-a-number".to_owned()),
|
|
||||||
..Default::default()
|
|
||||||
};
|
|
||||||
assert!(ctx.shift_enter_unavailable());
|
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
|
|||||||
@@ -267,6 +267,13 @@ struct WrapCache {
|
|||||||
lines: Vec<Range<usize>>,
|
lines: Vec<Range<usize>>,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Whether a wrapped row's exclusive end is a cursor position on that row.
|
||||||
|
#[derive(Debug, Clone, Copy)]
|
||||||
|
enum RowEnd {
|
||||||
|
HardBreak,
|
||||||
|
SoftWrap,
|
||||||
|
}
|
||||||
|
|
||||||
#[derive(Debug, Default, Clone, Copy)]
|
#[derive(Debug, Default, Clone, Copy)]
|
||||||
pub struct TextAreaState {
|
pub struct TextAreaState {
|
||||||
/// Index into wrapped lines of the first visible line.
|
/// Index into wrapped lines of the first visible line.
|
||||||
@@ -382,27 +389,13 @@ impl TextArea {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Clamp a buffer position so it stays within a wrapped line's range
|
/// Clamp `pos` to the start of the last grapheme in `[line_start, line_end)`.
|
||||||
/// `[line_start, line_end)`. Without this, `display_col_to_buffer_pos`
|
|
||||||
/// can return `line_end` when the column exceeds the line's display
|
|
||||||
/// width — and `line_end` equals the *next* wrapped line's start,
|
|
||||||
/// which confuses `effective_scroll` into thinking the cursor hasn't
|
|
||||||
/// actually moved to the target line.
|
|
||||||
///
|
|
||||||
/// Uses `self.text` to find the last valid char boundary inside the line
|
|
||||||
/// so we never land in the middle of a multi-byte character.
|
|
||||||
fn clamp_to_line(&self, pos: usize, line_start: usize, line_end: usize) -> usize {
|
fn clamp_to_line(&self, pos: usize, line_start: usize, line_end: usize) -> usize {
|
||||||
if line_end > line_start {
|
let last_grapheme_start = self.text[line_start..line_end]
|
||||||
// Find the start of the last character in the line.
|
.grapheme_indices(true)
|
||||||
let last_char_start = self.text[line_start..line_end]
|
.next_back()
|
||||||
.char_indices()
|
.map_or(line_start, |(i, _)| line_start + i);
|
||||||
.next_back()
|
pos.min(last_grapheme_start)
|
||||||
.map(|(i, _)| line_start + i)
|
|
||||||
.unwrap_or(line_start);
|
|
||||||
pos.min(last_char_start)
|
|
||||||
} else {
|
|
||||||
line_start
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn new() -> Self {
|
pub fn new() -> Self {
|
||||||
@@ -1699,6 +1692,35 @@ impl TextArea {
|
|||||||
if idx == 0 { None } else { Some(idx - 1) }
|
if idx == 0 { None } else { Some(idx - 1) }
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Soft-wrapped rows are byte-adjacent; a hard row leaves its newline between it and the next.
|
||||||
|
fn row_with_end(lines: &[Range<usize>], idx: usize) -> Option<(Range<usize>, RowEnd)> {
|
||||||
|
let row = lines.get(idx)?;
|
||||||
|
let end_kind = match lines.get(idx + 1) {
|
||||||
|
Some(next) if next.start == row.end => RowEnd::SoftWrap,
|
||||||
|
_ => RowEnd::HardBreak,
|
||||||
|
};
|
||||||
|
Some((row.clone(), end_kind))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn clamp_to_row(&self, pos: usize, row: &Range<usize>, end_kind: RowEnd) -> usize {
|
||||||
|
match end_kind {
|
||||||
|
RowEnd::HardBreak => pos,
|
||||||
|
RowEnd::SoftWrap => {
|
||||||
|
let last_grapheme_start = self.clamp_to_line(pos, row.start, row.end);
|
||||||
|
let Some(idx) = self.find_element_containing(last_grapheme_start) else {
|
||||||
|
return last_grapheme_start;
|
||||||
|
};
|
||||||
|
let element_start = self.elements[idx].range.start;
|
||||||
|
// A display-less element wraps as text; one that began on an earlier row keeps `pos`.
|
||||||
|
if element_start < row.start {
|
||||||
|
pos
|
||||||
|
} else {
|
||||||
|
element_start
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
/// Map a display column to a buffer byte position on a given wrapped line.
|
/// Map a display column to a buffer byte position on a given wrapped line.
|
||||||
///
|
///
|
||||||
/// Pure query — does not mutate any state. Handles elements (snapping to
|
/// Pure query — does not mutate any state. Handles elements (snapping to
|
||||||
@@ -1791,13 +1813,12 @@ impl TextArea {
|
|||||||
|
|
||||||
fn move_to_display_col_on_line(
|
fn move_to_display_col_on_line(
|
||||||
&mut self,
|
&mut self,
|
||||||
line_start: usize,
|
row: Range<usize>,
|
||||||
line_end: usize,
|
|
||||||
target_col: usize,
|
target_col: usize,
|
||||||
|
end_kind: RowEnd,
|
||||||
) {
|
) {
|
||||||
self.cursor_pos = self
|
let (pos, _hit_element) = self.display_col_to_buffer_pos(row.start, row.end, target_col);
|
||||||
.display_col_to_buffer_pos(line_start, line_end, target_col)
|
self.cursor_pos = self.clamp_to_row(pos, &row, end_kind);
|
||||||
.0;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
fn beginning_of_line(&self, pos: usize) -> usize {
|
fn beginning_of_line(&self, pos: usize) -> usize {
|
||||||
@@ -2652,14 +2673,10 @@ impl TextArea {
|
|||||||
let target_col = self.preferred_col.unwrap_or_else(|| {
|
let target_col = self.preferred_col.unwrap_or_else(|| {
|
||||||
self.display_width_of_range(cur_range.start, self.cursor_pos)
|
self.display_width_of_range(cur_range.start, self.cursor_pos)
|
||||||
});
|
});
|
||||||
if idx > 0 {
|
let prev = idx
|
||||||
let prev = &lines[idx - 1];
|
.checked_sub(1)
|
||||||
let line_start = prev.start;
|
.and_then(|prev_idx| Self::row_with_end(lines, prev_idx));
|
||||||
let line_end = prev.end;
|
Some((target_col, prev))
|
||||||
Some((target_col, Some((line_start, line_end))))
|
|
||||||
} else {
|
|
||||||
Some((target_col, None))
|
|
||||||
}
|
|
||||||
} else {
|
} else {
|
||||||
None
|
None
|
||||||
}
|
}
|
||||||
@@ -2669,11 +2686,11 @@ impl TextArea {
|
|||||||
} {
|
} {
|
||||||
// We had wrapping info. Apply movement accordingly.
|
// We had wrapping info. Apply movement accordingly.
|
||||||
match maybe_line {
|
match maybe_line {
|
||||||
Some((line_start, line_end)) => {
|
Some((prev, end_kind)) => {
|
||||||
if self.preferred_col.is_none() {
|
if self.preferred_col.is_none() {
|
||||||
self.preferred_col = Some(target_col);
|
self.preferred_col = Some(target_col);
|
||||||
}
|
}
|
||||||
self.move_to_display_col_on_line(line_start, line_end, target_col);
|
self.move_to_display_col_on_line(prev, target_col, end_kind);
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
None => {
|
None => {
|
||||||
@@ -2697,7 +2714,11 @@ impl TextArea {
|
|||||||
};
|
};
|
||||||
let prev_line_start = self.text[..prev_nl].rfind('\n').map(|i| i + 1).unwrap_or(0);
|
let prev_line_start = self.text[..prev_nl].rfind('\n').map(|i| i + 1).unwrap_or(0);
|
||||||
let prev_line_end = prev_nl;
|
let prev_line_end = prev_nl;
|
||||||
self.move_to_display_col_on_line(prev_line_start, prev_line_end, target_col);
|
self.move_to_display_col_on_line(
|
||||||
|
prev_line_start..prev_line_end,
|
||||||
|
target_col,
|
||||||
|
RowEnd::HardBreak,
|
||||||
|
);
|
||||||
} else {
|
} else {
|
||||||
self.cursor_pos = 0;
|
self.cursor_pos = 0;
|
||||||
self.preferred_col = None;
|
self.preferred_col = None;
|
||||||
@@ -2716,14 +2737,7 @@ impl TextArea {
|
|||||||
let target_col = self.preferred_col.unwrap_or_else(|| {
|
let target_col = self.preferred_col.unwrap_or_else(|| {
|
||||||
self.display_width_of_range(cur_range.start, self.cursor_pos)
|
self.display_width_of_range(cur_range.start, self.cursor_pos)
|
||||||
});
|
});
|
||||||
if idx + 1 < lines.len() {
|
Some((target_col, Self::row_with_end(lines, idx + 1)))
|
||||||
let next = &lines[idx + 1];
|
|
||||||
let line_start = next.start;
|
|
||||||
let line_end = next.end;
|
|
||||||
Some((target_col, Some((line_start, line_end))))
|
|
||||||
} else {
|
|
||||||
Some((target_col, None))
|
|
||||||
}
|
|
||||||
} else {
|
} else {
|
||||||
None
|
None
|
||||||
}
|
}
|
||||||
@@ -2732,11 +2746,11 @@ impl TextArea {
|
|||||||
}
|
}
|
||||||
} {
|
} {
|
||||||
match move_to_last {
|
match move_to_last {
|
||||||
Some((line_start, line_end)) => {
|
Some((next, end_kind)) => {
|
||||||
if self.preferred_col.is_none() {
|
if self.preferred_col.is_none() {
|
||||||
self.preferred_col = Some(target_col);
|
self.preferred_col = Some(target_col);
|
||||||
}
|
}
|
||||||
self.move_to_display_col_on_line(line_start, line_end, target_col);
|
self.move_to_display_col_on_line(next, target_col, end_kind);
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
None => {
|
None => {
|
||||||
@@ -2766,7 +2780,11 @@ impl TextArea {
|
|||||||
.find('\n')
|
.find('\n')
|
||||||
.map(|i| i + next_line_start)
|
.map(|i| i + next_line_start)
|
||||||
.unwrap_or(self.text.len());
|
.unwrap_or(self.text.len());
|
||||||
self.move_to_display_col_on_line(next_line_start, next_line_end, target_col);
|
self.move_to_display_col_on_line(
|
||||||
|
next_line_start..next_line_end,
|
||||||
|
target_col,
|
||||||
|
RowEnd::HardBreak,
|
||||||
|
);
|
||||||
} else {
|
} else {
|
||||||
self.cursor_pos = self.text.len();
|
self.cursor_pos = self.text.len();
|
||||||
self.preferred_col = None;
|
self.preferred_col = None;
|
||||||
@@ -3899,6 +3917,9 @@ fn truncate_line_display(line: &Line<'static>, max_width: usize) -> Line<'static
|
|||||||
Line::from(new_spans)
|
Line::from(new_spans)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[cfg(test)]
|
||||||
|
mod soft_wrap_nav_tests;
|
||||||
|
|
||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod tests {
|
mod tests {
|
||||||
use super::*;
|
use super::*;
|
||||||
@@ -6293,6 +6314,7 @@ mod tests {
|
|||||||
assert_eq!(t.cursor(), "👍👍".len());
|
assert_eq!(t.cursor(), "👍👍".len());
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Each ZWJ cluster fills a 4-col row; Up from the end lands on row 1's cluster start.
|
||||||
#[test]
|
#[test]
|
||||||
fn wrapped_navigation_with_zwj_graphemes() {
|
fn wrapped_navigation_with_zwj_graphemes() {
|
||||||
let grapheme = "👩\u{200D}💻";
|
let grapheme = "👩\u{200D}💻";
|
||||||
@@ -6306,7 +6328,7 @@ mod tests {
|
|||||||
assert!(pos_after_down >= grapheme.len() * 2);
|
assert!(pos_after_down >= grapheme.len() * 2);
|
||||||
|
|
||||||
t.move_cursor_up();
|
t.move_cursor_up();
|
||||||
assert_eq!(t.cursor(), grapheme.len() * 2);
|
assert_eq!(t.cursor(), grapheme.len());
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
|
|||||||
@@ -0,0 +1,121 @@
|
|||||||
|
//! Up/Down across soft-wrapped rows: a soft row's exclusive end is the next row's start.
|
||||||
|
|
||||||
|
use rand::prelude::*;
|
||||||
|
use ratatui::layout::Rect;
|
||||||
|
use ratatui::text::Line;
|
||||||
|
|
||||||
|
use super::{ElementKind, TextArea};
|
||||||
|
|
||||||
|
fn ta_with(text: &str) -> TextArea {
|
||||||
|
let mut t = TextArea::new();
|
||||||
|
t.insert_str(text);
|
||||||
|
t
|
||||||
|
}
|
||||||
|
|
||||||
|
fn cursor_row(t: &TextArea, width: u16) -> usize {
|
||||||
|
TextArea::wrapped_line_index_by_start(&t.wrapped_lines(width), t.cursor()).unwrap()
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn up_from_wide_row_lands_on_last_char_of_narrower_soft_row() {
|
||||||
|
let width = 8;
|
||||||
|
let mut t = ta_with("aaa bb ccccccc");
|
||||||
|
assert_eq!(vec![0..7, 7..14], *t.wrapped_lines(width));
|
||||||
|
|
||||||
|
t.move_cursor_up();
|
||||||
|
assert_eq!(6, t.cursor());
|
||||||
|
assert_eq!(0, cursor_row(&t, width));
|
||||||
|
assert_eq!(Some((6, 0)), t.cursor_pos(Rect::new(0, 0, width, 5)));
|
||||||
|
|
||||||
|
t.move_cursor_down();
|
||||||
|
assert_eq!(14, t.cursor());
|
||||||
|
|
||||||
|
t.move_cursor_up();
|
||||||
|
assert_eq!(6, t.cursor());
|
||||||
|
t.move_cursor_up();
|
||||||
|
assert_eq!(0, t.cursor());
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn up_onto_newline_terminated_row_lands_on_the_newline() {
|
||||||
|
let mut t = ta_with("ab\ncdef");
|
||||||
|
assert_eq!(vec![0..2, 3..7], *t.wrapped_lines(8));
|
||||||
|
|
||||||
|
t.move_cursor_up();
|
||||||
|
assert_eq!(2, t.cursor());
|
||||||
|
assert_eq!(0, cursor_row(&t, 8));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn down_from_wide_row_lands_on_last_char_of_narrower_soft_row() {
|
||||||
|
let mut t = ta_with("ccccccc aaa bb ddddddd");
|
||||||
|
assert_eq!(vec![0..8, 8..15, 15..22], *t.wrapped_lines(8));
|
||||||
|
t.set_cursor(7);
|
||||||
|
|
||||||
|
t.move_cursor_down();
|
||||||
|
assert_eq!(14, t.cursor());
|
||||||
|
assert_eq!(1, cursor_row(&t, 8));
|
||||||
|
|
||||||
|
t.move_cursor_down();
|
||||||
|
assert_eq!(22, t.cursor());
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn up_onto_soft_row_closed_by_element_lands_before_the_element() {
|
||||||
|
let mut t = TextArea::new();
|
||||||
|
t.insert_element("xyz", ElementKind(0), Some(Line::from("[ELEM]")));
|
||||||
|
t.insert_str("longword");
|
||||||
|
assert_eq!(vec![0..3, 3..11], *t.wrapped_lines(8));
|
||||||
|
|
||||||
|
t.move_cursor_up();
|
||||||
|
assert_eq!(0, t.cursor());
|
||||||
|
assert_eq!(0, cursor_row(&t, 8));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn down_through_element_spanning_rows_reaches_the_end() {
|
||||||
|
let mut t = TextArea::new();
|
||||||
|
t.insert_element("abcdefgh", ElementKind(0), None);
|
||||||
|
t.insert_str("z");
|
||||||
|
assert_eq!(vec![0..3, 3..6, 6..9], *t.wrapped_lines(3));
|
||||||
|
t.set_cursor(0);
|
||||||
|
|
||||||
|
t.move_cursor_down();
|
||||||
|
assert_eq!(8, t.cursor());
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn up_and_down_move_one_row_at_a_time() {
|
||||||
|
let mut rng = StdRng::seed_from_u64(7);
|
||||||
|
for _ in 0..500 {
|
||||||
|
let words = rng.random_range(1..12);
|
||||||
|
let text = (0..words)
|
||||||
|
.map(|_| "x".repeat(rng.random_range(1..9)))
|
||||||
|
.collect::<Vec<_>>()
|
||||||
|
.join(" ");
|
||||||
|
let width = rng.random_range(3..12);
|
||||||
|
let mut t = ta_with(&text);
|
||||||
|
let rows = t.wrapped_lines(width).len();
|
||||||
|
t.set_cursor(rng.random_range(0..=text.len()));
|
||||||
|
|
||||||
|
let mut row = cursor_row(&t, width);
|
||||||
|
while row + 1 < rows {
|
||||||
|
t.move_cursor_down();
|
||||||
|
assert_eq!(
|
||||||
|
row + 1,
|
||||||
|
cursor_row(&t, width),
|
||||||
|
"down in {text:?} at width {width}"
|
||||||
|
);
|
||||||
|
row += 1;
|
||||||
|
}
|
||||||
|
while row > 0 {
|
||||||
|
t.move_cursor_up();
|
||||||
|
assert_eq!(
|
||||||
|
row - 1,
|
||||||
|
cursor_row(&t, width),
|
||||||
|
"up in {text:?} at width {width}"
|
||||||
|
);
|
||||||
|
row -= 1;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -18,6 +18,7 @@ eventsource-stream = { workspace = true }
|
|||||||
futures-util = { workspace = true }
|
futures-util = { workspace = true }
|
||||||
indexmap = { workspace = true, features = ["serde"] }
|
indexmap = { workspace = true, features = ["serde"] }
|
||||||
reqwest = { workspace = true, features = ["stream"] }
|
reqwest = { workspace = true, features = ["stream"] }
|
||||||
|
kigi-secrets = { path = "../kigi-secrets" }
|
||||||
serde = { workspace = true, features = ["derive"] }
|
serde = { workspace = true, features = ["derive"] }
|
||||||
serde_json = { workspace = true }
|
serde_json = { workspace = true }
|
||||||
tokio = { workspace = true, features = ["rt", "macros", "time", "sync"] }
|
tokio = { workspace = true, features = ["rt", "macros", "time", "sync"] }
|
||||||
|
|||||||
@@ -193,6 +193,16 @@ fn extract_context_total(value: &serde_json::Value) -> Option<u32> {
|
|||||||
Some(i.saturating_add(o))
|
Some(i.saturating_add(o))
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// The endpoint as the HTTP client parses it, minus userinfo, sensitive query values and fragment; an unparseable one is not echoed.
|
||||||
|
fn redacted_endpoint(endpoint: &str) -> String {
|
||||||
|
match reqwest::Url::parse(endpoint) {
|
||||||
|
Ok(mut url) => {
|
||||||
|
kigi_secrets::redact_url(&mut url);
|
||||||
|
url.to_string()
|
||||||
|
}
|
||||||
|
Err(_) => "<unparseable endpoint>".to_owned(),
|
||||||
|
}
|
||||||
|
}
|
||||||
/// Record `success=false` + `error` on the active inference span when a stream
|
/// Record `success=false` + `error` on the active inference span when a stream
|
||||||
/// request fails before any response (transport/connect/TLS errors). Without
|
/// request fails before any response (transport/connect/TLS errors). Without
|
||||||
/// this the `#[instrument]` span closes with both fields Empty, so an outage
|
/// this the `#[instrument]` span closes with both fields Empty, so an outage
|
||||||
@@ -806,7 +816,7 @@ impl SamplingClient {
|
|||||||
let server_message_lower = server_message.to_lowercase();
|
let server_message_lower = server_message.to_lowercase();
|
||||||
|
|
||||||
let mut context_parts = vec![server_message.to_string()];
|
let mut context_parts = vec![server_message.to_string()];
|
||||||
context_parts.push(format!("\nRequest URL: {}", endpoint));
|
context_parts.push(format!("\nRequest URL: {}", redacted_endpoint(endpoint)));
|
||||||
|
|
||||||
// Show headers if error mentions headers
|
// Show headers if error mentions headers
|
||||||
if server_message_lower.contains("header") {
|
if server_message_lower.contains("header") {
|
||||||
@@ -1006,7 +1016,8 @@ impl SamplingClient {
|
|||||||
let endpoint = self.endpoint("chat/completions");
|
let endpoint = self.endpoint("chat/completions");
|
||||||
let server_message = response.text().await.unwrap_or_default();
|
let server_message = response.text().await.unwrap_or_default();
|
||||||
return Err(SamplingError::Auth(format!(
|
return Err(SamplingError::Auth(format!(
|
||||||
"Unauthorized (401) from {endpoint}: {server_message}"
|
"Unauthorized (401) from {}: {server_message}",
|
||||||
|
redacted_endpoint(&endpoint)
|
||||||
)));
|
)));
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1196,7 +1207,8 @@ impl SamplingClient {
|
|||||||
let endpoint = self.endpoint("responses");
|
let endpoint = self.endpoint("responses");
|
||||||
let server_message = parse_error_bytes(bytes.as_ref());
|
let server_message = parse_error_bytes(bytes.as_ref());
|
||||||
return Err(SamplingError::Auth(format!(
|
return Err(SamplingError::Auth(format!(
|
||||||
"Unauthorized (401) from {endpoint}: {server_message}"
|
"Unauthorized (401) from {}: {server_message}",
|
||||||
|
redacted_endpoint(&endpoint)
|
||||||
)));
|
)));
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1363,7 +1375,8 @@ impl SamplingClient {
|
|||||||
let endpoint = self.endpoint("responses");
|
let endpoint = self.endpoint("responses");
|
||||||
let server_message = response.text().await.unwrap_or_default();
|
let server_message = response.text().await.unwrap_or_default();
|
||||||
return Err(SamplingError::Auth(format!(
|
return Err(SamplingError::Auth(format!(
|
||||||
"Unauthorized (401) from {endpoint}: {server_message}"
|
"Unauthorized (401) from {}: {server_message}",
|
||||||
|
redacted_endpoint(&endpoint)
|
||||||
)));
|
)));
|
||||||
}
|
}
|
||||||
let model_metadata = extract_model_metadata(response.headers());
|
let model_metadata = extract_model_metadata(response.headers());
|
||||||
@@ -1542,7 +1555,8 @@ impl SamplingClient {
|
|||||||
let endpoint = self.endpoint("messages");
|
let endpoint = self.endpoint("messages");
|
||||||
let server_message = parse_error_bytes(bytes.as_ref());
|
let server_message = parse_error_bytes(bytes.as_ref());
|
||||||
return Err(SamplingError::Auth(format!(
|
return Err(SamplingError::Auth(format!(
|
||||||
"Unauthorized (401) from {endpoint}: {server_message}"
|
"Unauthorized (401) from {}: {server_message}",
|
||||||
|
redacted_endpoint(&endpoint)
|
||||||
)));
|
)));
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1657,7 +1671,8 @@ impl SamplingClient {
|
|||||||
let endpoint = self.endpoint("messages");
|
let endpoint = self.endpoint("messages");
|
||||||
let server_message = response.text().await.unwrap_or_default();
|
let server_message = response.text().await.unwrap_or_default();
|
||||||
return Err(SamplingError::Auth(format!(
|
return Err(SamplingError::Auth(format!(
|
||||||
"Unauthorized (401) from {endpoint}: {server_message}"
|
"Unauthorized (401) from {}: {server_message}",
|
||||||
|
redacted_endpoint(&endpoint)
|
||||||
)));
|
)));
|
||||||
}
|
}
|
||||||
let model_metadata = extract_model_metadata(response.headers());
|
let model_metadata = extract_model_metadata(response.headers());
|
||||||
@@ -3048,3 +3063,31 @@ mod tests {
|
|||||||
));
|
));
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[cfg(test)]
|
||||||
|
mod redacted_endpoint_tests {
|
||||||
|
/// Every spelling the client accepts (LF inside, one slash, no slash) loses its userinfo.
|
||||||
|
#[test]
|
||||||
|
fn redacted_endpoint_drops_userinfo_in_every_accepted_spelling() {
|
||||||
|
for spelling in [
|
||||||
|
"http://u:TEST_PASSWORD@127.0.0.1:1/v1/chat/completions",
|
||||||
|
"http://u:TEST PASSWORD@127.0.0.1:1/v1/chat/completions",
|
||||||
|
"http://u:TEST_PASSWORD\n@127.0.0.1:1/v1/chat/completions",
|
||||||
|
"http://u:TEST_PASSWORD\r\n@127.0.0.1:1/v1/chat/completions",
|
||||||
|
"http:/u:TEST_PASSWORD@127.0.0.1:1/v1/chat/completions",
|
||||||
|
"http:u:TEST_PASSWORD@127.0.0.1:1/v1/chat/completions",
|
||||||
|
"http:\\u:TEST_PASSWORD@127.0.0.1:1/v1/chat/completions",
|
||||||
|
] {
|
||||||
|
let redacted = super::redacted_endpoint(spelling);
|
||||||
|
assert_eq!(
|
||||||
|
redacted, "http://127.0.0.1:1/v1/chat/completions",
|
||||||
|
"{spelling:?}"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
let gateway = super::redacted_endpoint(
|
||||||
|
"http://127.0.0.1:1/?access_token=TEST_QUERY_TOKEN&route=x#frag",
|
||||||
|
);
|
||||||
|
assert!(!gateway.contains("TEST_QUERY_TOKEN"), "{gateway}");
|
||||||
|
assert!(gateway.contains("route=x"), "{gateway}");
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -55,6 +55,15 @@ enum BlockType {
|
|||||||
Thinking,
|
Thinking,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Executable after a `max_tokens` stop: every call's arguments parse or are empty (zero-arg convention).
|
||||||
|
fn tool_calls_complete(tool_calls: &[ToolCall]) -> bool {
|
||||||
|
!tool_calls.is_empty()
|
||||||
|
&& tool_calls.iter().all(|tc| {
|
||||||
|
tc.arguments.trim().is_empty()
|
||||||
|
|| serde_json::from_str::<serde::de::IgnoredAny>(&tc.arguments).is_ok()
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
/// Transform a raw Anthropic Messages API stream into a stream of
|
/// Transform a raw Anthropic Messages API stream into a stream of
|
||||||
/// [`SamplingEvent`]s.
|
/// [`SamplingEvent`]s.
|
||||||
///
|
///
|
||||||
@@ -454,11 +463,18 @@ pub fn stream_messages<'a>(
|
|||||||
}
|
}
|
||||||
|
|
||||||
if final_stop_reason == Some(StopReason::Length) {
|
if final_stop_reason == Some(StopReason::Length) {
|
||||||
yield SamplingEvent::Failed {
|
if !tool_calls_complete(&assistant_tool_calls) {
|
||||||
request_id: request_id.clone(),
|
yield SamplingEvent::Failed {
|
||||||
error: SamplingErrorInfo::from(&SamplingError::MaxTokensTruncation),
|
request_id: request_id.clone(),
|
||||||
};
|
error: SamplingErrorInfo::from(&SamplingError::MaxTokensTruncation),
|
||||||
return;
|
};
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
tracing::info!(
|
||||||
|
request_id = %request_id,
|
||||||
|
tool_calls = assistant_tool_calls.len(),
|
||||||
|
"max_tokens stop after complete tool calls; completing the turn so they run"
|
||||||
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Build the final response
|
// Build the final response
|
||||||
|
|||||||
@@ -653,3 +653,90 @@ async fn pure_cache_hit_with_zero_uncached_still_emits_usage() {
|
|||||||
assert_eq!(usage.cached_prompt_tokens, 2500);
|
assert_eq!(usage.cached_prompt_tokens, 2500);
|
||||||
assert_eq!(usage.total_tokens, 2501);
|
assert_eq!(usage.total_tokens, 2501);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn tool_use_start(index: u32, id: &str) -> MessageStreamEvent {
|
||||||
|
MessageStreamEvent::ContentBlockStart {
|
||||||
|
index,
|
||||||
|
content_block: ContentBlock::ToolUse {
|
||||||
|
id: id.into(),
|
||||||
|
name: "do_thing".into(),
|
||||||
|
input: serde_json::json!({}),
|
||||||
|
},
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn arg_delta(index: u32, partial_json: &str) -> MessageStreamEvent {
|
||||||
|
MessageStreamEvent::ContentBlockDelta {
|
||||||
|
index,
|
||||||
|
delta: StreamDelta::InputJsonDelta {
|
||||||
|
partial_json: partial_json.into(),
|
||||||
|
},
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
async fn max_tokens_after(events: Vec<MessageStreamEvent>) -> Vec<SamplingEvent> {
|
||||||
|
let mut all = vec![Ok(message_start())];
|
||||||
|
all.extend(events.into_iter().map(Ok));
|
||||||
|
all.push(Ok(message_delta_with_stop(messages::StopReason::MaxTokens)));
|
||||||
|
all.push(Ok(MessageStreamEvent::MessageStop));
|
||||||
|
let raw = stream::iter(all).boxed();
|
||||||
|
collect(stream_messages(raw, None, rid(), Duration::from_secs(60))).await
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Complete tool calls before a max_tokens stop complete the turn as ToolCalls.
|
||||||
|
#[tokio::test]
|
||||||
|
async fn max_tokens_after_complete_tool_calls_completes_as_tool_calls() {
|
||||||
|
let evs = max_tokens_after(vec![
|
||||||
|
tool_use_start(0, "call_done"),
|
||||||
|
arg_delta(0, "{\"x\": 1}"),
|
||||||
|
block_stop(0),
|
||||||
|
])
|
||||||
|
.await;
|
||||||
|
match evs.last().unwrap() {
|
||||||
|
SamplingEvent::Completed { response, .. } => {
|
||||||
|
assert_eq!(response.stop_reason, Some(StopReason::ToolCalls));
|
||||||
|
assert_eq!(response.tool_calls().len(), 1);
|
||||||
|
assert_eq!(response.tool_calls()[0].arguments.as_ref(), "{\"x\": 1}");
|
||||||
|
}
|
||||||
|
other => panic!("expected Completed(ToolCalls), got {other:?}"),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// A tool_use block with no argument deltas is the zero-argument convention, not truncation.
|
||||||
|
#[tokio::test]
|
||||||
|
async fn max_tokens_after_tool_call_without_arguments_completes() {
|
||||||
|
let evs = max_tokens_after(vec![tool_use_start(0, "call_no_args"), block_stop(0)]).await;
|
||||||
|
match evs.last().unwrap() {
|
||||||
|
SamplingEvent::Completed { response, .. } => {
|
||||||
|
assert_eq!(response.stop_reason, Some(StopReason::ToolCalls));
|
||||||
|
assert_eq!(response.tool_calls()[0].arguments.as_ref(), "");
|
||||||
|
}
|
||||||
|
other => panic!("expected Completed(ToolCalls), got {other:?}"),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// A call cut mid-arguments is truncation: the turn fails so the caller can compact.
|
||||||
|
#[tokio::test]
|
||||||
|
async fn max_tokens_with_truncated_tool_arguments_fails() {
|
||||||
|
let evs = max_tokens_after(vec![
|
||||||
|
tool_use_start(0, "call_ok"),
|
||||||
|
arg_delta(0, "{}"),
|
||||||
|
block_stop(0),
|
||||||
|
tool_use_start(1, "call_cut"),
|
||||||
|
arg_delta(1, "{\"x\": \"trunc"),
|
||||||
|
block_stop(1),
|
||||||
|
])
|
||||||
|
.await;
|
||||||
|
assert!(
|
||||||
|
!evs.iter()
|
||||||
|
.any(|e| matches!(e, SamplingEvent::Completed { .. })),
|
||||||
|
"a cut tool call must not complete: {evs:?}"
|
||||||
|
);
|
||||||
|
match evs.last().unwrap() {
|
||||||
|
SamplingEvent::Failed { error, .. } => assert_eq!(
|
||||||
|
error.kind,
|
||||||
|
crate::events::SamplingErrorKind::MaxTokensTruncation
|
||||||
|
),
|
||||||
|
other => panic!("expected Failed(MaxTokensTruncation), got {other:?}"),
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -897,7 +897,7 @@ impl CompactionsRemaining {
|
|||||||
}
|
}
|
||||||
|
|
||||||
/// Reasoning effort level. `None`/`Minimal` are omitted on the Anthropic Messages API.
|
/// Reasoning effort level. `None`/`Minimal` are omitted on the Anthropic Messages API.
|
||||||
#[derive(Clone, Copy, Debug, Default, PartialEq, Eq, serde::Serialize, serde::Deserialize)]
|
#[derive(Clone, Copy, Debug, Default, PartialEq, Eq, serde::Serialize)]
|
||||||
#[serde(rename_all = "lowercase")]
|
#[serde(rename_all = "lowercase")]
|
||||||
pub enum ReasoningEffort {
|
pub enum ReasoningEffort {
|
||||||
None,
|
None,
|
||||||
@@ -982,6 +982,16 @@ impl std::str::FromStr for ReasoningEffort {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
impl<'de> serde::Deserialize<'de> for ReasoningEffort {
|
||||||
|
fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
|
||||||
|
where
|
||||||
|
D: serde::Deserializer<'de>,
|
||||||
|
{
|
||||||
|
let raw = String::deserialize(deserializer)?;
|
||||||
|
raw.parse().map_err(serde::de::Error::custom)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
/// Canonical wire parse; remapped menu ids need a model catalog.
|
/// Canonical wire parse; remapped menu ids need a model catalog.
|
||||||
pub fn parse_canonical_effort_token(token: &str) -> Option<ReasoningEffort> {
|
pub fn parse_canonical_effort_token(token: &str) -> Option<ReasoningEffort> {
|
||||||
token.parse().ok()
|
token.parse().ok()
|
||||||
@@ -1146,7 +1156,7 @@ pub const ANTHROPIC_OAUTH_BETA: &str = "claude-code-20250219,oauth-2025-04-20";
|
|||||||
|
|
||||||
/// User-Agent kigi presents on the Claude-Code OAuth path (mirrors the
|
/// User-Agent kigi presents on the Claude-Code OAuth path (mirrors the
|
||||||
/// official Claude Code CLI). OAuth-gated: unrelated to the default kigi UA.
|
/// official Claude Code CLI). OAuth-gated: unrelated to the default kigi UA.
|
||||||
pub const CLAUDE_CODE_USER_AGENT: &str = "claude-cli/2.1.75";
|
pub const CLAUDE_CODE_USER_AGENT: &str = "claude-cli/2.1.280";
|
||||||
|
|
||||||
/// System-prompt prefix REQUIRED on the Claude-Code OAuth Messages path: the
|
/// System-prompt prefix REQUIRED on the Claude-Code OAuth Messages path: the
|
||||||
/// OAuth token is Claude-Code-scoped, so Anthropic rejects the request unless
|
/// OAuth token is Claude-Code-scoped, so Anthropic rejects the request unless
|
||||||
@@ -1192,7 +1202,7 @@ pub const CODEX_OPENAI_BETA: &str = "responses=experimental";
|
|||||||
/// openai-codex-gated). The Codex backend does not strictly validate the UA
|
/// openai-codex-gated). The Codex backend does not strictly validate the UA
|
||||||
/// string (Pi ships its own and it works), so this is a stable best-effort
|
/// string (Pi ships its own and it works), so this is a stable best-effort
|
||||||
/// identity, not a pinned build.
|
/// identity, not a pinned build.
|
||||||
pub const CODEX_USER_AGENT: &str = "codex_cli_rs/0.104.0";
|
pub const CODEX_USER_AGENT: &str = "codex_cli_rs/0.156.0";
|
||||||
/// JWT payload claim namespace carrying the ChatGPT account id.
|
/// JWT payload claim namespace carrying the ChatGPT account id.
|
||||||
const CODEX_JWT_AUTH_CLAIM: &str = "https://api.openai.com/auth";
|
const CODEX_JWT_AUTH_CLAIM: &str = "https://api.openai.com/auth";
|
||||||
|
|
||||||
@@ -1849,6 +1859,24 @@ mod tests {
|
|||||||
assert!(serde_json::from_str::<ReasoningEffort>("\"BOGUS\"").is_err());
|
assert!(serde_json::from_str::<ReasoningEffort>("\"BOGUS\"").is_err());
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn reasoning_effort_deserializes_mixed_case() {
|
||||||
|
for (token, want) in [
|
||||||
|
("\"High\"", ReasoningEffort::High),
|
||||||
|
("\"XHIGH\"", ReasoningEffort::Xhigh),
|
||||||
|
("\"mAx\"", ReasoningEffort::Max),
|
||||||
|
] {
|
||||||
|
let got: ReasoningEffort = serde_json::from_str(token).unwrap();
|
||||||
|
assert_eq!(got, want, "deserialize {token}");
|
||||||
|
}
|
||||||
|
let err = serde_json::from_str::<ReasoningEffort>("\"Highest\"").unwrap_err();
|
||||||
|
assert!(
|
||||||
|
err.to_string().contains("invalid reasoning effort"),
|
||||||
|
"{err}"
|
||||||
|
);
|
||||||
|
assert!(serde_json::from_str::<ReasoningEffort>("7").is_err());
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn reasoning_effort_from_str_max_and_xhigh_are_distinct() {
|
fn reasoning_effort_from_str_max_and_xhigh_are_distinct() {
|
||||||
assert_eq!(
|
assert_eq!(
|
||||||
|
|||||||
@@ -51,6 +51,7 @@ enforce = []
|
|||||||
|
|
||||||
[dev-dependencies]
|
[dev-dependencies]
|
||||||
serial_test = { workspace = true }
|
serial_test = { workspace = true }
|
||||||
|
tempfile = { workspace = true }
|
||||||
# Compiles the hand-rolled macOS deny-glob regex in tests to assert it matches
|
# Compiles the hand-rolled macOS deny-glob regex in tests to assert it matches
|
||||||
# EXACTLY the set globset (the Linux backend) matches — the cross-platform parity
|
# EXACTLY the set globset (the Linux backend) matches — the cross-platform parity
|
||||||
# guard for the glob dialect.
|
# guard for the glob dialect.
|
||||||
|
|||||||
@@ -1,91 +1,130 @@
|
|||||||
//! Per-child seccomp network filter. No-op on non-Linux.
|
//! Per-child seccomp network filter. No-op on non-Linux.
|
||||||
|
|
||||||
/// Install seccomp BPF filter blocking network syscalls.
|
#[cfg(target_os = "linux")]
|
||||||
|
mod bpf {
|
||||||
|
use libc::sock_filter;
|
||||||
|
|
||||||
|
pub(super) const SECCOMP_RET_ALLOW: u32 = 0x7fff_0000;
|
||||||
|
pub(super) const SECCOMP_RET_ERRNO: u32 = 0x0005_0000;
|
||||||
|
pub(super) const EPERM_VAL: u32 = 1;
|
||||||
|
#[cfg(target_arch = "x86_64")]
|
||||||
|
pub(super) const X32_SYSCALL_BIT: u32 = 0x4000_0000;
|
||||||
|
/// `seccomp_data` field offsets.
|
||||||
|
pub(super) const OFF_NR: u32 = 0;
|
||||||
|
pub(super) const OFF_ARCH: u32 = 4;
|
||||||
|
#[cfg(target_arch = "x86_64")]
|
||||||
|
pub(super) const EXPECTED_ARCH: u32 = 0xc000_003e; // AUDIT_ARCH_X86_64
|
||||||
|
#[cfg(target_arch = "aarch64")]
|
||||||
|
pub(super) const EXPECTED_ARCH: u32 = 0xc000_00b7; // AUDIT_ARCH_AARCH64
|
||||||
|
#[cfg(not(any(target_arch = "x86_64", target_arch = "aarch64")))]
|
||||||
|
pub(super) const EXPECTED_ARCH: u32 = 0;
|
||||||
|
|
||||||
|
pub(super) fn stmt(code: u32, k: u32) -> sock_filter {
|
||||||
|
sock_filter {
|
||||||
|
code: code as u16,
|
||||||
|
jt: 0,
|
||||||
|
jf: 0,
|
||||||
|
k,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
pub(super) fn jump(code: u32, k: u32, jt: u8, jf: u8) -> sock_filter {
|
||||||
|
sock_filter {
|
||||||
|
code: code as u16,
|
||||||
|
jt,
|
||||||
|
jf,
|
||||||
|
k,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Reject a foreign-arch (and, on x86_64, x32) syscall number before
|
||||||
|
/// matching `nr`, so a syscall reached through another table cannot
|
||||||
|
/// alias past the deny list.
|
||||||
|
pub(super) fn push_arch_nr_gate(f: &mut Vec<sock_filter>) {
|
||||||
|
use libc::{BPF_ABS, BPF_JEQ, BPF_JMP, BPF_K, BPF_LD, BPF_RET, BPF_W};
|
||||||
|
f.push(stmt(BPF_LD | BPF_W | BPF_ABS, OFF_ARCH));
|
||||||
|
f.push(jump(BPF_JMP | BPF_JEQ | BPF_K, EXPECTED_ARCH, 1, 0));
|
||||||
|
f.push(stmt(BPF_RET | BPF_K, SECCOMP_RET_ERRNO | EPERM_VAL));
|
||||||
|
f.push(stmt(BPF_LD | BPF_W | BPF_ABS, OFF_NR));
|
||||||
|
#[cfg(target_arch = "x86_64")]
|
||||||
|
{
|
||||||
|
f.push(jump(
|
||||||
|
BPF_JMP | libc::BPF_JSET | BPF_K,
|
||||||
|
X32_SYSCALL_BIT,
|
||||||
|
0,
|
||||||
|
1,
|
||||||
|
));
|
||||||
|
f.push(stmt(BPF_RET | BPF_K, SECCOMP_RET_ERRNO | EPERM_VAL));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Syscalls that open or send on a socket, including the `io_uring` and
|
||||||
|
/// `sendmmsg` paths that bypass the classic entry points.
|
||||||
|
#[cfg(target_os = "linux")]
|
||||||
|
fn child_network_blocked_syscalls() -> [u32; 11] {
|
||||||
|
use libc::{
|
||||||
|
SYS_accept, SYS_accept4, SYS_bind, SYS_connect, SYS_io_uring_enter, SYS_io_uring_register,
|
||||||
|
SYS_io_uring_setup, SYS_listen, SYS_sendmmsg, SYS_sendmsg, SYS_sendto,
|
||||||
|
};
|
||||||
|
[
|
||||||
|
SYS_connect as u32,
|
||||||
|
SYS_bind as u32,
|
||||||
|
SYS_sendto as u32,
|
||||||
|
SYS_sendmsg as u32,
|
||||||
|
SYS_sendmmsg as u32,
|
||||||
|
SYS_listen as u32,
|
||||||
|
SYS_accept as u32,
|
||||||
|
SYS_accept4 as u32,
|
||||||
|
SYS_io_uring_setup as u32,
|
||||||
|
SYS_io_uring_enter as u32,
|
||||||
|
SYS_io_uring_register as u32,
|
||||||
|
]
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(target_os = "linux")]
|
||||||
|
fn build_child_network_filter() -> Vec<libc::sock_filter> {
|
||||||
|
use bpf::{EPERM_VAL, SECCOMP_RET_ALLOW, SECCOMP_RET_ERRNO, jump, stmt};
|
||||||
|
use libc::{BPF_JEQ, BPF_JMP, BPF_K, BPF_RET};
|
||||||
|
|
||||||
|
let blocked = child_network_blocked_syscalls();
|
||||||
|
let mut f = Vec::with_capacity(blocked.len() + 10);
|
||||||
|
bpf::push_arch_nr_gate(&mut f);
|
||||||
|
let n = blocked.len();
|
||||||
|
for (i, &sys) in blocked.iter().enumerate() {
|
||||||
|
let remaining = n - i - 1;
|
||||||
|
f.push(jump(BPF_JMP | BPF_JEQ | BPF_K, sys, remaining as u8 + 1, 0));
|
||||||
|
}
|
||||||
|
f.push(stmt(BPF_RET | BPF_K, SECCOMP_RET_ALLOW));
|
||||||
|
f.push(stmt(BPF_RET | BPF_K, SECCOMP_RET_ERRNO | EPERM_VAL));
|
||||||
|
f
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Built once: `pre_exec` runs after `fork`, where allocating is unsafe.
|
||||||
|
#[cfg(target_os = "linux")]
|
||||||
|
pub fn prebuilt_child_network_filter() -> &'static [libc::sock_filter] {
|
||||||
|
static FILTER: std::sync::OnceLock<Vec<libc::sock_filter>> = std::sync::OnceLock::new();
|
||||||
|
FILTER.get_or_init(build_child_network_filter)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Install the seccomp BPF filter blocking network syscalls.
|
||||||
///
|
///
|
||||||
/// # Safety
|
/// # Safety
|
||||||
///
|
///
|
||||||
/// Must be called in a `pre_exec` context (after `fork`, before `exec`).
|
/// Must be called in a `pre_exec` context (after `fork`, before `exec`).
|
||||||
#[cfg(target_os = "linux")]
|
#[cfg(target_os = "linux")]
|
||||||
pub unsafe fn install_child_network_filter() -> std::io::Result<()> {
|
pub unsafe fn install_child_network_filter(filter: &[libc::sock_filter]) -> std::io::Result<()> {
|
||||||
use libc::{
|
use libc::{PR_SET_NO_NEW_PRIVS, PR_SET_SECCOMP, SECCOMP_MODE_FILTER, prctl, sock_fprog};
|
||||||
BPF_ABS, BPF_JEQ, BPF_JMP, BPF_K, BPF_LD, BPF_RET, BPF_W, PR_SET_NO_NEW_PRIVS,
|
|
||||||
PR_SET_SECCOMP, SECCOMP_MODE_FILTER, SYS_accept, SYS_accept4, SYS_bind, SYS_connect,
|
|
||||||
SYS_listen, SYS_sendmsg, SYS_sendto, prctl, sock_filter, sock_fprog,
|
|
||||||
};
|
|
||||||
|
|
||||||
const SECCOMP_RET_ALLOW: u32 = 0x7fff_0000;
|
|
||||||
const SECCOMP_RET_ERRNO: u32 = 0x0005_0000;
|
|
||||||
// libc::EPERM
|
|
||||||
const EPERM_VAL: u32 = 1;
|
|
||||||
|
|
||||||
macro_rules! bpf_stmt {
|
|
||||||
($code:expr, $k:expr) => {
|
|
||||||
sock_filter {
|
|
||||||
code: $code as u16,
|
|
||||||
jt: 0,
|
|
||||||
jf: 0,
|
|
||||||
k: $k as u32,
|
|
||||||
}
|
|
||||||
};
|
|
||||||
}
|
|
||||||
|
|
||||||
macro_rules! bpf_jump {
|
|
||||||
($code:expr, $k:expr, $jt:expr, $jf:expr) => {
|
|
||||||
sock_filter {
|
|
||||||
code: $code as u16,
|
|
||||||
jt: $jt,
|
|
||||||
jf: $jf,
|
|
||||||
k: $k as u32,
|
|
||||||
}
|
|
||||||
};
|
|
||||||
}
|
|
||||||
|
|
||||||
// seccomp_data.nr offset
|
|
||||||
const NR_OFFSET: u32 = 0;
|
|
||||||
|
|
||||||
let blocked_syscalls: &[i64] = &[
|
|
||||||
SYS_connect,
|
|
||||||
SYS_bind,
|
|
||||||
SYS_sendto,
|
|
||||||
SYS_sendmsg,
|
|
||||||
SYS_listen,
|
|
||||||
SYS_accept,
|
|
||||||
SYS_accept4,
|
|
||||||
];
|
|
||||||
|
|
||||||
let mut filter: Vec<sock_filter> = Vec::new();
|
|
||||||
let total_checks = blocked_syscalls.len();
|
|
||||||
|
|
||||||
filter.push(bpf_stmt!(BPF_LD | BPF_W | BPF_ABS, NR_OFFSET));
|
|
||||||
|
|
||||||
for (i, &syscall) in blocked_syscalls.iter().enumerate() {
|
|
||||||
let remaining = total_checks - i - 1;
|
|
||||||
filter.push(bpf_jump!(
|
|
||||||
BPF_JMP | BPF_JEQ | BPF_K,
|
|
||||||
syscall,
|
|
||||||
// match: jump to ERRNO
|
|
||||||
remaining as u8 + 1,
|
|
||||||
// no match: check next
|
|
||||||
0
|
|
||||||
));
|
|
||||||
}
|
|
||||||
|
|
||||||
filter.push(bpf_stmt!(BPF_RET | BPF_K, SECCOMP_RET_ALLOW));
|
|
||||||
|
|
||||||
filter.push(bpf_stmt!(BPF_RET | BPF_K, SECCOMP_RET_ERRNO | EPERM_VAL));
|
|
||||||
|
|
||||||
let prog = sock_fprog {
|
let prog = sock_fprog {
|
||||||
len: filter.len() as u16,
|
len: filter.len() as u16,
|
||||||
filter: filter.as_mut_ptr(),
|
filter: filter.as_ptr().cast_mut(),
|
||||||
};
|
};
|
||||||
|
|
||||||
// Must set PR_SET_NO_NEW_PRIVS before applying seccomp filter
|
|
||||||
// SAFETY: prctl with PR_SET_NO_NEW_PRIVS is safe in pre_exec context.
|
// SAFETY: prctl with PR_SET_NO_NEW_PRIVS is safe in pre_exec context.
|
||||||
if unsafe { prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0) } != 0 {
|
if unsafe { prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0) } != 0 {
|
||||||
return Err(std::io::Error::last_os_error());
|
return Err(std::io::Error::last_os_error());
|
||||||
}
|
}
|
||||||
|
// SAFETY: prog is a valid sock_fprog pointing to a filter the kernel copies.
|
||||||
// SAFETY: prog is a valid sock_fprog pointing to our filter array.
|
|
||||||
if unsafe {
|
if unsafe {
|
||||||
prctl(
|
prctl(
|
||||||
PR_SET_SECCOMP,
|
PR_SET_SECCOMP,
|
||||||
@@ -98,7 +137,6 @@ pub unsafe fn install_child_network_filter() -> std::io::Result<()> {
|
|||||||
{
|
{
|
||||||
return Err(std::io::Error::last_os_error());
|
return Err(std::io::Error::last_os_error());
|
||||||
}
|
}
|
||||||
|
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -109,3 +147,101 @@ pub unsafe fn install_child_network_filter() -> std::io::Result<()> {
|
|||||||
pub unsafe fn install_child_network_filter() -> std::io::Result<()> {
|
pub unsafe fn install_child_network_filter() -> std::io::Result<()> {
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[cfg(all(test, target_os = "linux"))]
|
||||||
|
mod tests {
|
||||||
|
use super::bpf::*;
|
||||||
|
use super::{build_child_network_filter, child_network_blocked_syscalls};
|
||||||
|
use libc::sock_filter;
|
||||||
|
|
||||||
|
/// Minimal classic-BPF interpreter over synthetic `seccomp_data` fields.
|
||||||
|
fn eval(filter: &[sock_filter], arch: u32, nr: u32) -> u32 {
|
||||||
|
use libc::{BPF_ABS, BPF_JEQ, BPF_JMP, BPF_JSET, BPF_K, BPF_LD, BPF_RET, BPF_W};
|
||||||
|
let mut pc = 0usize;
|
||||||
|
let mut a = 0u32;
|
||||||
|
for _ in 0..filter.len().saturating_mul(2) {
|
||||||
|
let insn = &filter[pc];
|
||||||
|
let op = insn.code as u32;
|
||||||
|
if op == (BPF_LD | BPF_W | BPF_ABS) {
|
||||||
|
a = match insn.k {
|
||||||
|
OFF_NR => nr,
|
||||||
|
OFF_ARCH => arch,
|
||||||
|
_ => 0,
|
||||||
|
};
|
||||||
|
pc += 1;
|
||||||
|
} else if op == (BPF_JMP | BPF_JEQ | BPF_K) {
|
||||||
|
pc = if a == insn.k {
|
||||||
|
pc + 1 + insn.jt as usize
|
||||||
|
} else {
|
||||||
|
pc + 1 + insn.jf as usize
|
||||||
|
};
|
||||||
|
} else if op == (BPF_JMP | BPF_JSET | BPF_K) {
|
||||||
|
pc = if a & insn.k != 0 {
|
||||||
|
pc + 1 + insn.jt as usize
|
||||||
|
} else {
|
||||||
|
pc + 1 + insn.jf as usize
|
||||||
|
};
|
||||||
|
} else if op == (BPF_RET | BPF_K) {
|
||||||
|
return insn.k;
|
||||||
|
} else {
|
||||||
|
panic!("unsupported opcode {:#x} at {pc}", insn.code);
|
||||||
|
}
|
||||||
|
assert!(pc < filter.len(), "pc out of range");
|
||||||
|
}
|
||||||
|
panic!("filter did not RET");
|
||||||
|
}
|
||||||
|
|
||||||
|
fn is_allow(r: u32) -> bool {
|
||||||
|
r == SECCOMP_RET_ALLOW
|
||||||
|
}
|
||||||
|
|
||||||
|
fn is_eperm(r: u32) -> bool {
|
||||||
|
r == (SECCOMP_RET_ERRNO | EPERM_VAL)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn blocks_every_network_syscall_and_allows_read_and_socket() {
|
||||||
|
let f = build_child_network_filter();
|
||||||
|
for sys in child_network_blocked_syscalls() {
|
||||||
|
assert!(
|
||||||
|
is_eperm(eval(&f, EXPECTED_ARCH, sys)),
|
||||||
|
"syscall {sys} must be EPERM"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
assert!(is_allow(eval(&f, EXPECTED_ARCH, libc::SYS_read as u32)));
|
||||||
|
assert!(is_allow(eval(&f, EXPECTED_ARCH, libc::SYS_socket as u32)));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn covers_io_uring_and_sendmmsg() {
|
||||||
|
let blocked = child_network_blocked_syscalls();
|
||||||
|
for sys in [
|
||||||
|
libc::SYS_sendmmsg,
|
||||||
|
libc::SYS_io_uring_setup,
|
||||||
|
libc::SYS_io_uring_enter,
|
||||||
|
libc::SYS_io_uring_register,
|
||||||
|
] {
|
||||||
|
assert!(blocked.contains(&(sys as u32)), "{sys} missing");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn wrong_arch_and_x32_are_denied_before_the_nr_match() {
|
||||||
|
let f = build_child_network_filter();
|
||||||
|
assert!(is_eperm(eval(&f, 0xdead_beef, libc::SYS_read as u32)));
|
||||||
|
#[cfg(target_arch = "x86_64")]
|
||||||
|
assert!(is_eperm(eval(
|
||||||
|
&f,
|
||||||
|
EXPECTED_ARCH,
|
||||||
|
(libc::SYS_read as u32) | X32_SYSCALL_BIT
|
||||||
|
)));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn prebuilt_filter_is_shared() {
|
||||||
|
let a = super::prebuilt_child_network_filter();
|
||||||
|
let b = super::prebuilt_child_network_filter();
|
||||||
|
assert!(std::ptr::eq(a, b));
|
||||||
|
assert_eq!(a.len(), build_child_network_filter().len());
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -333,6 +333,27 @@ fn is_devbox_based(profile: &ProfileName, config: &SandboxConfig) -> bool {
|
|||||||
_ => false,
|
_ => false,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
/// Whether an existing `/data` needs the devbox bwrap read-only bind; a filesystem error other than NotFound conservatively requires it.
|
||||||
|
#[cfg(target_os = "linux")]
|
||||||
|
pub fn requires_data_write_deny(profile: &ProfileName, workspace: &Path) -> bool {
|
||||||
|
requires_data_write_deny_for(
|
||||||
|
profile,
|
||||||
|
&profiles::load_sandbox_config(workspace),
|
||||||
|
data_path_requires_bind(Path::new("/data")),
|
||||||
|
)
|
||||||
|
}
|
||||||
|
#[cfg(target_os = "linux")]
|
||||||
|
fn requires_data_write_deny_for(
|
||||||
|
profile: &ProfileName,
|
||||||
|
config: &SandboxConfig,
|
||||||
|
is_data_present: bool,
|
||||||
|
) -> bool {
|
||||||
|
is_devbox_based(profile, config) && is_data_present
|
||||||
|
}
|
||||||
|
#[cfg(target_os = "linux")]
|
||||||
|
fn data_path_requires_bind(path: &Path) -> bool {
|
||||||
|
path.try_exists().unwrap_or(true)
|
||||||
|
}
|
||||||
/// Whether kernel read-deny enforcement is required. The single source of truth
|
/// Whether kernel read-deny enforcement is required. The single source of truth
|
||||||
/// for this classification so callers (e.g. the shell's fail-closed startup path)
|
/// for this classification so callers (e.g. the shell's fail-closed startup path)
|
||||||
/// cannot drift and silently fail open.
|
/// cannot drift and silently fail open.
|
||||||
@@ -360,6 +381,23 @@ pub fn requires_read_deny(profile: &ProfileName, workspace: &Path) -> bool {
|
|||||||
pub fn requires_read_deny(_profile: &ProfileName, _workspace: &Path) -> bool {
|
pub fn requires_read_deny(_profile: &ProfileName, _workspace: &Path) -> bool {
|
||||||
false
|
false
|
||||||
}
|
}
|
||||||
|
/// Whether the resolved profile leaves `~/.kigi` read-only outside its
|
||||||
|
/// state dirs (strict and every profile extending it), so files first use
|
||||||
|
/// would write there must be minted before enforcement.
|
||||||
|
#[cfg(all(feature = "enforce", unix))]
|
||||||
|
pub fn restricts_home_writes(profile: &ProfileName, workspace: &Path) -> bool {
|
||||||
|
if *profile == ProfileName::Off {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
let config = profiles::load_sandbox_config(workspace);
|
||||||
|
profile
|
||||||
|
.resolve_profile(workspace, &config)
|
||||||
|
.is_ok_and(|resolved| !resolved.read_write.contains(&paths::kigi_home()))
|
||||||
|
}
|
||||||
|
#[cfg(not(all(feature = "enforce", unix)))]
|
||||||
|
pub fn restricts_home_writes(_profile: &ProfileName, _workspace: &Path) -> bool {
|
||||||
|
false
|
||||||
|
}
|
||||||
/// A profile's resolved bwrap deny plan: read-only mounts (`deny_write`),
|
/// A profile's resolved bwrap deny plan: read-only mounts (`deny_write`),
|
||||||
/// bound-over unreadable placeholders (`deny_read`), and whether the profile
|
/// bound-over unreadable placeholders (`deny_read`), and whether the profile
|
||||||
/// carries deny globs (`has_globs`, so the re-exec proceeds even with zero
|
/// carries deny globs (`has_globs`, so the re-exec proceeds even with zero
|
||||||
@@ -382,7 +420,11 @@ struct BwrapDenyPlan {
|
|||||||
#[cfg(all(feature = "enforce", target_os = "linux"))]
|
#[cfg(all(feature = "enforce", target_os = "linux"))]
|
||||||
fn bwrap_deny_plan(profile: &ProfileName, workspace: &Path) -> Option<BwrapDenyPlan> {
|
fn bwrap_deny_plan(profile: &ProfileName, workspace: &Path) -> Option<BwrapDenyPlan> {
|
||||||
let config = profiles::load_sandbox_config(workspace);
|
let config = profiles::load_sandbox_config(workspace);
|
||||||
let deny_write: Vec<String> = if is_devbox_based(profile, &config) {
|
let deny_write: Vec<String> = if requires_data_write_deny_for(
|
||||||
|
profile,
|
||||||
|
&config,
|
||||||
|
data_path_requires_bind(Path::new("/data")),
|
||||||
|
) {
|
||||||
vec!["/data".to_string()]
|
vec!["/data".to_string()]
|
||||||
} else {
|
} else {
|
||||||
Vec::new()
|
Vec::new()
|
||||||
@@ -424,7 +466,11 @@ fn bwrap_deny_plan(profile: &ProfileName, workspace: &Path) -> Option<BwrapDenyP
|
|||||||
#[cfg(all(not(feature = "enforce"), target_os = "linux"))]
|
#[cfg(all(not(feature = "enforce"), target_os = "linux"))]
|
||||||
fn bwrap_deny_plan(profile: &ProfileName, workspace: &Path) -> Option<BwrapDenyPlan> {
|
fn bwrap_deny_plan(profile: &ProfileName, workspace: &Path) -> Option<BwrapDenyPlan> {
|
||||||
let config = profiles::load_sandbox_config(workspace);
|
let config = profiles::load_sandbox_config(workspace);
|
||||||
let deny_write: Vec<String> = if is_devbox_based(profile, &config) {
|
let deny_write: Vec<String> = if requires_data_write_deny_for(
|
||||||
|
profile,
|
||||||
|
&config,
|
||||||
|
data_path_requires_bind(Path::new("/data")),
|
||||||
|
) {
|
||||||
vec!["/data".to_string()]
|
vec!["/data".to_string()]
|
||||||
} else {
|
} else {
|
||||||
Vec::new()
|
Vec::new()
|
||||||
@@ -595,6 +641,43 @@ mod tests {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
#[test]
|
#[test]
|
||||||
|
#[cfg(target_os = "linux")]
|
||||||
|
fn data_write_deny_requires_devbox_and_a_present_data_dir() {
|
||||||
|
let tmp = tempfile::tempdir().unwrap();
|
||||||
|
std::fs::create_dir_all(tmp.path().join(".kigi")).unwrap();
|
||||||
|
std::fs::write(
|
||||||
|
tmp.path().join(".kigi/sandbox.toml"),
|
||||||
|
"[profiles.devext]\nextends = \"devbox\"\n\n[profiles.plain]\nextends = \"workspace\"\n",
|
||||||
|
)
|
||||||
|
.unwrap();
|
||||||
|
let config = profiles::load_sandbox_config(tmp.path());
|
||||||
|
assert!(requires_data_write_deny_for(
|
||||||
|
&ProfileName::Devbox,
|
||||||
|
&config,
|
||||||
|
true
|
||||||
|
));
|
||||||
|
assert!(!requires_data_write_deny_for(
|
||||||
|
&ProfileName::Devbox,
|
||||||
|
&config,
|
||||||
|
false
|
||||||
|
));
|
||||||
|
assert!(requires_data_write_deny_for(
|
||||||
|
&ProfileName::Custom("devext".into()),
|
||||||
|
&config,
|
||||||
|
true
|
||||||
|
));
|
||||||
|
assert!(!requires_data_write_deny_for(
|
||||||
|
&ProfileName::Custom("plain".into()),
|
||||||
|
&config,
|
||||||
|
true
|
||||||
|
));
|
||||||
|
assert!(!requires_data_write_deny_for(
|
||||||
|
&ProfileName::Workspace,
|
||||||
|
&config,
|
||||||
|
true
|
||||||
|
));
|
||||||
|
}
|
||||||
|
#[test]
|
||||||
fn configured_profile_is_recorded() {
|
fn configured_profile_is_recorded() {
|
||||||
set_configured_profile("read-only");
|
set_configured_profile("read-only");
|
||||||
assert_eq!(configured_profile_name(), Some("read-only"));
|
assert_eq!(configured_profile_name(), Some("read-only"));
|
||||||
@@ -700,10 +783,11 @@ mod tests {
|
|||||||
"devbox-empty",
|
"devbox-empty",
|
||||||
"[profiles.devempty]\nextends = \"devbox\"\n",
|
"[profiles.devempty]\nextends = \"devbox\"\n",
|
||||||
);
|
);
|
||||||
assert!(
|
assert_eq!(
|
||||||
bwrap_reexec_for_profile(&ProfileName::Custom("devempty".to_string()), &ws_empty)
|
bwrap_reexec_for_profile(&ProfileName::Custom("devempty".to_string()), &ws_empty)
|
||||||
.is_some(),
|
.is_some(),
|
||||||
"devbox-extending custom must compose the /data write-deny re-exec"
|
Path::new("/data").exists(),
|
||||||
|
"devbox-extending custom composes the /data write-deny re-exec exactly when /data exists"
|
||||||
);
|
);
|
||||||
let _ = std::fs::remove_dir_all(&ws_empty);
|
let _ = std::fs::remove_dir_all(&ws_empty);
|
||||||
let ws_ws = temp_workspace_with_sandbox_toml(
|
let ws_ws = temp_workspace_with_sandbox_toml(
|
||||||
@@ -717,3 +801,31 @@ mod tests {
|
|||||||
let _ = std::fs::remove_dir_all(&ws_ws);
|
let _ = std::fs::remove_dir_all(&ws_ws);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[cfg(all(test, feature = "enforce", unix))]
|
||||||
|
mod home_write_tests {
|
||||||
|
use super::{ProfileName, restricts_home_writes};
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn strict_restricts_home_writes_and_workspace_does_not() {
|
||||||
|
let workspace = std::env::temp_dir();
|
||||||
|
assert!(restricts_home_writes(&ProfileName::Strict, &workspace));
|
||||||
|
assert!(!restricts_home_writes(&ProfileName::Workspace, &workspace));
|
||||||
|
assert!(!restricts_home_writes(&ProfileName::ReadOnly, &workspace));
|
||||||
|
assert!(!restricts_home_writes(&ProfileName::Off, &workspace));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn custom_profile_extending_strict_inherits_the_restriction() {
|
||||||
|
let tmp = tempfile::tempdir().unwrap();
|
||||||
|
let project = tmp.path().join(".kigi");
|
||||||
|
std::fs::create_dir_all(&project).unwrap();
|
||||||
|
std::fs::write(
|
||||||
|
project.join("sandbox.toml"),
|
||||||
|
"[profiles.audit-home-write-test]\nextends = \"strict\"\n",
|
||||||
|
)
|
||||||
|
.unwrap();
|
||||||
|
let custom = ProfileName::Custom("audit-home-write-test".to_string());
|
||||||
|
assert!(restricts_home_writes(&custom, tmp.path()));
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -1,7 +1,7 @@
|
|||||||
//! Sandbox event logger.
|
//! Sandbox event logger.
|
||||||
//!
|
//!
|
||||||
//! Events (profile applied, violations, bypasses) are buffered in memory and
|
//! Events (profile applied, violations, bypasses) are buffered in memory and
|
||||||
//! flushed as JSONL to `~/.kigi/sandbox-events.jsonl`.
|
//! flushed as JSONL to `~/.kigi/sessions/sandbox-events.jsonl`.
|
||||||
|
|
||||||
use std::path::PathBuf;
|
use std::path::PathBuf;
|
||||||
use std::sync::Mutex;
|
use std::sync::Mutex;
|
||||||
@@ -87,8 +87,12 @@ impl SandboxLogger {
|
|||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Under `sessions/`: the only home subtree a strict sandbox leaves
|
||||||
|
/// writable, and this flush runs after enforcement.
|
||||||
fn log_file_path() -> PathBuf {
|
fn log_file_path() -> PathBuf {
|
||||||
kigi_config::kigi_home().join("sandbox-events.jsonl")
|
kigi_config::kigi_home()
|
||||||
|
.join("sessions")
|
||||||
|
.join("sandbox-events.jsonl")
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -96,6 +96,37 @@ pub(crate) fn essential_writable_paths(workspace: &Path) -> Vec<PathBuf> {
|
|||||||
paths
|
paths
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Home subtrees the process keeps writing after enforcement: session and
|
||||||
|
/// worktree state, memory, diagnostics. Landlock cannot carve a child out of
|
||||||
|
/// a write grant, so the rest of `~/.kigi` (`config.toml`, `auth.json`,
|
||||||
|
/// `sandbox.toml`, `hooks/`, `bin/`, `vendor/`, `plugin-data/`) stays
|
||||||
|
/// read-only and a sandboxed child cannot arm the next launch.
|
||||||
|
#[cfg(all(feature = "enforce", unix))]
|
||||||
|
const HOME_STATE_DIRS: &[&str] = &[
|
||||||
|
"run",
|
||||||
|
"sessions",
|
||||||
|
"worktrees",
|
||||||
|
"worktree_pool",
|
||||||
|
"tasks",
|
||||||
|
"memory",
|
||||||
|
"logs",
|
||||||
|
"debug",
|
||||||
|
"crash",
|
||||||
|
"memtrace",
|
||||||
|
"trace-exports",
|
||||||
|
];
|
||||||
|
|
||||||
|
/// Writable paths for the strict profile: the workspace, the home state
|
||||||
|
/// subtrees, and temp.
|
||||||
|
#[cfg(all(feature = "enforce", unix))]
|
||||||
|
pub(crate) fn essential_writable_paths_strict(workspace: &Path) -> Vec<PathBuf> {
|
||||||
|
let home = kigi_home();
|
||||||
|
let mut paths = vec![workspace.to_path_buf()];
|
||||||
|
paths.extend(HOME_STATE_DIRS.iter().map(|dir| home.join(dir)));
|
||||||
|
paths.extend(temp_writable_paths());
|
||||||
|
paths
|
||||||
|
}
|
||||||
|
|
||||||
/// Writable directory paths for the read-only profile (minimal: just ~/.kigi + temp).
|
/// Writable directory paths for the read-only profile (minimal: just ~/.kigi + temp).
|
||||||
/// Device files are handled separately via `allow_file` in `to_capability_set_with_config`.
|
/// Device files are handled separately via `allow_file` in `to_capability_set_with_config`.
|
||||||
#[cfg(all(feature = "enforce", unix))]
|
#[cfg(all(feature = "enforce", unix))]
|
||||||
|
|||||||
@@ -18,6 +18,7 @@ use crate::paths::kigi_home;
|
|||||||
#[cfg(all(feature = "enforce", unix))]
|
#[cfg(all(feature = "enforce", unix))]
|
||||||
use crate::paths::{
|
use crate::paths::{
|
||||||
DEVICE_DIRS, DEVICE_FILES, essential_writable_paths, essential_writable_paths_minimal,
|
DEVICE_DIRS, DEVICE_FILES, essential_writable_paths, essential_writable_paths_minimal,
|
||||||
|
essential_writable_paths_strict,
|
||||||
};
|
};
|
||||||
|
|
||||||
/// A resolved sandbox profile ready to be converted to a `CapabilitySet`.
|
/// A resolved sandbox profile ready to be converted to a `CapabilitySet`.
|
||||||
@@ -186,6 +187,32 @@ fn load_config_file(path: &Path) -> Option<SandboxConfig> {
|
|||||||
#[cfg(all(feature = "enforce", unix))]
|
#[cfg(all(feature = "enforce", unix))]
|
||||||
impl ProfileName {
|
impl ProfileName {
|
||||||
/// Convert this profile into a nono `CapabilitySet` for the given workspace.
|
/// Convert this profile into a nono `CapabilitySet` for the given workspace.
|
||||||
|
/// The directory a `read_write` entry really grants. A symlink under
|
||||||
|
/// `~/.kigi` is followed only to the default `~/.kigi/sessions` (the
|
||||||
|
/// `KIGI_SHARE_DIR` override case); any other target would widen the
|
||||||
|
/// grant to wherever the link points. Missing paths are created.
|
||||||
|
fn read_write_grant_path(path: &Path, home: &Path) -> Option<PathBuf> {
|
||||||
|
match std::fs::symlink_metadata(path) {
|
||||||
|
Ok(meta) if meta.file_type().is_symlink() => {
|
||||||
|
if path == home || !path.starts_with(home) {
|
||||||
|
return Some(path.to_path_buf());
|
||||||
|
}
|
||||||
|
let real = dunce::canonicalize(path).ok()?;
|
||||||
|
let default_sessions = kigi_config::default_kigi_home().join("sessions");
|
||||||
|
(real.is_dir()
|
||||||
|
&& path.file_name() == Some(std::ffi::OsStr::new("sessions"))
|
||||||
|
&& real == default_sessions)
|
||||||
|
.then_some(real)
|
||||||
|
}
|
||||||
|
Ok(_) => Some(path.to_path_buf()),
|
||||||
|
Err(err) if err.kind() == std::io::ErrorKind::NotFound => {
|
||||||
|
std::fs::create_dir_all(path).ok()?;
|
||||||
|
Some(path.to_path_buf())
|
||||||
|
}
|
||||||
|
Err(_) => None,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
pub fn to_capability_set(&self, workspace: &Path) -> anyhow::Result<CapabilitySet> {
|
pub fn to_capability_set(&self, workspace: &Path) -> anyhow::Result<CapabilitySet> {
|
||||||
let config = load_sandbox_config(workspace);
|
let config = load_sandbox_config(workspace);
|
||||||
self.to_capability_set_with_config(workspace, &config)
|
self.to_capability_set_with_config(workspace, &config)
|
||||||
@@ -231,13 +258,14 @@ impl ProfileName {
|
|||||||
// apply time (it opens an O_PATH fd), but new files within it can
|
// apply time (it opens an O_PATH fd), but new files within it can
|
||||||
// be created freely after the sandbox is applied. Pre-create
|
// be created freely after the sandbox is applied. Pre-create
|
||||||
// directories like ~/.kigi/ that may not exist on first run.
|
// directories like ~/.kigi/ that may not exist on first run.
|
||||||
|
let home = kigi_home();
|
||||||
for path in &profile.read_write {
|
for path in &profile.read_write {
|
||||||
if !path.exists() && std::fs::create_dir_all(path).is_err() {
|
let Some(grant) = Self::read_write_grant_path(path, &home) else {
|
||||||
tracing::warn!(path = ?path, "read_write path does not exist and could not be created, skipping");
|
tracing::warn!(path = ?path, "read_write grant skipped");
|
||||||
continue;
|
continue;
|
||||||
}
|
};
|
||||||
let Some(path_str) = path.to_str() else {
|
let Some(path_str) = grant.to_str() else {
|
||||||
tracing::warn!(path = ?path, "Skipping non-UTF8 read_write path");
|
tracing::warn!(path = ?grant, "Skipping non-UTF8 read_write path");
|
||||||
continue;
|
continue;
|
||||||
};
|
};
|
||||||
caps = caps.allow_path(path_str, AccessMode::ReadWrite)?;
|
caps = caps.allow_path(path_str, AccessMode::ReadWrite)?;
|
||||||
@@ -380,12 +408,15 @@ impl ProfileName {
|
|||||||
.chain(std::iter::once(home.join("Library")))
|
.chain(std::iter::once(home.join("Library")))
|
||||||
.filter(|p| p.exists())
|
.filter(|p| p.exists())
|
||||||
.chain(std::iter::once(workspace.to_path_buf()))
|
.chain(std::iter::once(workspace.to_path_buf()))
|
||||||
|
// Read-only: config, auth and global hooks are read after
|
||||||
|
// enforcement; only sessions/ below stays writable.
|
||||||
|
.chain(std::iter::once(kigi_home()))
|
||||||
.collect();
|
.collect();
|
||||||
|
|
||||||
Ok(SandboxProfile {
|
Ok(SandboxProfile {
|
||||||
name: "strict".to_string(),
|
name: "strict".to_string(),
|
||||||
read_only: system_read,
|
read_only: system_read,
|
||||||
read_write: essential_writable_paths(workspace),
|
read_write: essential_writable_paths_strict(workspace),
|
||||||
deny: vec![],
|
deny: vec![],
|
||||||
default_read: false,
|
default_read: false,
|
||||||
restrict_network: true,
|
restrict_network: true,
|
||||||
@@ -544,6 +575,82 @@ mod tests {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
#[cfg(all(feature = "enforce", unix))]
|
||||||
|
fn strict_read_write_is_workspace_home_state_and_temp() {
|
||||||
|
let workspace = std::env::temp_dir();
|
||||||
|
let profile = ProfileName::Strict
|
||||||
|
.resolve_profile(&workspace, &SandboxConfig::default())
|
||||||
|
.expect("strict resolves");
|
||||||
|
let home = kigi_home();
|
||||||
|
assert_eq!(profile.read_write[0], workspace);
|
||||||
|
for dir in ["sessions", "worktrees", "memory", "logs", "debug"] {
|
||||||
|
assert!(
|
||||||
|
profile.read_write.contains(&home.join(dir)),
|
||||||
|
"{dir} must stay writable: {:?}",
|
||||||
|
profile.read_write
|
||||||
|
);
|
||||||
|
}
|
||||||
|
for denied in [
|
||||||
|
home.clone(),
|
||||||
|
home.join("hooks"),
|
||||||
|
home.join("vendor"),
|
||||||
|
home.join("bin"),
|
||||||
|
] {
|
||||||
|
assert!(
|
||||||
|
!profile.read_write.contains(&denied),
|
||||||
|
"strict must not grant {}: {:?}",
|
||||||
|
denied.display(),
|
||||||
|
profile.read_write
|
||||||
|
);
|
||||||
|
}
|
||||||
|
assert!(
|
||||||
|
profile.read_only.contains(&home),
|
||||||
|
"config/auth/hooks are read after enforcement: {:?}",
|
||||||
|
profile.read_only
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
#[cfg(all(feature = "enforce", unix))]
|
||||||
|
fn read_write_grant_follows_real_dirs_and_creates_missing_ones() {
|
||||||
|
let tmp = tempfile::tempdir().unwrap();
|
||||||
|
let home = tmp.path().join("home");
|
||||||
|
std::fs::create_dir_all(home.join("sessions")).unwrap();
|
||||||
|
assert_eq!(
|
||||||
|
ProfileName::read_write_grant_path(&home.join("sessions"), &home),
|
||||||
|
Some(home.join("sessions"))
|
||||||
|
);
|
||||||
|
let missing = home.join("fresh");
|
||||||
|
assert_eq!(
|
||||||
|
ProfileName::read_write_grant_path(&missing, &home),
|
||||||
|
Some(missing.clone())
|
||||||
|
);
|
||||||
|
assert!(missing.is_dir());
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
#[cfg(all(feature = "enforce", unix))]
|
||||||
|
fn read_write_grant_refuses_a_home_symlink_pointing_elsewhere() {
|
||||||
|
let tmp = tempfile::tempdir().unwrap();
|
||||||
|
let home = tmp.path().join("home");
|
||||||
|
let outside = tmp.path().join("outside");
|
||||||
|
std::fs::create_dir_all(&home).unwrap();
|
||||||
|
std::fs::create_dir_all(&outside).unwrap();
|
||||||
|
std::os::unix::fs::symlink(&outside, home.join("sessions")).unwrap();
|
||||||
|
assert_eq!(
|
||||||
|
ProfileName::read_write_grant_path(&home.join("sessions"), &home),
|
||||||
|
None
|
||||||
|
);
|
||||||
|
// A symlinked workspace outside the home is the user's own choice.
|
||||||
|
let ws_link = tmp.path().join("ws");
|
||||||
|
std::os::unix::fs::symlink(&outside, &ws_link).unwrap();
|
||||||
|
assert_eq!(
|
||||||
|
ProfileName::read_write_grant_path(&ws_link, &home),
|
||||||
|
Some(ws_link.clone())
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
#[cfg(all(feature = "enforce", unix))]
|
#[cfg(all(feature = "enforce", unix))]
|
||||||
fn base_profile_capability_set_builds() {
|
fn base_profile_capability_set_builds() {
|
||||||
|
|||||||
@@ -544,13 +544,16 @@ mod attachments_protocol {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[cfg(any(target_os = "macos", test))]
|
||||||
|
mod osascript_probe;
|
||||||
|
|
||||||
// macOS: subprocess-based clipboard (no AppKit linkage)
|
// macOS: subprocess-based clipboard (no AppKit linkage)
|
||||||
#[cfg(target_os = "macos")]
|
#[cfg(target_os = "macos")]
|
||||||
mod platform {
|
mod platform {
|
||||||
use std::process::{Command, Stdio};
|
use std::process::{Command, Stdio};
|
||||||
use std::sync::OnceLock;
|
use std::sync::OnceLock;
|
||||||
|
|
||||||
use super::attachments_protocol::{FURL_MARKER, IMAGE_MARKER, parse_attachments_output};
|
use super::osascript_probe::{ProbeTemps, osascript_attachments, read_probe_raster};
|
||||||
use super::{ClipboardAttachments, ImageData};
|
use super::{ClipboardAttachments, ImageData};
|
||||||
|
|
||||||
// Fast pasteboard probes (NSPasteboard via lazy dlopen)
|
// Fast pasteboard probes (NSPasteboard via lazy dlopen)
|
||||||
@@ -759,153 +762,15 @@ mod platform {
|
|||||||
Ok(output.stdout)
|
Ok(output.stdout)
|
||||||
}
|
}
|
||||||
|
|
||||||
fn attachments_probe_temp_paths() -> (std::path::PathBuf, std::path::PathBuf, std::path::PathBuf)
|
fn run_osascript(script: &str) -> anyhow::Result<Vec<u8>> {
|
||||||
{
|
|
||||||
let temp_dir = std::env::temp_dir();
|
|
||||||
(
|
|
||||||
temp_dir.join("kigi-clipboard-probe.png"),
|
|
||||||
temp_dir.join("kigi-clipboard-probe.tiff"),
|
|
||||||
temp_dir.join("kigi-clipboard-probe.jpg"),
|
|
||||||
)
|
|
||||||
}
|
|
||||||
|
|
||||||
fn read_clipboard_image_from_class(
|
|
||||||
class: &str,
|
|
||||||
path_png: &std::path::Path,
|
|
||||||
path_tiff: &std::path::Path,
|
|
||||||
path_jpg: &std::path::Path,
|
|
||||||
) -> anyhow::Result<Option<ImageData>> {
|
|
||||||
let (temp_path, mime) = match class {
|
|
||||||
"PNGf" => (path_png, "image/png"),
|
|
||||||
"TIFF" => (path_tiff, "image/tiff"),
|
|
||||||
"JPEG" => (path_jpg, "image/jpeg"),
|
|
||||||
_ => return Ok(None),
|
|
||||||
};
|
|
||||||
|
|
||||||
let data = match std::fs::read(temp_path) {
|
|
||||||
Ok(bytes) if !bytes.is_empty() => bytes,
|
|
||||||
Ok(_) => {
|
|
||||||
let _ = std::fs::remove_file(temp_path);
|
|
||||||
return Ok(None);
|
|
||||||
}
|
|
||||||
Err(e) => {
|
|
||||||
let _ = std::fs::remove_file(temp_path);
|
|
||||||
return Err(anyhow::anyhow!("failed to read clipboard temp file: {e}"));
|
|
||||||
}
|
|
||||||
};
|
|
||||||
|
|
||||||
let _ = std::fs::remove_file(temp_path);
|
|
||||||
Ok(Some(ImageData {
|
|
||||||
data,
|
|
||||||
mime_type: mime.to_owned(),
|
|
||||||
}))
|
|
||||||
}
|
|
||||||
|
|
||||||
fn remove_attachment_probe_temps(
|
|
||||||
path_png: &std::path::Path,
|
|
||||||
path_tiff: &std::path::Path,
|
|
||||||
path_jpg: &std::path::Path,
|
|
||||||
) {
|
|
||||||
let _ = std::fs::remove_file(path_png);
|
|
||||||
let _ = std::fs::remove_file(path_tiff);
|
|
||||||
let _ = std::fs::remove_file(path_jpg);
|
|
||||||
}
|
|
||||||
|
|
||||||
fn attachments_osascript(
|
|
||||||
path_png: &std::path::Path,
|
|
||||||
path_tiff: &std::path::Path,
|
|
||||||
path_jpg: &std::path::Path,
|
|
||||||
) -> String {
|
|
||||||
format!(
|
|
||||||
"set furlOut to \"none\"\n\
|
|
||||||
try\n\
|
|
||||||
set urlList to the clipboard as list\n\
|
|
||||||
set out to \"\"\n\
|
|
||||||
repeat with u in urlList\n\
|
|
||||||
try\n\
|
|
||||||
set itemRef to contents of u as \u{00AB}class furl\u{00BB}\n\
|
|
||||||
set out to out & POSIX path of itemRef & \"\\n\"\n\
|
|
||||||
end try\n\
|
|
||||||
end repeat\n\
|
|
||||||
if out is not \"\" then\n\
|
|
||||||
set furlOut to out\n\
|
|
||||||
else\n\
|
|
||||||
try\n\
|
|
||||||
set urlRef to the clipboard as \u{00AB}class furl\u{00BB}\n\
|
|
||||||
set furlOut to POSIX path of urlRef\n\
|
|
||||||
on error\n\
|
|
||||||
end try\n\
|
|
||||||
end if\n\
|
|
||||||
on error\n\
|
|
||||||
try\n\
|
|
||||||
set urlRef to the clipboard as \u{00AB}class furl\u{00BB}\n\
|
|
||||||
set furlOut to POSIX path of urlRef\n\
|
|
||||||
on error\n\
|
|
||||||
end try\n\
|
|
||||||
end try\n\
|
|
||||||
set imageOut to \"NONE\"\n\
|
|
||||||
if furlOut is \"none\" then\n\
|
|
||||||
try\n\
|
|
||||||
set imgData to the clipboard as \u{00AB}class PNGf\u{00BB}\n\
|
|
||||||
set filePath to POSIX file \"{png}\" as text\n\
|
|
||||||
set fRef to open for access file filePath with write permission\n\
|
|
||||||
set eof of fRef to 0\n\
|
|
||||||
write imgData to fRef\n\
|
|
||||||
close access fRef\n\
|
|
||||||
set imageOut to \"PNGf\"\n\
|
|
||||||
on error\n\
|
|
||||||
try\n\
|
|
||||||
set imgData to the clipboard as \u{00AB}class TIFF\u{00BB}\n\
|
|
||||||
set filePath to POSIX file \"{tiff}\" as text\n\
|
|
||||||
set fRef to open for access file filePath with write permission\n\
|
|
||||||
set eof of fRef to 0\n\
|
|
||||||
write imgData to fRef\n\
|
|
||||||
close access fRef\n\
|
|
||||||
set imageOut to \"TIFF\"\n\
|
|
||||||
on error\n\
|
|
||||||
try\n\
|
|
||||||
set imgData to the clipboard as \u{00AB}class JPEG\u{00BB}\n\
|
|
||||||
set filePath to POSIX file \"{jpg}\" as text\n\
|
|
||||||
set fRef to open for access file filePath with write permission\n\
|
|
||||||
set eof of fRef to 0\n\
|
|
||||||
write imgData to fRef\n\
|
|
||||||
close access fRef\n\
|
|
||||||
set imageOut to \"JPEG\"\n\
|
|
||||||
on error\n\
|
|
||||||
end try\n\
|
|
||||||
end try\n\
|
|
||||||
end try\n\
|
|
||||||
end if\n\
|
|
||||||
return \"{furl_marker}\" & linefeed & furlOut & linefeed & \"{image_marker}\" & linefeed & \"IMAGE:\" & imageOut",
|
|
||||||
png = path_png.display(),
|
|
||||||
tiff = path_tiff.display(),
|
|
||||||
jpg = path_jpg.display(),
|
|
||||||
furl_marker = FURL_MARKER,
|
|
||||||
image_marker = IMAGE_MARKER,
|
|
||||||
)
|
|
||||||
}
|
|
||||||
|
|
||||||
fn run_attachments_osascript() -> anyhow::Result<String> {
|
|
||||||
let (path_png, path_tiff, path_jpg) = attachments_probe_temp_paths();
|
|
||||||
remove_attachment_probe_temps(&path_png, &path_tiff, &path_jpg);
|
|
||||||
|
|
||||||
let script = attachments_osascript(&path_png, &path_tiff, &path_jpg);
|
|
||||||
|
|
||||||
let mut cmd = Command::new("osascript");
|
let mut cmd = Command::new("osascript");
|
||||||
cmd.arg("-e")
|
cmd.arg("-e")
|
||||||
.arg(&script)
|
.arg(script)
|
||||||
.stdin(Stdio::null())
|
.stdin(Stdio::null())
|
||||||
.stdout(Stdio::piped())
|
.stdout(Stdio::piped())
|
||||||
.stderr(Stdio::piped());
|
.stderr(Stdio::piped());
|
||||||
kigi_tools::util::detach_std_command(&mut cmd);
|
kigi_tools::util::detach_std_command(&mut cmd);
|
||||||
let stdout = match checked_command_stdout("osascript", cmd.output()) {
|
checked_command_stdout("osascript", cmd.output())
|
||||||
Ok(stdout) => stdout,
|
|
||||||
Err(error) => {
|
|
||||||
remove_attachment_probe_temps(&path_png, &path_tiff, &path_jpg);
|
|
||||||
return Err(error);
|
|
||||||
}
|
|
||||||
};
|
|
||||||
Ok(String::from_utf8_lossy(&stdout).into_owned())
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Unified furl-then-image pasteboard probe.
|
/// Unified furl-then-image pasteboard probe.
|
||||||
@@ -923,28 +788,7 @@ mod platform {
|
|||||||
image: Some(image),
|
image: Some(image),
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
let raw = run_attachments_osascript()?;
|
osascript_attachments(ProbeTemps::new(), run_osascript)
|
||||||
if raw.trim().is_empty() {
|
|
||||||
return Ok(ClipboardAttachments::default());
|
|
||||||
}
|
|
||||||
|
|
||||||
let (path_png, path_tiff, path_jpg) = attachments_probe_temp_paths();
|
|
||||||
let (file_urls, image_class) = parse_attachments_output(&raw);
|
|
||||||
let image = if file_urls.is_some() {
|
|
||||||
remove_attachment_probe_temps(&path_png, &path_tiff, &path_jpg);
|
|
||||||
None
|
|
||||||
} else {
|
|
||||||
match image_class {
|
|
||||||
Some(class) => {
|
|
||||||
read_clipboard_image_from_class(class, &path_png, &path_tiff, &path_jpg)?
|
|
||||||
}
|
|
||||||
None => {
|
|
||||||
remove_attachment_probe_temps(&path_png, &path_tiff, &path_jpg);
|
|
||||||
None
|
|
||||||
}
|
|
||||||
}
|
|
||||||
};
|
|
||||||
Ok(ClipboardAttachments { file_urls, image })
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Read text via `pbpaste -Prefer txt`.
|
/// Read text via `pbpaste -Prefer txt`.
|
||||||
@@ -1020,8 +864,8 @@ mod platform {
|
|||||||
return Ok(Some(image));
|
return Ok(Some(image));
|
||||||
}
|
}
|
||||||
|
|
||||||
let (path_png, path_tiff, path_jpg) = attachments_probe_temp_paths();
|
let temps = ProbeTemps::new()?;
|
||||||
remove_attachment_probe_temps(&path_png, &path_tiff, &path_jpg);
|
let (path_png, path_tiff, path_jpg) = temps.paths();
|
||||||
|
|
||||||
// Image-only AppleScript (ImageOnly paste route). Unicode guillemets
|
// Image-only AppleScript (ImageOnly paste route). Unicode guillemets
|
||||||
// (\u{AB}/\u{BB}) are required for `«class …»` in `osascript -e`.
|
// (\u{AB}/\u{BB}) are required for `«class …»` in `osascript -e`.
|
||||||
@@ -1069,20 +913,13 @@ mod platform {
|
|||||||
.stdout(Stdio::piped())
|
.stdout(Stdio::piped())
|
||||||
.stderr(Stdio::null());
|
.stderr(Stdio::null());
|
||||||
kigi_tools::util::detach_std_command(&mut cmd);
|
kigi_tools::util::detach_std_command(&mut cmd);
|
||||||
let stdout = match checked_command_stdout("osascript", cmd.output()) {
|
let stdout = checked_command_stdout("osascript", cmd.output())?;
|
||||||
Ok(stdout) => stdout,
|
|
||||||
Err(error) => {
|
|
||||||
remove_attachment_probe_temps(&path_png, &path_tiff, &path_jpg);
|
|
||||||
return Err(error);
|
|
||||||
}
|
|
||||||
};
|
|
||||||
let class = String::from_utf8_lossy(&stdout);
|
let class = String::from_utf8_lossy(&stdout);
|
||||||
let class = class.trim();
|
let class = class.trim();
|
||||||
if class == "none" {
|
if class == "none" {
|
||||||
remove_attachment_probe_temps(&path_png, &path_tiff, &path_jpg);
|
|
||||||
return Ok(None);
|
return Ok(None);
|
||||||
}
|
}
|
||||||
read_clipboard_image_from_class(class, &path_png, &path_tiff, &path_jpg)
|
read_probe_raster(class, &temps)
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Read file URLs from the macOS pasteboard via `osascript`.
|
/// Read file URLs from the macOS pasteboard via `osascript`.
|
||||||
|
|||||||
@@ -0,0 +1,246 @@
|
|||||||
|
//! The macOS `osascript` attachment probe: scratch files, script text, and the read flow.
|
||||||
|
|
||||||
|
use std::path::PathBuf;
|
||||||
|
|
||||||
|
use super::attachments_protocol::{FURL_MARKER, IMAGE_MARKER, parse_attachments_output};
|
||||||
|
use super::{ClipboardAttachments, ImageData};
|
||||||
|
|
||||||
|
/// Private 0700 dir, removed on drop: a shared path let a concurrent kigi swap the raster.
|
||||||
|
pub(crate) struct ProbeTemps(tempfile::TempDir);
|
||||||
|
|
||||||
|
impl ProbeTemps {
|
||||||
|
pub(crate) fn new() -> anyhow::Result<Self> {
|
||||||
|
let mut builder = tempfile::Builder::new();
|
||||||
|
builder.prefix("kigi-clipboard-probe-");
|
||||||
|
#[cfg(unix)]
|
||||||
|
{
|
||||||
|
use std::os::unix::fs::PermissionsExt;
|
||||||
|
builder.permissions(std::fs::Permissions::from_mode(0o700));
|
||||||
|
}
|
||||||
|
builder
|
||||||
|
.tempdir()
|
||||||
|
.map(Self)
|
||||||
|
.map_err(|e| anyhow::anyhow!("failed to create clipboard probe dir: {e}"))
|
||||||
|
}
|
||||||
|
|
||||||
|
/// PNG, TIFF, JPEG: the AppleScript writes the first class that coerces.
|
||||||
|
pub(crate) fn paths(&self) -> (PathBuf, PathBuf, PathBuf) {
|
||||||
|
(
|
||||||
|
self.0.path().join("probe.png"),
|
||||||
|
self.0.path().join("probe.tiff"),
|
||||||
|
self.0.path().join("probe.jpg"),
|
||||||
|
)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// File URLs first, a raster only when none are present; without `temps` the raster half is skipped.
|
||||||
|
pub(crate) fn attachments_osascript(temps: Option<&ProbeTemps>) -> String {
|
||||||
|
let image_probe = temps.map_or_else(String::new, raster_half);
|
||||||
|
format!(
|
||||||
|
"set furlOut to \"none\"\n\
|
||||||
|
try\n\
|
||||||
|
set urlList to the clipboard as list\n\
|
||||||
|
set out to \"\"\n\
|
||||||
|
repeat with u in urlList\n\
|
||||||
|
try\n\
|
||||||
|
set itemRef to contents of u as \u{00AB}class furl\u{00BB}\n\
|
||||||
|
set out to out & POSIX path of itemRef & \"\\n\"\n\
|
||||||
|
end try\n\
|
||||||
|
end repeat\n\
|
||||||
|
if out is not \"\" then\n\
|
||||||
|
set furlOut to out\n\
|
||||||
|
else\n\
|
||||||
|
try\n\
|
||||||
|
set urlRef to the clipboard as \u{00AB}class furl\u{00BB}\n\
|
||||||
|
set furlOut to POSIX path of urlRef\n\
|
||||||
|
on error\n\
|
||||||
|
end try\n\
|
||||||
|
end if\n\
|
||||||
|
on error\n\
|
||||||
|
try\n\
|
||||||
|
set urlRef to the clipboard as \u{00AB}class furl\u{00BB}\n\
|
||||||
|
set furlOut to POSIX path of urlRef\n\
|
||||||
|
on error\n\
|
||||||
|
end try\n\
|
||||||
|
end try\n\
|
||||||
|
set imageOut to \"NONE\"\n\
|
||||||
|
{image_probe}\
|
||||||
|
return \"{furl_marker}\" & linefeed & furlOut & linefeed & \"{image_marker}\" & linefeed & \"IMAGE:\" & imageOut",
|
||||||
|
furl_marker = FURL_MARKER,
|
||||||
|
image_marker = IMAGE_MARKER,
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn raster_half(temps: &ProbeTemps) -> String {
|
||||||
|
let (path_png, path_tiff, path_jpg) = temps.paths();
|
||||||
|
format!(
|
||||||
|
"if furlOut is \"none\" then\n\
|
||||||
|
try\n\
|
||||||
|
set imgData to the clipboard as \u{00AB}class PNGf\u{00BB}\n\
|
||||||
|
set filePath to POSIX file \"{png}\" as text\n\
|
||||||
|
set fRef to open for access file filePath with write permission\n\
|
||||||
|
set eof of fRef to 0\n\
|
||||||
|
write imgData to fRef\n\
|
||||||
|
close access fRef\n\
|
||||||
|
set imageOut to \"PNGf\"\n\
|
||||||
|
on error\n\
|
||||||
|
try\n\
|
||||||
|
set imgData to the clipboard as \u{00AB}class TIFF\u{00BB}\n\
|
||||||
|
set filePath to POSIX file \"{tiff}\" as text\n\
|
||||||
|
set fRef to open for access file filePath with write permission\n\
|
||||||
|
set eof of fRef to 0\n\
|
||||||
|
write imgData to fRef\n\
|
||||||
|
close access fRef\n\
|
||||||
|
set imageOut to \"TIFF\"\n\
|
||||||
|
on error\n\
|
||||||
|
try\n\
|
||||||
|
set imgData to the clipboard as \u{00AB}class JPEG\u{00BB}\n\
|
||||||
|
set filePath to POSIX file \"{jpg}\" as text\n\
|
||||||
|
set fRef to open for access file filePath with write permission\n\
|
||||||
|
set eof of fRef to 0\n\
|
||||||
|
write imgData to fRef\n\
|
||||||
|
close access fRef\n\
|
||||||
|
set imageOut to \"JPEG\"\n\
|
||||||
|
on error\n\
|
||||||
|
end try\n\
|
||||||
|
end try\n\
|
||||||
|
end try\n\
|
||||||
|
end if\n",
|
||||||
|
png = path_png.display(),
|
||||||
|
tiff = path_tiff.display(),
|
||||||
|
jpg = path_jpg.display(),
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// The class on stdout picks the file and MIME; an empty file means no raster.
|
||||||
|
pub(crate) fn read_probe_raster(
|
||||||
|
class: &str,
|
||||||
|
temps: &ProbeTemps,
|
||||||
|
) -> anyhow::Result<Option<ImageData>> {
|
||||||
|
let (path_png, path_tiff, path_jpg) = temps.paths();
|
||||||
|
let (temp_path, mime) = match class {
|
||||||
|
"PNGf" => (path_png, "image/png"),
|
||||||
|
"TIFF" => (path_tiff, "image/tiff"),
|
||||||
|
"JPEG" => (path_jpg, "image/jpeg"),
|
||||||
|
_ => return Ok(None),
|
||||||
|
};
|
||||||
|
let data = std::fs::read(&temp_path)
|
||||||
|
.map_err(|e| anyhow::anyhow!("failed to read clipboard temp file: {e}"))?;
|
||||||
|
if data.is_empty() {
|
||||||
|
return Ok(None);
|
||||||
|
}
|
||||||
|
Ok(Some(ImageData {
|
||||||
|
data,
|
||||||
|
mime_type: mime.to_owned(),
|
||||||
|
}))
|
||||||
|
}
|
||||||
|
|
||||||
|
/// `run` executes a script and returns its stdout; a file paste needs no scratch dir.
|
||||||
|
pub(crate) fn osascript_attachments(
|
||||||
|
temps: anyhow::Result<ProbeTemps>,
|
||||||
|
run: impl FnOnce(&str) -> anyhow::Result<Vec<u8>>,
|
||||||
|
) -> anyhow::Result<ClipboardAttachments> {
|
||||||
|
if let Err(error) = &temps {
|
||||||
|
tracing::warn!(%error, "clipboard probe reads file URLs only");
|
||||||
|
}
|
||||||
|
let stdout = run(&attachments_osascript(temps.as_ref().ok()))?;
|
||||||
|
let (file_urls, image_class) = parse_attachments_output(&String::from_utf8_lossy(&stdout));
|
||||||
|
if file_urls.is_some() {
|
||||||
|
return Ok(ClipboardAttachments {
|
||||||
|
file_urls,
|
||||||
|
image: None,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
let temps = temps?;
|
||||||
|
let image = match image_class {
|
||||||
|
Some(class) => read_probe_raster(class, &temps)?,
|
||||||
|
None => None,
|
||||||
|
};
|
||||||
|
Ok(ClipboardAttachments {
|
||||||
|
file_urls: None,
|
||||||
|
image,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(test)]
|
||||||
|
mod tests {
|
||||||
|
use super::*;
|
||||||
|
|
||||||
|
fn attachments_stdout(furl: &str, image: &str) -> Vec<u8> {
|
||||||
|
format!("{FURL_MARKER}\n{furl}\n{IMAGE_MARKER}\nIMAGE:{image}").into_bytes()
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn two_probes_never_share_a_path() {
|
||||||
|
let first = ProbeTemps::new().unwrap();
|
||||||
|
let second = ProbeTemps::new().unwrap();
|
||||||
|
assert_ne!(first.paths().0, second.paths().0);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn scratch_dir_goes_away_with_the_probe() {
|
||||||
|
let temps = ProbeTemps::new().unwrap();
|
||||||
|
let (png, tiff, jpg) = temps.paths();
|
||||||
|
let dir = png.parent().unwrap().to_path_buf();
|
||||||
|
assert_eq!(tiff.parent().unwrap(), dir);
|
||||||
|
assert_eq!(jpg.parent().unwrap(), dir);
|
||||||
|
std::fs::write(&png, b"raster").unwrap();
|
||||||
|
|
||||||
|
drop(temps);
|
||||||
|
assert!(!dir.exists(), "{} must be removed", dir.display());
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(unix)]
|
||||||
|
#[test]
|
||||||
|
fn scratch_dir_is_private() {
|
||||||
|
use std::os::unix::fs::PermissionsExt;
|
||||||
|
let temps = ProbeTemps::new().unwrap();
|
||||||
|
let dir = temps.paths().0.parent().unwrap().to_path_buf();
|
||||||
|
let mode = std::fs::metadata(dir).unwrap().permissions().mode();
|
||||||
|
assert_eq!(mode & 0o777, 0o700);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn reported_class_is_read_from_this_probes_file() {
|
||||||
|
let temps = ProbeTemps::new().unwrap();
|
||||||
|
let (_png, tiff, _jpg) = temps.paths();
|
||||||
|
std::fs::write(&tiff, b"MM\x00\x2a").unwrap();
|
||||||
|
let script_names_the_file = tiff.display().to_string();
|
||||||
|
|
||||||
|
let read = osascript_attachments(Ok(temps), |script| {
|
||||||
|
assert!(script.contains(&script_names_the_file), "{script}");
|
||||||
|
Ok(attachments_stdout("none", "TIFF"))
|
||||||
|
})
|
||||||
|
.unwrap();
|
||||||
|
|
||||||
|
let image = read.image.expect("raster attached");
|
||||||
|
assert_eq!(image.mime_type, "image/tiff");
|
||||||
|
assert_eq!(image.data, b"MM\x00\x2a".to_vec());
|
||||||
|
assert_eq!(read.file_urls, None);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn file_urls_survive_a_missing_scratch_dir() {
|
||||||
|
let read = osascript_attachments(Err(anyhow::anyhow!("no scratch dir")), |script| {
|
||||||
|
assert!(
|
||||||
|
!script.contains("open for access"),
|
||||||
|
"raster half must be skipped"
|
||||||
|
);
|
||||||
|
Ok(attachments_stdout("/tmp/a.txt\n", "NONE"))
|
||||||
|
})
|
||||||
|
.unwrap();
|
||||||
|
|
||||||
|
assert_eq!(read.file_urls.as_deref(), Some("/tmp/a.txt"));
|
||||||
|
assert_eq!(read.image, None);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn no_scratch_dir_and_no_file_url_is_an_error_not_an_empty_board() {
|
||||||
|
let err = osascript_attachments(Err(anyhow::anyhow!("no scratch dir")), |_| {
|
||||||
|
Ok(attachments_stdout("none", "NONE"))
|
||||||
|
})
|
||||||
|
.unwrap_err();
|
||||||
|
|
||||||
|
assert!(err.to_string().contains("no scratch dir"), "{err}");
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -150,6 +150,7 @@ fs2 = { workspace = true }
|
|||||||
zstd = { workspace = true }
|
zstd = { workspace = true }
|
||||||
tar = { workspace = true }
|
tar = { workspace = true }
|
||||||
url = { workspace = true }
|
url = { workspace = true }
|
||||||
|
kigi-secrets = { path = "../kigi-secrets" }
|
||||||
walkdir = { workspace = true }
|
walkdir = { workspace = true }
|
||||||
tdigests = "1.0"
|
tdigests = "1.0"
|
||||||
semver = { workspace = true }
|
semver = { workspace = true }
|
||||||
|
|||||||
@@ -2101,7 +2101,7 @@ kigi --sandbox strict
|
|||||||
| `off` (default) | Unrestricted | Unrestricted | Unrestricted | No sandbox |
|
| `off` (default) | Unrestricted | Unrestricted | Unrestricted | No sandbox |
|
||||||
| `workspace` | Everywhere | CWD + `/tmp` + `~/.kigi/` | Allowed | Normal development |
|
| `workspace` | Everywhere | CWD + `/tmp` + `~/.kigi/` | Allowed | Normal development |
|
||||||
| `read-only` | Everywhere | `~/.kigi/` only | Blocked | Exploration, code review |
|
| `read-only` | Everywhere | `~/.kigi/` only | Blocked | Exploration, code review |
|
||||||
| `strict` | CWD + system paths | CWD + `/tmp` + `~/.kigi/` | Blocked | Untrusted code |
|
| `strict` | CWD + system paths | CWD + `/tmp` + `~/.kigi/` state dirs | Blocked | Untrusted code |
|
||||||
|
|
||||||
Sensitive paths (`~/.ssh/`, `~/.aws/`, `~/.gnupg/`, `~/.kigi/auth/`) are always
|
Sensitive paths (`~/.ssh/`, `~/.aws/`, `~/.gnupg/`, `~/.kigi/auth/`) are always
|
||||||
write-protected regardless of profile.
|
write-protected regardless of profile.
|
||||||
@@ -2160,7 +2160,7 @@ model cannot convince the agent to relax restrictions at runtime.
|
|||||||
|
|
||||||
### Event Logging
|
### Event Logging
|
||||||
|
|
||||||
Sandbox events (profile applied, violations) are logged to `~/.kigi/sandbox-events.jsonl`
|
Sandbox events (profile applied, violations) are logged to `~/.kigi/sessions/sandbox-events.jsonl`
|
||||||
for telemetry and debugging.
|
for telemetry and debugging.
|
||||||
|
|
||||||
---
|
---
|
||||||
|
|||||||
@@ -2601,6 +2601,7 @@ pub(crate) fn resolve_model_list(
|
|||||||
}
|
}
|
||||||
resolved = prefetched;
|
resolved = prefetched;
|
||||||
}
|
}
|
||||||
|
let mut explicit_api_backend_keys = std::collections::HashSet::new();
|
||||||
for (key, model_override) in &cfg.config_models {
|
for (key, model_override) in &cfg.config_models {
|
||||||
let had_base = resolved.contains_key(key);
|
let had_base = resolved.contains_key(key);
|
||||||
let base = resolved.shift_remove(key);
|
let base = resolved.shift_remove(key);
|
||||||
@@ -2617,6 +2618,9 @@ pub(crate) fn resolve_model_list(
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
if model_override.api_backend.is_some() {
|
||||||
|
explicit_api_backend_keys.insert(key.as_str());
|
||||||
|
}
|
||||||
let entry = model_override.apply(key, base, &cfg.endpoints);
|
let entry = model_override.apply(key, base, &cfg.endpoints);
|
||||||
tracing::debug!(
|
tracing::debug!(
|
||||||
model_key = % key, base_url = % entry.info.base_url, has_api_key = entry
|
model_key = % key, base_url = % entry.info.base_url, has_api_key = entry
|
||||||
@@ -2638,7 +2642,7 @@ pub(crate) fn resolve_model_list(
|
|||||||
)
|
)
|
||||||
})
|
})
|
||||||
.collect();
|
.collect();
|
||||||
for entry in resolved.values_mut() {
|
for (key, entry) in resolved.iter_mut() {
|
||||||
if let Some((donor_cw, donor_backend)) = donors.get(&entry.info.model) {
|
if let Some((donor_cw, donor_backend)) = donors.get(&entry.info.model) {
|
||||||
if entry.info.context_window.get() == default_cw {
|
if entry.info.context_window.get() == default_cw {
|
||||||
tracing::debug!(
|
tracing::debug!(
|
||||||
@@ -2648,7 +2652,9 @@ pub(crate) fn resolve_model_list(
|
|||||||
);
|
);
|
||||||
entry.info.context_window = *donor_cw;
|
entry.info.context_window = *donor_cw;
|
||||||
}
|
}
|
||||||
if entry.info.api_backend == ApiBackend::default()
|
// An explicit `[model.X] api_backend` wins even when it is the default.
|
||||||
|
if !explicit_api_backend_keys.contains(key.as_str())
|
||||||
|
&& entry.info.api_backend == ApiBackend::default()
|
||||||
&& *donor_backend != ApiBackend::default()
|
&& *donor_backend != ApiBackend::default()
|
||||||
{
|
{
|
||||||
entry.info.api_backend.clone_from(donor_backend);
|
entry.info.api_backend.clone_from(donor_backend);
|
||||||
@@ -6701,7 +6707,10 @@ reasoning_effort = "low"
|
|||||||
assert_eq!(model.info.base_url, "https://inference.example.com/v1");
|
assert_eq!(model.info.base_url, "https://inference.example.com/v1");
|
||||||
}
|
}
|
||||||
#[test]
|
#[test]
|
||||||
|
#[serial]
|
||||||
fn e2e_default_model_with_session_routes_to_proxy() {
|
fn e2e_default_model_with_session_routes_to_proxy() {
|
||||||
|
// Hermetic: serial tests point KIGI_CODE_BASE_URL at wiremock.
|
||||||
|
let _base = EnvGuard::unset(kigi_env::CODE_BASE_URL_ENV);
|
||||||
let (_, models) = resolve_models_from_toml("", None);
|
let (_, models) = resolve_models_from_toml("", None);
|
||||||
let model = models
|
let model = models
|
||||||
.get(BUNDLED_DEFAULT_KEY)
|
.get(BUNDLED_DEFAULT_KEY)
|
||||||
@@ -6833,7 +6842,10 @@ reasoning_effort = "low"
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
#[test]
|
#[test]
|
||||||
|
#[serial]
|
||||||
fn e2e_duplicate_model_field_both_entries_survive() {
|
fn e2e_duplicate_model_field_both_entries_survive() {
|
||||||
|
// Hermetic: serial tests point KIGI_CODE_BASE_URL at wiremock.
|
||||||
|
let _base = EnvGuard::unset(kigi_env::CODE_BASE_URL_ENV);
|
||||||
let dm = crate::models::default_model();
|
let dm = crate::models::default_model();
|
||||||
let (_, models) = resolve_models_from_toml(
|
let (_, models) = resolve_models_from_toml(
|
||||||
&format!(
|
&format!(
|
||||||
@@ -9067,6 +9079,47 @@ default = "kigi-4.5"
|
|||||||
sibling 'kigi-build' (same model slug), not stay at {default_cw}"
|
sibling 'kigi-build' (same model slug), not stay at {default_cw}"
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
/// An explicit `[model.X] api_backend` survives a same-slug sibling even when it is the default.
|
||||||
|
#[test]
|
||||||
|
fn slug_propagation_keeps_an_explicit_default_api_backend() {
|
||||||
|
// Only kigi-messages has a non-default context window: the slug's single donor.
|
||||||
|
let default_cw = DEFAULT_CONTEXT_WINDOW;
|
||||||
|
let raw: toml::Value = toml::from_str(&format!(
|
||||||
|
r#"
|
||||||
|
[model.kigi-messages]
|
||||||
|
model = "kigi-4.5"
|
||||||
|
context_window = 500000
|
||||||
|
base_url = "https://test.example.com/v1"
|
||||||
|
api_backend = "messages"
|
||||||
|
|
||||||
|
[model.kigi-chat]
|
||||||
|
model = "kigi-4.5"
|
||||||
|
context_window = {default_cw}
|
||||||
|
base_url = "https://test.example.com/v1"
|
||||||
|
api_backend = "chat_completions"
|
||||||
|
|
||||||
|
[model.kigi-plain]
|
||||||
|
model = "kigi-4.5"
|
||||||
|
context_window = {default_cw}
|
||||||
|
base_url = "https://test.example.com/v1"
|
||||||
|
"#
|
||||||
|
))
|
||||||
|
.unwrap();
|
||||||
|
let cfg = Config::new_from_toml_cfg(&raw).expect("config should parse");
|
||||||
|
let resolved = resolve_model_list(&cfg, None, &Default::default());
|
||||||
|
let backend = |key: &str| resolved.get(key).expect(key).info.api_backend.clone();
|
||||||
|
assert_eq!(
|
||||||
|
backend("kigi-chat"),
|
||||||
|
ApiBackend::ChatCompletions,
|
||||||
|
"explicit default backend must not be overwritten by the sibling"
|
||||||
|
);
|
||||||
|
assert_eq!(
|
||||||
|
backend("kigi-plain"),
|
||||||
|
ApiBackend::Messages,
|
||||||
|
"unset backend still inherits"
|
||||||
|
);
|
||||||
|
assert_eq!(backend("kigi-messages"), ApiBackend::Messages);
|
||||||
|
}
|
||||||
/// Slug propagation should carry over api_backend but NOT agent_type.
|
/// Slug propagation should carry over api_backend but NOT agent_type.
|
||||||
#[test]
|
#[test]
|
||||||
fn slug_propagation_inherits_api_backend_but_not_agent_type() {
|
fn slug_propagation_inherits_api_backend_but_not_agent_type() {
|
||||||
|
|||||||
@@ -367,7 +367,7 @@ mod tests {
|
|||||||
let _url = EnvGuard::set(MODELS_DEV_URL_ENV, "http://127.0.0.1:1/api.json");
|
let _url = EnvGuard::set(MODELS_DEV_URL_ENV, "http://127.0.0.1:1/api.json");
|
||||||
let catalog = load_enrichment_catalog_at(&path);
|
let catalog = load_enrichment_catalog_at(&path);
|
||||||
assert!(
|
assert!(
|
||||||
kigi_models::enrichment::lookup(&catalog, "kimi-for-coding", "k3").is_some(),
|
kigi_models::enrichment::lookup(&catalog, "kimi-code-plan-cn", "k3").is_some(),
|
||||||
"bundled snapshot must back a total refresh failure"
|
"bundled snapshot must back a total refresh failure"
|
||||||
);
|
);
|
||||||
assert!(!path.exists(), "failed refresh must not write a cache");
|
assert!(!path.exists(), "failed refresh must not write a cache");
|
||||||
@@ -385,7 +385,7 @@ mod tests {
|
|||||||
let _url = EnvGuard::set(MODELS_DEV_URL_ENV, token);
|
let _url = EnvGuard::set(MODELS_DEV_URL_ENV, token);
|
||||||
assert!(refresh_url().is_none(), "token {token:?} must disable");
|
assert!(refresh_url().is_none(), "token {token:?} must disable");
|
||||||
let catalog = load_enrichment_catalog_at(&path);
|
let catalog = load_enrichment_catalog_at(&path);
|
||||||
assert!(kigi_models::enrichment::lookup(&catalog, "kimi-for-coding", "k3").is_some());
|
assert!(kigi_models::enrichment::lookup(&catalog, "kimi-code-plan-cn", "k3").is_some());
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -12,8 +12,7 @@ use std::sync::Arc;
|
|||||||
use serde::Serialize;
|
use serde::Serialize;
|
||||||
|
|
||||||
/// Where non-subscription users (no OAuth session) submit feedback instead.
|
/// Where non-subscription users (no OAuth session) submit feedback instead.
|
||||||
pub const FEEDBACK_ISSUES_URL: &str =
|
pub const FEEDBACK_ISSUES_URL: &str = "https://github.com/ZacharyZhang-NY/Kigi-CLI/issues";
|
||||||
"https://github.com/ZacharyZhang-NY/Kigi-CLI/issues";
|
|
||||||
|
|
||||||
/// HTTP error from the feedback endpoint with a preserved status code, so
|
/// HTTP error from the feedback endpoint with a preserved status code, so
|
||||||
/// callers can distinguish auth failures (401) without string matching.
|
/// callers can distinguish auth failures (401) without string matching.
|
||||||
|
|||||||
@@ -210,9 +210,9 @@ pub(crate) async fn apply(
|
|||||||
auto_compact_threshold_percent: new_threshold,
|
auto_compact_threshold_percent: new_threshold,
|
||||||
responds_to: tx,
|
responds_to: tx,
|
||||||
});
|
});
|
||||||
let updated_model = rx
|
let (updated_model, context_window) = rx
|
||||||
.await
|
.await
|
||||||
.map_err(|_| acp::Error::internal_error().data("failed to set session model"))?;
|
.map_err(|_| acp::Error::internal_error().data("failed to set session model"))??;
|
||||||
if let Some(handle) = agent.sessions.borrow_mut().get_mut(&session_id) {
|
if let Some(handle) = agent.sessions.borrow_mut().get_mut(&session_id) {
|
||||||
handle.model_id = model_id.clone();
|
handle.model_id = model_id.clone();
|
||||||
handle.reasoning_effort = applied_effort;
|
handle.reasoning_effort = applied_effort;
|
||||||
@@ -224,6 +224,7 @@ pub(crate) async fn apply(
|
|||||||
&session_id,
|
&session_id,
|
||||||
model_id.0.as_ref(),
|
model_id.0.as_ref(),
|
||||||
applied_effort.map(|eff| eff.to_string()),
|
applied_effort.map(|eff| eff.to_string()),
|
||||||
|
context_window.get(),
|
||||||
);
|
);
|
||||||
if agent.cfg.borrow().mode != config::AgentMode::Leader {
|
if agent.cfg.borrow().mode != config::AgentMode::Leader {
|
||||||
agent.models_manager.set_current_model_id(model_id);
|
agent.models_manager.set_current_model_id(model_id);
|
||||||
@@ -232,9 +233,12 @@ pub(crate) async fn apply(
|
|||||||
.set_current_reasoning_effort(applied_effort);
|
.set_current_reasoning_effort(applied_effort);
|
||||||
}
|
}
|
||||||
Ok(acp::SetSessionModelResponse::new().meta(
|
Ok(acp::SetSessionModelResponse::new().meta(
|
||||||
serde_json::json!({ "model" : updated_model, })
|
serde_json::json!({
|
||||||
.as_object()
|
"model": updated_model,
|
||||||
.cloned(),
|
"totalContextTokens": context_window.get(),
|
||||||
|
})
|
||||||
|
.as_object()
|
||||||
|
.cloned(),
|
||||||
))
|
))
|
||||||
}
|
}
|
||||||
/// Broadcast a `ModelChanged` to every client subscribed to this session so
|
/// Broadcast a `ModelChanged` to every client subscribed to this session so
|
||||||
@@ -245,12 +249,14 @@ fn broadcast_model_changed(
|
|||||||
session_id: &acp::SessionId,
|
session_id: &acp::SessionId,
|
||||||
model_id: &str,
|
model_id: &str,
|
||||||
reasoning_effort: Option<String>,
|
reasoning_effort: Option<String>,
|
||||||
|
context_window: u64,
|
||||||
) {
|
) {
|
||||||
let notification = crate::extensions::notification::SessionNotification {
|
let notification = crate::extensions::notification::SessionNotification {
|
||||||
session_id: session_id.clone(),
|
session_id: session_id.clone(),
|
||||||
update: crate::extensions::notification::SessionUpdate::ModelChanged {
|
update: crate::extensions::notification::SessionUpdate::ModelChanged {
|
||||||
model_id: model_id.to_owned(),
|
model_id: model_id.to_owned(),
|
||||||
reasoning_effort,
|
reasoning_effort,
|
||||||
|
context_window: Some(context_window),
|
||||||
},
|
},
|
||||||
meta: None,
|
meta: None,
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -1473,7 +1473,7 @@ mod tests {
|
|||||||
|
|
||||||
/// openai-codex fetch: the catalog is HARDCODED, so the fetch path
|
/// openai-codex fetch: the catalog is HARDCODED, so the fetch path
|
||||||
/// short-circuits BEFORE any HTTP — there is NO mock `/models` server, yet
|
/// short-circuits BEFORE any HTTP — there is NO mock `/models` server, yet
|
||||||
/// the fetch returns exactly the 4 compiled-in models keyed
|
/// the fetch returns exactly the 7 compiled-in models keyed
|
||||||
/// `openai-codex/<slug>` on the Responses backend, ctx 272000, each exposing
|
/// `openai-codex/<slug>` on the Responses backend, ctx 272000, each exposing
|
||||||
/// its exact reasoning efforts (incl. the codex-only `xhigh`/`max`).
|
/// its exact reasoning efforts (incl. the codex-only `xhigh`/`max`).
|
||||||
/// A BOGUS base URL confirms no live `/models` request is attempted (it would
|
/// A BOGUS base URL confirms no live `/models` request is attempted (it would
|
||||||
@@ -1510,20 +1510,18 @@ mod tests {
|
|||||||
.map(|m| m.id.as_deref().unwrap_or_default())
|
.map(|m| m.id.as_deref().unwrap_or_default())
|
||||||
.collect::<Vec<_>>(),
|
.collect::<Vec<_>>(),
|
||||||
vec![
|
vec![
|
||||||
|
"openai-codex/gpt-6-astra",
|
||||||
|
"openai-codex/gpt-6-sol",
|
||||||
|
"openai-codex/gpt-6-luna",
|
||||||
"openai-codex/gpt-5.6-sol",
|
"openai-codex/gpt-5.6-sol",
|
||||||
"openai-codex/gpt-5.6-terra",
|
"openai-codex/gpt-5.6-terra",
|
||||||
"openai-codex/gpt-5.6-luna",
|
"openai-codex/gpt-5.6-luna",
|
||||||
"openai-codex/gpt-5.5",
|
"openai-codex/gpt-5.5",
|
||||||
],
|
],
|
||||||
"exactly the 4 hardcoded models, keyed openai-codex/<slug>"
|
"exactly the 7 hardcoded models, keyed openai-codex/<slug>"
|
||||||
);
|
);
|
||||||
// Excluded models never appear.
|
// Excluded models never appear.
|
||||||
for absent in [
|
for absent in ["openai-codex/gpt-reserve", "openai-codex/codex-auto-review"] {
|
||||||
"openai-codex/gpt-5.3-codex-spark",
|
|
||||||
"openai-codex/gpt-5.4",
|
|
||||||
"openai-codex/gpt-5.4-mini",
|
|
||||||
"openai-codex/codex-auto-review",
|
|
||||||
] {
|
|
||||||
assert!(
|
assert!(
|
||||||
!result
|
!result
|
||||||
.models
|
.models
|
||||||
@@ -1532,7 +1530,14 @@ mod tests {
|
|||||||
"{absent} must be absent from the hardcoded catalog"
|
"{absent} must be absent from the hardcoded catalog"
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
let sol = &result.models[0];
|
let astra = &result.models[0];
|
||||||
|
assert_eq!(astra.name.as_deref(), Some("GPT-6-Astra"));
|
||||||
|
assert_eq!(astra.context_window.get(), 272_000);
|
||||||
|
let sol = result
|
||||||
|
.models
|
||||||
|
.iter()
|
||||||
|
.find(|m| m.id.as_deref() == Some("openai-codex/gpt-5.6-sol"))
|
||||||
|
.unwrap();
|
||||||
assert_eq!(
|
assert_eq!(
|
||||||
sol.api_backend,
|
sol.api_backend,
|
||||||
crate::sampling::ApiBackend::Responses,
|
crate::sampling::ApiBackend::Responses,
|
||||||
|
|||||||
@@ -1365,7 +1365,8 @@ impl MvpAgent {
|
|||||||
/// `FlushAndAck` on the persistence actor — a true sync barrier that only
|
/// `FlushAndAck` on the persistence actor — a true sync barrier that only
|
||||||
/// resolves after all queued writes (chat messages, updates) hit disk.
|
/// resolves after all queued writes (chat messages, updates) hit disk.
|
||||||
///
|
///
|
||||||
/// Returns `Ok(())` on success, `Err(reason)` on timeout or channel failure.
|
/// Returns `Ok(())` once the writes are on disk, `Err(reason)` on a failed
|
||||||
|
/// flush, timeout or channel failure.
|
||||||
pub(crate) async fn flush_session(
|
pub(crate) async fn flush_session(
|
||||||
&self,
|
&self,
|
||||||
session_id: &acp::SessionId,
|
session_id: &acp::SessionId,
|
||||||
@@ -1384,7 +1385,11 @@ impl MvpAgent {
|
|||||||
return Err("send failed");
|
return Err("send failed");
|
||||||
}
|
}
|
||||||
match tokio::time::timeout(std::time::Duration::from_secs(5), rx).await {
|
match tokio::time::timeout(std::time::Duration::from_secs(5), rx).await {
|
||||||
Ok(Ok(_)) => Ok(()),
|
Ok(Ok(Ok(()))) => Ok(()),
|
||||||
|
Ok(Ok(Err(error))) => {
|
||||||
|
tracing::error!(session_id = %session_id.0, %error, "persistence flush failed");
|
||||||
|
Err("persistence flush failed")
|
||||||
|
}
|
||||||
Ok(Err(_)) => Err("channel closed"),
|
Ok(Err(_)) => Err("channel closed"),
|
||||||
Err(_) => Err("timeout"),
|
Err(_) => Err("timeout"),
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -27,7 +27,7 @@ async fn subagent_spawn_context_inherits_parent_permission_handle() {
|
|||||||
kigi_workspace::permission::spawn_permission_manager(
|
kigi_workspace::permission::spawn_permission_manager(
|
||||||
sid.clone(),
|
sid.clone(),
|
||||||
gateway,
|
gateway,
|
||||||
cwd,
|
cwd.clone(),
|
||||||
kigi_workspace::permission::types::ClientType::Generic,
|
kigi_workspace::permission::types::ClientType::Generic,
|
||||||
Some(PermissionConfig::new(vec![PermissionRule {
|
Some(PermissionConfig::new(vec![PermissionRule {
|
||||||
action: RuleAction::Deny,
|
action: RuleAction::Deny,
|
||||||
@@ -64,6 +64,8 @@ async fn subagent_spawn_context_inherits_parent_permission_handle() {
|
|||||||
Some("child-session".to_owned()),
|
Some("child-session".to_owned()),
|
||||||
Some("general-purpose".to_owned()),
|
Some("general-purpose".to_owned()),
|
||||||
Some("permission inheritance regression".to_owned()),
|
Some("permission inheritance regression".to_owned()),
|
||||||
|
cwd.clone(),
|
||||||
|
None,
|
||||||
)
|
)
|
||||||
.await;
|
.await;
|
||||||
assert!(
|
assert!(
|
||||||
|
|||||||
@@ -19,6 +19,99 @@ use kigi_tools::implementations::kigi::task::types::*;
|
|||||||
use kigi_workspace::file_system::AsyncFileSystem;
|
use kigi_workspace::file_system::AsyncFileSystem;
|
||||||
use kigi_hunk_tracker::HunkTrackerHandle;
|
use kigi_hunk_tracker::HunkTrackerHandle;
|
||||||
use super::*;
|
use super::*;
|
||||||
|
|
||||||
|
/// Bounds each parent-side await in the child completion path so a starved parent `cmd_rx` cannot park a completed child forever.
|
||||||
|
pub(super) const PARENT_ACK_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(30);
|
||||||
|
/// Bounds reads of the child's own actors, which freeze with a tool that blocks the child thread; teardown must still reach `Shutdown`.
|
||||||
|
pub(super) const CHILD_ACTOR_ACK_TIMEOUT: std::time::Duration =
|
||||||
|
std::time::Duration::from_secs(10);
|
||||||
|
|
||||||
|
/// One bounded child-actor query, degrading to `fallback` when the actor never answers.
|
||||||
|
pub(super) async fn child_actor_query<T>(
|
||||||
|
what: &'static str,
|
||||||
|
query: impl std::future::Future<Output = T>,
|
||||||
|
fallback: T,
|
||||||
|
) -> T {
|
||||||
|
match tokio::time::timeout(CHILD_ACTOR_ACK_TIMEOUT, query).await {
|
||||||
|
Ok(value) => value,
|
||||||
|
Err(_) => {
|
||||||
|
tracing::warn!(query = what, "child actor did not answer in time; using fallback");
|
||||||
|
fallback
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Bounds the post-Shutdown worktree snapshot (a `git add` behind a stuck clean filter must not park completion).
|
||||||
|
const WORKTREE_SNAPSHOT_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(120);
|
||||||
|
|
||||||
|
/// Snapshot the child worktree to `ref_name`, persist the ref, then remove the worktree; returns `(snapshot_ref, removed)`.
|
||||||
|
async fn dispose_subagent_worktree(
|
||||||
|
worktree: &Path,
|
||||||
|
source_repo: &Path,
|
||||||
|
ref_name: &str,
|
||||||
|
meta_dir: &Path,
|
||||||
|
final_status: &str,
|
||||||
|
subagent_id: &str,
|
||||||
|
) -> (Option<String>, bool) {
|
||||||
|
let snapshot = tokio::time::timeout(
|
||||||
|
WORKTREE_SNAPSHOT_TIMEOUT,
|
||||||
|
crate::session::worktree::snapshot_subagent_worktree(worktree, source_repo, ref_name),
|
||||||
|
)
|
||||||
|
.await;
|
||||||
|
let snapshot_ref = match snapshot {
|
||||||
|
Ok(Ok(snapshot_ref)) => snapshot_ref,
|
||||||
|
Ok(Err(e)) => {
|
||||||
|
tracing::warn!(
|
||||||
|
subagent_id = % subagent_id, worktree_path = % worktree.display(), error = % e,
|
||||||
|
"Failed to snapshot subagent worktree; preserving for review"
|
||||||
|
);
|
||||||
|
return (None, false);
|
||||||
|
}
|
||||||
|
Err(_) => {
|
||||||
|
tracing::warn!(
|
||||||
|
subagent_id = % subagent_id, worktree_path = % worktree.display(),
|
||||||
|
"worktree snapshot did not finish in time; preserving worktree for resume"
|
||||||
|
);
|
||||||
|
return (None, false);
|
||||||
|
}
|
||||||
|
};
|
||||||
|
if !update_subagent_meta_snapshot_ref(meta_dir, &snapshot_ref, final_status) {
|
||||||
|
tracing::warn!(
|
||||||
|
subagent_id = % subagent_id, worktree_path = % worktree.display(),
|
||||||
|
"snapshot_ref not persisted; preserving worktree for resume"
|
||||||
|
);
|
||||||
|
return (None, false);
|
||||||
|
}
|
||||||
|
// Removal is awaited in full: a detached deletion could race a resume that rehydrates into this path.
|
||||||
|
match crate::session::worktree::remove_subagent_worktree(worktree).await {
|
||||||
|
Ok(()) => {
|
||||||
|
tracing::info!(
|
||||||
|
subagent_id = % subagent_id, worktree_path = % worktree.display(),
|
||||||
|
"snapshotted and removed subagent worktree"
|
||||||
|
);
|
||||||
|
(Some(snapshot_ref), true)
|
||||||
|
}
|
||||||
|
Err(e) => {
|
||||||
|
tracing::warn!(
|
||||||
|
subagent_id = % subagent_id, worktree_path = % worktree.display(), error = % e,
|
||||||
|
"snapshotted subagent worktree but removal failed; ref persisted for resume"
|
||||||
|
);
|
||||||
|
(Some(snapshot_ref), false)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Await a parent ack for at most `PARENT_ACK_TIMEOUT`; `false` when it never answers or drops the sender.
|
||||||
|
pub(super) async fn parent_ack(what: &'static str, ack: oneshot::Receiver<()>) -> bool {
|
||||||
|
match tokio::time::timeout(PARENT_ACK_TIMEOUT, ack).await {
|
||||||
|
Ok(Ok(())) => true,
|
||||||
|
Ok(Err(_)) => false,
|
||||||
|
Err(_) => {
|
||||||
|
tracing::warn!(ack = what, "parent did not ack in time; proceeding to teardown");
|
||||||
|
false
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
pub(super) fn task_model_override_error(
|
pub(super) fn task_model_override_error(
|
||||||
requested: Option<&str>,
|
requested: Option<&str>,
|
||||||
provenance: ModelOverrideProvenance,
|
provenance: ModelOverrideProvenance,
|
||||||
@@ -895,13 +988,22 @@ pub(crate) async fn handle_subagent_request(
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
let agent_mcp_servers: Vec<_> = if is_plugin_agent {
|
let agent_mcp_servers: Vec<_> = if definition.mcp_servers.is_empty() {
|
||||||
if !definition.mcp_servers.is_empty() {
|
vec![]
|
||||||
tracing::warn!(
|
} else if is_plugin_agent {
|
||||||
agent = % definition.name, plugin = ? definition.plugin_name,
|
tracing::warn!(
|
||||||
"ignoring mcpServers on plugin agent (not supported for security)"
|
agent = % definition.name, plugin = ? definition.plugin_name,
|
||||||
);
|
"ignoring mcpServers on plugin agent (not supported for security)"
|
||||||
}
|
);
|
||||||
|
vec![]
|
||||||
|
} else if !crate::agent::folder_trust::agent_inline_hooks_allowed(definition.scope, || {
|
||||||
|
crate::agent::folder_trust::project_scope_allowed(&ctx.parent_cwd)
|
||||||
|
}) {
|
||||||
|
// An untrusted repo's inline stdio MCP command would run like an inline hook.
|
||||||
|
tracing::warn!(
|
||||||
|
agent = % definition.name,
|
||||||
|
"ignoring mcpServers on untrusted project agent (folder not trusted; re-run with --trust)"
|
||||||
|
);
|
||||||
vec![]
|
vec![]
|
||||||
} else {
|
} else {
|
||||||
definition
|
definition
|
||||||
@@ -1333,7 +1435,12 @@ pub(crate) async fn handle_subagent_request(
|
|||||||
let duration_ms = start.elapsed().as_millis() as u64;
|
let duration_ms = start.elapsed().as_millis() as u64;
|
||||||
let mut result = match wait_outcome {
|
let mut result = match wait_outcome {
|
||||||
SubagentWaitOutcome::Cancelled => {
|
SubagentWaitOutcome::Cancelled => {
|
||||||
let (tool_calls, turns) = signals_snapshot_counts(&child_handle).await;
|
let (tool_calls, turns) = child_actor_query(
|
||||||
|
"signals_snapshot_counts",
|
||||||
|
signals_snapshot_counts(&child_handle),
|
||||||
|
(0, 0),
|
||||||
|
)
|
||||||
|
.await;
|
||||||
SubagentResult {
|
SubagentResult {
|
||||||
success: false,
|
success: false,
|
||||||
cancelled: true,
|
cancelled: true,
|
||||||
@@ -1360,14 +1467,28 @@ pub(crate) async fn handle_subagent_request(
|
|||||||
},
|
},
|
||||||
),
|
),
|
||||||
) => (snapshot.current.tool_call_count, snapshot.current.turn_count),
|
) => (snapshot.current.tool_call_count, snapshot.current.turn_count),
|
||||||
_ => signals_snapshot_counts(&child_handle).await,
|
_ => {
|
||||||
|
child_actor_query(
|
||||||
|
"signals_snapshot_counts",
|
||||||
|
signals_snapshot_counts(&child_handle),
|
||||||
|
(0, 0),
|
||||||
|
)
|
||||||
|
.await
|
||||||
|
}
|
||||||
};
|
};
|
||||||
let final_text = child_handle
|
let final_text = child_actor_query(
|
||||||
.chat_state_handle
|
"get_last_assistant_text",
|
||||||
.get_last_assistant_text()
|
child_handle.chat_state_handle.get_last_assistant_text(),
|
||||||
.await
|
None,
|
||||||
.unwrap_or_default();
|
)
|
||||||
let result_tokens = child_handle.chat_state_handle.get_total_tokens().await;
|
.await
|
||||||
|
.unwrap_or_default();
|
||||||
|
let result_tokens = child_actor_query(
|
||||||
|
"get_total_tokens",
|
||||||
|
child_handle.chat_state_handle.get_total_tokens(),
|
||||||
|
0,
|
||||||
|
)
|
||||||
|
.await;
|
||||||
match *turn_result {
|
match *turn_result {
|
||||||
Ok(
|
Ok(
|
||||||
Ok(
|
Ok(
|
||||||
@@ -1527,14 +1648,21 @@ pub(crate) async fn handle_subagent_request(
|
|||||||
let final_status = result.status().to_string();
|
let final_status = result.status().to_string();
|
||||||
let snapshot_dispose_enabled = ctx.resolve_subagent_worktree_snapshot_enabled();
|
let snapshot_dispose_enabled = ctx.resolve_subagent_worktree_snapshot_enabled();
|
||||||
let telemetry_tokens = if result.tool_calls > 0 || result.success {
|
let telemetry_tokens = if result.tool_calls > 0 || result.success {
|
||||||
child_handle.chat_state_handle.get_total_tokens().await
|
child_actor_query(
|
||||||
|
"get_total_tokens",
|
||||||
|
child_handle.chat_state_handle.get_total_tokens(),
|
||||||
|
0,
|
||||||
|
)
|
||||||
|
.await
|
||||||
} else {
|
} else {
|
||||||
0
|
0
|
||||||
};
|
};
|
||||||
let (subagent_usage_by_model, subagent_usage_incomplete) = match child_handle
|
let (subagent_usage_by_model, subagent_usage_incomplete) = match child_actor_query(
|
||||||
.chat_state_handle
|
"try_get_session_usage",
|
||||||
.try_get_session_usage()
|
child_handle.chat_state_handle.try_get_session_usage(),
|
||||||
.await
|
Err(()),
|
||||||
|
)
|
||||||
|
.await
|
||||||
{
|
{
|
||||||
Ok(u) => (Some(u.by_model.into_iter().collect::<Vec<_>>()), u.incomplete),
|
Ok(u) => (Some(u.by_model.into_iter().collect::<Vec<_>>()), u.incomplete),
|
||||||
Err(()) => (None, true),
|
Err(()) => (None, true),
|
||||||
@@ -1553,7 +1681,7 @@ pub(crate) async fn handle_subagent_request(
|
|||||||
respond_to,
|
respond_to,
|
||||||
})
|
})
|
||||||
{
|
{
|
||||||
Ok(()) => ack.await.is_ok(),
|
Ok(()) => parent_ack("RecordSubagentUsage", ack).await,
|
||||||
Err(_) => false,
|
Err(_) => false,
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
@@ -1570,53 +1698,71 @@ pub(crate) async fn handle_subagent_request(
|
|||||||
.parent_prompt_id
|
.parent_prompt_id
|
||||||
.clone()
|
.clone()
|
||||||
.or_else(|| coordinator.borrow().parent_prompt_id_for(&request.id));
|
.or_else(|| coordinator.borrow().parent_prompt_id_for(&request.id));
|
||||||
if let Some(cmd_tx) = ctx.parent_cmd_tx.as_ref() {
|
// A slow parent may apply both the fold and this mark; both are idempotent.
|
||||||
|
let marked_by_parent = if let Some(cmd_tx) = ctx.parent_cmd_tx.as_ref() {
|
||||||
let (respond_to, ack) = tokio::sync::oneshot::channel();
|
let (respond_to, ack) = tokio::sync::oneshot::channel();
|
||||||
if cmd_tx
|
cmd_tx
|
||||||
.send(crate::session::commands::SessionCommand::MarkSubagentUsageNotApplied {
|
.send(crate::session::commands::SessionCommand::MarkSubagentUsageNotApplied {
|
||||||
parent_prompt_id: sticky_prompt,
|
parent_prompt_id: sticky_prompt.clone(),
|
||||||
respond_to,
|
respond_to,
|
||||||
})
|
})
|
||||||
.is_ok()
|
.is_ok()
|
||||||
{
|
&& parent_ack("MarkSubagentUsageNotApplied", ack).await
|
||||||
let _ = ack.await;
|
} else {
|
||||||
}
|
false
|
||||||
} else if let Some(ref pid) = sticky_prompt {
|
};
|
||||||
|
if !marked_by_parent && let Some(ref pid) = sticky_prompt {
|
||||||
coordinator.borrow_mut().mark_subagent_usage_not_applied(pid);
|
coordinator.borrow_mut().mark_subagent_usage_not_applied(pid);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
match (&ctx.parent_terminal_backend, &ctx.parent_notification_handle) {
|
match (&ctx.parent_terminal_backend, &ctx.parent_notification_handle) {
|
||||||
(Some(parent_tb), Some(parent_notif_handle)) => {
|
(Some(parent_tb), Some(parent_notif_handle)) => {
|
||||||
if !request.surface_completion {
|
if !request.surface_completion {
|
||||||
let reparented_task_ids: Vec<String> = parent_tb
|
match tokio::time::timeout(PARENT_ACK_TIMEOUT, parent_tb.list_tasks()).await {
|
||||||
.list_tasks()
|
Ok(tasks) => {
|
||||||
.await
|
let reparented_task_ids: Vec<String> = tasks
|
||||||
.into_iter()
|
.into_iter()
|
||||||
.filter(|t| {
|
.filter(|t| {
|
||||||
!t.completed
|
!t.completed
|
||||||
&& t.owner_session_id.as_deref()
|
&& t.owner_session_id.as_deref()
|
||||||
== Some(&*child_session_id.0)
|
== Some(&*child_session_id.0)
|
||||||
})
|
})
|
||||||
.map(|t| t.task_id)
|
.map(|t| t.task_id)
|
||||||
.collect();
|
.collect();
|
||||||
if !reparented_task_ids.is_empty()
|
if !reparented_task_ids.is_empty()
|
||||||
&& let Some(cmd_tx) = ctx.parent_cmd_tx.as_ref()
|
&& let Some(cmd_tx) = ctx.parent_cmd_tx.as_ref()
|
||||||
{
|
{
|
||||||
let _ = cmd_tx
|
let _ = cmd_tx.send(SessionCommand::RecordGoalTurnTaskIds {
|
||||||
.send(SessionCommand::RecordGoalTurnTaskIds {
|
task_ids: reparented_task_ids,
|
||||||
task_ids: reparented_task_ids,
|
});
|
||||||
});
|
}
|
||||||
|
}
|
||||||
|
Err(_) => tracing::warn!(
|
||||||
|
child_session_id = % child_session_id.0,
|
||||||
|
parent_session_id = % ctx.parent_session_id,
|
||||||
|
"list_tasks not answered in time; skipping goal-turn task-id recording"
|
||||||
|
),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
let parent_backend_weak = std::sync::Arc::downgrade(parent_tb);
|
let parent_backend_weak = std::sync::Arc::downgrade(parent_tb);
|
||||||
parent_tb
|
if tokio::time::timeout(
|
||||||
.reparent_notifications(
|
PARENT_ACK_TIMEOUT,
|
||||||
|
parent_tb.reparent_notifications(
|
||||||
&child_session_id.0,
|
&child_session_id.0,
|
||||||
&ctx.parent_session_id,
|
&ctx.parent_session_id,
|
||||||
parent_notif_handle.clone(),
|
parent_notif_handle.clone(),
|
||||||
parent_backend_weak,
|
parent_backend_weak,
|
||||||
)
|
),
|
||||||
.await;
|
)
|
||||||
|
.await
|
||||||
|
.is_err()
|
||||||
|
{
|
||||||
|
tracing::warn!(
|
||||||
|
child_session_id = % child_session_id.0,
|
||||||
|
parent_session_id = % ctx.parent_session_id,
|
||||||
|
"reparent_notifications not acked in time; proceeding to child shutdown"
|
||||||
|
);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
(Some(_), None) | (None, Some(_)) => {
|
(Some(_), None) | (None, Some(_)) => {
|
||||||
tracing::warn!(
|
tracing::warn!(
|
||||||
@@ -1637,55 +1783,17 @@ pub(crate) async fn handle_subagent_request(
|
|||||||
if snapshot_dispose_enabled {
|
if snapshot_dispose_enabled {
|
||||||
let ref_name = format!("refs/kigi/subagents/{}", request.id);
|
let ref_name = format!("refs/kigi/subagents/{}", request.id);
|
||||||
let source_repo = resolve_subagent_source_repo(&ctx);
|
let source_repo = resolve_subagent_source_repo(&ctx);
|
||||||
match crate::session::worktree::snapshot_subagent_worktree(
|
let (snapshot_ref, removed) = dispose_subagent_worktree(
|
||||||
wt_path,
|
wt_path,
|
||||||
&source_repo,
|
&source_repo,
|
||||||
&ref_name,
|
&ref_name,
|
||||||
)
|
&subagent_meta_dir,
|
||||||
.await
|
&final_status,
|
||||||
{
|
&request.id,
|
||||||
Ok(snapshot_ref) => {
|
)
|
||||||
let persisted = update_subagent_meta_snapshot_ref(
|
.await;
|
||||||
&subagent_meta_dir,
|
disposed_snapshot_ref = snapshot_ref;
|
||||||
&snapshot_ref,
|
worktree_removed = removed;
|
||||||
&final_status,
|
|
||||||
);
|
|
||||||
if persisted {
|
|
||||||
disposed_snapshot_ref = Some(snapshot_ref);
|
|
||||||
match crate::session::worktree::remove_subagent_worktree(wt_path)
|
|
||||||
.await
|
|
||||||
{
|
|
||||||
Ok(()) => {
|
|
||||||
worktree_removed = true;
|
|
||||||
tracing::info!(
|
|
||||||
subagent_id = % request.id, worktree_path = % wt_path
|
|
||||||
.display(), "snapshotted and removed subagent worktree"
|
|
||||||
);
|
|
||||||
}
|
|
||||||
Err(e) => {
|
|
||||||
tracing::warn!(
|
|
||||||
subagent_id = % request.id, worktree_path = % wt_path
|
|
||||||
.display(), error = % e,
|
|
||||||
"snapshotted subagent worktree but removal failed; ref persisted for resume"
|
|
||||||
)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
} else {
|
|
||||||
tracing::warn!(
|
|
||||||
subagent_id = % request.id, worktree_path = % wt_path
|
|
||||||
.display(),
|
|
||||||
"snapshot_ref not persisted; preserving worktree for resume"
|
|
||||||
);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
Err(e) => {
|
|
||||||
tracing::warn!(
|
|
||||||
subagent_id = % request.id, worktree_path = % wt_path.display(),
|
|
||||||
error = % e,
|
|
||||||
"Failed to snapshot subagent worktree; preserving for review"
|
|
||||||
);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
} else {
|
} else {
|
||||||
tracing::info!(
|
tracing::info!(
|
||||||
subagent_id = % request.id, worktree_path = % wt_path.display(),
|
subagent_id = % request.id, worktree_path = % wt_path.display(),
|
||||||
|
|||||||
@@ -3298,3 +3298,27 @@ fn spawn_test_parent_chat_state(model_slug: &str) -> kigi_chat_state::ChatStateH
|
|||||||
)
|
)
|
||||||
}
|
}
|
||||||
mod rest;
|
mod rest;
|
||||||
|
|
||||||
|
/// A blocked child actor must not park teardown: the read degrades to the fallback in bounded time.
|
||||||
|
#[tokio::test(start_paused = true)]
|
||||||
|
async fn child_actor_query_is_bounded_when_the_actor_never_answers() {
|
||||||
|
use super::handle_request::{CHILD_ACTOR_ACK_TIMEOUT, child_actor_query};
|
||||||
|
let tokens = tokio::time::timeout(
|
||||||
|
20 * CHILD_ACTOR_ACK_TIMEOUT,
|
||||||
|
child_actor_query("test_query", std::future::pending::<u64>(), 7),
|
||||||
|
)
|
||||||
|
.await
|
||||||
|
.expect("child-actor queries must complete in bounded time");
|
||||||
|
assert_eq!(tokens, 7, "a starved query must degrade to the fallback");
|
||||||
|
}
|
||||||
|
|
||||||
|
/// A parent that never services `cmd_rx` must not park a completed child.
|
||||||
|
#[tokio::test(start_paused = true)]
|
||||||
|
async fn parent_ack_is_bounded_when_the_parent_never_answers() {
|
||||||
|
use super::handle_request::{PARENT_ACK_TIMEOUT, parent_ack};
|
||||||
|
let (_never_answered, ack) = tokio::sync::oneshot::channel::<()>();
|
||||||
|
let acked = tokio::time::timeout(20 * PARENT_ACK_TIMEOUT, parent_ack("test_ack", ack))
|
||||||
|
.await
|
||||||
|
.expect("parent acks must complete in bounded time");
|
||||||
|
assert!(!acked, "an unanswered ack must report a miss");
|
||||||
|
}
|
||||||
@@ -638,6 +638,7 @@ fn write_import_marker(config_path: &Path) -> anyhow::Result<()> {
|
|||||||
if let Some(parent) = config_path.parent() {
|
if let Some(parent) = config_path.parent() {
|
||||||
std::fs::create_dir_all(parent)?;
|
std::fs::create_dir_all(parent)?;
|
||||||
}
|
}
|
||||||
|
let config_path = &crate::util::config::config_write_dest(config_path)?;
|
||||||
let tmp = config_path.with_extension("toml.tmp");
|
let tmp = config_path.with_extension("toml.tmp");
|
||||||
// Best-effort cleanup of the .tmp file if either write or rename fails so
|
// Best-effort cleanup of the .tmp file if either write or rename fails so
|
||||||
// a failed marker write doesn't leave a stale artefact next to the real
|
// a failed marker write doesn't leave a stale artefact next to the real
|
||||||
@@ -820,6 +821,7 @@ fn apply_items_to_config(config_path: &Path, items: &[ImportableItem]) -> anyhow
|
|||||||
|
|
||||||
if count > 0 {
|
if count > 0 {
|
||||||
let toml_str = toml::to_string_pretty(&root)?;
|
let toml_str = toml::to_string_pretty(&root)?;
|
||||||
|
let config_path = &crate::util::config::config_write_dest(config_path)?;
|
||||||
let tmp = config_path.with_extension("toml.tmp");
|
let tmp = config_path.with_extension("toml.tmp");
|
||||||
if let Some(parent) = config_path.parent() {
|
if let Some(parent) = config_path.parent() {
|
||||||
std::fs::create_dir_all(parent)?;
|
std::fs::create_dir_all(parent)?;
|
||||||
|
|||||||
@@ -1034,16 +1034,27 @@ pub fn apply_sandbox(
|
|||||||
.and_then(|p| dunce::canonicalize(p).ok())
|
.and_then(|p| dunce::canonicalize(p).ok())
|
||||||
.or_else(|| std::env::current_dir().ok())
|
.or_else(|| std::env::current_dir().ok())
|
||||||
.unwrap_or_else(|| std::path::PathBuf::from("."));
|
.unwrap_or_else(|| std::path::PathBuf::from("."));
|
||||||
|
if kigi_sandbox::restricts_home_writes(&sandbox_profile, &workspace) {
|
||||||
|
// The profile leaves ~/.kigi read-only outside its state dirs: mint
|
||||||
|
// what first use would otherwise write after enforcement.
|
||||||
|
if let Err(e) = crate::auth::device::device_id() {
|
||||||
|
tracing::warn!(error = %e, "sandbox: device id not created before enforcement");
|
||||||
|
}
|
||||||
|
kigi_tools::implementations::kigi::grep::ripgrep::rg_path();
|
||||||
|
crate::builtin::extract_bundled_files(&crate::util::kigi_home::kigi_home());
|
||||||
|
}
|
||||||
|
// The devbox `/data` write-deny is a bwrap mount; Landlock would grant the workspace under `/data`.
|
||||||
#[cfg(target_os = "linux")]
|
#[cfg(target_os = "linux")]
|
||||||
let requires_read_deny = kigi_sandbox::requires_read_deny(&sandbox_profile, &workspace);
|
let bwrap_required = kigi_sandbox::requires_read_deny(&sandbox_profile, &workspace)
|
||||||
|
|| kigi_sandbox::requires_data_write_deny(&sandbox_profile, &workspace);
|
||||||
#[cfg(target_os = "linux")]
|
#[cfg(target_os = "linux")]
|
||||||
{
|
{
|
||||||
let refuse_unprotected = |detail: &str| {
|
let refuse_unprotected = |detail: &str| {
|
||||||
eprintln!(
|
eprintln!(
|
||||||
"error: this sandbox could not enforce its read-deny set on Linux \
|
"error: this sandbox could not enforce its read-deny set or the devbox \
|
||||||
(bubblewrap missing/unusable, or a deny glob exceeded its expansion \
|
`/data` write-deny on Linux (bubblewrap missing/unusable, or a deny glob \
|
||||||
limit — see any message above). Install bubblewrap with \
|
exceeded its expansion limit — see any message above). Install bubblewrap \
|
||||||
`apt install -y bubblewrap` if needed. Refusing to start with denied \
|
with `apt install -y bubblewrap` if needed. Refusing to start with denied \
|
||||||
paths unprotected.{detail}"
|
paths unprotected.{detail}"
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
@@ -1051,7 +1062,7 @@ pub fn apply_sandbox(
|
|||||||
Some(mut cmd) => {
|
Some(mut cmd) => {
|
||||||
use std::os::unix::process::CommandExt;
|
use std::os::unix::process::CommandExt;
|
||||||
let err = cmd.exec();
|
let err = cmd.exec();
|
||||||
if requires_read_deny {
|
if bwrap_required {
|
||||||
refuse_unprotected(&format!(" (bwrap exec failed: {err})"));
|
refuse_unprotected(&format!(" (bwrap exec failed: {err})"));
|
||||||
std::process::exit(1);
|
std::process::exit(1);
|
||||||
}
|
}
|
||||||
@@ -1061,7 +1072,7 @@ pub fn apply_sandbox(
|
|||||||
Install bubblewrap: apt install -y bubblewrap"
|
Install bubblewrap: apt install -y bubblewrap"
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
None if requires_read_deny && !kigi_sandbox::is_inside_bwrap() => {
|
None if bwrap_required && !kigi_sandbox::is_inside_bwrap() => {
|
||||||
refuse_unprotected("");
|
refuse_unprotected("");
|
||||||
std::process::exit(1);
|
std::process::exit(1);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -37,9 +37,9 @@ async fn handle_compact(agent: &MvpAgent, args: &acp::ExtRequest) -> ExtResult {
|
|||||||
respond_to: tx,
|
respond_to: tx,
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
// The session's own ACP error goes through unchanged: a Debug wrapper would escape its detail.
|
||||||
rx.await
|
rx.await
|
||||||
.map_err(|_| acp::Error::internal_error().data("session failed to respond"))?
|
.map_err(|_| acp::Error::internal_error().data("session failed to respond"))??;
|
||||||
.map_err(|e| acp::Error::internal_error().data(format!("Internal error: {:?}", e)))?;
|
|
||||||
to_raw_response(&CompactConversationResponse {})
|
to_raw_response(&CompactConversationResponse {})
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -691,6 +691,11 @@ pub enum SessionUpdate {
|
|||||||
/// does not support reasoning effort or no effort override was applied.
|
/// does not support reasoning effort or no effort override was applied.
|
||||||
#[serde(default, skip_serializing_if = "Option::is_none")]
|
#[serde(default, skip_serializing_if = "Option::is_none")]
|
||||||
reasoning_effort: Option<String>,
|
reasoning_effort: Option<String>,
|
||||||
|
/// The session's effective context window after the switch, so a
|
||||||
|
/// follower repaints its header without waiting for the next turn.
|
||||||
|
/// `None` from an agent that predates the field.
|
||||||
|
#[serde(default, skip_serializing_if = "Option::is_none")]
|
||||||
|
context_window: Option<u64>,
|
||||||
},
|
},
|
||||||
/// Streaming chunk of a tool call's arguments.
|
/// Streaming chunk of a tool call's arguments.
|
||||||
///
|
///
|
||||||
@@ -1970,15 +1975,18 @@ mod tests {
|
|||||||
let with_effort = SessionUpdate::ModelChanged {
|
let with_effort = SessionUpdate::ModelChanged {
|
||||||
model_id: "kigi-4".into(),
|
model_id: "kigi-4".into(),
|
||||||
reasoning_effort: Some("high".into()),
|
reasoning_effort: Some("high".into()),
|
||||||
|
context_window: Some(262_144),
|
||||||
};
|
};
|
||||||
let json = serde_json::to_value(&with_effort).unwrap();
|
let json = serde_json::to_value(&with_effort).unwrap();
|
||||||
assert_eq!(json["sessionUpdate"], "model_changed");
|
assert_eq!(json["sessionUpdate"], "model_changed");
|
||||||
assert_eq!(json["model_id"], "kigi-4");
|
assert_eq!(json["model_id"], "kigi-4");
|
||||||
assert_eq!(json["reasoning_effort"], "high");
|
assert_eq!(json["reasoning_effort"], "high");
|
||||||
|
assert_eq!(json["context_window"], 262_144);
|
||||||
|
|
||||||
let without_effort = SessionUpdate::ModelChanged {
|
let without_effort = SessionUpdate::ModelChanged {
|
||||||
model_id: "kigi-3".into(),
|
model_id: "kigi-3".into(),
|
||||||
reasoning_effort: None,
|
reasoning_effort: None,
|
||||||
|
context_window: None,
|
||||||
};
|
};
|
||||||
let json = serde_json::to_value(&without_effort).unwrap();
|
let json = serde_json::to_value(&without_effort).unwrap();
|
||||||
assert_eq!(json["sessionUpdate"], "model_changed");
|
assert_eq!(json["sessionUpdate"], "model_changed");
|
||||||
@@ -1988,6 +1996,7 @@ mod tests {
|
|||||||
"reasoning_effort: None must be skipped on the wire so old pagers \
|
"reasoning_effort: None must be skipped on the wire so old pagers \
|
||||||
and third-party ACP clients see a smaller, no-extra-keys payload"
|
and third-party ACP clients see a smaller, no-extra-keys payload"
|
||||||
);
|
);
|
||||||
|
assert!(json.get("context_window").is_none());
|
||||||
}
|
}
|
||||||
|
|
||||||
/// `ModelChanged` round-trips through JSON: a follower client deserializes
|
/// `ModelChanged` round-trips through JSON: a follower client deserializes
|
||||||
@@ -2000,6 +2009,7 @@ mod tests {
|
|||||||
let original = SessionUpdate::ModelChanged {
|
let original = SessionUpdate::ModelChanged {
|
||||||
model_id: "kigi-4".into(),
|
model_id: "kigi-4".into(),
|
||||||
reasoning_effort: Some("medium".into()),
|
reasoning_effort: Some("medium".into()),
|
||||||
|
context_window: Some(1_000_000),
|
||||||
};
|
};
|
||||||
let json_str = serde_json::to_string(&original).unwrap();
|
let json_str = serde_json::to_string(&original).unwrap();
|
||||||
let parsed: SessionUpdate = serde_json::from_str(&json_str).unwrap();
|
let parsed: SessionUpdate = serde_json::from_str(&json_str).unwrap();
|
||||||
@@ -2021,6 +2031,7 @@ mod tests {
|
|||||||
update: SessionUpdate::ModelChanged {
|
update: SessionUpdate::ModelChanged {
|
||||||
model_id: "kigi-4".into(),
|
model_id: "kigi-4".into(),
|
||||||
reasoning_effort: None,
|
reasoning_effort: None,
|
||||||
|
context_window: None,
|
||||||
},
|
},
|
||||||
meta: None,
|
meta: None,
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -513,6 +513,7 @@ pub fn apply_at(plan: &KimiImportPlan, kigi_home: &Path) -> anyhow::Result<KimiA
|
|||||||
if applied.total_added() > 0 {
|
if applied.total_added() > 0 {
|
||||||
// Atomic write: tmp + rename (same pattern as save_mcp_server_config).
|
// Atomic write: tmp + rename (same pattern as save_mcp_server_config).
|
||||||
let toml_str = toml::to_string_pretty(&root)?;
|
let toml_str = toml::to_string_pretty(&root)?;
|
||||||
|
let config_path = crate::util::config::config_write_dest(&config_path)?;
|
||||||
let tmp = config_path.with_extension("toml.tmp");
|
let tmp = config_path.with_extension("toml.tmp");
|
||||||
if let Err(e) = std::fs::write(&tmp, &toml_str) {
|
if let Err(e) = std::fs::write(&tmp, &toml_str) {
|
||||||
let _ = std::fs::remove_file(&tmp);
|
let _ = std::fs::remove_file(&tmp);
|
||||||
|
|||||||
@@ -52,10 +52,16 @@ pub fn default_lock_path_in(root: &Path) -> PathBuf {
|
|||||||
root.join("leader.lock")
|
root.join("leader.lock")
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Runtime files live under `~/.kigi/run`: the one home subtree a strict
|
||||||
|
/// sandbox leaves writable for them.
|
||||||
|
pub(super) fn runtime_root() -> PathBuf {
|
||||||
|
kigi_home().join("run")
|
||||||
|
}
|
||||||
|
|
||||||
/// Effective leader lock path: the [`LEADER_SOCKET_ENV`] override's sibling
|
/// Effective leader lock path: the [`LEADER_SOCKET_ENV`] override's sibling
|
||||||
/// `.lock` when set, else the default under kigi home.
|
/// `.lock` when set, else the default under `~/.kigi/run`.
|
||||||
pub fn default_lock_path() -> PathBuf {
|
pub fn default_lock_path() -> PathBuf {
|
||||||
resolve_lock_path(leader_socket_override(), &kigi_home())
|
resolve_lock_path(leader_socket_override(), &runtime_root())
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn default_socket_path_in(root: &Path) -> PathBuf {
|
pub fn default_socket_path_in(root: &Path) -> PathBuf {
|
||||||
@@ -63,9 +69,9 @@ pub fn default_socket_path_in(root: &Path) -> PathBuf {
|
|||||||
}
|
}
|
||||||
|
|
||||||
/// Effective leader socket path: the [`LEADER_SOCKET_ENV`] override when set,
|
/// Effective leader socket path: the [`LEADER_SOCKET_ENV`] override when set,
|
||||||
/// else the default under kigi home.
|
/// else the default under `~/.kigi/run`.
|
||||||
pub fn default_socket_path() -> PathBuf {
|
pub fn default_socket_path() -> PathBuf {
|
||||||
resolve_socket_path(leader_socket_override(), &kigi_home())
|
resolve_socket_path(leader_socket_override(), &runtime_root())
|
||||||
}
|
}
|
||||||
|
|
||||||
/// The instance suffix encoded in a lock/socket file-name pair
|
/// The instance suffix encoded in a lock/socket file-name pair
|
||||||
@@ -145,6 +151,9 @@ impl LeaderLock {
|
|||||||
}
|
}
|
||||||
|
|
||||||
fn open_lock_file(&self) -> Result<File, LockError> {
|
fn open_lock_file(&self) -> Result<File, LockError> {
|
||||||
|
if let Some(parent) = self.lock_path.parent() {
|
||||||
|
std::fs::create_dir_all(parent)?;
|
||||||
|
}
|
||||||
Ok(OpenOptions::new()
|
Ok(OpenOptions::new()
|
||||||
.read(true)
|
.read(true)
|
||||||
.write(true)
|
.write(true)
|
||||||
|
|||||||
@@ -23,7 +23,7 @@
|
|||||||
//! │ │ - Tracks session ownership for routing ││
|
//! │ │ - Tracks session ownership for routing ││
|
||||||
//! │ └────────────────────────┬────────────────────────────────┘│
|
//! │ └────────────────────────┬────────────────────────────────┘│
|
||||||
//! └───────────────────────────┼──────────────────────────────────┘
|
//! └───────────────────────────┼──────────────────────────────────┘
|
||||||
//! │ IPC (Unix socket at ~/.kigi/leader.sock)
|
//! │ IPC (Unix socket at ~/.kigi/run/leader.sock)
|
||||||
//! ┌───────────────────┼───────────────────┐
|
//! ┌───────────────────┼───────────────────┐
|
||||||
//! ▼ ▼ ▼
|
//! ▼ ▼ ▼
|
||||||
//! ┌───────────────┐ ┌───────────────┐ ┌───────────────┐
|
//! ┌───────────────┐ ┌───────────────┐ ┌───────────────┐
|
||||||
@@ -481,7 +481,10 @@ async fn discover_leaders_in(root: &Path) -> Vec<LeaderDescriptor> {
|
|||||||
entries
|
entries
|
||||||
}
|
}
|
||||||
pub async fn discover_leaders() -> Vec<LeaderDescriptor> {
|
pub async fn discover_leaders() -> Vec<LeaderDescriptor> {
|
||||||
discover_leaders_in(&crate::util::kigi_home::kigi_home()).await
|
let mut entries = discover_leaders_in(&lock::runtime_root()).await;
|
||||||
|
// Pre-0.1.15 leaders and socket overrides keep their files at the home root.
|
||||||
|
entries.extend(discover_leaders_in(&crate::util::kigi_home::kigi_home()).await);
|
||||||
|
entries
|
||||||
}
|
}
|
||||||
/// (pid, leader_binary_version) of socket-verified (Reachable) leaders; a
|
/// (pid, leader_binary_version) of socket-verified (Reachable) leaders; a
|
||||||
/// stale-lock-only descriptor is skipped (its `pid_from_lock` may be recycled).
|
/// stale-lock-only descriptor is skipped (its `pid_from_lock` may be recycled).
|
||||||
@@ -610,13 +613,28 @@ fn resolve_matching_descriptors(
|
|||||||
fn resolve_target_from_descriptors(
|
fn resolve_target_from_descriptors(
|
||||||
target: LeaderTarget,
|
target: LeaderTarget,
|
||||||
leaders: Vec<LeaderDescriptor>,
|
leaders: Vec<LeaderDescriptor>,
|
||||||
|
current_default_socket: &Path,
|
||||||
) -> Result<LeaderTargetSelection, LeaderTargetError> {
|
) -> Result<LeaderTargetSelection, LeaderTargetError> {
|
||||||
match target {
|
match target {
|
||||||
LeaderTarget::Default => {
|
LeaderTarget::Default => {
|
||||||
let matching: Vec<_> = leaders
|
let defaults: Vec<_> = leaders
|
||||||
.into_iter()
|
.into_iter()
|
||||||
.filter(|descriptor| descriptor.is_default)
|
.filter(|descriptor| descriptor.is_default)
|
||||||
.collect();
|
.collect();
|
||||||
|
// An upgrade can leave a pre-0.1.15 default at the home root; the
|
||||||
|
// current default socket wins while it exists.
|
||||||
|
let current: Vec<_> = defaults
|
||||||
|
.iter()
|
||||||
|
.filter(|descriptor| {
|
||||||
|
descriptor.socket_path.as_deref() == Some(current_default_socket)
|
||||||
|
})
|
||||||
|
.cloned()
|
||||||
|
.collect();
|
||||||
|
let matching = if current.is_empty() {
|
||||||
|
defaults
|
||||||
|
} else {
|
||||||
|
current
|
||||||
|
};
|
||||||
resolve_matching_descriptors("default", matching)
|
resolve_matching_descriptors("default", matching)
|
||||||
}
|
}
|
||||||
LeaderTarget::Socket(socket_path) => {
|
LeaderTarget::Socket(socket_path) => {
|
||||||
@@ -685,7 +703,7 @@ pub async fn resolve_leader_target(
|
|||||||
target: LeaderTarget,
|
target: LeaderTarget,
|
||||||
) -> Result<LeaderTargetSelection, LeaderTargetError> {
|
) -> Result<LeaderTargetSelection, LeaderTargetError> {
|
||||||
let leaders = discover_leaders().await;
|
let leaders = discover_leaders().await;
|
||||||
resolve_target_from_descriptors(target, leaders)
|
resolve_target_from_descriptors(target, leaders, &lock::default_socket_path())
|
||||||
}
|
}
|
||||||
#[derive(Debug, thiserror::Error)]
|
#[derive(Debug, thiserror::Error)]
|
||||||
pub enum ConnectionError {
|
pub enum ConnectionError {
|
||||||
@@ -1315,7 +1333,12 @@ fn spawn_leader_subprocess() -> Result<u32, ConnectionError> {
|
|||||||
}
|
}
|
||||||
cmd.stdin(std::process::Stdio::null())
|
cmd.stdin(std::process::Stdio::null())
|
||||||
.stdout(std::process::Stdio::null());
|
.stdout(std::process::Stdio::null());
|
||||||
let log_path = crate::util::kigi_home::kigi_home().join("leader.log");
|
let log_path = crate::util::kigi_home::kigi_home()
|
||||||
|
.join("logs")
|
||||||
|
.join("leader.log");
|
||||||
|
if let Some(parent) = log_path.parent() {
|
||||||
|
let _ = std::fs::create_dir_all(parent);
|
||||||
|
}
|
||||||
match std::fs::File::create(&log_path) {
|
match std::fs::File::create(&log_path) {
|
||||||
Ok(log_file) => {
|
Ok(log_file) => {
|
||||||
info!("Leader stderr → log file");
|
info!("Leader stderr → log file");
|
||||||
@@ -1444,6 +1467,46 @@ mod tests {
|
|||||||
vec![(222, "0.2.52".to_string())]
|
vec![(222, "0.2.52".to_string())]
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
fn reachable_default(socket: &str) -> LeaderDescriptor {
|
||||||
|
let socket_path = PathBuf::from(socket);
|
||||||
|
LeaderDescriptor {
|
||||||
|
pid_from_lock: Some(1),
|
||||||
|
lock_path: Some(socket_path.with_extension("lock")),
|
||||||
|
socket_path: Some(socket_path.clone()),
|
||||||
|
socket_suffix: String::new(),
|
||||||
|
classification: LeaderDiscoveryState::Reachable,
|
||||||
|
is_default: true,
|
||||||
|
live_info: Some(LiveLeaderInfo {
|
||||||
|
pid: 1,
|
||||||
|
socket_path,
|
||||||
|
lock_path: PathBuf::new(),
|
||||||
|
socket_suffix: String::new(),
|
||||||
|
leader_protocol_version: 1,
|
||||||
|
leader_binary_version: "0.1.15".to_string(),
|
||||||
|
}),
|
||||||
|
target_error: None,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
#[test]
|
||||||
|
fn default_target_prefers_the_current_socket_over_a_legacy_default() {
|
||||||
|
let legacy = reachable_default("/h/.kigi/leader.sock");
|
||||||
|
let current = reachable_default("/h/.kigi/run/leader.sock");
|
||||||
|
let current_socket = PathBuf::from("/h/.kigi/run/leader.sock");
|
||||||
|
let picked = resolve_target_from_descriptors(
|
||||||
|
LeaderTarget::Default,
|
||||||
|
vec![current.clone(), legacy.clone()],
|
||||||
|
¤t_socket,
|
||||||
|
)
|
||||||
|
.expect("current default resolves");
|
||||||
|
assert_eq!(picked.descriptor.socket_path, current.socket_path);
|
||||||
|
let fallback = resolve_target_from_descriptors(
|
||||||
|
LeaderTarget::Default,
|
||||||
|
vec![legacy.clone()],
|
||||||
|
¤t_socket,
|
||||||
|
)
|
||||||
|
.expect("legacy default still resolves alone");
|
||||||
|
assert_eq!(fallback.descriptor.socket_path, legacy.socket_path);
|
||||||
|
}
|
||||||
#[test]
|
#[test]
|
||||||
fn leader_is_older_than_directional() {
|
fn leader_is_older_than_directional() {
|
||||||
assert!(leader_is_older_than("0.1.0", "0.2.0"));
|
assert!(leader_is_older_than("0.1.0", "0.2.0"));
|
||||||
|
|||||||
@@ -1146,6 +1146,9 @@ pub async fn run_leader_server(
|
|||||||
control_state: LeaderServerControlState,
|
control_state: LeaderServerControlState,
|
||||||
) -> Result<(), ServerError> {
|
) -> Result<(), ServerError> {
|
||||||
let _ = std::fs::remove_file(&socket_path);
|
let _ = std::fs::remove_file(&socket_path);
|
||||||
|
if let Some(parent) = socket_path.parent() {
|
||||||
|
std::fs::create_dir_all(parent)?;
|
||||||
|
}
|
||||||
let shutdown_reason_rx = shutdown_tx.subscribe();
|
let shutdown_reason_rx = shutdown_tx.subscribe();
|
||||||
let listener = LeaderListener::bind(&socket_path)?;
|
let listener = LeaderListener::bind(&socket_path)?;
|
||||||
info!("Leader server listening");
|
info!("Leader server listening");
|
||||||
|
|||||||
@@ -171,6 +171,70 @@ pub fn error_detail_from_data(data: &serde_json::Value) -> Option<String> {
|
|||||||
.map(str::to_owned)
|
.map(str::to_owned)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// The human-readable text of an ACP error: its `data` detail when present (Display would JSON-escape it), else the message.
|
||||||
|
pub fn acp_error_message(err: &acp::Error) -> String {
|
||||||
|
err.data
|
||||||
|
.as_ref()
|
||||||
|
.and_then(error_detail_from_data)
|
||||||
|
.unwrap_or_else(|| err.message.clone())
|
||||||
|
}
|
||||||
|
|
||||||
|
/// First line of a compaction error without internal `compact failed:` prefixes, capped for a banner; diagnostic lines (request URLs) are dropped.
|
||||||
|
pub fn user_facing_compact_error(raw: &str) -> String {
|
||||||
|
const INTERNAL_PREFIX: &str = "compact failed:";
|
||||||
|
const MAX_CHARS: usize = 200;
|
||||||
|
// Redact before line selection: a line break inside a URL must not hide its `@`.
|
||||||
|
let raw = redact_urls_in_text(raw);
|
||||||
|
let mut rest = raw.trim();
|
||||||
|
while rest
|
||||||
|
.get(..INTERNAL_PREFIX.len())
|
||||||
|
.is_some_and(|head| head.eq_ignore_ascii_case(INTERNAL_PREFIX))
|
||||||
|
{
|
||||||
|
rest = rest[INTERNAL_PREFIX.len()..].trim_start();
|
||||||
|
}
|
||||||
|
rest.lines()
|
||||||
|
.next()
|
||||||
|
.unwrap_or_default()
|
||||||
|
.trim()
|
||||||
|
.chars()
|
||||||
|
.take(MAX_CHARS)
|
||||||
|
.collect()
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Every canonical `scheme://` URL in `text` loses userinfo, sensitive query values and fragment; one that fails to parse is not echoed.
|
||||||
|
fn redact_urls_in_text(text: &str) -> String {
|
||||||
|
let mut out = String::with_capacity(text.len());
|
||||||
|
let mut rest = text;
|
||||||
|
while let Some(sep) = rest.find("://") {
|
||||||
|
// The delimiter before the scheme may be multi-byte (`“`, `:`): step past its UTF-8 length.
|
||||||
|
let scheme_start = rest[..sep]
|
||||||
|
.char_indices()
|
||||||
|
.rev()
|
||||||
|
.find(|(_, c)| !(c.is_ascii_alphanumeric() || matches!(c, '+' | '-' | '.')))
|
||||||
|
.map_or(0, |(at, c)| at + c.len_utf8());
|
||||||
|
out.push_str(&rest[..scheme_start]);
|
||||||
|
// The authority may hold whitespace (a configured password); the token ends at whitespace after it.
|
||||||
|
let authority = &rest[sep + 3..];
|
||||||
|
let authority_end = authority.find(['/', '?', '#']).unwrap_or(authority.len());
|
||||||
|
let token_end = authority[authority_end..]
|
||||||
|
.find(char::is_whitespace)
|
||||||
|
.map_or(rest.len(), |at| sep + 3 + authority_end + at);
|
||||||
|
let token = &rest[scheme_start..token_end];
|
||||||
|
let url_text = token.trim_end_matches([')', ']', '}', ',', '.', ';', '\'', '"', '>']);
|
||||||
|
match url::Url::parse(url_text) {
|
||||||
|
Ok(mut url) => {
|
||||||
|
kigi_secrets::redact_url(&mut url);
|
||||||
|
out.push_str(url.as_str());
|
||||||
|
}
|
||||||
|
Err(_) => out.push_str("<unparseable url>"),
|
||||||
|
}
|
||||||
|
out.push_str(&token[url_text.len()..]);
|
||||||
|
rest = &rest[token_end..];
|
||||||
|
}
|
||||||
|
out.push_str(rest);
|
||||||
|
out
|
||||||
|
}
|
||||||
|
|
||||||
pub fn http_status_from_error(err: &acp::Error) -> Option<u16> {
|
pub fn http_status_from_error(err: &acp::Error) -> Option<u16> {
|
||||||
err.data
|
err.data
|
||||||
.as_ref()?
|
.as_ref()?
|
||||||
@@ -254,6 +318,77 @@ pub fn prompt_complete_fields(
|
|||||||
|
|
||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod tests {
|
mod tests {
|
||||||
|
#[test]
|
||||||
|
fn compact_error_text_keeps_the_first_decoded_line_only() {
|
||||||
|
let err = super::acp::Error::internal_error().data(
|
||||||
|
"compact failed: API error (status 500): overloaded\n\nRequest URL: http://u:TEST_PASSWORD@127.0.0.1/v1",
|
||||||
|
);
|
||||||
|
let detail = super::user_facing_compact_error(&super::acp_error_message(&err));
|
||||||
|
assert_eq!(detail, "API error (status 500): overloaded");
|
||||||
|
assert!(!detail.contains("TEST_PASSWORD"));
|
||||||
|
assert_eq!(
|
||||||
|
super::user_facing_compact_error(&"x".repeat(500))
|
||||||
|
.chars()
|
||||||
|
.count(),
|
||||||
|
200
|
||||||
|
);
|
||||||
|
assert_eq!(
|
||||||
|
super::acp_error_message(&super::acp::Error::internal_error()),
|
||||||
|
"Internal error"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
/// A sampler 401 names the endpoint on the retained line; its userinfo must not survive.
|
||||||
|
#[test]
|
||||||
|
fn compact_error_text_redacts_url_credentials_on_the_first_line() {
|
||||||
|
for password in [
|
||||||
|
"TEST_PASSWORD",
|
||||||
|
"TEST PASSWORD",
|
||||||
|
"TEST%20PASSWORD",
|
||||||
|
"TEST_PASSWORD\n",
|
||||||
|
"TEST_PASSWORD\r\n",
|
||||||
|
] {
|
||||||
|
let raw = format!(
|
||||||
|
"compact failed: Unauthorized (401) from http://u:{password}@127.0.0.1:33263/401/v1/chat/completions: bad auth"
|
||||||
|
);
|
||||||
|
assert_eq!(
|
||||||
|
super::user_facing_compact_error(&raw),
|
||||||
|
"Unauthorized (401) from http://127.0.0.1:33263/401/v1/chat/completions: bad auth",
|
||||||
|
"{password:?}"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
assert_eq!(
|
||||||
|
super::redact_urls_in_text("see https://a:b@h.example/x and http://h2/"),
|
||||||
|
"see https://h.example/x and http://h2/"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
/// A credential carried as a query value survives no failure shape: 401 message or transport error.
|
||||||
|
#[test]
|
||||||
|
fn compact_error_text_redacts_query_credentials_in_every_failure_shape() {
|
||||||
|
let unauthorized = "compact failed: Unauthorized (401) from http://127.0.0.1:1/?access_token=TEST_QUERY_TOKEN&route=/v1/chat/completions: bad auth";
|
||||||
|
let transport = "compact failed: request error: error sending request for url (http://127.0.0.1:1/?access_token=TEST_QUERY_TOKEN&route=/500/v1/chat/completions)";
|
||||||
|
for raw in [unauthorized, transport] {
|
||||||
|
let detail = super::user_facing_compact_error(raw);
|
||||||
|
assert!(!detail.contains("TEST_QUERY_TOKEN"), "{detail}");
|
||||||
|
assert!(detail.contains("route="), "{detail}");
|
||||||
|
}
|
||||||
|
assert!(super::user_facing_compact_error("see http://:://").contains("<unparseable url>"));
|
||||||
|
}
|
||||||
|
|
||||||
|
/// A multi-byte delimiter right before the URL must not break the scan.
|
||||||
|
#[test]
|
||||||
|
fn compact_error_text_handles_unicode_before_a_url() {
|
||||||
|
for raw in [
|
||||||
|
"compact failed: Service unavailable. See “https://u:TEST_PASSWORD@status.example/”.",
|
||||||
|
"compact failed: 请参阅:https://u:TEST_PASSWORD@status.example/",
|
||||||
|
] {
|
||||||
|
let detail = super::user_facing_compact_error(raw);
|
||||||
|
assert!(!detail.contains("TEST_PASSWORD"), "{detail}");
|
||||||
|
assert!(detail.contains("https://status.example/"), "{detail}");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
use super::*;
|
use super::*;
|
||||||
use reqwest::StatusCode;
|
use reqwest::StatusCode;
|
||||||
|
|
||||||
|
|||||||
@@ -1518,6 +1518,9 @@ mod load_user_prompts_tests;
|
|||||||
#[path = "acp_session_tests/memory_config_tests.rs"]
|
#[path = "acp_session_tests/memory_config_tests.rs"]
|
||||||
mod memory_config_tests;
|
mod memory_config_tests;
|
||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
|
#[path = "acp_session_tests/model_switch_window_tests.rs"]
|
||||||
|
mod model_switch_window_tests;
|
||||||
|
#[cfg(test)]
|
||||||
#[path = "acp_session_tests/parallel_dispatch_tests.rs"]
|
#[path = "acp_session_tests/parallel_dispatch_tests.rs"]
|
||||||
mod parallel_dispatch_tests;
|
mod parallel_dispatch_tests;
|
||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
|
|||||||
@@ -10,7 +10,7 @@ impl SessionActor {
|
|||||||
apply_prompt_override: bool,
|
apply_prompt_override: bool,
|
||||||
skip_prompt_rewrite: bool,
|
skip_prompt_rewrite: bool,
|
||||||
auto_compact_threshold_percent: u8,
|
auto_compact_threshold_percent: u8,
|
||||||
) -> Result<acp::ModelId, acp::Error> {
|
) -> Result<(acp::ModelId, std::num::NonZeroU64), acp::Error> {
|
||||||
let model_id = acp::ModelId::new(sampling_config.model.clone());
|
let model_id = acp::ModelId::new(sampling_config.model.clone());
|
||||||
// H4: record the picker's catalog KEY as this SESSION's own selection.
|
// H4: record the picker's catalog KEY as this SESSION's own selection.
|
||||||
// `sampling_config.model` is the ambiguous bare slug; the key is what
|
// `sampling_config.model` is the ambiguous bare slug; the key is what
|
||||||
@@ -120,7 +120,7 @@ impl SessionActor {
|
|||||||
agent_name: Some(agent_name),
|
agent_name: Some(agent_name),
|
||||||
reasoning_effort: Some(sampling_config.reasoning_effort),
|
reasoning_effort: Some(sampling_config.reasoning_effort),
|
||||||
});
|
});
|
||||||
Ok(model_id)
|
Ok((model_id, new_context_window))
|
||||||
}
|
}
|
||||||
/// Handle [`SessionCommand::RebuildAgentForDefinition`].
|
/// Handle [`SessionCommand::RebuildAgentForDefinition`].
|
||||||
///
|
///
|
||||||
|
|||||||
@@ -548,17 +548,10 @@ impl SessionActor {
|
|||||||
|
|
||||||
if report.changed() && !dry_run {
|
if report.changed() && !dry_run {
|
||||||
// Flush barrier: success must mean the rewrite is on disk.
|
// Flush barrier: success must mean the rewrite is on disk.
|
||||||
let (flush_tx, flush_rx) = tokio::sync::oneshot::channel();
|
if let Err(error) = self.persistence_barrier().await {
|
||||||
if self
|
anyhow::bail!(
|
||||||
.notifications
|
"history repaired in memory but the persistence flush failed: {error}"
|
||||||
.persistence_tx
|
);
|
||||||
.send(PersistenceMsg::FlushAndAck {
|
|
||||||
respond_to: flush_tx,
|
|
||||||
})
|
|
||||||
.is_err()
|
|
||||||
|| flush_rx.await.is_err()
|
|
||||||
{
|
|
||||||
anyhow::bail!("history repaired in memory but the persistence flush failed");
|
|
||||||
}
|
}
|
||||||
tracing::warn!(
|
tracing::warn!(
|
||||||
session_id = %self.session_info.id.0,
|
session_id = %self.session_info.id.0,
|
||||||
|
|||||||
@@ -957,6 +957,8 @@ impl SessionActor {
|
|||||||
Some(self.session_info.id.0.to_string()),
|
Some(self.session_info.id.0.to_string()),
|
||||||
None,
|
None,
|
||||||
None,
|
None,
|
||||||
|
self.tool_context.cwd.clone(),
|
||||||
|
self.display_cwd.get().map(std::path::PathBuf::from),
|
||||||
)
|
)
|
||||||
.await
|
.await
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -681,22 +681,14 @@ impl SessionActor {
|
|||||||
.await
|
.await
|
||||||
.is_some()
|
.is_some()
|
||||||
{
|
{
|
||||||
let (flush_tx, flush_rx) = oneshot::channel();
|
match self.persistence_barrier().await {
|
||||||
if self
|
Ok(()) => {
|
||||||
.notifications
|
let _ = ack.send(());
|
||||||
.persistence_tx
|
}
|
||||||
.send(PersistenceMsg::FlushAndAck {
|
Err(error) => tracing::error!(
|
||||||
respond_to: flush_tx,
|
session_id = % self.session_info.id.0, prompt_id = % prompt_id,
|
||||||
})
|
%error, "persist_ack flush barrier failed"
|
||||||
.is_ok()
|
),
|
||||||
&& flush_rx.await.is_ok()
|
|
||||||
{
|
|
||||||
let _ = ack.send(());
|
|
||||||
} else {
|
|
||||||
tracing::error!(
|
|
||||||
session_id = % self.session_info.id.0, prompt_id = %
|
|
||||||
prompt_id, "persist_ack flush barrier failed"
|
|
||||||
);
|
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
tracing::error!(
|
tracing::error!(
|
||||||
|
|||||||
@@ -333,15 +333,24 @@ impl SessionActor {
|
|||||||
if let Err(e) = crate::session::replay_events::flush_replay_actor(&self.event_tx).await {
|
if let Err(e) = crate::session::replay_events::flush_replay_actor(&self.event_tx).await {
|
||||||
tracing::warn!(?e, "flush_replay_actor failed");
|
tracing::warn!(?e, "flush_replay_actor failed");
|
||||||
}
|
}
|
||||||
|
if let Err(error) = self.persistence_barrier().await {
|
||||||
|
tracing::error!(%error, "persistence flush failed");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
/// The `FlushAndAck` durability barrier: `Ok` only once every prior
|
||||||
|
/// persistence write is on stable media.
|
||||||
|
pub(super) async fn persistence_barrier(&self) -> std::io::Result<()> {
|
||||||
let (tx, rx) = tokio::sync::oneshot::channel();
|
let (tx, rx) = tokio::sync::oneshot::channel();
|
||||||
if self
|
if self
|
||||||
.notifications
|
.notifications
|
||||||
.persistence_tx
|
.persistence_tx
|
||||||
.send(PersistenceMsg::FlushAndAck { respond_to: tx })
|
.send(PersistenceMsg::FlushAndAck { respond_to: tx })
|
||||||
.is_ok()
|
.is_err()
|
||||||
{
|
{
|
||||||
let _ = rx.await;
|
return Err(std::io::Error::other("persistence actor gone"));
|
||||||
}
|
}
|
||||||
|
rx.await
|
||||||
|
.unwrap_or_else(|_| Err(std::io::Error::other("persistence actor gone")))
|
||||||
}
|
}
|
||||||
/// Extracts the update type name and relevant parameters for logging
|
/// Extracts the update type name and relevant parameters for logging
|
||||||
fn extract_update_info(
|
fn extract_update_info(
|
||||||
|
|||||||
+3
-3
@@ -435,7 +435,7 @@ async fn first_turn_memory_injection_persists_to_chat_history() {
|
|||||||
respond_to: flush_tx,
|
respond_to: flush_tx,
|
||||||
})
|
})
|
||||||
.unwrap();
|
.unwrap();
|
||||||
flush_rx.await.unwrap();
|
flush_rx.await.unwrap().unwrap();
|
||||||
let loaded = storage
|
let loaded = storage
|
||||||
.load_session_without_updates(&session_info)
|
.load_session_without_updates(&session_info)
|
||||||
.await
|
.await
|
||||||
@@ -757,7 +757,7 @@ async fn first_turn_memory_injection_disabled_does_not_persist_to_chat_history()
|
|||||||
respond_to: flush_tx,
|
respond_to: flush_tx,
|
||||||
})
|
})
|
||||||
.unwrap();
|
.unwrap();
|
||||||
flush_rx.await.unwrap();
|
flush_rx.await.unwrap().unwrap();
|
||||||
let storage = crate::session::storage::JsonlStorageAdapter::with_explicit_session_dir(
|
let storage = crate::session::storage::JsonlStorageAdapter::with_explicit_session_dir(
|
||||||
session_dir.path().to_path_buf(),
|
session_dir.path().to_path_buf(),
|
||||||
);
|
);
|
||||||
@@ -1310,7 +1310,7 @@ async fn actor_with_persistence_drain() -> std::sync::Arc<SessionActor> {
|
|||||||
tokio::task::spawn_local(async move {
|
tokio::task::spawn_local(async move {
|
||||||
while let Some(msg) = persistence_rx.recv().await {
|
while let Some(msg) = persistence_rx.recv().await {
|
||||||
if let PersistenceMsg::FlushAndAck { respond_to } = msg {
|
if let PersistenceMsg::FlushAndAck { respond_to } = msg {
|
||||||
let _ = respond_to.send(());
|
let _ = respond_to.send(Ok(()));
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -0,0 +1,24 @@
|
|||||||
|
//! `handle_set_session_model` reports the session's effective context
|
||||||
|
//! window so clients repaint their header without waiting for a turn.
|
||||||
|
use super::support::*;
|
||||||
|
|
||||||
|
#[tokio::test(flavor = "current_thread")]
|
||||||
|
async fn set_session_model_returns_the_effective_context_window() {
|
||||||
|
let local = tokio::task::LocalSet::new();
|
||||||
|
local
|
||||||
|
.run_until(async {
|
||||||
|
let (actor, _rx) = build_actor().await;
|
||||||
|
let cfg = kigi_sampler::SamplerConfig {
|
||||||
|
model: "narrow".to_string(),
|
||||||
|
context_window: 128_000,
|
||||||
|
..Default::default()
|
||||||
|
};
|
||||||
|
let (model_id, window) = actor
|
||||||
|
.handle_set_session_model(cfg, None, false, false, true, 85)
|
||||||
|
.await
|
||||||
|
.expect("model switch");
|
||||||
|
assert_eq!(model_id.0.as_ref(), "narrow");
|
||||||
|
assert_eq!(window.get(), 128_000);
|
||||||
|
})
|
||||||
|
.await;
|
||||||
|
}
|
||||||
@@ -82,6 +82,8 @@ async fn set_auto_mode_path_wires_live_side_query_via_session_actor() {
|
|||||||
None,
|
None,
|
||||||
None,
|
None,
|
||||||
None,
|
None,
|
||||||
|
session.tool_context.cwd.clone(),
|
||||||
|
None,
|
||||||
)
|
)
|
||||||
.await;
|
.await;
|
||||||
// cargo is heuristic-allow when sampling fails; must not be Prompt-only
|
// cargo is heuristic-allow when sampling fails; must not be Prompt-only
|
||||||
@@ -99,6 +101,8 @@ async fn set_auto_mode_path_wires_live_side_query_via_session_actor() {
|
|||||||
None,
|
None,
|
||||||
None,
|
None,
|
||||||
None,
|
None,
|
||||||
|
session.tool_context.cwd.clone(),
|
||||||
|
None,
|
||||||
)
|
)
|
||||||
.await;
|
.await;
|
||||||
assert!(
|
assert!(
|
||||||
|
|||||||
@@ -173,7 +173,9 @@ pub enum SessionCommand {
|
|||||||
/// `compaction.threshold_percent` (which is `Cell<u8>` so it can
|
/// `compaction.threshold_percent` (which is `Cell<u8>` so it can
|
||||||
/// update without `&mut self`).
|
/// update without `&mut self`).
|
||||||
auto_compact_threshold_percent: u8,
|
auto_compact_threshold_percent: u8,
|
||||||
responds_to: oneshot::Sender<Result<acp::ModelId, acp::Error>>,
|
/// Ok: the applied model id and the session's effective context
|
||||||
|
/// window, which clients repaint from without waiting for a turn.
|
||||||
|
responds_to: oneshot::Sender<Result<(acp::ModelId, std::num::NonZeroU64), acp::Error>>,
|
||||||
},
|
},
|
||||||
/// Zero-turn harness rebuild: build a brand-new `Agent` from the
|
/// Zero-turn harness rebuild: build a brand-new `Agent` from the
|
||||||
/// session's `AgentRebuildSpec` and the new `AgentDefinition`,
|
/// session's `AgentRebuildSpec` and the new `AgentDefinition`,
|
||||||
@@ -332,10 +334,10 @@ pub enum SessionCommand {
|
|||||||
CopyFile {
|
CopyFile {
|
||||||
respond_to: oneshot::Sender<anyhow::Result<crate::session::persistence::SessionStateCopy>>,
|
respond_to: oneshot::Sender<anyhow::Result<crate::session::persistence::SessionStateCopy>>,
|
||||||
},
|
},
|
||||||
/// Flush the replay buffer and persistence, then signal completion.
|
/// Flush the replay buffer and persistence, then report the durability
|
||||||
/// Used during reconnect to ensure all buffered content is persisted before replay.
|
/// barrier result. Used during reconnect so replay follows persisted content.
|
||||||
FlushComplete {
|
FlushComplete {
|
||||||
respond_to: oneshot::Sender<()>,
|
respond_to: oneshot::Sender<std::io::Result<()>>,
|
||||||
},
|
},
|
||||||
/// Update MCP servers for an existing session (used during reconnect or
|
/// Update MCP servers for an existing session (used during reconnect or
|
||||||
/// mid-session via the `kigi/session/update_mcp_servers` extension method).
|
/// mid-session via the `kigi/session/update_mcp_servers` extension method).
|
||||||
|
|||||||
@@ -689,6 +689,19 @@ impl SessionActor {
|
|||||||
.await;
|
.await;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
/// Retry guidance headline, then the user-facing detail on its own line.
|
||||||
|
fn failure_with_retry_guidance(err: &acp::Error) -> String {
|
||||||
|
const RETRY_GUIDANCE: &str =
|
||||||
|
"it'll retry on the next turn, or start a new session using /new.";
|
||||||
|
let detail = crate::sampling::error::user_facing_compact_error(
|
||||||
|
&crate::sampling::error::acp_error_message(err),
|
||||||
|
);
|
||||||
|
if detail.is_empty() {
|
||||||
|
RETRY_GUIDANCE.to_string()
|
||||||
|
} else {
|
||||||
|
format!("{RETRY_GUIDANCE}\n{detail}")
|
||||||
|
}
|
||||||
|
}
|
||||||
/// Map a deterministic failure's error text to a fixed, content-free
|
/// Map a deterministic failure's error text to a fixed, content-free
|
||||||
/// [`SuppressReason`] (drives telemetry + sticky-vs-per-turn scope).
|
/// [`SuppressReason`] (drives telemetry + sticky-vs-per-turn scope).
|
||||||
fn classify_suppress_reason(error_msg: &str) -> SuppressReason {
|
fn classify_suppress_reason(error_msg: &str) -> SuppressReason {
|
||||||
@@ -1945,7 +1958,7 @@ impl SessionActor {
|
|||||||
== SUPPRESS_NONE
|
== SUPPRESS_NONE
|
||||||
{
|
{
|
||||||
self.send_xai_notification(XaiSessionUpdate::AutoCompactFailed {
|
self.send_xai_notification(XaiSessionUpdate::AutoCompactFailed {
|
||||||
error: String::new(),
|
error: Self::failure_with_retry_guidance(&e),
|
||||||
})
|
})
|
||||||
.await;
|
.await;
|
||||||
}
|
}
|
||||||
@@ -3286,3 +3299,28 @@ mod inline_auto_compact_flow_tests {
|
|||||||
.await;
|
.await;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[cfg(test)]
|
||||||
|
mod failure_message_tests {
|
||||||
|
use super::SessionActor;
|
||||||
|
use agent_client_protocol as acp;
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn transient_failure_message_carries_guidance_and_the_decoded_detail() {
|
||||||
|
let err = acp::Error::internal_error().data(
|
||||||
|
"Compact failed: compact failed: HTTP 500 from upstream\n\nRequest URL: http://u:TEST_PASSWORD@host/v1",
|
||||||
|
);
|
||||||
|
let text = SessionActor::failure_with_retry_guidance(&err);
|
||||||
|
let (headline, detail) = text.split_once('\n').expect("guidance + detail");
|
||||||
|
assert_eq!(
|
||||||
|
headline,
|
||||||
|
"it'll retry on the next turn, or start a new session using /new."
|
||||||
|
);
|
||||||
|
assert_eq!(detail, "HTTP 500 from upstream");
|
||||||
|
assert!(!text.contains("TEST_PASSWORD"));
|
||||||
|
assert_eq!(
|
||||||
|
SessionActor::failure_with_retry_guidance(&acp::Error::internal_error().data(" ")),
|
||||||
|
"it'll retry on the next turn, or start a new session using /new."
|
||||||
|
);
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -519,6 +519,9 @@ pub(crate) async fn capture_plan_changes(
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Pin the `a/` `b/` header prefixes [`extract_changed_files`] parses.
|
||||||
|
const DIFF_PREFIX_ARGS: [&str; 2] = ["--src-prefix=a/", "--dst-prefix=b/"];
|
||||||
|
|
||||||
/// Run `git diff <baseline>` and return the FULL (untruncated) stdout;
|
/// Run `git diff <baseline>` and return the FULL (untruncated) stdout;
|
||||||
/// the caller extracts the changed-file list before truncating.
|
/// the caller extracts the changed-file list before truncating.
|
||||||
async fn run_git_diff_against_baseline(
|
async fn run_git_diff_against_baseline(
|
||||||
@@ -526,7 +529,7 @@ async fn run_git_diff_against_baseline(
|
|||||||
workspace_root: &Path,
|
workspace_root: &Path,
|
||||||
) -> Result<String, ChangesCaptureError> {
|
) -> Result<String, ChangesCaptureError> {
|
||||||
let mut cmd = git_command(workspace_root);
|
let mut cmd = git_command(workspace_root);
|
||||||
cmd.arg("diff").arg(baseline);
|
cmd.arg("diff").args(DIFF_PREFIX_ARGS).arg(baseline);
|
||||||
let output = match tokio::time::timeout(DIFF_COMMAND_TIMEOUT, cmd.output()).await {
|
let output = match tokio::time::timeout(DIFF_COMMAND_TIMEOUT, cmd.output()).await {
|
||||||
Ok(Ok(output)) => output,
|
Ok(Ok(output)) => output,
|
||||||
Ok(Err(err)) => return Err(ChangesCaptureError::DiffCommandFailed(err.to_string())),
|
Ok(Err(err)) => return Err(ChangesCaptureError::DiffCommandFailed(err.to_string())),
|
||||||
@@ -579,10 +582,14 @@ async fn lazy_git_baseline_diff(
|
|||||||
// support SHA-256 repos.
|
// support SHA-256 repos.
|
||||||
let mut cmd = git_command(workspace_root);
|
let mut cmd = git_command(workspace_root);
|
||||||
if git_has_parent(workspace_root, &oldest).await {
|
if git_has_parent(workspace_root, &oldest).await {
|
||||||
cmd.arg("diff").arg(format!("{oldest}^..{head}"));
|
cmd.arg("diff")
|
||||||
|
.args(DIFF_PREFIX_ARGS)
|
||||||
|
.arg(format!("{oldest}^..{head}"));
|
||||||
} else {
|
} else {
|
||||||
let empty_tree = derive_empty_tree_sha(workspace_root).await;
|
let empty_tree = derive_empty_tree_sha(workspace_root).await;
|
||||||
cmd.arg("diff").arg(format!("{empty_tree}..{head}"));
|
cmd.arg("diff")
|
||||||
|
.args(DIFF_PREFIX_ARGS)
|
||||||
|
.arg(format!("{empty_tree}..{head}"));
|
||||||
}
|
}
|
||||||
|
|
||||||
let output = match tokio::time::timeout(DIFF_COMMAND_TIMEOUT, cmd.output()).await {
|
let output = match tokio::time::timeout(DIFF_COMMAND_TIMEOUT, cmd.output()).await {
|
||||||
@@ -2192,4 +2199,38 @@ mod tests {
|
|||||||
"patch must carry the untracked-files note",
|
"patch must carry the untracked-files note",
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
#[tokio::test]
|
||||||
|
async fn changed_files_ignore_the_host_diff_prefix_config() {
|
||||||
|
// Both keys rewrite the `diff --git a/<old> b/<new>` header the parser keys on.
|
||||||
|
for key in ["diff.mnemonicprefix", "diff.noprefix"] {
|
||||||
|
let tmp = tempfile::tempdir().unwrap();
|
||||||
|
init_repo(tmp.path());
|
||||||
|
git(tmp.path(), &["config", key, "true"]);
|
||||||
|
tokio::fs::write(tmp.path().join("tracked.txt"), b"seed\n")
|
||||||
|
.await
|
||||||
|
.unwrap();
|
||||||
|
let goal_created_at: i64 = 1_700_000_100;
|
||||||
|
git_at(tmp.path(), &["add", "."], goal_created_at + 100);
|
||||||
|
git_at(
|
||||||
|
tmp.path(),
|
||||||
|
&["commit", "-q", "-m", "post-goal"],
|
||||||
|
goal_created_at + 100,
|
||||||
|
);
|
||||||
|
let lazy = capture_changes_diff(None, tmp.path(), goal_created_at)
|
||||||
|
.await
|
||||||
|
.expect("lazy baseline must succeed");
|
||||||
|
assert_eq!(lazy.changed_files, ["tracked.txt"], "{key}: lazy baseline");
|
||||||
|
tokio::fs::write(tmp.path().join("tracked.txt"), b"changed\n")
|
||||||
|
.await
|
||||||
|
.unwrap();
|
||||||
|
let explicit = capture_changes_diff(Some("HEAD"), tmp.path(), goal_created_at)
|
||||||
|
.await
|
||||||
|
.expect("layer-1 git diff must succeed");
|
||||||
|
assert_eq!(
|
||||||
|
explicit.changed_files,
|
||||||
|
["tracked.txt"],
|
||||||
|
"{key}: explicit baseline"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
@@ -467,7 +467,24 @@ fn compute_normalized_blocking(
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
if buf.len() >= original_bytes {
|
// A resize that falls under the vision floors cannot be sent; keep the original with the fallback note.
|
||||||
|
if new_w < MIN_VISION_SIDE_PX
|
||||||
|
|| new_h < MIN_VISION_SIDE_PX
|
||||||
|
|| u64::from(new_w) * u64::from(new_h) < MIN_VISION_TOTAL_PX
|
||||||
|
{
|
||||||
|
tracing::warn!(
|
||||||
|
index,
|
||||||
|
width = new_w,
|
||||||
|
height = new_h,
|
||||||
|
"image resize fell under the minimum dimensions; keeping original attachment"
|
||||||
|
);
|
||||||
|
return Ok(NormalizedEntry::ReEncodingOversized {
|
||||||
|
bytes: Bytes::from(raw_bytes),
|
||||||
|
mime: Cow::Borrowed(orig_mime),
|
||||||
|
});
|
||||||
|
}
|
||||||
|
// An image over the dimension caps is resized even when that saves no bytes.
|
||||||
|
if !exceeded_dimensions && buf.len() >= original_bytes {
|
||||||
return Ok(NormalizedEntry::Unchanged {
|
return Ok(NormalizedEntry::Unchanged {
|
||||||
bytes: Bytes::from(raw_bytes),
|
bytes: Bytes::from(raw_bytes),
|
||||||
mime: Cow::Borrowed(orig_mime),
|
mime: Cow::Borrowed(orig_mime),
|
||||||
@@ -551,6 +568,50 @@ mod tests {
|
|||||||
image::ImageFormat::Png
|
image::ImageFormat::Png
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
/// A flat image at the best PNG compression is tinier than any re-encode the fast encoder produces.
|
||||||
|
fn make_best_compressed_png_content(width: u32, height: u32) -> ImageContent {
|
||||||
|
use image::codecs::png::{CompressionType, FilterType, PngEncoder};
|
||||||
|
use image::{ImageBuffer, ImageEncoder, Rgba};
|
||||||
|
let img: ImageBuffer<Rgba<u8>, Vec<u8>> =
|
||||||
|
ImageBuffer::from_pixel(width, height, Rgba([128, 64, 32, 255]));
|
||||||
|
let mut buf = Vec::new();
|
||||||
|
PngEncoder::new_with_quality(&mut buf, CompressionType::Best, FilterType::Adaptive)
|
||||||
|
.write_image(img.as_raw(), width, height, image::ExtendedColorType::Rgba8)
|
||||||
|
.unwrap();
|
||||||
|
ImageContent::new(
|
||||||
|
base64::engine::general_purpose::STANDARD.encode(&buf),
|
||||||
|
"image/png",
|
||||||
|
)
|
||||||
|
}
|
||||||
|
/// Over the dimension caps, a re-encode that saves no bytes is still a resize.
|
||||||
|
#[tokio::test]
|
||||||
|
async fn over_dimension_image_is_resized_even_when_re_encode_saves_no_bytes() {
|
||||||
|
let img = make_best_compressed_png_content(3000, 2000);
|
||||||
|
let cache = fresh_cache();
|
||||||
|
match normalize_one_in(img, 1, false, &cache).await {
|
||||||
|
Outcome::Compressed { info, .. } => {
|
||||||
|
assert!(
|
||||||
|
info.compressed_bytes >= info.original_bytes,
|
||||||
|
"test premise: the re-encode must not shrink ({} vs {})",
|
||||||
|
info.compressed_bytes,
|
||||||
|
info.original_bytes
|
||||||
|
);
|
||||||
|
assert!(info.compressed_width <= MAX_ENCODE_SIDE_PX);
|
||||||
|
assert!(info.compressed_height <= MAX_ENCODE_SIDE_PX);
|
||||||
|
}
|
||||||
|
other => panic!("expected the oversized image to be downscaled, got {other:?}"),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
/// A 3000x8 strip resizes to 2000x5, under the 8 px floor: it is kept with the fallback note.
|
||||||
|
#[tokio::test]
|
||||||
|
async fn resize_under_the_minimum_side_keeps_the_original() {
|
||||||
|
let img = make_best_compressed_png_content(3000, 8);
|
||||||
|
let cache = fresh_cache();
|
||||||
|
match normalize_one_in(img, 1, false, &cache).await {
|
||||||
|
Outcome::ReEncodingOversized(content) => assert_eq!(content.mime_type, "image/png"),
|
||||||
|
other => panic!("expected the strip to be kept with a fallback note, got {other:?}"),
|
||||||
|
}
|
||||||
|
}
|
||||||
fn make_gif_content(width: u32, height: u32) -> ImageContent {
|
fn make_gif_content(width: u32, height: u32) -> ImageContent {
|
||||||
use image::{ImageBuffer, Rgba};
|
use image::{ImageBuffer, Rgba};
|
||||||
let img: ImageBuffer<Rgba<u8>, Vec<u8>> =
|
let img: ImageBuffer<Rgba<u8>, Vec<u8>> =
|
||||||
|
|||||||
@@ -359,11 +359,13 @@ pub enum PersistenceMsg {
|
|||||||
/// stays sequential with other summary.json mutations.
|
/// stays sequential with other summary.json mutations.
|
||||||
GeneratedTitle(String),
|
GeneratedTitle(String),
|
||||||
Flush,
|
Flush,
|
||||||
/// Flush all pending writes, then signal the caller once the flush is complete.
|
/// Flush all pending writes AND fsync the session files, then signal the
|
||||||
/// Unlike `Flush` (fire-and-forget), this is a **sync barrier**: the caller's
|
/// caller. Unlike `Flush` (fire-and-forget, page cache only), this is a
|
||||||
/// oneshot only resolves after `flush_pending()` finishes writing to disk.
|
/// **durability barrier**: `Ok` means every prior write is on stable
|
||||||
|
/// media; `Err` reports a storage write that failed since the last
|
||||||
|
/// barrier or a failed sync.
|
||||||
FlushAndAck {
|
FlushAndAck {
|
||||||
respond_to: tokio::sync::oneshot::Sender<()>,
|
respond_to: tokio::sync::oneshot::Sender<io::Result<()>>,
|
||||||
},
|
},
|
||||||
/// Flush all pending writes, then copy the current session directory contents and return
|
/// Flush all pending writes, then copy the current session directory contents and return
|
||||||
/// the in-memory snapshot to the caller (who can tar.gz + upload to GCS, etc.).
|
/// the in-memory snapshot to the caller (who can tar.gz + upload to GCS, etc.).
|
||||||
@@ -1392,6 +1394,9 @@ struct SessionPersistence {
|
|||||||
storage: Arc<dyn StorageAdapter>,
|
storage: Arc<dyn StorageAdapter>,
|
||||||
/// Pending ACP notification for merging consecutive text chunks
|
/// Pending ACP notification for merging consecutive text chunks
|
||||||
pending_notification: Option<acp::SessionNotification>,
|
pending_notification: Option<acp::SessionNotification>,
|
||||||
|
/// First storage failure since the last barrier: `FlushAndAck` must not
|
||||||
|
/// report `Ok` for state that never reached the file.
|
||||||
|
pending_write_error: Option<io::Error>,
|
||||||
rx: mpsc::UnboundedReceiver<PersistenceMsg>,
|
rx: mpsc::UnboundedReceiver<PersistenceMsg>,
|
||||||
/// Session title generation lifecycle.
|
/// Session title generation lifecycle.
|
||||||
summary: crate::session::summary::SummaryGenerator,
|
summary: crate::session::summary::SummaryGenerator,
|
||||||
@@ -1491,29 +1496,49 @@ impl SessionPersistence {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
async fn write_update(&mut self, update: &SessionUpdate) {
|
fn note_storage_failure(&mut self, error: &io::Error) {
|
||||||
if let Err(e) = self.storage.append_update(&self.info, update).await {
|
if self.pending_write_error.is_none() {
|
||||||
tracing::warn!(?e, "failed to write update");
|
self.pending_write_error = Some(io::Error::new(error.kind(), error.to_string()));
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Flush any pending merged ACP notification to disk.
|
/// Append an update; a failure is logged and latched for the next barrier.
|
||||||
async fn flush_pending(&mut self) {
|
async fn write_update(&mut self, update: &SessionUpdate) -> io::Result<()> {
|
||||||
// Write any pending merged ACP notification
|
let result = self.storage.append_update(&self.info, update).await;
|
||||||
if let Some(notification) = self.pending_notification.take() {
|
if let Err(error) = &result {
|
||||||
self.write_update(&SessionUpdate::Acp(Box::new(notification)))
|
tracing::warn!(%error, "failed to write update");
|
||||||
.await;
|
self.note_storage_failure(error);
|
||||||
|
}
|
||||||
|
result
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Write the pending merged ACP notification.
|
||||||
|
async fn flush_pending(&mut self) -> io::Result<()> {
|
||||||
|
match self.pending_notification.take() {
|
||||||
|
Some(notification) => {
|
||||||
|
self.write_update(&SessionUpdate::Acp(Box::new(notification)))
|
||||||
|
.await
|
||||||
|
}
|
||||||
|
None => Ok(()),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Flush pending writes and sync all session files to disk.
|
/// Fsync every session file to stable media.
|
||||||
/// Called before CopyFile to ensure all data is persisted.
|
async fn sync_files(&self) -> io::Result<()> {
|
||||||
async fn flush_and_sync(&mut self) {
|
let synced = self.storage.sync_session_files(&self.info).await;
|
||||||
self.flush_pending().await;
|
if let Err(error) = &synced {
|
||||||
// Sync all session files to disk to ensure they're actually written
|
tracing::warn!(%error, "failed to sync session files to disk");
|
||||||
if let Err(e) = self.storage.sync_session_files(&self.info).await {
|
|
||||||
tracing::warn!(?e, "Failed to sync session files to disk");
|
|
||||||
}
|
}
|
||||||
|
synced
|
||||||
|
}
|
||||||
|
|
||||||
|
/// The `FlushAndAck` barrier. First error wins: a write that failed since
|
||||||
|
/// the last barrier outranks a failed sync.
|
||||||
|
async fn flush_and_sync(&mut self) -> io::Result<()> {
|
||||||
|
let flushed = self.flush_pending().await;
|
||||||
|
let prior_write = self.pending_write_error.take().map_or(Ok(()), Err);
|
||||||
|
let synced = self.sync_files().await;
|
||||||
|
flushed.and(prior_write).and(synced)
|
||||||
}
|
}
|
||||||
|
|
||||||
async fn run(mut self) {
|
async fn run(mut self) {
|
||||||
@@ -1530,34 +1555,38 @@ impl SessionPersistence {
|
|||||||
}
|
}
|
||||||
match msg {
|
match msg {
|
||||||
PersistenceMsg::Flush => {
|
PersistenceMsg::Flush => {
|
||||||
self.flush_pending().await;
|
// Logged and latched by write_update; the next barrier reports it.
|
||||||
|
let _ = self.flush_pending().await;
|
||||||
}
|
}
|
||||||
PersistenceMsg::FlushAndAck { respond_to } => {
|
PersistenceMsg::FlushAndAck { respond_to } => {
|
||||||
self.flush_pending().await;
|
let result = self.flush_and_sync().await;
|
||||||
let _ = respond_to.send(());
|
let _ = respond_to.send(result);
|
||||||
}
|
}
|
||||||
PersistenceMsg::Update(update) => {
|
PersistenceMsg::Update(update) => {
|
||||||
match update {
|
match update {
|
||||||
SessionUpdate::Acp(notification) => {
|
SessionUpdate::Acp(notification) => {
|
||||||
// ACP notifications use merging to coalesce consecutive text chunks
|
// ACP notifications use merging to coalesce consecutive text chunks
|
||||||
if let Some(to_write) = self.maybe_merge_notification(¬ification) {
|
if let Some(to_write) = self.maybe_merge_notification(¬ification) {
|
||||||
self.write_update(&SessionUpdate::Acp(Box::new(to_write)))
|
// Logged and latched by write_update.
|
||||||
|
let _ = self
|
||||||
|
.write_update(&SessionUpdate::Acp(Box::new(to_write)))
|
||||||
.await;
|
.await;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
SessionUpdate::Xai(_) => {
|
SessionUpdate::Xai(_) => {
|
||||||
// xAI notifications are written directly without merging
|
// Written directly without merging; logged and latched by write_update.
|
||||||
self.write_update(&update).await;
|
let _ = self.write_update(&update).await;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
PersistenceMsg::Chat(chat_msg) => {
|
PersistenceMsg::Chat(chat_msg) => {
|
||||||
if let Err(e) = self
|
if let Err(error) = self
|
||||||
.storage
|
.storage
|
||||||
.append_chat_message(&self.info, &chat_msg)
|
.append_chat_message(&self.info, &chat_msg)
|
||||||
.await
|
.await
|
||||||
{
|
{
|
||||||
tracing::warn!(?e, "failed to write chat message");
|
tracing::warn!(%error, "failed to write chat message");
|
||||||
|
self.note_storage_failure(&error);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
PersistenceMsg::ReplaceChatHistory(messages) => {
|
PersistenceMsg::ReplaceChatHistory(messages) => {
|
||||||
@@ -1571,6 +1600,7 @@ impl SessionPersistence {
|
|||||||
.await
|
.await
|
||||||
{
|
{
|
||||||
tracing::warn!(?e, "failed to replace chat history");
|
tracing::warn!(?e, "failed to replace chat history");
|
||||||
|
self.note_storage_failure(&e);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
PersistenceMsg::CurrentModel {
|
PersistenceMsg::CurrentModel {
|
||||||
@@ -1589,21 +1619,25 @@ impl SessionPersistence {
|
|||||||
.await
|
.await
|
||||||
{
|
{
|
||||||
tracing::warn!(?e, "failed to update current model");
|
tracing::warn!(?e, "failed to update current model");
|
||||||
|
self.note_storage_failure(&e);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
PersistenceMsg::PlanState(state) => {
|
PersistenceMsg::PlanState(state) => {
|
||||||
if let Err(e) = self.storage.write_plan_state(&self.info, &state).await {
|
if let Err(e) = self.storage.write_plan_state(&self.info, &state).await {
|
||||||
tracing::warn!(?e, "failed to write plan state");
|
tracing::warn!(?e, "failed to write plan state");
|
||||||
|
self.note_storage_failure(&e);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
PersistenceMsg::PlanModeState(state) => {
|
PersistenceMsg::PlanModeState(state) => {
|
||||||
if let Err(e) = self.storage.write_plan_mode_state(&self.info, &state).await {
|
if let Err(e) = self.storage.write_plan_mode_state(&self.info, &state).await {
|
||||||
tracing::warn!(?e, "failed to write plan mode state");
|
tracing::warn!(?e, "failed to write plan mode state");
|
||||||
|
self.note_storage_failure(&e);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
PersistenceMsg::GoalModeState(state) => {
|
PersistenceMsg::GoalModeState(state) => {
|
||||||
if let Err(e) = self.storage.write_goal_mode_state(&self.info, &state).await {
|
if let Err(e) = self.storage.write_goal_mode_state(&self.info, &state).await {
|
||||||
tracing::warn!(?e, "failed to write goal mode state");
|
tracing::warn!(?e, "failed to write goal mode state");
|
||||||
|
self.note_storage_failure(&e);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
PersistenceMsg::GraphModeState(state) => {
|
PersistenceMsg::GraphModeState(state) => {
|
||||||
@@ -1613,6 +1647,7 @@ impl SessionPersistence {
|
|||||||
.await
|
.await
|
||||||
{
|
{
|
||||||
tracing::warn!(?e, "failed to write graph mode state");
|
tracing::warn!(?e, "failed to write graph mode state");
|
||||||
|
self.note_storage_failure(&e);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
PersistenceMsg::ContentChunk(content_chunks) => {
|
PersistenceMsg::ContentChunk(content_chunks) => {
|
||||||
@@ -1686,12 +1721,14 @@ impl SessionPersistence {
|
|||||||
}
|
}
|
||||||
Err(e) => {
|
Err(e) => {
|
||||||
tracing::warn!(?e, "failed to persist generated session title");
|
tracing::warn!(?e, "failed to persist generated session title");
|
||||||
|
self.note_storage_failure(&e);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
PersistenceMsg::RewindPoint(point) => {
|
PersistenceMsg::RewindPoint(point) => {
|
||||||
if let Err(e) = self.storage.append_rewind_point(&self.info, &point).await {
|
if let Err(error) = self.storage.append_rewind_point(&self.info, &point).await {
|
||||||
tracing::warn!(?e, "failed to write rewind point");
|
tracing::warn!(%error, "failed to write rewind point");
|
||||||
|
self.note_storage_failure(&error);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
PersistenceMsg::TruncateRewindPoints { from_index } => {
|
PersistenceMsg::TruncateRewindPoints { from_index } => {
|
||||||
@@ -1701,6 +1738,7 @@ impl SessionPersistence {
|
|||||||
.await
|
.await
|
||||||
{
|
{
|
||||||
tracing::warn!(?e, from_index, "failed to truncate rewind points");
|
tracing::warn!(?e, from_index, "failed to truncate rewind points");
|
||||||
|
self.note_storage_failure(&e);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
PersistenceMsg::MergeRewindPointsFrom { target_index } => {
|
PersistenceMsg::MergeRewindPointsFrom { target_index } => {
|
||||||
@@ -1710,6 +1748,7 @@ impl SessionPersistence {
|
|||||||
.await
|
.await
|
||||||
{
|
{
|
||||||
tracing::warn!(?e, target_index, "failed to merge rewind points");
|
tracing::warn!(?e, target_index, "failed to merge rewind points");
|
||||||
|
self.note_storage_failure(&e);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
PersistenceMsg::CollectionId(collection_id) => {
|
PersistenceMsg::CollectionId(collection_id) => {
|
||||||
@@ -1719,6 +1758,7 @@ impl SessionPersistence {
|
|||||||
.await
|
.await
|
||||||
{
|
{
|
||||||
tracing::warn!(?e, "failed to write collection id");
|
tracing::warn!(?e, "failed to write collection id");
|
||||||
|
self.note_storage_failure(&e);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
PersistenceMsg::NextTraceTurn {
|
PersistenceMsg::NextTraceTurn {
|
||||||
@@ -1731,11 +1771,13 @@ impl SessionPersistence {
|
|||||||
.await
|
.await
|
||||||
{
|
{
|
||||||
tracing::warn!(?e, "failed to write next trace turn");
|
tracing::warn!(?e, "failed to write next trace turn");
|
||||||
|
self.note_storage_failure(&e);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
PersistenceMsg::Signals(signals) => {
|
PersistenceMsg::Signals(signals) => {
|
||||||
if let Err(e) = self.storage.write_signals(&self.info, &signals).await {
|
if let Err(e) = self.storage.write_signals(&self.info, &signals).await {
|
||||||
tracing::warn!(?e, "failed to write session signals");
|
tracing::warn!(?e, "failed to write session signals");
|
||||||
|
self.note_storage_failure(&e);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
PersistenceMsg::AnnouncementState(state) => {
|
PersistenceMsg::AnnouncementState(state) => {
|
||||||
@@ -1745,16 +1787,19 @@ impl SessionPersistence {
|
|||||||
.await
|
.await
|
||||||
{
|
{
|
||||||
tracing::warn!(?e, "failed to write announcement state");
|
tracing::warn!(?e, "failed to write announcement state");
|
||||||
|
self.note_storage_failure(&e);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
PersistenceMsg::Feedback(entry) => {
|
PersistenceMsg::Feedback(entry) => {
|
||||||
if let Err(e) = self.storage.append_feedback(&self.info, &entry).await {
|
if let Err(e) = self.storage.append_feedback(&self.info, &entry).await {
|
||||||
tracing::warn!(?e, "failed to write feedback entry");
|
tracing::warn!(?e, "failed to write feedback entry");
|
||||||
|
self.note_storage_failure(&e);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
PersistenceMsg::Btw(entry) => {
|
PersistenceMsg::Btw(entry) => {
|
||||||
if let Err(e) = self.storage.append_btw(&self.info, &entry).await {
|
if let Err(e) = self.storage.append_btw(&self.info, &entry).await {
|
||||||
tracing::warn!(?e, "failed to write btw entry");
|
tracing::warn!(?e, "failed to write btw entry");
|
||||||
|
self.note_storage_failure(&e);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
PersistenceMsg::GitHead { commit, branch } => {
|
PersistenceMsg::GitHead { commit, branch } => {
|
||||||
@@ -1764,6 +1809,7 @@ impl SessionPersistence {
|
|||||||
.await
|
.await
|
||||||
{
|
{
|
||||||
tracing::warn!(?e, "failed to persist git HEAD");
|
tracing::warn!(?e, "failed to persist git HEAD");
|
||||||
|
self.note_storage_failure(&e);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
PersistenceMsg::CompactionCheckpoint(checkpoint) => {
|
PersistenceMsg::CompactionCheckpoint(checkpoint) => {
|
||||||
@@ -1773,6 +1819,7 @@ impl SessionPersistence {
|
|||||||
.await
|
.await
|
||||||
{
|
{
|
||||||
tracing::warn!(?e, "failed to write compaction checkpoint file");
|
tracing::warn!(?e, "failed to write compaction checkpoint file");
|
||||||
|
self.note_storage_failure(&e);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
PersistenceMsg::CompactionRequest(request) => {
|
PersistenceMsg::CompactionRequest(request) => {
|
||||||
@@ -1782,11 +1829,13 @@ impl SessionPersistence {
|
|||||||
.await
|
.await
|
||||||
{
|
{
|
||||||
tracing::warn!(?e, "failed to write compaction request artifact");
|
tracing::warn!(?e, "failed to write compaction request artifact");
|
||||||
|
self.note_storage_failure(&e);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
PersistenceMsg::RecapRequest(request) => {
|
PersistenceMsg::RecapRequest(request) => {
|
||||||
if let Err(e) = self.storage.write_recap_request(&self.info, &request).await {
|
if let Err(e) = self.storage.write_recap_request(&self.info, &request).await {
|
||||||
tracing::warn!(?e, "failed to write recap request artifact");
|
tracing::warn!(?e, "failed to write recap request artifact");
|
||||||
|
self.note_storage_failure(&e);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
PersistenceMsg::CompactionSegment(segment) => {
|
PersistenceMsg::CompactionSegment(segment) => {
|
||||||
@@ -1796,20 +1845,25 @@ impl SessionPersistence {
|
|||||||
.await
|
.await
|
||||||
{
|
{
|
||||||
tracing::warn!(?e, "failed to write compaction segment");
|
tracing::warn!(?e, "failed to write compaction segment");
|
||||||
|
self.note_storage_failure(&e);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
PersistenceMsg::CopyFile { one_shot } => {
|
PersistenceMsg::CopyFile { one_shot } => {
|
||||||
// Flush pending writes and sync all session files to disk before copying.
|
// Not the durability barrier: the write-failure latch stays for FlushAndAck.
|
||||||
self.flush_and_sync().await;
|
let flushed = self.flush_pending().await;
|
||||||
|
let result = match flushed.and(self.sync_files().await) {
|
||||||
let result = self.copy_session_dir_to_memory().await;
|
Ok(()) => self.copy_session_dir_to_memory().await,
|
||||||
|
Err(error) => {
|
||||||
|
Err(anyhow::Error::new(error).context("session files are not on disk"))
|
||||||
|
}
|
||||||
|
};
|
||||||
let _ = one_shot.send(result);
|
let _ = one_shot.send(result);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Drain the merge buffer on channel close.
|
// Drain the merge buffer on channel close; a failure is logged by write_update.
|
||||||
self.flush_pending().await;
|
let _ = self.flush_pending().await;
|
||||||
}
|
}
|
||||||
|
|
||||||
async fn copy_session_dir_to_memory(&self) -> anyhow::Result<SessionStateCopy> {
|
async fn copy_session_dir_to_memory(&self) -> anyhow::Result<SessionStateCopy> {
|
||||||
@@ -2002,6 +2056,7 @@ pub(crate) async fn new(
|
|||||||
info: info_clone,
|
info: info_clone,
|
||||||
storage: storage.clone(),
|
storage: storage.clone(),
|
||||||
pending_notification: None,
|
pending_notification: None,
|
||||||
|
pending_write_error: None,
|
||||||
rx,
|
rx,
|
||||||
summary: crate::session::summary::SummaryGenerator::new(
|
summary: crate::session::summary::SummaryGenerator::new(
|
||||||
crate::session::summary::SummaryConfig {
|
crate::session::summary::SummaryConfig {
|
||||||
@@ -2070,6 +2125,7 @@ pub async fn new_with_explicit_dir(
|
|||||||
info: info_clone,
|
info: info_clone,
|
||||||
storage: storage.clone(),
|
storage: storage.clone(),
|
||||||
pending_notification: None,
|
pending_notification: None,
|
||||||
|
pending_write_error: None,
|
||||||
rx,
|
rx,
|
||||||
summary: crate::session::summary::SummaryGenerator::new(
|
summary: crate::session::summary::SummaryGenerator::new(
|
||||||
crate::session::summary::SummaryConfig {
|
crate::session::summary::SummaryConfig {
|
||||||
@@ -2181,6 +2237,7 @@ pub(crate) async fn load_light(
|
|||||||
info: loaded_info,
|
info: loaded_info,
|
||||||
storage: storage.clone(),
|
storage: storage.clone(),
|
||||||
pending_notification: None,
|
pending_notification: None,
|
||||||
|
pending_write_error: None,
|
||||||
rx,
|
rx,
|
||||||
summary: summary_gen,
|
summary: summary_gen,
|
||||||
registry_title_sync,
|
registry_title_sync,
|
||||||
@@ -3625,3 +3682,120 @@ mod repo_wide_resolution_tests {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[cfg(test)]
|
||||||
|
mod barrier_tests {
|
||||||
|
use super::*;
|
||||||
|
|
||||||
|
fn sampling_client() -> crate::sampling::Client {
|
||||||
|
crate::sampling::Client::new(kigi_sampler::SamplerConfig {
|
||||||
|
api_key: Some("test-key".to_string()),
|
||||||
|
base_url: "http://localhost".to_string(),
|
||||||
|
model: "test".to_string(),
|
||||||
|
max_completion_tokens: None,
|
||||||
|
temperature: None,
|
||||||
|
top_p: None,
|
||||||
|
api_backend: Default::default(),
|
||||||
|
chat_compat: Default::default(),
|
||||||
|
auth_scheme: Default::default(),
|
||||||
|
anthropic_oauth: false,
|
||||||
|
github_copilot: false,
|
||||||
|
openai_codex: false,
|
||||||
|
extra_headers: Default::default(),
|
||||||
|
context_window: 100_000,
|
||||||
|
force_http1: false,
|
||||||
|
max_retries: None,
|
||||||
|
stream_tool_calls: false,
|
||||||
|
idle_timeout_secs: None,
|
||||||
|
reasoning_effort: None,
|
||||||
|
origin_client: None,
|
||||||
|
attribution_callback: None,
|
||||||
|
bearer_resolver: None,
|
||||||
|
supports_backend_search: false,
|
||||||
|
compactions_remaining: None,
|
||||||
|
compaction_at_tokens: None,
|
||||||
|
doom_loop_recovery: None,
|
||||||
|
header_injector: None,
|
||||||
|
})
|
||||||
|
.expect("sampling client should build")
|
||||||
|
}
|
||||||
|
|
||||||
|
async fn barrier(handle: &PersistenceHandle) -> io::Result<()> {
|
||||||
|
let (tx, rx) = tokio::sync::oneshot::channel();
|
||||||
|
handle
|
||||||
|
.tx
|
||||||
|
.send(PersistenceMsg::FlushAndAck { respond_to: tx })
|
||||||
|
.unwrap();
|
||||||
|
rx.await.unwrap()
|
||||||
|
}
|
||||||
|
|
||||||
|
async fn spawn(dir: &std::path::Path) -> (Info, PersistenceHandle) {
|
||||||
|
let info = Info {
|
||||||
|
id: acp::SessionId::new("barrier"),
|
||||||
|
cwd: dir.to_string_lossy().into_owned(),
|
||||||
|
};
|
||||||
|
let handle = new_with_explicit_dir(
|
||||||
|
&info,
|
||||||
|
dir.to_path_buf(),
|
||||||
|
acp::ModelId::new("test-model"),
|
||||||
|
sampling_client(),
|
||||||
|
crate::test_support::TEST_MODEL.to_owned(),
|
||||||
|
)
|
||||||
|
.await
|
||||||
|
.unwrap();
|
||||||
|
(info, handle)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// A chat append that never reached the file fails the next barrier once;
|
||||||
|
/// the barrier after that is clean again.
|
||||||
|
#[tokio::test]
|
||||||
|
async fn flush_and_ack_reports_a_lost_chat_append_once() {
|
||||||
|
let dir = tempfile::tempdir().unwrap();
|
||||||
|
let (info, handle) = spawn(dir.path()).await;
|
||||||
|
barrier(&handle).await.unwrap();
|
||||||
|
|
||||||
|
// A directory where the chat log should be makes the append fail.
|
||||||
|
let chat_file = JsonlStorageAdapter::with_explicit_session_dir(dir.path().to_path_buf())
|
||||||
|
.chat_file(&info);
|
||||||
|
let _ = std::fs::remove_file(&chat_file);
|
||||||
|
std::fs::create_dir(&chat_file).unwrap();
|
||||||
|
handle
|
||||||
|
.tx
|
||||||
|
.send(PersistenceMsg::Chat(ConversationItem::user("lost")))
|
||||||
|
.unwrap();
|
||||||
|
// CopyFile is an ordering fence that keeps the write-failure latch.
|
||||||
|
let (tx, rx) = tokio::sync::oneshot::channel();
|
||||||
|
handle
|
||||||
|
.tx
|
||||||
|
.send(PersistenceMsg::CopyFile { one_shot: tx })
|
||||||
|
.unwrap();
|
||||||
|
let _ = rx.await.unwrap();
|
||||||
|
// With the path restored only the lost append can fail the barrier.
|
||||||
|
std::fs::remove_dir(&chat_file).unwrap();
|
||||||
|
let error = barrier(&handle).await.unwrap_err();
|
||||||
|
assert_ne!(error.kind(), io::ErrorKind::NotFound, "got {error}");
|
||||||
|
|
||||||
|
barrier(&handle).await.unwrap();
|
||||||
|
}
|
||||||
|
|
||||||
|
/// A history rewrite that never landed fails the next barrier.
|
||||||
|
#[tokio::test]
|
||||||
|
async fn flush_and_ack_reports_a_failed_history_replacement() {
|
||||||
|
let dir = tempfile::tempdir().unwrap();
|
||||||
|
let (info, handle) = spawn(dir.path()).await;
|
||||||
|
let chat_file = JsonlStorageAdapter::with_explicit_session_dir(dir.path().to_path_buf())
|
||||||
|
.chat_file(&info);
|
||||||
|
// The rewrite stages a sibling temp file; a directory there fails it.
|
||||||
|
std::fs::create_dir(chat_file.with_extension("jsonl.tmp")).unwrap();
|
||||||
|
handle
|
||||||
|
.tx
|
||||||
|
.send(PersistenceMsg::ReplaceChatHistory(vec![
|
||||||
|
ConversationItem::user("rewritten"),
|
||||||
|
]))
|
||||||
|
.unwrap();
|
||||||
|
let error = barrier(&handle).await.unwrap_err();
|
||||||
|
assert_ne!(error.kind(), io::ErrorKind::NotFound, "got {error}");
|
||||||
|
|
||||||
|
barrier(&handle).await.unwrap();
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -1020,6 +1020,7 @@ pub(super) async fn build_skill_information_for_refs(
|
|||||||
slash_skills: &[SkillInfo],
|
slash_skills: &[SkillInfo],
|
||||||
session_id: &str,
|
session_id: &str,
|
||||||
) -> Option<String> {
|
) -> Option<String> {
|
||||||
|
use kigi_tools::implementations::skills::body_cap::cap_skill_body;
|
||||||
use kigi_tools::implementations::skills::skill::{
|
use kigi_tools::implementations::skills::skill::{
|
||||||
SkillRef, SubstitutionContext, apply_substitutions, build_skill_block,
|
SkillRef, SubstitutionContext, apply_substitutions, build_skill_block,
|
||||||
build_skill_information, load_skill_content,
|
build_skill_information, load_skill_content,
|
||||||
@@ -1034,6 +1035,13 @@ pub(super) async fn build_skill_information_for_refs(
|
|||||||
};
|
};
|
||||||
match load_skill_content(info).await {
|
match load_skill_content(info).await {
|
||||||
Ok(mut content) => {
|
Ok(mut content) => {
|
||||||
|
if cap_skill_body(&mut content) {
|
||||||
|
tracing::info!(
|
||||||
|
skill = %sk.name,
|
||||||
|
path = %info.path,
|
||||||
|
"skill body truncated at read cap"
|
||||||
|
);
|
||||||
|
}
|
||||||
let skill_dir = std::path::Path::new(&info.path)
|
let skill_dir = std::path::Path::new(&info.path)
|
||||||
.parent()
|
.parent()
|
||||||
.and_then(|p| p.to_str());
|
.and_then(|p| p.to_str());
|
||||||
@@ -1465,6 +1473,31 @@ mod tests {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// A 220 KB skill body stops at the read cap; the tail stays on disk.
|
||||||
|
#[tokio::test]
|
||||||
|
async fn build_skill_information_for_refs_caps_an_oversized_body() {
|
||||||
|
let dir = tempfile::tempdir().unwrap();
|
||||||
|
let path = dir.path().join("SKILL.md");
|
||||||
|
let body = (1..=1100)
|
||||||
|
.map(|n| format!("{n:05} {}", "x".repeat(194)))
|
||||||
|
.collect::<Vec<_>>()
|
||||||
|
.join("\n");
|
||||||
|
std::fs::write(&path, &body).unwrap();
|
||||||
|
|
||||||
|
let mut skill = make_skill("big", true);
|
||||||
|
skill.path = path.to_string_lossy().to_string();
|
||||||
|
let skills = vec![skill];
|
||||||
|
|
||||||
|
let parsed =
|
||||||
|
parse_skill_references("/big", &skills, all_gated()).expect("known skill must parse");
|
||||||
|
let info = build_skill_information_for_refs(&parsed, &skills, "sid-1")
|
||||||
|
.await
|
||||||
|
.expect("skill body must load");
|
||||||
|
assert!(info.contains("00001 "), "head must survive");
|
||||||
|
assert!(!info.contains("01100 "), "tail must be cut");
|
||||||
|
assert!(info.contains("Skill body truncated at the 25000-token cap"));
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn resolve_loop_annotates_block_with_compact_display_text() {
|
fn resolve_loop_annotates_block_with_compact_display_text() {
|
||||||
let outcome = resolve(
|
let outcome = resolve(
|
||||||
|
|||||||
@@ -86,7 +86,7 @@ impl JsonlStorageAdapter {
|
|||||||
fn updates_file(&self, info: &Info) -> PathBuf {
|
fn updates_file(&self, info: &Info) -> PathBuf {
|
||||||
self.session_dir(info).join("updates.jsonl")
|
self.session_dir(info).join("updates.jsonl")
|
||||||
}
|
}
|
||||||
fn chat_file(&self, info: &Info) -> PathBuf {
|
pub(crate) fn chat_file(&self, info: &Info) -> PathBuf {
|
||||||
self.session_dir(info).join("chat_history.jsonl")
|
self.session_dir(info).join("chat_history.jsonl")
|
||||||
}
|
}
|
||||||
fn summary_file(&self, info: &Info) -> PathBuf {
|
fn summary_file(&self, info: &Info) -> PathBuf {
|
||||||
@@ -700,7 +700,7 @@ impl JsonlStorageAdapter {
|
|||||||
options: super::CopySessionOptions,
|
options: super::CopySessionOptions,
|
||||||
) -> io::Result<super::CopySessionResult> {
|
) -> io::Result<super::CopySessionResult> {
|
||||||
let target_dir = self.session_dir(target_info);
|
let target_dir = self.session_dir(target_info);
|
||||||
std::fs::create_dir_all(&target_dir)?;
|
super::create_dir_all_durable(&target_dir)?;
|
||||||
let source_summary = self.read_summary_sync(source_info)?;
|
let source_summary = self.read_summary_sync(source_info)?;
|
||||||
let chat_format_version = source_summary.chat_format_version;
|
let chat_format_version = source_summary.chat_format_version;
|
||||||
let mut chat_to_copy: Vec<ConversationItem> =
|
let mut chat_to_copy: Vec<ConversationItem> =
|
||||||
@@ -920,7 +920,7 @@ async fn next_compaction_segment_index(compaction_dir: &std::path::Path) -> u64
|
|||||||
impl StorageAdapter for JsonlStorageAdapter {
|
impl StorageAdapter for JsonlStorageAdapter {
|
||||||
async fn init_session(&self, info: &Info, model_id: acp::ModelId) -> io::Result<Summary> {
|
async fn init_session(&self, info: &Info, model_id: acp::ModelId) -> io::Result<Summary> {
|
||||||
let dir = self.session_dir(info);
|
let dir = self.session_dir(info);
|
||||||
std::fs::create_dir_all(&dir)?;
|
super::create_dir_all_durable(&dir)?;
|
||||||
let summary_path = self.summary_file(info);
|
let summary_path = self.summary_file(info);
|
||||||
if Path::new(&summary_path).exists() {
|
if Path::new(&summary_path).exists() {
|
||||||
tracing::info!("Loading existing session from JSONL");
|
tracing::info!("Loading existing session from JSONL");
|
||||||
@@ -1283,29 +1283,10 @@ impl StorageAdapter for JsonlStorageAdapter {
|
|||||||
.await
|
.await
|
||||||
}
|
}
|
||||||
async fn sync_session_files(&self, info: &Info) -> io::Result<()> {
|
async fn sync_session_files(&self, info: &Info) -> io::Result<()> {
|
||||||
let info_clone = info.clone();
|
let dir = self.session_dir(info);
|
||||||
let adapter_clone = self.clone();
|
tokio::task::spawn_blocking(move || super::sync_tree_durable(&dir))
|
||||||
tokio::task::spawn_blocking(move || -> io::Result<()> {
|
.await
|
||||||
use std::fs::OpenOptions;
|
.map_err(io::Error::other)?
|
||||||
let adapter = adapter_clone;
|
|
||||||
let files_to_sync = [
|
|
||||||
adapter.updates_file(&info_clone),
|
|
||||||
adapter.chat_file(&info_clone),
|
|
||||||
adapter.summary_file(&info_clone),
|
|
||||||
adapter.plan_file(&info_clone),
|
|
||||||
adapter.rewind_points_file(&info_clone),
|
|
||||||
];
|
|
||||||
for file_path in &files_to_sync {
|
|
||||||
if file_path.exists()
|
|
||||||
&& let Ok(file) = OpenOptions::new().write(true).open(file_path)
|
|
||||||
{
|
|
||||||
let _ = file.sync_all();
|
|
||||||
}
|
|
||||||
}
|
|
||||||
Ok(())
|
|
||||||
})
|
|
||||||
.await
|
|
||||||
.map_err(io::Error::other)?
|
|
||||||
}
|
}
|
||||||
async fn replace_chat_history(
|
async fn replace_chat_history(
|
||||||
&self,
|
&self,
|
||||||
|
|||||||
@@ -2794,3 +2794,24 @@ async fn graph_mode_state_round_trips_and_tombstones() {
|
|||||||
let after = adapter.load_session_without_updates(&info).await.unwrap();
|
let after = adapter.load_session_without_updates(&info).await.unwrap();
|
||||||
assert!(after.graph_mode_state.is_none(), "cleared graph must not resurrect");
|
assert!(after.graph_mode_state.is_none(), "cleared graph must not resurrect");
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// The barrier covers nested state files, and an unsyncable one fails it.
|
||||||
|
#[cfg(unix)]
|
||||||
|
#[tokio::test]
|
||||||
|
async fn sync_session_files_reports_a_nested_file_that_cannot_be_synced() {
|
||||||
|
use std::os::unix::fs::PermissionsExt;
|
||||||
|
// Root opens anything; the permission probe is meaningless there.
|
||||||
|
if unsafe { libc::geteuid() } == 0 {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
let dir = TempDir::new().unwrap();
|
||||||
|
let adapter = JsonlStorageAdapter::with_explicit_session_dir(dir.path().to_path_buf());
|
||||||
|
let info = create_test_info();
|
||||||
|
adapter.init_session(&info, default_model_id()).await.unwrap();
|
||||||
|
let nested = adapter.goal_mode_state_file(&info);
|
||||||
|
std::fs::create_dir_all(nested.parent().unwrap()).unwrap();
|
||||||
|
std::fs::write(&nested, b"{}").unwrap();
|
||||||
|
std::fs::set_permissions(&nested, std::fs::Permissions::from_mode(0o000)).unwrap();
|
||||||
|
let error = adapter.sync_session_files(&info).await.unwrap_err();
|
||||||
|
assert_eq!(error.kind(), io::ErrorKind::PermissionDenied, "got {error}");
|
||||||
|
}
|
||||||
@@ -1,5 +1,5 @@
|
|||||||
use async_trait::async_trait;
|
use async_trait::async_trait;
|
||||||
use std::io::{self, BufRead, BufReader, Seek, SeekFrom};
|
use std::io::{self, BufRead, BufReader, Seek, SeekFrom, Write};
|
||||||
use std::path::Path;
|
use std::path::Path;
|
||||||
|
|
||||||
use crate::extensions::notification::SessionNotification;
|
use crate::extensions::notification::SessionNotification;
|
||||||
@@ -15,6 +15,137 @@ use agent_client_protocol as acp;
|
|||||||
use kigi_sampling_types::ReasoningEffort;
|
use kigi_sampling_types::ReasoningEffort;
|
||||||
use kigi_workspace::session::file_state::RewindPoint;
|
use kigi_workspace::session::file_state::RewindPoint;
|
||||||
|
|
||||||
|
/// Fsync `file` to stable media; macOS `fsync` may stop at the drive cache.
|
||||||
|
#[cfg(target_os = "macos")]
|
||||||
|
pub(crate) fn sync_file_durable(file: &std::fs::File) -> io::Result<()> {
|
||||||
|
use std::os::fd::AsRawFd;
|
||||||
|
file.sync_all()?;
|
||||||
|
fullfsync_raw(file.as_raw_fd())
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(target_os = "macos")]
|
||||||
|
fn fullfsync_raw(fd: std::os::fd::RawFd) -> io::Result<()> {
|
||||||
|
// SAFETY: fcntl on a live descriptor with no pointer arguments.
|
||||||
|
if unsafe { libc::fcntl(fd, libc::F_FULLFSYNC) } == -1 {
|
||||||
|
return Err(io::Error::last_os_error());
|
||||||
|
}
|
||||||
|
Ok(())
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(not(target_os = "macos"))]
|
||||||
|
pub(crate) fn sync_file_durable(file: &std::fs::File) -> io::Result<()> {
|
||||||
|
file.sync_all()
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Fsync `dir` so entries just created or renamed into it survive power loss.
|
||||||
|
#[cfg(target_os = "macos")]
|
||||||
|
pub(crate) fn sync_dir_durable(dir: &Path) -> io::Result<()> {
|
||||||
|
use std::os::fd::AsRawFd;
|
||||||
|
let file = std::fs::File::open(dir)?;
|
||||||
|
file.sync_all()?;
|
||||||
|
fullfsync_raw(file.as_raw_fd())
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(all(unix, not(target_os = "macos")))]
|
||||||
|
pub(crate) fn sync_dir_durable(dir: &Path) -> io::Result<()> {
|
||||||
|
std::fs::File::open(dir)?.sync_all()
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Windows has no directory-handle fsync; NTFS journals directory metadata.
|
||||||
|
#[cfg(windows)]
|
||||||
|
pub(crate) fn sync_dir_durable(_dir: &Path) -> io::Result<()> {
|
||||||
|
Ok(())
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Write `bytes` to `tmp`, fsync them, rename over `dest`, fsync the parent:
|
||||||
|
/// a crash never leaves `dest` torn, and the rename never publishes
|
||||||
|
/// unsynced bytes over a synced file.
|
||||||
|
pub(crate) fn write_bytes_atomic(tmp: &Path, dest: &Path, bytes: &[u8]) -> io::Result<()> {
|
||||||
|
let written = std::fs::File::create(tmp).and_then(|mut file| {
|
||||||
|
file.write_all(bytes)?;
|
||||||
|
sync_file_durable(&file)
|
||||||
|
});
|
||||||
|
if let Err(error) = written {
|
||||||
|
let _ = std::fs::remove_file(tmp);
|
||||||
|
return Err(error);
|
||||||
|
}
|
||||||
|
crate::util::fs::replace_file(tmp, dest)?;
|
||||||
|
sync_parent_dir_durable(dest)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn sync_parent_dir_durable(path: &Path) -> io::Result<()> {
|
||||||
|
let parent = path
|
||||||
|
.parent()
|
||||||
|
.ok_or_else(|| io::Error::new(io::ErrorKind::InvalidInput, "path has no parent"))?;
|
||||||
|
sync_dir_durable(parent)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn open_for_sync(path: &Path) -> io::Result<std::fs::File> {
|
||||||
|
let mut options = std::fs::OpenOptions::new();
|
||||||
|
options.read(true);
|
||||||
|
// FlushFileBuffers needs a writable handle; fsync does not.
|
||||||
|
options.write(cfg!(windows));
|
||||||
|
options.open(path)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Fsync every file and directory under `dir`, `dir` included, so all
|
||||||
|
/// session state reaches stable media. A path that vanished is not an error.
|
||||||
|
pub(crate) fn sync_tree_durable(dir: &Path) -> io::Result<()> {
|
||||||
|
let entries = match std::fs::read_dir(dir) {
|
||||||
|
Ok(entries) => entries,
|
||||||
|
Err(error) if error.kind() == io::ErrorKind::NotFound => return Ok(()),
|
||||||
|
Err(error) => return Err(error),
|
||||||
|
};
|
||||||
|
for entry in entries {
|
||||||
|
let entry = entry?;
|
||||||
|
let file_type = match entry.file_type() {
|
||||||
|
Ok(file_type) => file_type,
|
||||||
|
Err(error) if error.kind() == io::ErrorKind::NotFound => continue,
|
||||||
|
Err(error) => return Err(error),
|
||||||
|
};
|
||||||
|
if file_type.is_dir() {
|
||||||
|
sync_tree_durable(&entry.path())?;
|
||||||
|
} else if file_type.is_file() {
|
||||||
|
match open_for_sync(&entry.path()) {
|
||||||
|
Ok(file) => sync_file_durable(&file)?,
|
||||||
|
Err(error) if error.kind() == io::ErrorKind::NotFound => {}
|
||||||
|
Err(error) => return Err(error),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
match sync_dir_durable(dir) {
|
||||||
|
Err(error) if error.kind() == io::ErrorKind::NotFound => Ok(()),
|
||||||
|
result => result,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// `create_dir_all`, then fsync every directory that gained an entry so the
|
||||||
|
/// chain itself survives power loss. A directory that exists but is still
|
||||||
|
/// empty re-syncs a few ancestors: an earlier create may have died before
|
||||||
|
/// its sync.
|
||||||
|
pub(crate) fn create_dir_all_durable(dir: &Path) -> io::Result<()> {
|
||||||
|
let mut gaining_an_entry = Vec::new();
|
||||||
|
let mut cursor = dir;
|
||||||
|
while !cursor.exists() {
|
||||||
|
let Some(parent) = cursor.parent() else { break };
|
||||||
|
gaining_an_entry.push(parent.to_path_buf());
|
||||||
|
cursor = parent;
|
||||||
|
}
|
||||||
|
std::fs::create_dir_all(dir)?;
|
||||||
|
if gaining_an_entry.is_empty() && std::fs::read_dir(dir)?.next().is_none() {
|
||||||
|
gaining_an_entry.extend(dir.ancestors().skip(1).take(4).map(Path::to_path_buf));
|
||||||
|
}
|
||||||
|
for parent in gaining_an_entry.iter().filter(|parent| !is_fs_root(parent)) {
|
||||||
|
sync_dir_durable(parent)?;
|
||||||
|
}
|
||||||
|
Ok(())
|
||||||
|
}
|
||||||
|
|
||||||
|
fn is_fs_root(path: &Path) -> bool {
|
||||||
|
path.parent()
|
||||||
|
.is_none_or(|parent| parent.as_os_str().is_empty())
|
||||||
|
}
|
||||||
|
|
||||||
pub mod jsonl;
|
pub mod jsonl;
|
||||||
pub mod search;
|
pub mod search;
|
||||||
pub mod search_fts;
|
pub mod search_fts;
|
||||||
|
|||||||
@@ -228,12 +228,13 @@ fn read_summary(path: &Path) -> io::Result<Summary> {
|
|||||||
fn write_summary_atomic(summary_path: &Path, summary: &Summary) -> io::Result<()> {
|
fn write_summary_atomic(summary_path: &Path, summary: &Summary) -> io::Result<()> {
|
||||||
let bytes = serde_json::to_vec_pretty(summary)
|
let bytes = serde_json::to_vec_pretty(summary)
|
||||||
.map_err(|e| io::Error::new(io::ErrorKind::InvalidData, e))?;
|
.map_err(|e| io::Error::new(io::ErrorKind::InvalidData, e))?;
|
||||||
let tmp = summary_path.with_extension("json.tmp");
|
// Durable and Windows-safe: this write persists a session's CURRENT MODEL,
|
||||||
std::fs::write(&tmp, &bytes)?;
|
// and other writers (`/rename`) race the persistence barrier on this path.
|
||||||
// Windows-safe replace: this is the write that persists a session's
|
super::write_bytes_atomic(
|
||||||
// CURRENT MODEL — a bare rename made a switched model silently revert
|
&summary_path.with_extension("json.tmp"),
|
||||||
// on resume whenever AV/indexer held summary.json open on Windows.
|
summary_path,
|
||||||
crate::util::fs::replace_file(&tmp, summary_path)
|
&bytes,
|
||||||
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
|
|||||||
@@ -912,7 +912,10 @@ fn spawn_with_argv(
|
|||||||
if kigi_sandbox::should_restrict_child_network() {
|
if kigi_sandbox::should_restrict_child_network() {
|
||||||
// SAFETY: single prctl syscall (async-signal-safe).
|
// SAFETY: single prctl syscall (async-signal-safe).
|
||||||
unsafe {
|
unsafe {
|
||||||
cmd.pre_exec(|| kigi_sandbox::child_net::install_child_network_filter());
|
let filter = kigi_sandbox::child_net::prebuilt_child_network_filter();
|
||||||
|
cmd.pre_exec(move || {
|
||||||
|
kigi_sandbox::child_net::install_child_network_filter(filter)
|
||||||
|
});
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -359,6 +359,7 @@ pub async fn save_mcp_disabled_tools(server_name: &str, disabled_tools: &[String
|
|||||||
}
|
}
|
||||||
|
|
||||||
let toml_str = toml::to_string_pretty(&root)?;
|
let toml_str = toml::to_string_pretty(&root)?;
|
||||||
|
let path = super::config_write_dest(&path)?;
|
||||||
let tmp = path.with_extension("toml.tmp");
|
let tmp = path.with_extension("toml.tmp");
|
||||||
if let Some(parent) = path.parent() {
|
if let Some(parent) = path.parent() {
|
||||||
let _ = tokio::fs::create_dir_all(parent).await;
|
let _ = tokio::fs::create_dir_all(parent).await;
|
||||||
@@ -413,6 +414,7 @@ pub async fn save_mcp_server_enabled(server_name: &str, enabled: bool) -> Result
|
|||||||
}
|
}
|
||||||
|
|
||||||
let toml_str = toml::to_string_pretty(&root)?;
|
let toml_str = toml::to_string_pretty(&root)?;
|
||||||
|
let path = super::config_write_dest(&path)?;
|
||||||
let tmp = path.with_extension("toml.tmp");
|
let tmp = path.with_extension("toml.tmp");
|
||||||
if let Some(parent) = path.parent() {
|
if let Some(parent) = path.parent() {
|
||||||
let _ = tokio::fs::create_dir_all(parent).await;
|
let _ = tokio::fs::create_dir_all(parent).await;
|
||||||
@@ -472,6 +474,7 @@ pub async fn save_mcp_server_config_at(
|
|||||||
}
|
}
|
||||||
|
|
||||||
let toml_str = toml::to_string_pretty(&root)?;
|
let toml_str = toml::to_string_pretty(&root)?;
|
||||||
|
let path = super::config_write_dest(path)?;
|
||||||
let tmp = path.with_extension("toml.tmp");
|
let tmp = path.with_extension("toml.tmp");
|
||||||
if let Some(parent) = path.parent() {
|
if let Some(parent) = path.parent() {
|
||||||
let _ = tokio::fs::create_dir_all(parent).await;
|
let _ = tokio::fs::create_dir_all(parent).await;
|
||||||
@@ -552,6 +555,7 @@ pub async fn delete_mcp_server_config_at(
|
|||||||
}
|
}
|
||||||
|
|
||||||
let toml_str = toml::to_string_pretty(&root)?;
|
let toml_str = toml::to_string_pretty(&root)?;
|
||||||
|
let path = super::config_write_dest(path)?;
|
||||||
let tmp = path.with_extension("toml.tmp");
|
let tmp = path.with_extension("toml.tmp");
|
||||||
if let Some(parent) = path.parent() {
|
if let Some(parent) = path.parent() {
|
||||||
let _ = tokio::fs::create_dir_all(parent).await;
|
let _ = tokio::fs::create_dir_all(parent).await;
|
||||||
|
|||||||
@@ -10,6 +10,7 @@ mod resolve;
|
|||||||
mod settings_writes;
|
mod settings_writes;
|
||||||
mod tips;
|
mod tips;
|
||||||
mod worktree;
|
mod worktree;
|
||||||
|
mod write_dest;
|
||||||
|
|
||||||
pub use campaigns::{
|
pub use campaigns::{
|
||||||
load_effective_config, load_effective_config_disk_only, persist_models_default,
|
load_effective_config, load_effective_config_disk_only, persist_models_default,
|
||||||
@@ -30,3 +31,4 @@ pub use resolve::*;
|
|||||||
pub use settings_writes::*;
|
pub use settings_writes::*;
|
||||||
pub use tips::*;
|
pub use tips::*;
|
||||||
pub use worktree::*;
|
pub use worktree::*;
|
||||||
|
pub(crate) use write_dest::config_write_dest;
|
||||||
@@ -52,6 +52,7 @@ pub async fn save_config(config: &Config) -> Result<()> {
|
|||||||
}
|
}
|
||||||
|
|
||||||
let toml_str = toml::to_string_pretty(&root)?;
|
let toml_str = toml::to_string_pretty(&root)?;
|
||||||
|
let path = super::config_write_dest(&path)?;
|
||||||
if let Some(parent) = path.parent() {
|
if let Some(parent) = path.parent() {
|
||||||
let _ = tokio::fs::create_dir_all(parent).await;
|
let _ = tokio::fs::create_dir_all(parent).await;
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,110 @@
|
|||||||
|
//! Where a config write lands when the path is a symlink.
|
||||||
|
|
||||||
|
use std::io;
|
||||||
|
use std::path::{Path, PathBuf};
|
||||||
|
|
||||||
|
/// The user's own config.toml keeps its symlink; every other path comes back unchanged.
|
||||||
|
pub(crate) fn config_write_dest(path: &Path) -> io::Result<PathBuf> {
|
||||||
|
// With no home, `kigi_home()` is `./.kigi`: the project's own tree, never trusted.
|
||||||
|
let user_config = kigi_config::user_kigi_home().map(|home| home.join("config.toml"));
|
||||||
|
write_dest(path, user_config.as_deref())
|
||||||
|
}
|
||||||
|
|
||||||
|
/// A project config is repo-controlled: following its symlink would overwrite any file it names.
|
||||||
|
fn write_dest(path: &Path, user_config: Option<&Path>) -> io::Result<PathBuf> {
|
||||||
|
if user_config != Some(path) {
|
||||||
|
return Ok(path.to_path_buf());
|
||||||
|
}
|
||||||
|
match std::fs::symlink_metadata(path) {
|
||||||
|
Ok(meta) if meta.file_type().is_symlink() => dunce::canonicalize(path).map_err(|e| {
|
||||||
|
let context = format!("config symlink {} does not resolve: {e}", path.display());
|
||||||
|
io::Error::new(e.kind(), context)
|
||||||
|
}),
|
||||||
|
Ok(_) => Ok(path.to_path_buf()),
|
||||||
|
Err(e) if e.kind() == io::ErrorKind::NotFound => Ok(path.to_path_buf()),
|
||||||
|
Err(e) => Err(e),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(all(test, unix))]
|
||||||
|
mod tests {
|
||||||
|
use super::*;
|
||||||
|
use crate::util::config::{McpServerConfig, save_mcp_server_config_at};
|
||||||
|
|
||||||
|
fn symlinked_config(dir: &Path, referent_content: &str) -> (PathBuf, PathBuf) {
|
||||||
|
let referent = dir.join("dotfiles.toml");
|
||||||
|
std::fs::write(&referent, referent_content).unwrap();
|
||||||
|
let link = dir.join("config.toml");
|
||||||
|
std::os::unix::fs::symlink(&referent, &link).unwrap();
|
||||||
|
(link, referent)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn user_config_symlink_resolves_to_its_referent() {
|
||||||
|
let dir = tempfile::tempdir().unwrap();
|
||||||
|
let (link, referent) = symlinked_config(dir.path(), "");
|
||||||
|
|
||||||
|
let dest = write_dest(&link, Some(&link)).unwrap();
|
||||||
|
assert_eq!(dest, dunce::canonicalize(&referent).unwrap());
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn regular_and_missing_user_config_keep_their_path() {
|
||||||
|
let dir = tempfile::tempdir().unwrap();
|
||||||
|
let regular = dir.path().join("config.toml");
|
||||||
|
std::fs::write(®ular, "").unwrap();
|
||||||
|
let missing = dir.path().join("absent.toml");
|
||||||
|
|
||||||
|
assert_eq!(write_dest(®ular, Some(®ular)).unwrap(), regular);
|
||||||
|
assert_eq!(write_dest(&missing, Some(&missing)).unwrap(), missing);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn dangling_user_config_symlink_is_an_error_not_a_clobber() {
|
||||||
|
let dir = tempfile::tempdir().unwrap();
|
||||||
|
let link = dir.path().join("config.toml");
|
||||||
|
std::os::unix::fs::symlink(dir.path().join("gone.toml"), &link).unwrap();
|
||||||
|
|
||||||
|
let err = write_dest(&link, Some(&link)).unwrap_err();
|
||||||
|
assert_eq!(err.kind(), io::ErrorKind::NotFound);
|
||||||
|
assert!(err.to_string().contains("does not resolve"), "{err}");
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn project_config_symlink_is_never_followed() {
|
||||||
|
let dir = tempfile::tempdir().unwrap();
|
||||||
|
let (link, _referent) = symlinked_config(dir.path(), "");
|
||||||
|
let user_config = dir.path().join("home").join("config.toml");
|
||||||
|
|
||||||
|
assert_eq!(write_dest(&link, Some(&user_config)).unwrap(), link);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn nothing_is_followed_when_no_user_home_resolves() {
|
||||||
|
let dir = tempfile::tempdir().unwrap();
|
||||||
|
let (link, _referent) = symlinked_config(dir.path(), "");
|
||||||
|
|
||||||
|
assert_eq!(write_dest(&link, None).unwrap(), link);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[tokio::test]
|
||||||
|
async fn project_scope_save_replaces_the_link_and_spares_its_target() {
|
||||||
|
let dir = tempfile::tempdir().unwrap();
|
||||||
|
let (link, target) = symlinked_config(dir.path(), "victim = true\n");
|
||||||
|
|
||||||
|
let server: McpServerConfig =
|
||||||
|
toml::from_str("command = \"echo\"\nargs = [\"hi\"]\n").unwrap();
|
||||||
|
save_mcp_server_config_at(&link, "demo", &server)
|
||||||
|
.await
|
||||||
|
.unwrap();
|
||||||
|
|
||||||
|
let meta = std::fs::symlink_metadata(&link).unwrap();
|
||||||
|
assert!(
|
||||||
|
meta.file_type().is_file(),
|
||||||
|
"the link is replaced, not followed"
|
||||||
|
);
|
||||||
|
assert_eq!(std::fs::read_to_string(&target).unwrap(), "victim = true\n");
|
||||||
|
let saved = std::fs::read_to_string(&link).unwrap();
|
||||||
|
assert!(saved.contains("[mcp_servers.demo]"), "{saved}");
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,35 @@
|
|||||||
|
//! A symlinked `~/.kigi/config.toml` survives a save: the write lands on the referent.
|
||||||
|
#![cfg(unix)]
|
||||||
|
|
||||||
|
use kigi_shell::util::config::{McpServerConfig, save_mcp_server_config};
|
||||||
|
|
||||||
|
#[tokio::test]
|
||||||
|
async fn user_config_symlink_survives_a_save() {
|
||||||
|
let home = tempfile::tempdir().unwrap();
|
||||||
|
let dotfiles = tempfile::tempdir().unwrap();
|
||||||
|
// SAFETY: the only test in this binary; set before `kigi_home()` first runs.
|
||||||
|
unsafe { std::env::set_var("KIGI_SHARE_DIR", home.path()) };
|
||||||
|
|
||||||
|
let referent = dotfiles.path().join("kigi.toml");
|
||||||
|
std::fs::write(&referent, "[ui]\ntheme = \"dark\"\n").unwrap();
|
||||||
|
let link = home.path().join("config.toml");
|
||||||
|
std::os::unix::fs::symlink(&referent, &link).unwrap();
|
||||||
|
|
||||||
|
let server: McpServerConfig = toml::from_str("command = \"echo\"\nargs = [\"hi\"]\n").unwrap();
|
||||||
|
save_mcp_server_config("demo", &server).await.unwrap();
|
||||||
|
|
||||||
|
let meta = std::fs::symlink_metadata(&link).unwrap();
|
||||||
|
assert!(meta.file_type().is_symlink(), "the link must survive");
|
||||||
|
let saved = std::fs::read_to_string(&referent).unwrap();
|
||||||
|
assert!(saved.contains("[mcp_servers.demo]"), "{saved}");
|
||||||
|
assert!(saved.contains("theme = \"dark\""), "{saved}");
|
||||||
|
let leftovers: Vec<_> = std::fs::read_dir(home.path())
|
||||||
|
.unwrap()
|
||||||
|
.map(|entry| entry.unwrap().file_name())
|
||||||
|
.filter(|name| name != "config.toml")
|
||||||
|
.collect();
|
||||||
|
assert!(
|
||||||
|
leftovers.is_empty(),
|
||||||
|
"no tmp beside the link: {leftovers:?}"
|
||||||
|
);
|
||||||
|
}
|
||||||
@@ -161,6 +161,9 @@ async fn request(handle: &PermissionHandle, access: AccessKind, id: &str) -> Dec
|
|||||||
session_id: None,
|
session_id: None,
|
||||||
subagent_type: None,
|
subagent_type: None,
|
||||||
subagent_description: None,
|
subagent_description: None,
|
||||||
|
// The accesses here carry no file path; the process cwd is a real cwd.
|
||||||
|
tool_cwd: AbsPathBuf::new(std::env::current_dir().unwrap()).unwrap(),
|
||||||
|
display_cwd: None,
|
||||||
};
|
};
|
||||||
let PermissionHandle::Actor { cmd_tx, .. } = handle else {
|
let PermissionHandle::Actor { cmd_tx, .. } = handle else {
|
||||||
panic!("expected actor handle");
|
panic!("expected actor handle");
|
||||||
|
|||||||
@@ -144,7 +144,7 @@ impl LeaderStdioClient {
|
|||||||
.env("KIGI_TRACE_UPLOAD", "false")
|
.env("KIGI_TRACE_UPLOAD", "false")
|
||||||
.env("KIGI_INSTRUMENTATION", "disabled")
|
.env("KIGI_INSTRUMENTATION", "disabled")
|
||||||
// Inherited by the spawned leader, whose stderr goes to
|
// Inherited by the spawned leader, whose stderr goes to
|
||||||
// ~/.kigi/leader.log — keep it chatty for diagnosis.
|
// ~/.kigi/logs/leader.log — keep it chatty for diagnosis.
|
||||||
.env("RUST_LOG", "kigi_shell=debug");
|
.env("RUST_LOG", "kigi_shell=debug");
|
||||||
|
|
||||||
let (mut child, stderr) = spawn_piped_with_stderr_capture(cmd);
|
let (mut child, stderr) = spawn_piped_with_stderr_capture(cmd);
|
||||||
@@ -345,5 +345,5 @@ pub async fn wait_for_replay_notifications(
|
|||||||
}
|
}
|
||||||
|
|
||||||
pub fn leader_log(home: &Path) -> String {
|
pub fn leader_log(home: &Path) -> String {
|
||||||
std::fs::read_to_string(home.join(".kigi").join("leader.log")).unwrap_or_default()
|
std::fs::read_to_string(home.join(".kigi").join("logs").join("leader.log")).unwrap_or_default()
|
||||||
}
|
}
|
||||||
@@ -634,7 +634,8 @@ impl LocalTerminalActor {
|
|||||||
#[cfg(target_os = "linux")]
|
#[cfg(target_os = "linux")]
|
||||||
if kigi_sandbox::should_restrict_child_network() {
|
if kigi_sandbox::should_restrict_child_network() {
|
||||||
unsafe {
|
unsafe {
|
||||||
cmd.pre_exec(|| kigi_sandbox::child_net::install_child_network_filter());
|
let filter = kigi_sandbox::child_net::prebuilt_child_network_filter();
|
||||||
|
cmd.pre_exec(move || kigi_sandbox::child_net::install_child_network_filter(filter));
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -2646,7 +2647,8 @@ fn spawn_shell_command(
|
|||||||
#[cfg(target_os = "linux")]
|
#[cfg(target_os = "linux")]
|
||||||
if kigi_sandbox::should_restrict_child_network() {
|
if kigi_sandbox::should_restrict_child_network() {
|
||||||
unsafe {
|
unsafe {
|
||||||
cmd.pre_exec(|| kigi_sandbox::child_net::install_child_network_filter());
|
let filter = kigi_sandbox::child_net::prebuilt_child_network_filter();
|
||||||
|
cmd.pre_exec(move || kigi_sandbox::child_net::install_child_network_filter(filter));
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
cmd
|
cmd
|
||||||
|
|||||||
@@ -46,6 +46,12 @@ impl ReadFileVersion {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
pub(crate) const MAX_NUM_TOKENS: usize = 25_000;
|
pub(crate) const MAX_NUM_TOKENS: usize = 25_000;
|
||||||
|
pub(crate) const MAX_NUM_BYTES: usize =
|
||||||
|
MAX_NUM_TOKENS * kigi_token_estimation::BYTES_PER_TOKEN as usize;
|
||||||
|
/// True when `text` is over the per-call token cap.
|
||||||
|
pub(crate) fn exceeds_read_cap(text: &str) -> bool {
|
||||||
|
crate::util::truncate::estimate_tokens(text) > MAX_NUM_TOKENS
|
||||||
|
}
|
||||||
pub const MAX_LINES_READ: usize = 1_000;
|
pub const MAX_LINES_READ: usize = 1_000;
|
||||||
pub use crate::implementations::read_file::{
|
pub use crate::implementations::read_file::{
|
||||||
FileMetadata, PDF_MAX_PAGES_PER_READ, bytes_to_metadata, parse_page_range,
|
FileMetadata, PDF_MAX_PAGES_PER_READ, bytes_to_metadata, parse_page_range,
|
||||||
@@ -434,22 +440,25 @@ pub(crate) async fn run_read_file(
|
|||||||
.map(|t| t.0.max_lines_read())
|
.map(|t| t.0.max_lines_read())
|
||||||
.unwrap_or_else(|| TruncationConfig::default().max_lines_read())
|
.unwrap_or_else(|| TruncationConfig::default().max_lines_read())
|
||||||
};
|
};
|
||||||
let (effective_offset, effective_limit) = if is_skill_file {
|
// A skill file under the cap comes back whole; over it, it reads like any other file.
|
||||||
(None, None)
|
let skill_full = is_skill_file
|
||||||
} else {
|
.then(|| extract_file_content_lines(&file_content, None, None, total_lines))
|
||||||
(
|
.filter(|full| !exceeds_read_cap(&full.content));
|
||||||
input.offset,
|
let (extracted, stored_offset, stored_limit) = match skill_full {
|
||||||
Some(input.limit.unwrap_or(usize::MAX).min(max_lines)),
|
Some(full) => (full, None, None),
|
||||||
)
|
None => (
|
||||||
|
extract_file_content_lines(
|
||||||
|
&file_content,
|
||||||
|
input.offset,
|
||||||
|
Some(input.limit.unwrap_or(usize::MAX).min(max_lines)),
|
||||||
|
total_lines,
|
||||||
|
),
|
||||||
|
stored_read_offset(input.offset),
|
||||||
|
input.limit,
|
||||||
|
),
|
||||||
};
|
};
|
||||||
let extracted = extract_file_content_lines(
|
if exceeds_read_cap(&extracted.content) {
|
||||||
&file_content,
|
let token_count = crate::util::truncate::estimate_tokens(&extracted.content);
|
||||||
effective_offset,
|
|
||||||
effective_limit,
|
|
||||||
total_lines,
|
|
||||||
);
|
|
||||||
let token_count = crate::util::truncate::estimate_tokens(&extracted.content);
|
|
||||||
if !is_skill_file && token_count > MAX_NUM_TOKENS {
|
|
||||||
let (grep_name, execute_name);
|
let (grep_name, execute_name);
|
||||||
{
|
{
|
||||||
let res = resources.lock().await;
|
let res = resources.lock().await;
|
||||||
@@ -497,11 +506,6 @@ pub(crate) async fn run_read_file(
|
|||||||
};
|
};
|
||||||
return Ok(ReadFileOutput::FileTooLarge(msg));
|
return Ok(ReadFileOutput::FileTooLarge(msg));
|
||||||
}
|
}
|
||||||
let (stored_offset, stored_limit) = if is_skill_file {
|
|
||||||
(None, None)
|
|
||||||
} else {
|
|
||||||
(stored_read_offset(input.offset), input.limit)
|
|
||||||
};
|
|
||||||
if let Some(flag) = streamable_out {
|
if let Some(flag) = streamable_out {
|
||||||
*flag = true;
|
*flag = true;
|
||||||
}
|
}
|
||||||
@@ -1660,9 +1664,8 @@ pub fn verify(req: &HttpRequest) -> Result<Claims, Error> {
|
|||||||
other => panic!("Expected FileContent, got {:?}", other),
|
other => panic!("Expected FileContent, got {:?}", other),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
#[tokio::test]
|
/// 1100 lines of 200 bytes: about 55k tokens, over the 25k cap.
|
||||||
async fn skill_file_skips_token_limit() {
|
fn write_oversized_skill(tmp: &TempDir) {
|
||||||
let tmp = TempDir::new().unwrap();
|
|
||||||
let line = "x".repeat(200);
|
let line = "x".repeat(200);
|
||||||
let big_content = std::iter::repeat_n(line.as_str(), 1100)
|
let big_content = std::iter::repeat_n(line.as_str(), 1100)
|
||||||
.collect::<Vec<_>>()
|
.collect::<Vec<_>>()
|
||||||
@@ -1670,6 +1673,11 @@ pub fn verify(req: &HttpRequest) -> Result<Claims, Error> {
|
|||||||
let skill_dir = tmp.path().join("skills");
|
let skill_dir = tmp.path().join("skills");
|
||||||
std::fs::create_dir_all(&skill_dir).unwrap();
|
std::fs::create_dir_all(&skill_dir).unwrap();
|
||||||
std::fs::write(skill_dir.join("SKILL.md"), &big_content).unwrap();
|
std::fs::write(skill_dir.join("SKILL.md"), &big_content).unwrap();
|
||||||
|
}
|
||||||
|
#[tokio::test]
|
||||||
|
async fn skill_file_over_cap_returns_file_too_large() {
|
||||||
|
let tmp = TempDir::new().unwrap();
|
||||||
|
write_oversized_skill(&tmp);
|
||||||
let tool = ReadFileTool;
|
let tool = ReadFileTool;
|
||||||
let mut resources = test_resources(tmp.path());
|
let mut resources = test_resources(tmp.path());
|
||||||
resources.insert(TemplateRenderer::new(
|
resources.insert(TemplateRenderer::new(
|
||||||
@@ -1687,11 +1695,36 @@ pub fn verify(req: &HttpRequest) -> Result<Claims, Error> {
|
|||||||
.await
|
.await
|
||||||
.unwrap();
|
.unwrap();
|
||||||
assert!(
|
assert!(
|
||||||
matches!(result, ReadFileOutput::FileContent(_)),
|
matches!(result, ReadFileOutput::FileTooLarge(_)),
|
||||||
"SKILL.md should not be truncated, got {:?}",
|
"got {:?}",
|
||||||
std::mem::discriminant(&result),
|
std::mem::discriminant(&result),
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
#[tokio::test]
|
||||||
|
async fn skill_file_over_cap_honors_offset_and_limit() {
|
||||||
|
let tmp = TempDir::new().unwrap();
|
||||||
|
write_oversized_skill(&tmp);
|
||||||
|
let tool = ReadFileTool;
|
||||||
|
let resources = test_resources(tmp.path());
|
||||||
|
let input = ReadFileInput {
|
||||||
|
path: "skills/SKILL.md".to_string(),
|
||||||
|
offset: Some(3),
|
||||||
|
limit: Some(2),
|
||||||
|
pages: None,
|
||||||
|
format: None,
|
||||||
|
};
|
||||||
|
let result = kigi_tool_runtime::Tool::run(&tool, test_ctx(resources.into_shared()), input)
|
||||||
|
.await
|
||||||
|
.unwrap();
|
||||||
|
match result {
|
||||||
|
ReadFileOutput::FileContent(fc) => {
|
||||||
|
assert_eq!((Some(3), Some(2)), (fc.offset, fc.limit));
|
||||||
|
let line = "x".repeat(200);
|
||||||
|
assert_eq!(format!("3→{line}\n{line}"), fc.content);
|
||||||
|
}
|
||||||
|
other => panic!("Expected FileContent, got {:?}", other),
|
||||||
|
}
|
||||||
|
}
|
||||||
#[test]
|
#[test]
|
||||||
fn parse_single_page() {
|
fn parse_single_page() {
|
||||||
assert_eq!(parse_page_range("3", 10).unwrap(), vec![2]);
|
assert_eq!(parse_page_range("3", 10).unwrap(), vec![2]);
|
||||||
|
|||||||
@@ -6,6 +6,7 @@
|
|||||||
|
|
||||||
use std::path::Path;
|
use std::path::Path;
|
||||||
|
|
||||||
|
use crate::implementations::skills::body_cap::cap_skill_body;
|
||||||
use crate::implementations::skills::skill::{SkillOutput, extract_skill_body, format_skill_name};
|
use crate::implementations::skills::skill::{SkillOutput, extract_skill_body, format_skill_name};
|
||||||
use crate::implementations::skills::types::SkillInfo;
|
use crate::implementations::skills::types::SkillInfo;
|
||||||
use crate::types::requirements::{Expr, ToolRequirement};
|
use crate::types::requirements::{Expr, ToolRequirement};
|
||||||
@@ -279,7 +280,7 @@ impl kigi_tool_runtime::Tool for SkillTool {
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
let content = match load_skill_content(&skill).await {
|
let mut content = match load_skill_content(&skill).await {
|
||||||
Ok(c) => c,
|
Ok(c) => c,
|
||||||
Err(e) => {
|
Err(e) => {
|
||||||
return Ok(SkillOutput {
|
return Ok(SkillOutput {
|
||||||
@@ -292,6 +293,14 @@ impl kigi_tool_runtime::Tool for SkillTool {
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
|
if cap_skill_body(&mut content) {
|
||||||
|
tracing::info!(
|
||||||
|
skill = %skill.name,
|
||||||
|
path = %skill.path,
|
||||||
|
"skill body truncated at read cap"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
let files = list_skill_files(&skill, 10).await;
|
let files = list_skill_files(&skill, 10).await;
|
||||||
|
|
||||||
let output = format_output(&skill, &content, &files);
|
let output = format_output(&skill, &content, &files);
|
||||||
|
|||||||
@@ -0,0 +1,59 @@
|
|||||||
|
//! Cap an injected skill body at the file-read token cap.
|
||||||
|
|
||||||
|
use crate::implementations::kigi::read_file::{MAX_NUM_BYTES, MAX_NUM_TOKENS, exceeds_read_cap};
|
||||||
|
use crate::util::truncate::floor_char_boundary;
|
||||||
|
|
||||||
|
/// Cuts `body` on a line boundary under the read cap and appends a note; true when it cut.
|
||||||
|
pub fn cap_skill_body(body: &mut String) -> bool {
|
||||||
|
if !exceeds_read_cap(body) {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
let note = format!(
|
||||||
|
"[Skill body truncated at the {MAX_NUM_TOKENS}-token cap. Read the rest of the \
|
||||||
|
skill file with the file read tool using a line offset and limit.]"
|
||||||
|
);
|
||||||
|
let budget = MAX_NUM_BYTES.saturating_sub(note.len() + 2);
|
||||||
|
let end = floor_char_boundary(body, budget);
|
||||||
|
let cut = body[..end].rfind('\n').filter(|&i| i > 0).unwrap_or(end);
|
||||||
|
body.truncate(cut);
|
||||||
|
body.push_str("\n\n");
|
||||||
|
body.push_str(¬e);
|
||||||
|
true
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(test)]
|
||||||
|
mod tests {
|
||||||
|
use super::*;
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn leaves_body_under_cap_untouched() {
|
||||||
|
let mut body = "# Small skill\n\nDo the thing.".to_owned();
|
||||||
|
assert!(!cap_skill_body(&mut body));
|
||||||
|
assert_eq!("# Small skill\n\nDo the thing.", body);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn cuts_on_line_boundary_under_cap() {
|
||||||
|
let mut body = (1..=1100)
|
||||||
|
.map(|n| format!("{n:05} {}", "x".repeat(194)))
|
||||||
|
.collect::<Vec<_>>()
|
||||||
|
.join("\n");
|
||||||
|
|
||||||
|
assert!(cap_skill_body(&mut body));
|
||||||
|
assert!(!exceeds_read_cap(&body));
|
||||||
|
assert!(!body.contains("01100 "));
|
||||||
|
assert!(body.contains("offset"));
|
||||||
|
let (head, _note) = body.rsplit_once("\n\n").expect("note separator");
|
||||||
|
let last_line = head.rsplit('\n').next().expect("head has a line");
|
||||||
|
assert_eq!(200, last_line.len());
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn single_long_line_falls_back_to_char_cut() {
|
||||||
|
let mut body = "é".repeat(60_000);
|
||||||
|
|
||||||
|
assert!(cap_skill_body(&mut body));
|
||||||
|
assert!(!exceeds_read_cap(&body));
|
||||||
|
assert!(body.starts_with("éé"));
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -1,3 +1,4 @@
|
|||||||
|
pub mod body_cap;
|
||||||
pub mod discovery;
|
pub mod discovery;
|
||||||
pub mod skill;
|
pub mod skill;
|
||||||
pub mod types;
|
pub mod types;
|
||||||
@@ -8,8 +8,8 @@ const MAX_LINES_READ_DEFAULT: usize = 1_000;
|
|||||||
/// There is deliberately no per-line cap: clipping long lines silently
|
/// There is deliberately no per-line cap: clipping long lines silently
|
||||||
/// corrupts single-line files (minified JSON, data dumps) with no way for
|
/// corrupts single-line files (minified JSON, data dumps) with no way for
|
||||||
/// the model to recover the clipped bytes. Non-skill reads are bounded by
|
/// the model to recover the clipped bytes. Non-skill reads are bounded by
|
||||||
/// the whole-read `MAX_NUM_TOKENS` cap instead (skill files are exempt from
|
/// the whole-read `MAX_NUM_TOKENS` cap instead (a skill file under that cap
|
||||||
/// all read limits by design). Other agent CLIs likewise apply no
|
/// comes back whole, offset and limit ignored). Other agent CLIs likewise apply no
|
||||||
/// per-line cap. The wire field (`TruncationConfig.max_chars_per_line` in
|
/// per-line cap. The wire field (`TruncationConfig.max_chars_per_line` in
|
||||||
/// kigi-tools.proto) is deprecated and ignored.
|
/// kigi-tools.proto) is deprecated and ignored.
|
||||||
#[derive(Debug, Clone, Default)]
|
#[derive(Debug, Clone, Default)]
|
||||||
|
|||||||
@@ -585,6 +585,19 @@ pub fn dup_tui_stderr() -> io::Result<std::fs::File> {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Point fd 2 at `/dev/null` for the rest of the process: the terminal stopped reading, so any further stderr write would block.
|
||||||
|
pub fn silence_native_stderr() {
|
||||||
|
#[cfg(unix)]
|
||||||
|
{
|
||||||
|
use std::os::unix::io::AsRawFd;
|
||||||
|
let Ok(devnull) = std::fs::OpenOptions::new().write(true).open("/dev/null") else {
|
||||||
|
return;
|
||||||
|
};
|
||||||
|
// SAFETY: devnull is a valid descriptor; fd 2 is a valid target.
|
||||||
|
unsafe { libc::dup2(devnull.as_raw_fd(), 2) };
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
/// Restore fd 2 to point to the real terminal stderr.
|
/// Restore fd 2 to point to the real terminal stderr.
|
||||||
///
|
///
|
||||||
/// Call this before exiting so that any final messages (panic output,
|
/// Call this before exiting so that any final messages (panic output,
|
||||||
|
|||||||
@@ -15,7 +15,7 @@ kigi --sandbox workspace
|
|||||||
# Read-only mode (read everywhere, write only to ~/.kigi/ + temp dirs)
|
# Read-only mode (read everywhere, write only to ~/.kigi/ + temp dirs)
|
||||||
kigi --sandbox read-only
|
kigi --sandbox read-only
|
||||||
|
|
||||||
# Most restrictive profile (read CWD + system paths, write CWD + temp dirs + ~/.kigi/, no child network)
|
# Most restrictive profile (read CWD + system paths, write CWD + temp dirs + ~/.kigi/ state dirs, no child network)
|
||||||
kigi --sandbox strict
|
kigi --sandbox strict
|
||||||
```
|
```
|
||||||
|
|
||||||
@@ -29,10 +29,12 @@ kigi --sandbox strict
|
|||||||
| `workspace` | Everywhere | CWD + `~/.kigi/` + `/tmp` + `/var/tmp` | Allowed | Normal development |
|
| `workspace` | Everywhere | CWD + `~/.kigi/` + `/tmp` + `/var/tmp` | Allowed | Normal development |
|
||||||
| `devbox` | Everywhere | All top-level dirs except `/data` | Allowed | Disposable dev VMs |
|
| `devbox` | Everywhere | All top-level dirs except `/data` | Allowed | Disposable dev VMs |
|
||||||
| `read-only` | Everywhere | `~/.kigi/` + `/tmp` + `/var/tmp` | Blocked¹ | Exploration, code review |
|
| `read-only` | Everywhere | `~/.kigi/` + `/tmp` + `/var/tmp` | Blocked¹ | Exploration, code review |
|
||||||
| `strict` | CWD + system paths | CWD + `~/.kigi/` + `/tmp` + `/var/tmp` | Blocked¹ | Untrusted code |
|
| `strict` | CWD + system paths | CWD + `/tmp` + `/var/tmp` + `~/.kigi/` state dirs² | Blocked¹ | Untrusted code |
|
||||||
|
|
||||||
¹ Child-network blocking is enforced on **Linux only** (via seccomp). On macOS it is a no-op — these profiles do not restrict child-process network there.
|
¹ Child-network blocking is enforced on **Linux only** (via seccomp). On macOS it is a no-op — these profiles do not restrict child-process network there.
|
||||||
|
|
||||||
|
² `run`, `sessions`, `worktrees`, `worktree_pool`, `tasks`, `memory`, `logs`, `debug`, `crash`, `memtrace`, `trace-exports`. The rest of `~/.kigi/` (`config.toml`, `auth.json`, `sandbox.toml`, `hooks/`, `bin/`, `vendor/`) is read-only, so a sandboxed command cannot change the next launch. Root-level caches (`version.json`, `slash-mru.json`, `pager.toml` settings) are not written under `strict`.
|
||||||
|
|
||||||
To block specific files (e.g. `.env` or credential paths) on top of a profile, define a [custom profile](#custom-profiles) with a `deny` list — it is kernel-enforced (read + write/rename) and supports glob patterns like `**/*.pem`.
|
To block specific files (e.g. `.env` or credential paths) on top of a profile, define a [custom profile](#custom-profiles) with a `deny` list — it is kernel-enforced (read + write/rename) and supports glob patterns like `**/*.pem`.
|
||||||
|
|
||||||
### Profile Details
|
### Profile Details
|
||||||
@@ -43,7 +45,7 @@ To block specific files (e.g. `.env` or credential paths) on top of a profile, d
|
|||||||
|
|
||||||
**read-only** -- Use when you want the agent to analyze code without modifying your project files. The agent can read everything but can only write to `~/.kigi/` (needed for session persistence) and temp directories. Child-process network access is blocked on Linux (no-op on macOS).
|
**read-only** -- Use when you want the agent to analyze code without modifying your project files. The agent can read everything but can only write to `~/.kigi/` (needed for session persistence) and temp directories. Child-process network access is blocked on Linux (no-op on macOS).
|
||||||
|
|
||||||
**strict** -- The most restrictive profile, for reviewing untrusted code. The agent can only read files within the current working directory and essential system paths. Writes are limited to CWD, `~/.kigi/`, and temp directories. Child-process network access is blocked on Linux (no-op on macOS).
|
**strict** -- The most restrictive profile, for reviewing untrusted code. The agent can only read files within the current working directory, essential system paths, and `~/.kigi/`. Writes are limited to CWD, the `~/.kigi/` state directories (sessions, worktrees, memory, logs), and temp directories; `config.toml`, `auth.json`, `hooks/` and `bin/` stay read-only. Child-process network access is blocked on Linux (no-op on macOS).
|
||||||
|
|
||||||
---
|
---
|
||||||
|
|
||||||
@@ -193,7 +195,7 @@ In practice, on Linux this means:
|
|||||||
|
|
||||||
## Event Logging
|
## Event Logging
|
||||||
|
|
||||||
Sandbox events are logged to `~/.kigi/sandbox-events.jsonl` for debugging. Events include:
|
Sandbox events are logged to `~/.kigi/sessions/sandbox-events.jsonl` for debugging. Events include:
|
||||||
|
|
||||||
- Profile applied (which profile, timestamp)
|
- Profile applied (which profile, timestamp)
|
||||||
- Violations (attempted access to denied paths)
|
- Violations (attempted access to denied paths)
|
||||||
|
|||||||
@@ -270,10 +270,10 @@ Path patterns are globs matched against the path string the tool was called with
|
|||||||
- `*` and `?` do not cross `/`; `**` does. `Read(src/*)` matches `src/main.rs` but not `src/nested/mod.rs`; use `Read(src/**)` for the whole tree.
|
- `*` and `?` do not cross `/`; `**` does. `Read(src/*)` matches `src/main.rs` but not `src/nested/mod.rs`; use `Read(src/**)` for the whole tree.
|
||||||
- A bare filename matches only that exact string. Use `**/.env` to match `.env` at any depth.
|
- A bare filename matches only that exact string. Use `**/.env` to match `.env` at any depth.
|
||||||
- There are no anchor prefixes: a leading `//` or `~/` in a pattern is treated as literal glob text. Write absolute-path patterns or `**/` patterns instead.
|
- There are no anchor prefixes: a leading `//` or `~/` in a pattern is treated as literal glob text. Write absolute-path patterns or `**/` patterns instead.
|
||||||
- Paths are matched as given, without canonicalization. Whether a path is absolute or relative depends on how the tool was invoked, so patterns intended as boundaries should cover both forms (for example both `/repo/secrets/**` and `secrets/**`).
|
- Allow rules match the path as the tool was called with it. Deny and ask rules are also checked against the file the tool will open: the path is resolved against the session directory, symlinks are followed, and the absolute and the workspace-relative spelling (with or without a leading `./`) are matched. `secrets/**` therefore catches a read of `/repo/secrets/key` and a read through a symlink that points into `secrets/`. A symlink that cannot be resolved (a loop) prompts when any deny or ask rule covers the tool.
|
||||||
- `Read` rules also govern `grep` searches; `Grep(...)` rules match only grep.
|
- `Read` rules also govern `grep` searches; `Grep(...)` rules match only grep.
|
||||||
|
|
||||||
`Read` and `Edit` deny rules additionally apply to file paths that shell commands touch (for example `cat` or `sed` on a denied path), and that shell-level check resolves symlinks. The direct `read_file`/`search_replace` tool checks do not resolve symlinks. For OS-level enforcement that covers every process, combine deny rules with the sandbox ([18-sandbox.md](18-sandbox.md)).
|
`Read` and `Edit` deny rules additionally apply to file paths that shell commands touch (for example `cat` or `sed` on a denied path), and that shell-level check resolves symlinks too. For OS-level enforcement that covers every process, combine deny rules with the sandbox ([18-sandbox.md](18-sandbox.md)).
|
||||||
|
|
||||||
### MCP Rules
|
### MCP Rules
|
||||||
|
|
||||||
|
|||||||
@@ -45,6 +45,14 @@ pub(super) fn refresh_context_used(view: &mut AgentView, used: u64) {
|
|||||||
let total = view.session.models.get_context_window().unwrap_or(0);
|
let total = view.session.models.get_context_window().unwrap_or(0);
|
||||||
view.apply_context_used(used, total);
|
view.apply_context_used(used, total);
|
||||||
}
|
}
|
||||||
|
/// The count a compaction lifecycle update carries for the context bar: the banner's "N% full" must not sit next to a stale pre-turn number.
|
||||||
|
pub(super) fn compaction_context_refresh(update: &XaiSessionUpdate) -> Option<u64> {
|
||||||
|
match update {
|
||||||
|
XaiSessionUpdate::AutoCompactStarted { tokens_used, .. } => Some(*tokens_used),
|
||||||
|
XaiSessionUpdate::AutoCompactCompleted { tokens_after, .. } => Some(*tokens_after),
|
||||||
|
_ => None,
|
||||||
|
}
|
||||||
|
}
|
||||||
/// Refresh the bar and record `used` as the confirmed count for a pending
|
/// Refresh the bar and record `used` as the confirmed count for a pending
|
||||||
/// compaction message; call only from the `meta.totalTokens` path.
|
/// compaction message; call only from the `meta.totalTokens` path.
|
||||||
pub(super) fn confirm_context_used(view: &mut AgentView, used: u64) {
|
pub(super) fn confirm_context_used(view: &mut AgentView, used: u64) {
|
||||||
@@ -197,8 +205,10 @@ pub(super) fn handle_session_notification(notif: &acp::ExtNotification, app: &mu
|
|||||||
&mut agent.scrollback,
|
&mut agent.scrollback,
|
||||||
is_api_key_auth,
|
is_api_key_auth,
|
||||||
);
|
);
|
||||||
if let XaiSessionUpdate::AutoCompactCompleted { tokens_after, .. } = update {
|
if let Some(used) = compaction_context_refresh(update) {
|
||||||
refresh_context_used(agent, *tokens_after);
|
refresh_context_used(agent, used);
|
||||||
|
}
|
||||||
|
if let XaiSessionUpdate::AutoCompactCompleted { .. } = update {
|
||||||
agent.todo.update_todos(Vec::new());
|
agent.todo.update_todos(Vec::new());
|
||||||
}
|
}
|
||||||
changed
|
changed
|
||||||
@@ -812,6 +822,7 @@ pub(super) fn handle_session_notification(notif: &acp::ExtNotification, app: &mu
|
|||||||
XaiSessionUpdate::ModelChanged {
|
XaiSessionUpdate::ModelChanged {
|
||||||
model_id,
|
model_id,
|
||||||
reasoning_effort,
|
reasoning_effort,
|
||||||
|
context_window,
|
||||||
} => {
|
} => {
|
||||||
if agent.session.model_switch_pending {
|
if agent.session.model_switch_pending {
|
||||||
tracing::debug!(
|
tracing::debug!(
|
||||||
@@ -847,6 +858,8 @@ pub(super) fn handle_session_notification(notif: &acp::ExtNotification, app: &mu
|
|||||||
.session
|
.session
|
||||||
.models
|
.models
|
||||||
.set_current(new_model_id.clone(), effort);
|
.set_current(new_model_id.clone(), effort);
|
||||||
|
let window_changed =
|
||||||
|
context_window.is_some_and(|total| agent.apply_context_window(total));
|
||||||
agent.session.user_model_preference = Some(new_model_id.clone());
|
agent.session.user_model_preference = Some(new_model_id.clone());
|
||||||
let resolved_effort = agent.session.models.reasoning_effort;
|
let resolved_effort = agent.session.models.reasoning_effort;
|
||||||
let actually_changed =
|
let actually_changed =
|
||||||
@@ -858,7 +871,7 @@ pub(super) fn handle_session_notification(notif: &acp::ExtNotification, app: &mu
|
|||||||
"ModelChanged broadcast applied (remote switch)"
|
"ModelChanged broadcast applied (remote switch)"
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
actually_changed
|
actually_changed || window_changed
|
||||||
}
|
}
|
||||||
XaiSessionUpdate::MemoryFiles { files } => {
|
XaiSessionUpdate::MemoryFiles { files } => {
|
||||||
let entries = crate::views::memory_modal::build_entries(files);
|
let entries = crate::views::memory_modal::build_entries(files);
|
||||||
@@ -1068,10 +1081,7 @@ pub(super) fn handle_child_session_notification(
|
|||||||
| XaiSessionUpdate::AutoCompactFailed { .. }
|
| XaiSessionUpdate::AutoCompactFailed { .. }
|
||||||
| XaiSessionUpdate::AutoCompactCancelled { .. }
|
| XaiSessionUpdate::AutoCompactCancelled { .. }
|
||||||
| XaiSessionUpdate::RetryState(_) => {
|
| XaiSessionUpdate::RetryState(_) => {
|
||||||
let compact_tokens = match &update {
|
let compact_tokens = compaction_context_refresh(&update);
|
||||||
XaiSessionUpdate::AutoCompactCompleted { tokens_after, .. } => Some(*tokens_after),
|
|
||||||
_ => None,
|
|
||||||
};
|
|
||||||
let mut changed = false;
|
let mut changed = false;
|
||||||
if let Some(child_view) = agent.subagent_views.get_mut(child_sid) {
|
if let Some(child_view) = agent.subagent_views.get_mut(child_sid) {
|
||||||
changed = apply_session_event(
|
changed = apply_session_event(
|
||||||
|
|||||||
@@ -1701,12 +1701,14 @@ pub(super) fn model_changed_ext(
|
|||||||
session_id: &str,
|
session_id: &str,
|
||||||
model_id: &str,
|
model_id: &str,
|
||||||
reasoning_effort: Option<&str>,
|
reasoning_effort: Option<&str>,
|
||||||
|
context_window: Option<u64>,
|
||||||
) -> acp::ExtNotification {
|
) -> acp::ExtNotification {
|
||||||
let payload = SessionNotification {
|
let payload = SessionNotification {
|
||||||
session_id: acp::SessionId::new(session_id),
|
session_id: acp::SessionId::new(session_id),
|
||||||
update: XaiSessionUpdate::ModelChanged {
|
update: XaiSessionUpdate::ModelChanged {
|
||||||
model_id: model_id.to_string(),
|
model_id: model_id.to_string(),
|
||||||
reasoning_effort: reasoning_effort.map(String::from),
|
reasoning_effort: reasoning_effort.map(String::from),
|
||||||
|
context_window,
|
||||||
},
|
},
|
||||||
meta: None,
|
meta: None,
|
||||||
};
|
};
|
||||||
@@ -1723,6 +1725,7 @@ pub(super) fn model_changed_ext_with_event(
|
|||||||
update: XaiSessionUpdate::ModelChanged {
|
update: XaiSessionUpdate::ModelChanged {
|
||||||
model_id: model_id.to_string(),
|
model_id: model_id.to_string(),
|
||||||
reasoning_effort: None,
|
reasoning_effort: None,
|
||||||
|
context_window: None,
|
||||||
},
|
},
|
||||||
meta: Some(serde_json::json!({ "eventId" : event_id })),
|
meta: Some(serde_json::json!({ "eventId" : event_id })),
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -110,6 +110,70 @@
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn seed_windowed_models(agent: &mut AgentView) {
|
||||||
|
for (slug, window) in [("wide", 1_000_000u64), ("narrow", 262_144)] {
|
||||||
|
let mut info = make_model_info(slug);
|
||||||
|
info.meta = serde_json::json!({ "totalContextTokens": window })
|
||||||
|
.as_object()
|
||||||
|
.cloned();
|
||||||
|
agent
|
||||||
|
.session
|
||||||
|
.models
|
||||||
|
.available
|
||||||
|
.insert(acp::ModelId::new(std::sync::Arc::from(slug)), info);
|
||||||
|
}
|
||||||
|
agent
|
||||||
|
.session
|
||||||
|
.models
|
||||||
|
.set_current(acp::ModelId::new(std::sync::Arc::from("wide")), None);
|
||||||
|
agent.apply_context_used(15_000, 1_000_000);
|
||||||
|
}
|
||||||
|
|
||||||
|
/// A follower mirrors a remote switch and installs the effective window
|
||||||
|
/// the broadcast carries, like the invoking client does.
|
||||||
|
#[test]
|
||||||
|
fn model_changed_broadcast_installs_the_reported_context_window() {
|
||||||
|
let mut app = make_app_with_agent("sess-1");
|
||||||
|
seed_windowed_models(app.agents.get_mut(&AgentId(0)).unwrap());
|
||||||
|
|
||||||
|
let notif = model_changed_ext("sess-1", "narrow", None, Some(262_144));
|
||||||
|
assert!(handle_ext_notification(¬if, &mut app));
|
||||||
|
|
||||||
|
let snap = app.agents[&AgentId(0)].context_state.as_ref().unwrap();
|
||||||
|
assert_eq!((snap.used, snap.total, snap.usage_pct), (15_000, 262_144, 6));
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Same model, same effort, new effective window (the catalog was
|
||||||
|
/// reloaded and re-applied): the follower must still request a redraw.
|
||||||
|
#[test]
|
||||||
|
fn model_changed_same_model_new_window_requests_redraw() {
|
||||||
|
let mut app = make_app_with_agent("sess-1");
|
||||||
|
seed_windowed_models(app.agents.get_mut(&AgentId(0)).unwrap());
|
||||||
|
|
||||||
|
let notif = model_changed_ext("sess-1", "wide", None, Some(2_000_000));
|
||||||
|
assert!(handle_ext_notification(¬if, &mut app));
|
||||||
|
|
||||||
|
let snap = app.agents[&AgentId(0)].context_state.as_ref().unwrap();
|
||||||
|
assert_eq!((snap.used, snap.total), (15_000, 2_000_000));
|
||||||
|
|
||||||
|
let again = model_changed_ext("sess-1", "wide", None, Some(2_000_000));
|
||||||
|
assert!(!handle_ext_notification(&again, &mut app));
|
||||||
|
}
|
||||||
|
|
||||||
|
/// A broadcast from a leader that predates the field carries no window;
|
||||||
|
/// the snapshot is left for the next streaming update to refresh.
|
||||||
|
#[test]
|
||||||
|
fn model_changed_broadcast_without_window_keeps_the_snapshot() {
|
||||||
|
let mut app = make_app_with_agent("sess-1");
|
||||||
|
seed_windowed_models(app.agents.get_mut(&AgentId(0)).unwrap());
|
||||||
|
|
||||||
|
let notif = model_changed_ext("sess-1", "narrow", None, None);
|
||||||
|
assert!(handle_ext_notification(¬if, &mut app));
|
||||||
|
|
||||||
|
let snap = app.agents[&AgentId(0)].context_state.as_ref().unwrap();
|
||||||
|
assert_eq!((snap.used, snap.total), (15_000, 1_000_000));
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn models_update_without_active_agent_uses_shell_default() {
|
fn models_update_without_active_agent_uses_shell_default() {
|
||||||
let (tx, _rx) = tokio::sync::mpsc::unbounded_channel();
|
let (tx, _rx) = tokio::sync::mpsc::unbounded_channel();
|
||||||
@@ -232,7 +296,7 @@
|
|||||||
let scrollback_before = agent.scrollback.len();
|
let scrollback_before = agent.scrollback.len();
|
||||||
assert!(!agent.session.model_switch_pending);
|
assert!(!agent.session.model_switch_pending);
|
||||||
|
|
||||||
let notif = model_changed_ext("sess-1", "kigi-4", None);
|
let notif = model_changed_ext("sess-1", "kigi-4", None, None);
|
||||||
let changed = handle_ext_notification(¬if, &mut app);
|
let changed = handle_ext_notification(¬if, &mut app);
|
||||||
assert!(
|
assert!(
|
||||||
changed,
|
changed,
|
||||||
@@ -278,7 +342,7 @@
|
|||||||
Some(acp::ModelId::new(std::sync::Arc::from("heavy")));
|
Some(acp::ModelId::new(std::sync::Arc::from("heavy")));
|
||||||
assert!(!agent.session.model_switch_pending);
|
assert!(!agent.session.model_switch_pending);
|
||||||
|
|
||||||
let notif = model_changed_ext("sess-1", "auto", None);
|
let notif = model_changed_ext("sess-1", "auto", None, None);
|
||||||
let changed = handle_ext_notification(¬if, &mut app);
|
let changed = handle_ext_notification(¬if, &mut app);
|
||||||
assert!(
|
assert!(
|
||||||
changed,
|
changed,
|
||||||
@@ -328,7 +392,7 @@
|
|||||||
agent.session.model_switch_pending = true;
|
agent.session.model_switch_pending = true;
|
||||||
let scrollback_before = agent.scrollback.len();
|
let scrollback_before = agent.scrollback.len();
|
||||||
|
|
||||||
let notif = model_changed_ext("sess-1", "kigi-4", None);
|
let notif = model_changed_ext("sess-1", "kigi-4", None, None);
|
||||||
let changed = handle_ext_notification(¬if, &mut app);
|
let changed = handle_ext_notification(¬if, &mut app);
|
||||||
assert!(
|
assert!(
|
||||||
!changed,
|
!changed,
|
||||||
@@ -369,7 +433,7 @@
|
|||||||
let agent = app.agents.get_mut(&AgentId(0)).unwrap();
|
let agent = app.agents.get_mut(&AgentId(0)).unwrap();
|
||||||
seed_models(agent, "kigi-3", &["kigi-3", "kigi-4"]);
|
seed_models(agent, "kigi-3", &["kigi-3", "kigi-4"]);
|
||||||
|
|
||||||
let notif = model_changed_ext("sess-1", "kigi-99-unknown", None);
|
let notif = model_changed_ext("sess-1", "kigi-99-unknown", None, None);
|
||||||
let changed = handle_ext_notification(¬if, &mut app);
|
let changed = handle_ext_notification(¬if, &mut app);
|
||||||
assert!(
|
assert!(
|
||||||
!changed,
|
!changed,
|
||||||
@@ -400,7 +464,7 @@
|
|||||||
let agent = app.agents.get_mut(&AgentId(0)).unwrap();
|
let agent = app.agents.get_mut(&AgentId(0)).unwrap();
|
||||||
seed_models(agent, "kigi-3", &["kigi-3", "kigi-4"]);
|
seed_models(agent, "kigi-3", &["kigi-3", "kigi-4"]);
|
||||||
|
|
||||||
let notif = model_changed_ext("sess-1", "kigi-4", Some("high"));
|
let notif = model_changed_ext("sess-1", "kigi-4", Some("high"), None);
|
||||||
assert!(handle_ext_notification(¬if, &mut app));
|
assert!(handle_ext_notification(¬if, &mut app));
|
||||||
|
|
||||||
let agent = app.agents.get(&AgentId(0)).unwrap();
|
let agent = app.agents.get(&AgentId(0)).unwrap();
|
||||||
@@ -422,7 +486,7 @@
|
|||||||
let agent = app.agents.get_mut(&AgentId(0)).unwrap();
|
let agent = app.agents.get_mut(&AgentId(0)).unwrap();
|
||||||
seed_models(agent, "kigi-3", &["kigi-3", "kigi-4"]);
|
seed_models(agent, "kigi-3", &["kigi-3", "kigi-4"]);
|
||||||
|
|
||||||
let notif = model_changed_ext("sess-OTHER", "kigi-4", None);
|
let notif = model_changed_ext("sess-OTHER", "kigi-4", None, None);
|
||||||
let changed = handle_ext_notification(¬if, &mut app);
|
let changed = handle_ext_notification(¬if, &mut app);
|
||||||
assert!(!changed);
|
assert!(!changed);
|
||||||
|
|
||||||
|
|||||||
@@ -576,9 +576,8 @@
|
|||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn child_compact_started_does_not_reset_context_used() {
|
fn child_compact_started_refreshes_context_used() {
|
||||||
// Sibling variants in the same outer arm must not touch the numerator;
|
// AutoCompactStarted carries the count the trigger fired on; the child bar must show it.
|
||||||
// guards against accidental widening of the AutoCompactCompleted gate.
|
|
||||||
let mut agent = make_agent(Some("root-sess"));
|
let mut agent = make_agent(Some("root-sess"));
|
||||||
let child_sid = "child-sess-3";
|
let child_sid = "child-sess-3";
|
||||||
agent
|
agent
|
||||||
@@ -603,7 +602,17 @@
|
|||||||
let child_view = agent.subagent_views.get(child_sid).unwrap();
|
let child_view = agent.subagent_views.get(child_sid).unwrap();
|
||||||
assert_eq!(
|
assert_eq!(
|
||||||
child_view.context_state.as_ref().map(|c| c.used),
|
child_view.context_state.as_ref().map(|c| c.used),
|
||||||
Some(90_000)
|
Some(95_000)
|
||||||
|
);
|
||||||
|
// A sibling variant without a count leaves the numerator alone.
|
||||||
|
let cancelled = XaiSessionUpdate::AutoCompactCancelled {
|
||||||
|
reason: "user".into(),
|
||||||
|
};
|
||||||
|
let _ = handle_child_session_notification(cancelled, child_sid, &mut agent, false);
|
||||||
|
let child_view = agent.subagent_views.get(child_sid).unwrap();
|
||||||
|
assert_eq!(
|
||||||
|
child_view.context_state.as_ref().map(|c| c.used),
|
||||||
|
Some(95_000)
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -693,5 +702,30 @@
|
|||||||
!session.model_incompatible,
|
!session.model_incompatible,
|
||||||
"non-encrypted_content error types must not set model_incompatible"
|
"non-encrypted_content error types must not set model_incompatible"
|
||||||
);
|
);
|
||||||
|
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// The banner's count must also refresh the context bar.
|
||||||
|
#[test]
|
||||||
|
fn auto_compact_started_refreshes_the_context_bar() {
|
||||||
|
let mut app = make_app_with_agent("sess-1");
|
||||||
|
let id = AgentId(0);
|
||||||
|
app.agents.get_mut(&id).unwrap().apply_context_used(15_000, 262_144);
|
||||||
|
let payload = SessionNotification {
|
||||||
|
session_id: acp::SessionId::new("sess-1"),
|
||||||
|
update: XaiSessionUpdate::AutoCompactStarted {
|
||||||
|
tokens_used: 90_000,
|
||||||
|
context_window: 262_144,
|
||||||
|
percentage: 34,
|
||||||
|
reason: "threshold".into(),
|
||||||
|
},
|
||||||
|
meta: None,
|
||||||
|
};
|
||||||
|
let notif = acp::ExtNotification::new(
|
||||||
|
"kigi/session/update",
|
||||||
|
std::sync::Arc::from(serde_json::value::to_raw_value(&payload).unwrap()),
|
||||||
|
);
|
||||||
|
let _ = handle_ext_notification(¬if, &mut app);
|
||||||
|
let bar = app.agents[&id].context_state.as_ref().map(|c| (c.used, c.total));
|
||||||
|
assert_eq!(bar, Some((90_000, 262_144)));
|
||||||
|
}
|
||||||
@@ -1431,6 +1431,8 @@ pub enum Effect {
|
|||||||
Compact {
|
Compact {
|
||||||
agent_id: AgentId,
|
agent_id: AgentId,
|
||||||
session_id: acp::SessionId,
|
session_id: acp::SessionId,
|
||||||
|
/// `/compact <instructions>`, forwarded as `userContext`.
|
||||||
|
user_context: Option<String>,
|
||||||
},
|
},
|
||||||
/// Kill a background task.
|
/// Kill a background task.
|
||||||
KillBgTask {
|
KillBgTask {
|
||||||
@@ -2112,7 +2114,10 @@ pub enum TaskResult {
|
|||||||
agent_id: AgentId,
|
agent_id: AgentId,
|
||||||
model_id: acp::ModelId,
|
model_id: acp::ModelId,
|
||||||
effort: Option<ReasoningEffort>,
|
effort: Option<ReasoningEffort>,
|
||||||
result: Result<(), SwitchModelError>,
|
/// Ok carries the effective context window the shell reported
|
||||||
|
/// (`totalContextTokens` in the response meta; `None` from a shell
|
||||||
|
/// that predates it).
|
||||||
|
result: Result<Option<u64>, SwitchModelError>,
|
||||||
/// Forwarded from `Effect::SwitchModel.prev_model_id` for
|
/// Forwarded from `Effect::SwitchModel.prev_model_id` for
|
||||||
/// rollback on `IncompatibleAgent`.
|
/// rollback on `IncompatibleAgent`.
|
||||||
prev_model_id: Option<acp::ModelId>,
|
prev_model_id: Option<acp::ModelId>,
|
||||||
|
|||||||
@@ -734,7 +734,8 @@ impl AgentView {
|
|||||||
Event::Mouse(mouse) => self.handle_inline_edit_mouse(mouse),
|
Event::Mouse(mouse) => self.handle_inline_edit_mouse(mouse),
|
||||||
Event::Paste(text) => {
|
Event::Paste(text) => {
|
||||||
if let Some(ref mut edit) = self.inline_edit {
|
if let Some(ref mut edit) = self.inline_edit {
|
||||||
edit.textarea.insert_str(text);
|
edit.textarea
|
||||||
|
.insert_str(&crate::views::prompt_widget::normalize_line_breaks(text));
|
||||||
}
|
}
|
||||||
InputOutcome::Changed
|
InputOutcome::Changed
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1231,6 +1231,17 @@ mod cancel_turn_mouse_tests {
|
|||||||
use crate::views::modal::{CancelTurnChoice, CancelTurnViewState};
|
use crate::views::modal::{CancelTurnChoice, CancelTurnViewState};
|
||||||
use crossterm::event::{MouseButton, MouseEvent, MouseEventKind};
|
use crossterm::event::{MouseButton, MouseEvent, MouseEventKind};
|
||||||
use ratatui::layout::Rect;
|
use ratatui::layout::Rect;
|
||||||
|
#[test]
|
||||||
|
fn queued_post_flush_escapes_drain_in_order() {
|
||||||
|
let mut agent = make_agent();
|
||||||
|
agent.queue_post_flush(crate::terminal::overlay::PostFlush::plain("a".into()));
|
||||||
|
agent.queue_post_flush(crate::terminal::overlay::PostFlush::plain("b".into()));
|
||||||
|
let drained = agent
|
||||||
|
.take_pending_post_flush()
|
||||||
|
.map(|p| p.as_str().to_owned());
|
||||||
|
assert_eq!(drained.as_deref(), Some("ab"));
|
||||||
|
assert!(agent.take_pending_post_flush().is_none());
|
||||||
|
}
|
||||||
fn make_agent() -> AgentView {
|
fn make_agent() -> AgentView {
|
||||||
let (tx, _rx) = tokio::sync::mpsc::unbounded_channel();
|
let (tx, _rx) = tokio::sync::mpsc::unbounded_channel();
|
||||||
AgentView::new(
|
AgentView::new(
|
||||||
|
|||||||
@@ -22,10 +22,7 @@ impl AgentView {
|
|||||||
match key.code {
|
match key.code {
|
||||||
KeyCode::Esc | KeyCode::Char('q') => {
|
KeyCode::Esc | KeyCode::Char('q') => {
|
||||||
// Kitty images outlive the dropped viewer state; clear before close.
|
// Kitty images outlive the dropped viewer state; clear before close.
|
||||||
kigi_shell::util::with_locked_stderr(|stderr| {
|
self.queue_post_flush(PostFlush::from(overlay::clear_kitty()));
|
||||||
let clear = PostFlush::from(overlay::clear_kitty());
|
|
||||||
let _ = clear.write_to(stderr);
|
|
||||||
});
|
|
||||||
self.image_viewer = None;
|
self.image_viewer = None;
|
||||||
self.image_load_rx = None;
|
self.image_load_rx = None;
|
||||||
// The viewer's decoded/re-encoded overlay image (tens of MB
|
// The viewer's decoded/re-encoded overlay image (tens of MB
|
||||||
@@ -539,10 +536,7 @@ impl AgentView {
|
|||||||
match key.code {
|
match key.code {
|
||||||
KeyCode::Esc | KeyCode::Char('q') => {
|
KeyCode::Esc | KeyCode::Char('q') => {
|
||||||
// Kitty images outlive the dropped viewer state; clear before close.
|
// Kitty images outlive the dropped viewer state; clear before close.
|
||||||
kigi_shell::util::with_locked_stderr(|stderr| {
|
self.queue_post_flush(PostFlush::from(overlay::clear_kitty()));
|
||||||
let clear = PostFlush::from(overlay::clear_kitty());
|
|
||||||
let _ = clear.write_to(stderr);
|
|
||||||
});
|
|
||||||
self.video_viewer = None;
|
self.video_viewer = None;
|
||||||
// The viewer's pre-extracted frame set (~50–300 MB for a
|
// The viewer's pre-extracted frame set (~50–300 MB for a
|
||||||
// typical clip) just dropped; return the pages to the OS.
|
// typical clip) just dropped; return the pages to the OS.
|
||||||
@@ -569,10 +563,7 @@ impl AgentView {
|
|||||||
match gboom.handle_key(key) {
|
match gboom.handle_key(key) {
|
||||||
crate::gboom::GboomKeyOutcome::Close => {
|
crate::gboom::GboomKeyOutcome::Close => {
|
||||||
// Kitty images outlive the dropped game state; clear before close.
|
// Kitty images outlive the dropped game state; clear before close.
|
||||||
kigi_shell::util::with_locked_stderr(|stderr| {
|
self.queue_post_flush(PostFlush::from(overlay::clear_kitty()));
|
||||||
let clear = PostFlush::from(overlay::clear_kitty());
|
|
||||||
let _ = clear.write_to(stderr);
|
|
||||||
});
|
|
||||||
self.gboom = None;
|
self.gboom = None;
|
||||||
}
|
}
|
||||||
crate::gboom::GboomKeyOutcome::Changed => {}
|
crate::gboom::GboomKeyOutcome::Changed => {}
|
||||||
|
|||||||
@@ -1003,6 +1003,8 @@ pub struct AgentView {
|
|||||||
pub(crate) edit_hl: Option<crate::app::edit_highlight_worker::EditHlRuntime>,
|
pub(crate) edit_hl: Option<crate::app::edit_highlight_worker::EditHlRuntime>,
|
||||||
/// Whether any inline media is currently placed on screen.
|
/// Whether any inline media is currently placed on screen.
|
||||||
pub(crate) inline_media_active: bool,
|
pub(crate) inline_media_active: bool,
|
||||||
|
/// Escapes queued for the next frame's post-flush write (see `queue_post_flush`).
|
||||||
|
pub(crate) pending_post_flush: Option<crate::terminal::overlay::PostFlush>,
|
||||||
/// Image IDs that were placed on screen last frame. Used to detect
|
/// Image IDs that were placed on screen last frame. Used to detect
|
||||||
/// images that scrolled off and need their Kitty placements cleared.
|
/// images that scrolled off and need their Kitty placements cleared.
|
||||||
pub(crate) last_placed_ids: HashSet<u32>,
|
pub(crate) last_placed_ids: HashSet<u32>,
|
||||||
|
|||||||
@@ -344,7 +344,10 @@ impl AgentView {
|
|||||||
self.prompt.textarea.begin_undo_group();
|
self.prompt.textarea.begin_undo_group();
|
||||||
group_open = true;
|
group_open = true;
|
||||||
}
|
}
|
||||||
if matches!(self.prompt.handle_paste(&to_insert), PromptEvent::Edited) {
|
if matches!(
|
||||||
|
self.prompt.insert_dropped_path(&to_insert),
|
||||||
|
PromptEvent::Edited
|
||||||
|
) {
|
||||||
inserted_non_image = true;
|
inserted_non_image = true;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -605,13 +605,32 @@ impl AgentView {
|
|||||||
false,
|
false,
|
||||||
&mut Vec::new(),
|
&mut Vec::new(),
|
||||||
);
|
);
|
||||||
child_post_flush = post_flush;
|
// The child's own queued clears (inline image ids) go out before its frame escapes.
|
||||||
|
child_post_flush = match (child_view.take_pending_post_flush(), post_flush) {
|
||||||
|
(Some(mut pending), Some(frame)) => {
|
||||||
|
pending.append(frame);
|
||||||
|
Some(pending)
|
||||||
|
}
|
||||||
|
(pending, frame) => pending.or(frame),
|
||||||
|
};
|
||||||
}
|
}
|
||||||
(None, child_post_flush)
|
(None, child_post_flush)
|
||||||
}
|
}
|
||||||
pub fn should_show_tip(&mut self) -> bool {
|
pub fn should_show_tip(&mut self) -> bool {
|
||||||
false
|
false
|
||||||
}
|
}
|
||||||
|
/// Queue escapes for the frame's post-flush write: the event loop never writes stderr inline.
|
||||||
|
pub(crate) fn queue_post_flush(&mut self, escapes: crate::terminal::overlay::PostFlush) {
|
||||||
|
match self.pending_post_flush.as_mut() {
|
||||||
|
Some(pending) => pending.append(escapes),
|
||||||
|
None => self.pending_post_flush = Some(escapes),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
pub(crate) fn take_pending_post_flush(
|
||||||
|
&mut self,
|
||||||
|
) -> Option<crate::terminal::overlay::PostFlush> {
|
||||||
|
self.pending_post_flush.take()
|
||||||
|
}
|
||||||
/// `area` is the screen region assigned to this agent view.
|
/// `area` is the screen region assigned to this agent view.
|
||||||
/// When a tracing overlay is visible, this is smaller than `f.area()`.
|
/// When a tracing overlay is visible, this is smaller than `f.area()`.
|
||||||
///
|
///
|
||||||
@@ -669,20 +688,17 @@ impl AgentView {
|
|||||||
|| self.active_modal.is_some())
|
|| self.active_modal.is_some())
|
||||||
{
|
{
|
||||||
self.inline_media_active = false;
|
self.inline_media_active = false;
|
||||||
kigi_shell::util::with_locked_stderr(|stderr| {
|
let mut clears = String::new();
|
||||||
for &id in self.inline_media_ids.values() {
|
for &id in self.inline_media_ids.values() {
|
||||||
let clear = crate::terminal::image::clear_kitty_image(id);
|
clears.push_str(&crate::terminal::image::clear_kitty_image(id));
|
||||||
let _ = std::io::Write::write_all(stderr, clear.as_bytes());
|
}
|
||||||
}
|
self.queue_post_flush(crate::terminal::overlay::PostFlush::plain(clears));
|
||||||
});
|
|
||||||
self.inline_media_ids.clear();
|
self.inline_media_ids.clear();
|
||||||
self.inline_media_iterm_emitted.clear();
|
self.inline_media_iterm_emitted.clear();
|
||||||
}
|
}
|
||||||
if let Some(ref child_sid) = self.active_subagent.clone() {
|
if let Some(ref child_sid) = self.active_subagent.clone() {
|
||||||
if let Some(esc) = self.take_own_inline_media_clear_escapes() {
|
if let Some(esc) = self.take_own_inline_media_clear_escapes() {
|
||||||
kigi_shell::util::with_locked_stderr(|stderr| {
|
self.queue_post_flush(crate::terminal::overlay::PostFlush::plain(esc));
|
||||||
let _ = std::io::Write::write_all(stderr, esc.as_bytes());
|
|
||||||
});
|
|
||||||
}
|
}
|
||||||
return self.draw_subagent_fullscreen(
|
return self.draw_subagent_fullscreen(
|
||||||
&child_sid.clone(),
|
&child_sid.clone(),
|
||||||
@@ -695,9 +711,7 @@ impl AgentView {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
if let Some(esc) = self.take_subagent_inline_media_clear_escapes() {
|
if let Some(esc) = self.take_subagent_inline_media_clear_escapes() {
|
||||||
kigi_shell::util::with_locked_stderr(|stderr| {
|
self.queue_post_flush(crate::terminal::overlay::PostFlush::plain(esc));
|
||||||
let _ = std::io::Write::write_all(stderr, esc.as_bytes());
|
|
||||||
});
|
|
||||||
}
|
}
|
||||||
let appearance = self.scrollback.appearance().clone();
|
let appearance = self.scrollback.appearance().clone();
|
||||||
let layout_cfg = &appearance.scrollback.layout;
|
let layout_cfg = &appearance.scrollback.layout;
|
||||||
|
|||||||
Loaded 100 of 133 files, more files were not shown because too many files have changed in this diff.
Show more
Reference in new issue
Block a user