ZacharyZhang-NY
6f31415ed6
The PRD's first acceptance gate now holds: grep -RinE '\bx\.ai\b|grok' crates/ --include='*.rs' → 0 matches (exempt: NOTICE and third-party license archives, README provenance, and the required 'Based on Grok Build Open Source' attribution, now sourced from version_attribution.txt). Wire-visible renames (both sides in this repo, changed in lockstep): - Auth method id 'grok.com' → 'kimi-code' (AuthMethodKind::KimiCode). - Every x.ai/* and _x.ai/* ACP ext method and meta key → kigi/* / _kigi/* (~200 names; grokShell → kigiShell). Session-file replay keeps a read-side alias for the legacy '_x.ai/session/update' method so existing updates.jsonl histories load; writes emit only the new name (both directions test-pinned). - Agent types grok-build* → kigi* with a documented legacy-prefix alias at resolution time so persisted sessions keep resolving. - ToolNamespace/BuiltinAgentName GrokBuild* → Kigi* (wire snake_case kigi/kigi_concise/kigi_hashline; schema regenerated); grok_build implementation dirs renamed to kigi*. - x-grok-* headers → x-kigi-*, __GROK_* sentinels → __KIGI_*, themes grokday/groknight → kigiday/kiginight (old persisted values fall back to the default theme), web_fetch allowlist xAI hosts → kimi.com + moonshot platforms, changelog CDN → this repo, grok-build changelog archives deleted. - BYOK default endpoint removed: [endpoints] api_base_url is now truly optional with NO default — consumers fail fast with the flag name when unset (no silent x.ai egress). Mock harnesses inject it explicitly. - System-prompt identity fixed: 'released by xAI' → 'an unofficial community CLI for Kimi' (template + regenerated encrypted form). Also repaired pre-existing grok-era test debt found by the sweep: the stale trace_classify default-model pin, the grok-pager UA label test, pty-harness stale-binary reuse and non-hermetic moonshot routing (a PTY test could previously reach the real api.moonshot.cn), and the outdated oauth fixture scope key. Gates: §9 grep 0; fmt clean; workspace check/clippy 0/0 (-D warnings); FULL cargo test --workspace: 234 suites, 21,961 passed, 0 failed; deny advisories ok.
90 lines
2.8 KiB
Rust
90 lines
2.8 KiB
Rust
//! `ToolDescriptionWithSchema::derive_tool_id`: namespaced descriptions
|
|
//! render as `"{ns}:{name}"`; bare names pass through; descriptions whose
|
|
//! derived id fails [`ToolId`] validation return `Err`.
|
|
|
|
use kigi_tool_protocol::{IdError, ToolDescriptionWithSchema, ToolId};
|
|
use kigi_tool_types::ToolDescription;
|
|
|
|
fn entry(name: &str, namespace: Option<&str>) -> ToolDescriptionWithSchema {
|
|
let mut description = ToolDescription::new(name, "test description");
|
|
if let Some(ns) = namespace {
|
|
description = description.with_namespace(ns);
|
|
}
|
|
ToolDescriptionWithSchema {
|
|
description,
|
|
input_schema: None,
|
|
capabilities: None,
|
|
notification_schemas: None,
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn bare_name_derives_to_tool_id_without_namespace() {
|
|
let derived = entry("read_file", None).derive_tool_id().unwrap();
|
|
assert_eq!(derived, ToolId::new("read_file").unwrap());
|
|
}
|
|
|
|
#[test]
|
|
fn namespaced_name_derives_to_namespaced_tool_id() {
|
|
let derived = entry("read_file", Some("Kigi")).derive_tool_id().unwrap();
|
|
assert_eq!(derived, ToolId::new("Kigi:read_file").unwrap());
|
|
}
|
|
|
|
#[test]
|
|
fn invalid_name_propagates_id_validation_error() {
|
|
let err = entry("foo bar", None).derive_tool_id().unwrap_err();
|
|
assert!(
|
|
matches!(err, IdError::InvalidFormat { .. }),
|
|
"expected InvalidFormat, got {err:?}"
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn invalid_namespace_propagates_id_validation_error() {
|
|
let err = entry("read_file", Some("bad ns"))
|
|
.derive_tool_id()
|
|
.unwrap_err();
|
|
assert!(matches!(err, IdError::InvalidFormat { .. }));
|
|
}
|
|
|
|
#[test]
|
|
fn empty_name_yields_empty_id_error() {
|
|
let err = entry("", None).derive_tool_id().unwrap_err();
|
|
assert_eq!(err, IdError::Empty);
|
|
}
|
|
|
|
#[test]
|
|
fn duplicate_derivations_in_a_batch_are_detectable() {
|
|
let batch = [
|
|
entry("read_file", Some("Kigi")),
|
|
entry("write_file", Some("Kigi")),
|
|
entry("read_file", Some("Kigi")),
|
|
];
|
|
|
|
let mut seen = std::collections::HashMap::new();
|
|
let mut duplicates: Vec<(ToolId, Vec<usize>)> = Vec::new();
|
|
for (i, e) in batch.iter().enumerate() {
|
|
let id = e.derive_tool_id().unwrap();
|
|
seen.entry(id).or_insert_with(Vec::new).push(i);
|
|
}
|
|
for (id, indices) in seen {
|
|
if indices.len() > 1 {
|
|
duplicates.push((id, indices));
|
|
}
|
|
}
|
|
assert_eq!(duplicates.len(), 1, "exactly one duplicate id expected");
|
|
let (id, indices) = &duplicates[0];
|
|
assert_eq!(id, &ToolId::new("Kigi:read_file").unwrap());
|
|
assert_eq!(indices, &vec![0, 2]);
|
|
}
|
|
|
|
#[test]
|
|
fn derivation_does_not_collide_across_namespaces() {
|
|
let a = entry("read_file", Some("Kigi")).derive_tool_id().unwrap();
|
|
let b = entry("read_file", Some("github")).derive_tool_id().unwrap();
|
|
let c = entry("read_file", None).derive_tool_id().unwrap();
|
|
assert_ne!(a, b);
|
|
assert_ne!(a, c);
|
|
assert_ne!(b, c);
|
|
}
|