Files
ZacharyZhang-NYandClaude Opus 5.5 bcce34cda1 Upgrade MyGo to v0.5.5
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:

- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
  elements expire and Context methods are inert: read IsDisabled into a
  local during the build, keep a ui.Handle for Focus, use c.Services()
  for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
  content builds, so same-frame autofocus lost focus restore on close.
  It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
  c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
  split button tooltip no longer reorders its open menu; disabled
  menubar rows pass presses to the panel; Form defers blur-started
  async checks so the growing message no longer moves Submit away
  from the release; Combobox drops its disabled copy now that MyGo
  blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
  time.Sleep/time.Now and read element state inside the view. The web
  mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.

Snapshot goldens are darwin-only and were not re-verified here.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-17 01:37:54 -04:00

175 lines
6.3 KiB
Go

package datetime
import (
"log/slog"
"slices"
"strings"
"time"
"github.com/egoist/mygo/ui"
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/input"
)
// EventEditorOptions configure an EventEditor.
type EventEditorOptions struct {
// Location is the zone times are edited in; required.
Location *time.Location
Hour12 bool
WeekStart WeekStart
Disabled bool
Label string
}
// EventEditorResult is the editor and its save or cancel.
type EventEditorResult struct {
Element ui.Element
saved bool
canceled bool
}
// Saved reports a valid draft written to the event.
func (r EventEditorResult) Saved() bool { return r.saved }
// Canceled reports that the user discarded the draft.
func (r EventEditorResult) Canceled() bool { return r.canceled }
// eventEditorState is the draft and whether Save was tried.
type eventEditorState struct {
draft CalendarEvent
tried bool
origin string
}
// EventEditor edits a copy of *ev; Save checks and writes.
func EventEditor(c *ui.Context, ev *CalendarEvent, opts EventEditorOptions) EventEditorResult {
loc := eventLocation("EventEditor", opts.Location)
d := core.Density(c)
label := opts.Label
if label == "" {
label = core.Msg(c, "event_editor.label")
}
r := EventEditorResult{}
root := ui.Column(c).Gap(d.Unit() * 4).Role(ui.RoleGroup).Label(label).Disabled(opts.Disabled)
r.Element = root
st := ui.Local(root, "event-editor", func() *eventEditorState { return nil })
if *st == nil || (*st).origin != ev.ID {
*st = &eventEditorState{draft: eventCopy(*ev), origin: ev.ID}
}
s := *st
dr := &s.draft
problems := eventEditorProblems(c, *dr, s.tried)
root.Children(func() {
input.FormField(c, core.Msg(c, "event_editor.title"), input.FormFieldOptions{Required: true, Error: problems["title"]}, func() ui.Element {
return input.TextInput(c, &dr.Title, input.TextInputOptions{Label: core.Msg(c, "event_editor.title"), Disabled: opts.Disabled, Error: problems["title"]}).Input
})
input.Checkbox(c, &dr.AllDay, core.Msg(c, "event_editor.all_day"), input.CheckboxOptions{Disabled: opts.Disabled})
ui.Row(c).Gap(d.Unit() * 3).Wrap().AlignItems(ui.Start).Children(func() {
for _, f := range []struct {
key string
t *time.Time
}{{"event_editor.starts", &dr.Start}, {"event_editor.ends", &dr.End}} {
input.FormField(c, core.Msg(c, f.key), input.FormFieldOptions{Error: problems[f.key]}, func() ui.Element {
if dr.AllDay {
day := core.DateOf(f.t.In(loc))
r := DatePicker(c, &day, DatePickerOptions{Label: core.Msg(c, f.key), WeekStart: opts.WeekStart, Disabled: opts.Disabled})
if r.Changed() {
*f.t = eventDayStart(day, loc)
}
return r.Input
}
return DateTimePicker(c, f.t, DateTimePickerOptions{Location: loc, Hour12: opts.Hour12, MinuteStep: 5,
WeekStart: opts.WeekStart, Label: core.Msg(c, f.key), Disabled: opts.Disabled}).Element
})
}
})
input.FormField(c, core.Msg(c, "event_editor.where"), input.FormFieldOptions{}, func() ui.Element {
return input.TextInput(c, &dr.Location, input.TextInputOptions{Label: core.Msg(c, "event_editor.where"), Disabled: opts.Disabled}).Input
})
input.FormField(c, core.Msg(c, "event_editor.guests"), input.FormFieldOptions{Description: core.Msg(c, "event_editor.guests_help")}, func() ui.Element {
names := make([]string, len(dr.Attendees))
for i, a := range dr.Attendees {
names[i] = a.Name
}
p := input.TagsInput(c, &names, input.TagsInputOptions{Label: core.Msg(c, "event_editor.guests"), Disabled: opts.Disabled})
if p.Changed() {
dr.Attendees = eventAttendees(dr.Attendees, names)
}
return p.Input
})
if len(dr.Attendees) > 0 {
AttendeeList(c, dr.Attendees, AttendeeListOptions{Disabled: opts.Disabled})
}
input.FormField(c, core.Msg(c, "event_editor.reminders"), input.FormFieldOptions{}, func() ui.Element {
return ReminderPicker(c, &dr.Reminders, ReminderPickerOptions{Disabled: opts.Disabled}).Element
})
var rec RecurrenceResult
input.FormField(c, core.Msg(c, "recurrence_editor.repeat"), input.FormFieldOptions{}, func() ui.Element {
rec = RecurrenceEditor(c, &dr.Repeat, RecurrenceEditorOptions{Start: core.DateOf(dr.Start.In(loc)), WeekStart: opts.WeekStart, Disabled: opts.Disabled})
return rec.Element
})
core.DatetimeFooter(c, func() {
if input.Button(c, core.Msg(c, "calendar.cancel"), input.ButtonOptions{Variant: input.Secondary}).Clicked() && !root.IsDisabled() {
slog.Debug("mujica: event_editor cancel", "id", ev.ID)
*st, r.canceled = nil, true
}
if input.Button(c, core.Msg(c, "event_editor.save"), input.ButtonOptions{}).Clicked() && !root.IsDisabled() {
s.tried = true
if len(eventEditorProblems(c, *dr, true)) == 0 && rec.Problem() == "" {
slog.Debug("mujica: event_editor save", "id", ev.ID)
out := eventCopy(*dr)
if out.AllDay {
first, last := core.DateOf(out.Start.In(loc)), core.DateOf(out.End.Add(-time.Nanosecond).In(loc))
out.Start, out.End = eventDayStart(first, loc), eventDayStart(last.AddDays(1), loc)
}
*ev, r.saved = out, true
} else {
slog.Debug("mujica: event_editor invalid", "id", ev.ID)
}
}
})
})
return r
}
// eventEditorProblems checks a draft once Save was tried.
func eventEditorProblems(c *ui.Context, ev CalendarEvent, tried bool) map[string]string {
p := map[string]string{}
if !tried {
return p
}
if strings.TrimSpace(ev.Title) == "" {
p["title"] = core.Msg(c, "event_editor.need_title")
}
if ev.Start.IsZero() {
p["event_editor.starts"] = core.Msg(c, "event_editor.need_start")
}
if !ev.End.After(ev.Start) {
p["event_editor.ends"] = core.Msg(c, "event_editor.end_order")
}
return p
}
// eventAttendees keeps known attendees and adds new ones.
func eventAttendees(old []Attendee, names []string) []Attendee {
out := make([]Attendee, 0, len(names))
for _, n := range names {
i := slices.IndexFunc(old, func(a Attendee) bool { return a.Name == n })
if i >= 0 {
out = append(out, old[i])
} else {
out = append(out, Attendee{Name: n})
}
}
return out
}
// eventCopy clones an event's slices for a draft.
func eventCopy(ev CalendarEvent) CalendarEvent {
ev.Attendees = slices.Clone(ev.Attendees)
ev.Reminders = slices.Clone(ev.Reminders)
ev.Repeat.Weekdays = slices.Clone(ev.Repeat.Weekdays)
return ev
}