ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
63 lines
1.9 KiB
Go
63 lines
1.9 KiB
Go
package input
|
|
|
|
import (
|
|
"log/slog"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/icons"
|
|
)
|
|
|
|
// PasswordInputOptions configure a PasswordInput.
|
|
type PasswordInputOptions struct {
|
|
Placeholder string
|
|
// Label names the field for assistive technology.
|
|
Label string
|
|
Disabled bool
|
|
// Error marks the value invalid and shows the message below.
|
|
Error string
|
|
}
|
|
|
|
// PasswordInput is a masked field with a show and hide toggle.
|
|
func PasswordInput(c *ui.Context, value *string, opts PasswordInputOptions) InputResult {
|
|
if value == nil {
|
|
panic("mujica: PasswordInput needs a value")
|
|
}
|
|
var r InputResult
|
|
look := &textInputLook{disabled: opts.Disabled, err: opts.Error}
|
|
r.Element, r.Input = textInputFrame(c, look, func(frame ui.Element) ui.Element {
|
|
shown := ui.Local(frame, "shown", func() bool { return false })
|
|
var in ui.Element
|
|
// MyGo's mask cannot be lifted, so each mode keeps its own editor.
|
|
mode := "masked"
|
|
if *shown {
|
|
mode = "shown"
|
|
}
|
|
ui.Row(c.Key(mode)).Grow(1).Children(func() {
|
|
in = TextInputEditor(c, frame, value, look.disabled, ui.TextInputBase).Grow(1).MinWidth(core.Density(c).Unit() * 10).
|
|
Placeholder(opts.Placeholder).Label(opts.Label)
|
|
if !*shown {
|
|
in.Password()
|
|
}
|
|
})
|
|
r.changed = in.Changed() && !look.disabled
|
|
r.submitted = in.Submitted() && !look.disabled
|
|
if passwordInputToggle(c, *shown) {
|
|
*shown = !*shown
|
|
slog.Debug("mujica: password_input reveal", "shown", *shown)
|
|
}
|
|
return in
|
|
}, nil)
|
|
return r
|
|
}
|
|
|
|
// passwordInputToggle builds the show or hide button and reports a click.
|
|
func passwordInputToggle(c *ui.Context, shown bool) bool {
|
|
name, icon := core.Msg(c, "password_input.show"), "eye"
|
|
if shown {
|
|
name, icon = core.Msg(c, "password_input.hide"), "eye-off"
|
|
}
|
|
return core.IconAction(c, icons.Must(icon), name).Tooltip(name).Clicked()
|
|
}
|