ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
67 lines
1.8 KiB
Go
67 lines
1.8 KiB
Go
package layout
|
|
|
|
import (
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/theme"
|
|
)
|
|
|
|
// ScrollDirection is the way a ScrollArea scrolls. The zero value is vertical.
|
|
type ScrollDirection int
|
|
|
|
const (
|
|
ScrollVertical ScrollDirection = iota
|
|
ScrollHorizontal
|
|
ScrollBoth
|
|
)
|
|
|
|
// ScrollAreaOptions configure a ScrollArea.
|
|
type ScrollAreaOptions struct {
|
|
Direction ScrollDirection
|
|
// Label names the region for assistive technology.
|
|
Label string
|
|
}
|
|
|
|
// ScrollArea scrolls children; state keeps and sets the offset, nil keeps it by place.
|
|
func ScrollArea(c *ui.Context, state *ui.ScrollState, opts ScrollAreaOptions, children func()) ui.Element {
|
|
if children == nil {
|
|
panic("mujica: ScrollArea needs children")
|
|
}
|
|
var e ui.Element
|
|
switch opts.Direction {
|
|
case ScrollVertical:
|
|
e = ui.Scroll(c)
|
|
case ScrollHorizontal:
|
|
e = ui.ScrollHorizontal(c)
|
|
case ScrollBoth:
|
|
e = ui.ScrollBoth(c)
|
|
default:
|
|
panic("mujica: invalid ScrollDirection")
|
|
}
|
|
if state == nil {
|
|
state = ui.Local(e, "scroll_area.state", func() ui.ScrollState { return ui.ScrollState{} })
|
|
}
|
|
e.TrackScroll(state)
|
|
overflow := state.MaxX > 0 || state.MaxY > 0
|
|
if overflow {
|
|
e.Focusable()
|
|
}
|
|
focus := core.Tokens(c).Focus
|
|
// The ring goes inside, past the focus gap: areas often fill a clipped pane.
|
|
e.FocusRing(false).DrawOver(func(p *ui.Painter, r ui.Rect) {
|
|
if overflow != (state.MaxX > 0 || state.MaxY > 0) {
|
|
// Layout changed the overflow: rebuild so the focus stop follows it.
|
|
c.Invalidate()
|
|
}
|
|
if e.FocusVisible() {
|
|
in := theme.FocusGap + theme.FocusWidth/2
|
|
p.Stroke(ui.Rect{X: r.X + in, Y: r.Y + in, W: r.W - 2*in, H: r.H - 2*in}, focus, theme.ControlRadius, theme.FocusWidth)
|
|
}
|
|
})
|
|
if opts.Label != "" {
|
|
e.Label(opts.Label)
|
|
}
|
|
return e.Children(children)
|
|
}
|