ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
107 lines
3.2 KiB
Go
107 lines
3.2 KiB
Go
package account
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/input"
|
|
)
|
|
|
|
// accountTester runs a themed view inside a padded column.
|
|
func accountTester(w, h int, view func(c *ui.Context)) *ui.Tester {
|
|
return ui.NewTester(func(c *ui.Context) {
|
|
core.Use(c, core.Settings{})
|
|
ui.Column(c).Padding(10).Fill().Children(func() { view(c) })
|
|
}, w, h)
|
|
}
|
|
|
|
var settingsPages = []SettingsPage{{ID: "general", Label: "General"}, {ID: "privacy", Label: "Privacy"}}
|
|
|
|
func settingsView(c *ui.Context, page *string, sound, track *bool, changes *int) {
|
|
if SettingsLayout(c, page, settingsPages, SettingsLayoutOptions{}, func(id string) {
|
|
switch id {
|
|
case "general":
|
|
SettingsSection(c, "Notifications", func() {
|
|
SettingsRow(c, "Sound", SettingsRowOptions{ID: "sound", Description: "Chime on new messages."}, func() ui.Element {
|
|
return input.Switch(c, sound, "", input.SwitchOptions{})
|
|
})
|
|
})
|
|
case "privacy":
|
|
SettingsSection(c, "Data", func() {
|
|
SettingsRow(c, "Usage reports", SettingsRowOptions{ID: "track"}, func() ui.Element {
|
|
return input.Switch(c, track, "", input.SwitchOptions{})
|
|
})
|
|
})
|
|
}
|
|
}).Changed() {
|
|
*changes++
|
|
}
|
|
}
|
|
|
|
func TestSettingsLayoutNavigatesAndLabelsRows(t *testing.T) {
|
|
page, sound, track, n := "", false, false, 0
|
|
tt := accountTester(900, 500, func(c *ui.Context) { settingsView(c, &page, &sound, &track, &n) })
|
|
if page != "general" || !tt.HasText("Chime on new messages.") {
|
|
t.Fatalf("first page: %q", page)
|
|
}
|
|
if err := tt.Click("Chime on new messages."); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
tt.Key(0, ui.KeySpace)
|
|
if !tt.Focused("Sound") || !sound {
|
|
t.Fatal("row label does not reach its control")
|
|
}
|
|
if err := tt.Click("Privacy"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if page != "privacy" || n != 1 || !tt.HasText("Usage reports") || tt.HasText("Sound") {
|
|
t.Fatalf("page %q changes %d texts %q", page, n, tt.Texts())
|
|
}
|
|
}
|
|
|
|
func TestSettingsLayoutRejectsUnknownPage(t *testing.T) {
|
|
defer func() {
|
|
if recover() == nil {
|
|
t.Fatal("unknown page accepted")
|
|
}
|
|
}()
|
|
page := "nope"
|
|
accountTester(400, 300, func(c *ui.Context) { SettingsLayout(c, &page, settingsPages, SettingsLayoutOptions{}, func(string) {}) })
|
|
}
|
|
|
|
func TestSettingsLayoutSnapshot(t *testing.T) {
|
|
snapshot(t, "settings_layout", 860, 360, func(c *ui.Context) {
|
|
st := ui.Local(c.Root(), "snap", func() [3]bool { return [3]bool{false, true, false} })
|
|
page := "general"
|
|
ui.Box(c).Fill().Children(func() { settingsView(c, &page, &st[1], &st[2], new(int)) })
|
|
})
|
|
}
|
|
|
|
func accountPanics(t *testing.T, view func(*ui.Context)) {
|
|
t.Helper()
|
|
defer func() {
|
|
if recover() == nil {
|
|
t.Fatal("invalid options accepted")
|
|
}
|
|
}()
|
|
accountTester(600, 500, view)
|
|
}
|
|
|
|
func TestSettingsLayoutDisabledNavigationAndControl(t *testing.T) {
|
|
page, sound, track, changes := "general", false, false, 0
|
|
tt := accountTester(900, 500, func(c *ui.Context) {
|
|
ui.Column(c).Fill().Disabled(true).Children(func() { settingsView(c, &page, &sound, &track, &changes) })
|
|
})
|
|
if err := tt.Click("Privacy"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
tt.Key(0, ui.KeyTab)
|
|
tt.Key(0, ui.KeyDown)
|
|
tt.Key(0, ui.KeySpace)
|
|
if page != "general" || sound || track || changes != 0 {
|
|
t.Fatal("disabled settings change state")
|
|
}
|
|
}
|