ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
82 lines
2.4 KiB
Go
82 lines
2.4 KiB
Go
package chart
|
||
|
||
import (
|
||
"math"
|
||
"testing"
|
||
|
||
"github.com/egoist/mygo/ui"
|
||
|
||
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
||
)
|
||
|
||
func TestViolinPlotReadout(t *testing.T) {
|
||
h := &chartHarness{build: func(c *ui.Context) ChartResult {
|
||
return ViolinPlot(c, append(densityGroups(), boxGroups[0]), ViolinPlotOptions{Frame: ChartFrame{Label: "Hymns"}})
|
||
}}
|
||
tt := ui.NewTester(h.view, 520, 420)
|
||
tabTo(t, tt, "Hymns")
|
||
tt.Key(0, ui.KeyEnd)
|
||
if got := chartReadout(tt); got != "Choir · median 5.5 · quartiles 3.25–7.75 · 10 values" {
|
||
t.Fatalf("readout %q", got)
|
||
}
|
||
tt.Key(0, ui.KeyEscape)
|
||
b := h.box(tt)
|
||
tt.Move(b.X+52+(b.W-64)/6, b.Y+120)
|
||
if h.res.Point != 0 {
|
||
t.Fatalf("hover %d", h.res.Point)
|
||
}
|
||
}
|
||
|
||
func TestViolinPlotBad(t *testing.T) {
|
||
defer func() {
|
||
if recover() == nil {
|
||
t.Fatal("no panic for an unnamed group")
|
||
}
|
||
}()
|
||
ui.NewTester(func(c *ui.Context) {
|
||
core.Use(c, core.Settings{})
|
||
ViolinPlot(c, []BoxGroup{{Values: []float64{1}}}, ViolinPlotOptions{Frame: ChartFrame{Label: "x"}})
|
||
}, 300, 300)
|
||
}
|
||
|
||
func TestViolinPlotSnapshot(t *testing.T) {
|
||
snapshot(t, "violin_plot", 520, 320, func(c *ui.Context) {
|
||
ui.Column(c).Padding(16).Children(func() {
|
||
ViolinPlot(c, densityGroups(), ViolinPlotOptions{Frame: ChartFrame{Label: "Hymns"}})
|
||
})
|
||
})
|
||
}
|
||
|
||
func TestViolinPlotFiniteBandwidthAndFlatShape(t *testing.T) {
|
||
charts2MustPanic(t, func(c *ui.Context) {
|
||
ViolinPlot(c, []BoxGroup{{Name: "Flat", Values: []float64{4, 4}}}, ViolinPlotOptions{Frame: ChartFrame{Label: "Flat"}, Bandwidth: math.NaN()})
|
||
})
|
||
}
|
||
|
||
func TestViolinPlotLargeDataAndDisabled(t *testing.T) {
|
||
values := make([]float64, 100_000)
|
||
for i := range values {
|
||
values[i] = float64(i % 100)
|
||
}
|
||
groups := []BoxGroup{{Name: "Sample", Values: values}}
|
||
h := &chartHarness{build: func(c *ui.Context) ChartResult {
|
||
return ViolinPlot(c, groups, ViolinPlotOptions{Frame: ChartFrame{Label: "Large violin"}})
|
||
}}
|
||
var shown *[]int
|
||
h.built = func(r ChartResult) { shown = ui.Local(r.Element, "mujica.violin.visible", func() []int { return nil }) }
|
||
tt := ui.NewTester(h.view, 520, 420)
|
||
tabTo(t, tt, "Large violin")
|
||
tt.Key(0, ui.KeyRight)
|
||
if chartReadout(tt) != "Sample · median 49.5 · quartiles 24.75–74.25 · 100000 values" {
|
||
t.Fatalf("large readout %q", chartReadout(tt))
|
||
}
|
||
if len(*shown) != 1 {
|
||
t.Fatalf("built %d violins", len(*shown))
|
||
}
|
||
h.disabled = true
|
||
tt.Frame()
|
||
if h.res.Point != -1 {
|
||
t.Fatalf("disabled violin %d", h.res.Point)
|
||
}
|
||
}
|