ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
77 lines
2.0 KiB
Go
77 lines
2.0 KiB
Go
package feedback
|
|
|
|
import (
|
|
"log/slog"
|
|
"time"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/theme"
|
|
)
|
|
|
|
// PresenceKind is how content comes and goes.
|
|
type PresenceKind int
|
|
|
|
const (
|
|
// PresenceFade fades in and out.
|
|
PresenceFade PresenceKind = iota
|
|
// PresenceSlide fades while moving up into place and down out.
|
|
PresenceSlide
|
|
// PresenceCollapse grows open and shrinks shut along the parent's direction.
|
|
PresenceCollapse
|
|
)
|
|
|
|
// PresenceOptions configure a Presence.
|
|
type PresenceOptions struct {
|
|
Kind PresenceKind
|
|
// Duration is PopupDuration when zero.
|
|
Duration time.Duration
|
|
}
|
|
|
|
// presenceMotion is where content comes from and goes.
|
|
func presenceMotion(kind PresenceKind) *ui.Motion {
|
|
switch kind {
|
|
case PresenceFade:
|
|
return &ui.Motion{}
|
|
case PresenceSlide:
|
|
return &ui.Motion{Y: 8}
|
|
case PresenceCollapse:
|
|
return &ui.Motion{Collapse: true, Opacity: 1}
|
|
}
|
|
panic("mujica: unknown PresenceKind")
|
|
}
|
|
|
|
type presenceState struct{ shown bool }
|
|
|
|
// Presence builds content while show, entering and exiting with motion.
|
|
func Presence(c *ui.Context, show bool, opts PresenceOptions, content func()) ui.Element {
|
|
m := presenceMotion(opts.Kind)
|
|
if opts.Duration < 0 {
|
|
panic("mujica: Presence Duration is negative")
|
|
}
|
|
d := opts.Duration
|
|
if d == 0 {
|
|
d = theme.PopupDuration
|
|
}
|
|
holder := ui.Column(c).AlignItems(ui.Stretch).Shrink(0)
|
|
st := ui.Local(holder, "presence", func() presenceState { return presenceState{shown: show} })
|
|
if st.shown != show {
|
|
st.shown = show
|
|
slog.Debug("mujica: presence", "show", show)
|
|
}
|
|
holder.Children(func() {
|
|
if !show {
|
|
if c.Preferences().ReduceMotion {
|
|
// Rebuilding the empty slot cancels MyGo's active exit.
|
|
ui.Column(c.Key("presence")).Invisible().Transition(ui.ElementTransition{Duration: d, Position: true})
|
|
}
|
|
return
|
|
}
|
|
box := ui.Column(c.Key("presence")).AlignItems(ui.Stretch)
|
|
box.Transition(ui.ElementTransition{Duration: core.Motion(c, d), Enter: m, Exit: m})
|
|
box.Children(content)
|
|
})
|
|
return holder
|
|
}
|