ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
86 lines
2.4 KiB
Go
86 lines
2.4 KiB
Go
package feedback
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
)
|
|
|
|
func TestPresenceEntersExitsAndRemoves(t *testing.T) {
|
|
for _, kind := range []PresenceKind{PresenceFade, PresenceSlide, PresenceCollapse} {
|
|
show := false
|
|
tt, n := motionFrames(func(c *ui.Context) {
|
|
ui.Column(c).Children(func() {
|
|
Presence(c, show, PresenceOptions{Kind: kind}, func() { ui.Text(c, "Notice") })
|
|
ui.Text(c, "Below")
|
|
})
|
|
}, 300, 120)
|
|
if tt.HasText("Notice") {
|
|
t.Fatal("hidden content built")
|
|
}
|
|
show = true
|
|
before := *n
|
|
tt.Frame()
|
|
if !tt.HasText("Notice") || *n-before < 3 {
|
|
t.Fatalf("kind %d: no entry motion (%d frames)", kind, *n-before)
|
|
}
|
|
tt.Advance(250 * time.Millisecond)
|
|
show = false
|
|
before = *n
|
|
tt.Frame()
|
|
if *n-before < 3 {
|
|
t.Fatalf("kind %d: no exit motion", kind)
|
|
}
|
|
tt.Advance(250 * time.Millisecond)
|
|
if tt.HasText("Notice") || motionBusy(tt, n) {
|
|
t.Fatalf("kind %d: not removed after exit", kind)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestPresenceReducedMotionAndInvalid(t *testing.T) {
|
|
show := false
|
|
tt, n := motionFrames(func(c *ui.Context) {
|
|
ui.Column(c).Children(func() { Presence(c, show, PresenceOptions{Kind: PresenceSlide}, func() { ui.Text(c, "Notice") }) })
|
|
}, 300, 120)
|
|
tt.SetPreferences(ui.Preferences{ReduceMotion: true, TextScale: 1})
|
|
show = true
|
|
if motionBusy(tt, n) || !tt.HasText("Notice") {
|
|
t.Fatal("reduced motion animated")
|
|
}
|
|
defer func() {
|
|
if recover() == nil {
|
|
t.Fatal("unknown kind did not panic")
|
|
}
|
|
}()
|
|
ui.Render(func(c *ui.Context) { core.Use(c, core.Settings{}); Presence(c, true, PresenceOptions{Kind: 9}, nil) }, 100, 50, 1)
|
|
}
|
|
|
|
func TestPresenceSnapshot(t *testing.T) {
|
|
snapshot(t, "presence", 300, 100, func(c *ui.Context) {
|
|
ui.Column(c).Padding(16).Children(func() {
|
|
Presence(c, true, PresenceOptions{}, func() { ui.Text(c, "The doors open.") })
|
|
})
|
|
})
|
|
}
|
|
|
|
func TestPresenceReducedMotionCancelsActiveExit(t *testing.T) {
|
|
show := true
|
|
tt, n := motionFrames(func(c *ui.Context) {
|
|
Presence(c, show, PresenceOptions{Duration: 5 * time.Second}, func() { ui.Text(c, "Leaving notice") })
|
|
}, 300, 100)
|
|
show = false
|
|
tt.Frame()
|
|
tt.SetPreferences(ui.Preferences{ReduceMotion: true, TextScale: 1})
|
|
if motionBusy(tt, n) || tt.HasText("Leaving notice") {
|
|
t.Fatal("active exit continued under reduced motion")
|
|
}
|
|
tt.SetPreferences(ui.Preferences{TextScale: 1})
|
|
if motionBusy(tt, n) {
|
|
t.Fatal("exit replayed after restoring motion")
|
|
}
|
|
}
|