ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
73 lines
1.8 KiB
Go
73 lines
1.8 KiB
Go
package feedback
|
|
|
|
import (
|
|
"math"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/internal"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/theme"
|
|
)
|
|
|
|
// ShimmerOptions configure a Shimmer placeholder.
|
|
type ShimmerOptions struct {
|
|
// Width fills the parent when zero.
|
|
Width float32
|
|
// Height is ControlHeight when zero.
|
|
Height float32
|
|
// Label is read out while loading; empty means "Loading".
|
|
Label string
|
|
}
|
|
|
|
// Shimmer sweeps a placeholder while loading, then builds content.
|
|
func Shimmer(c *ui.Context, loading bool, opts ShimmerOptions, content func()) ui.Element {
|
|
if !(opts.Width >= 0) || !(opts.Height >= 0) || math.IsInf(float64(opts.Width+opts.Height), 1) {
|
|
panic("mujica: Shimmer size must be finite and not negative")
|
|
}
|
|
if !loading {
|
|
box := ui.Column(c).AlignItems(ui.Stretch)
|
|
if content != nil {
|
|
box.Children(content)
|
|
}
|
|
return box
|
|
}
|
|
k := core.Tokens(c)
|
|
h := opts.Height
|
|
if h == 0 {
|
|
h = core.Density(c).ControlHeight()
|
|
}
|
|
label := opts.Label
|
|
if label == "" {
|
|
label = core.Msg(c, "shimmer.loading")
|
|
}
|
|
fill := k.SurfaceHover
|
|
if k.Dark {
|
|
fill = k.Border
|
|
}
|
|
still := c.Preferences().ReduceMotion
|
|
e := ui.Column(c).Height(h).AlignItems(ui.Stretch).Role(ui.RoleProgress).Label(label)
|
|
if opts.Width > 0 {
|
|
e.Width(opts.Width)
|
|
} else {
|
|
e.FillWidth()
|
|
}
|
|
// Keyed by motion so a flip repaints.
|
|
e.Children(func() {
|
|
ui.Box(c.Key(still)).Grow(1).Role(ui.RoleNone).Draw(func(p *ui.Painter, r ui.Rect) {
|
|
p.Fill(r, fill, theme.CardRadius)
|
|
if still {
|
|
return
|
|
}
|
|
p.AnimationFrame()
|
|
t := float32(p.Now().UnixMilli()%1600) / 1600
|
|
band := max(r.W*0.25, 24)
|
|
x := internal.Snap(p, r.X-band+(r.W+band)*t)
|
|
p.Clip(r, theme.CardRadius, func() {
|
|
p.Fill(ui.Rect{X: x, Y: r.Y, W: band, H: r.H}, k.Surface.Alpha(0.55), 0)
|
|
})
|
|
})
|
|
})
|
|
return e
|
|
}
|