ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
78 lines
2.1 KiB
Go
78 lines
2.1 KiB
Go
package feedback
|
|
|
|
import (
|
|
"bytes"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
)
|
|
|
|
func TestShimmerTextSweepsAndStops(t *testing.T) {
|
|
active := true
|
|
tt, n := motionFrames(func(c *ui.Context) {
|
|
ShimmerText(c, "Thinking", ShimmerTextOptions{Active: active})
|
|
}, 200, 60)
|
|
if _, ok := tt.Find("Thinking"); !ok {
|
|
t.Fatal("text not named")
|
|
}
|
|
a := encode(t, tt.Image())
|
|
tt.Advance(200 * time.Millisecond)
|
|
if bytes.Equal(a, encode(t, tt.Image())) || !motionBusy(tt, n) {
|
|
t.Fatal("no sweep")
|
|
}
|
|
active = false
|
|
tt.Frame()
|
|
if motionBusy(tt, n) || !tt.HasText("Thinking") {
|
|
t.Fatal("inactive text still sweeps")
|
|
}
|
|
active = true
|
|
tt.SetPreferences(ui.Preferences{ReduceMotion: true, TextScale: 1})
|
|
if motionBusy(tt, n) {
|
|
t.Fatal("sweeps under reduced motion")
|
|
}
|
|
defer func() {
|
|
if recover() == nil {
|
|
t.Fatal("empty text did not panic")
|
|
}
|
|
}()
|
|
ui.Render(func(c *ui.Context) {
|
|
core.Use(c, core.Settings{})
|
|
ShimmerText(c, "", ShimmerTextOptions{})
|
|
}, 100, 50, 1)
|
|
}
|
|
|
|
func TestShimmerTextSnapshot(t *testing.T) {
|
|
snapshot(t, "shimmer_text", 300, 80, func(c *ui.Context) {
|
|
ui.Column(c).Padding(16).Gap(8).Children(func() {
|
|
ShimmerText(c, "Thinking…", ShimmerTextOptions{Active: true})
|
|
ShimmerText(c, "思考中…", ShimmerTextOptions{})
|
|
})
|
|
})
|
|
}
|
|
|
|
func TestShimmerTextConstrainedWidth(t *testing.T) {
|
|
var background ui.Color
|
|
tt := ui.NewTester(func(c *ui.Context) {
|
|
core.Use(c, core.Settings{})
|
|
background = core.Tokens(c).Background
|
|
ui.Column(c).Padding(10).Children(func() {
|
|
ShimmerText(c, "Thinking about the complete program and planning the next steps", ShimmerTextOptions{Active: true}).Width(80)
|
|
})
|
|
}, 500, 100)
|
|
for _, reduce := range []bool{false, true} {
|
|
tt.SetPreferences(ui.Preferences{ReduceMotion: reduce, TextScale: 1})
|
|
img := tt.Image()
|
|
for y := 0; y < img.Bounds().Dy(); y++ {
|
|
for x := 92; x < img.Bounds().Dx(); x++ {
|
|
pixel := img.RGBAAt(x, y)
|
|
if pixel.R != background.R || pixel.G != background.G || pixel.B != background.B {
|
|
t.Fatalf("text escaped 80 DIP width at %d,%d", x, y)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|