ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
84 lines
2.2 KiB
Go
84 lines
2.2 KiB
Go
package project
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
)
|
|
|
|
func TestIssueIdBadgeCopy(t *testing.T) {
|
|
n, disabled := 0, false
|
|
tt := ui.NewTester(func(c *ui.Context) {
|
|
core.Use(c, core.Settings{})
|
|
ui.Column(c).Children(func() {
|
|
if IssueIdBadge(c, "ENG-123", IssueIdBadgeOptions{Copyable: true, Disabled: disabled}).Changed() {
|
|
n++
|
|
}
|
|
IssueIdBadge(c, "OPS-7", IssueIdBadgeOptions{})
|
|
})
|
|
}, 300, 120)
|
|
_ = tt.Click("Copy ENG-123")
|
|
if tt.Clipboard() != "ENG-123" || n != 1 || !tt.HasText("Copied") {
|
|
t.Fatalf("copy %q %d %v", tt.Clipboard(), n, tt.Texts())
|
|
}
|
|
if a := tt.Announcements(); len(a) != 1 || a[0] != "ENG-123 copied" {
|
|
t.Fatalf("announce %q", a)
|
|
}
|
|
tt.SetClipboard("")
|
|
tt.Key(0, ui.KeyTab)
|
|
tt.Key(0, ui.KeyEnter)
|
|
if tt.Clipboard() != "ENG-123" || n != 2 {
|
|
t.Fatal("Enter should copy")
|
|
}
|
|
if !tt.HasText("OPS-7") || tt.HasText("Copy OPS-7") {
|
|
t.Fatal("plain badge should not be a button")
|
|
}
|
|
disabled = true
|
|
tt.SetClipboard("")
|
|
tt.Frame()
|
|
_ = tt.Click("Copy ENG-123")
|
|
if tt.Clipboard() != "" || n != 2 {
|
|
t.Fatal("disabled badge copied")
|
|
}
|
|
}
|
|
|
|
func TestIssueIdBadgeCopiedFades(t *testing.T) {
|
|
tt := ui.NewTester(func(c *ui.Context) {
|
|
core.Use(c, core.Settings{})
|
|
IssueIdBadge(c, "ENG-1", IssueIdBadgeOptions{Copyable: true})
|
|
}, 300, 120)
|
|
_ = tt.Click("Copy ENG-1")
|
|
if !tt.HasText("Copied") {
|
|
t.Fatal("no Copied note")
|
|
}
|
|
tt.Advance(issueCopiedFor + 50*time.Millisecond)
|
|
if tt.HasText("Copied") {
|
|
t.Fatal("Copied should go away")
|
|
}
|
|
}
|
|
|
|
func TestIssueIdBadgeInvalid(t *testing.T) {
|
|
for _, id := range []string{"eng-1", "ENG-0", "ENG123", ""} {
|
|
func() {
|
|
defer func() {
|
|
if recover() == nil {
|
|
t.Errorf("%q: expected panic", id)
|
|
}
|
|
}()
|
|
ui.NewTester(func(c *ui.Context) { core.Use(c, core.Settings{}); IssueIdBadge(c, id, IssueIdBadgeOptions{}) }, 10, 10)
|
|
}()
|
|
}
|
|
}
|
|
|
|
func TestIssueIdBadgeSnapshot(t *testing.T) {
|
|
snapshot(t, "issue_id_badge", 300, 60, func(c *ui.Context) {
|
|
ui.Row(c).Padding(16).Gap(12).AlignItems(ui.Center).Children(func() {
|
|
IssueIdBadge(c, "ENG-123", IssueIdBadgeOptions{Copyable: true})
|
|
IssueIdBadge(c, "OPS-7", IssueIdBadgeOptions{})
|
|
})
|
|
})
|
|
}
|