ZacharyZhang-NY/OmaPhoto
1
1 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Tab drags: the press measured where it lands; another button's move drags nothing (13.14)

Browse Source
This commit is contained in:
ZacharyZhang-NY committed 2026-10-01 17:25:57 -04:00
1 parent 5be68a4f96
commit 91dc6f2252
1 file changed
+5 -6
Download Patch File Download Diff File Expand all files Collapse all files
tests/ProjectTabDragTests.cpp
+5 -6
View File
@@ -48,7 +48,7 @@ struct Strip {
ProjectTabButton &tab = button(strip, title);
const QPoint point = tab.mapTo(&strip, QPoint(20, 14));
pressed = &select(tab);
QTest::mousePress(pressed, Qt::LeftButton, {}, QPoint(20 - pressed->x(), 14));
QTest::mousePress(pressed, Qt::LeftButton, {}, pressed->mapFrom(&strip, point));
return point;
}
void move(QPoint point) { QTest::mouseMove(pressed, pressed->mapFrom(&strip, point)); }
@@ -158,11 +158,10 @@ void ProjectTabDragTests::aSmallOrUpwardMoveIsAClick()
fixture.move(start + QPoint(2, -3));
QCOMPARE(fixture.workspace.selectedID(), fixture.workspace.tabs()[2]->id);
QCOMPARE(button(fixture.strip, "Untitled").x(), 0);
// A move with the button let go unseen drags nothing.
QMouseEvent unheld(QEvent::MouseMove, QPointF(fixture.pressed->mapFrom(&fixture.strip, start + QPoint(200, 0))),
QPointF(fixture.pressed->mapToGlobal(fixture.pressed->mapFrom(&fixture.strip, start + QPoint(200, 0)))), Qt::NoButton,
Qt::NoButton, Qt::NoModifier);
QApplication::sendEvent(fixture.pressed, &unheld);
// Its release lost, a move under another button drags nothing.
const QPoint far = fixture.pressed->mapFrom(&fixture.strip, start + QPoint(200, 0));
QMouseEvent other(QEvent::MouseMove, QPointF(far), QPointF(fixture.pressed->mapToGlobal(far)), Qt::NoButton, Qt::RightButton, Qt::NoModifier);
QApplication::sendEvent(fixture.pressed, &other);
QCOMPARE(button(fixture.strip, "Untitled").x(), 0);
fixture.release("Untitled", start + QPoint(2, -3));
// The click selects; the order stays.