Files
ely-eye/bench/scale_check.py
T
ZacharyZhang-NY 9cb46c18d3 Keep every file inside the rules the repo already wrote down
The 500-line rule and the one-line-comment rule were enforced only from
memory, so they drifted. bench/filesize_check.py now checks the budget on
every tracked source file, and it passes.

Split, with behaviour proven unchanged by comparing each moved function body
against HEAD byte for byte (53 training bodies, 21 benchmark bodies, 0
differences):

  db.py        503 -> 396   store_search.py     105
  bench/run.py 609 -> 351   query_set.py         80, report.py 211
  benchmarks.py 619 -> 424  benchmark_scoring.py 262
  training.py 1630 ->  94   training_{common,encode,metrics,datasets,lora,retrieval}

TrainingService stays as a thin facade for the CLI; the facade's parameter
lists are pinned against the module functions by inspect, which is what
catches a leaked self.

Deleted the eight top-level functions no file called, after fixing the scan
that had reported 201 false positives by skipping the defining file. The
v1/v2/v3 sweep found nothing to delete and says so: every remaining version
tag is an on-disk format marker, a migration step, a fixture name, or a
third-party model name.

Collapsed 39 multi-line comment blocks (86 lines) to one line each, keeping
the measured facts and error strings that justify the code.

269 tests pass; ruff clean; mypy 24 errors in 9 files against a 24-in-6
baseline, net zero; pyright 4, the same four HEAD measures.
2026-10-08 08:20:21 -04:00

126 lines
4.7 KiB
Python

"""Time the product's own search at the size the acceptance contract names.
The baseline recorded RetrievalService.search at p50 20.16s over 165,973 atoms because it
pulled every atom into Python and rebuilt a BM25 index per query. This check answers one
question with a number: what does the same call cost now, on the same corpus, on an idle
machine, with the same thread budget the benchmark pins?
"""
from __future__ import annotations
import argparse
import json
import time
from pathlib import Path
from typing import Any
from bench.query_set import load_queries, scale_probes
from bench.run import latency
from bench.systems import machine_facts
DEFAULT_HOME = Path("bench/runs/baseline")
MIN_ATOMS = 100_000
DEFAULT_PROBES = 300
def measure(home: Path, probes: int) -> dict[str, Any]:
"""Open the product store (migrating it in place if it is old) and time real searches."""
from ely_eye.config import Settings
from ely_eye.db import Database
from ely_eye.retrieval import RetrievalService
if not (home / "data" / "ely_eye.sqlite").is_file():
raise SystemExit(
f"{home / 'data' / 'ely_eye.sqlite'}: no product database, "
"build it with python -m bench.ingest_baseline"
)
settings = Settings(home=home)
started = time.perf_counter()
database = Database(settings)
migration_seconds = time.perf_counter() - started
atoms = database.atom_count()
if atoms < MIN_ATOMS:
raise SystemExit(f"{database.path}: {atoms} atoms, this check needs at least {MIN_ATOMS}")
queries = scale_probes(load_queries(), probes)
service = RetrievalService(settings, database)
service.search(queries[0].text) # warm the index and any model before the first sample
times: list[float] = []
for query in queries:
began = time.perf_counter()
service.search(query.text)
times.append(time.perf_counter() - began)
return {
"database": str(database.path),
"atoms": atoms,
"migration_seconds": migration_seconds,
"dense_embeddings_enabled": settings.dense_embeddings_enabled,
"probes": len(queries),
"probe_modalities": sorted({query.modality for query in queries}),
"latency": latency(times),
"machine": machine_facts(),
}
def write_markdown(report: dict[str, Any], path: Path) -> None:
timing = report["latency"]
machine = report["machine"]
path.write_text(
"\n".join(
[
"# SCALE: the product's own search at corpus size",
"",
f"- database: {report['database']}",
(
f"- atoms: {report['atoms']}, probes: {report['probes']} "
f"({', '.join(report['probe_modalities'])})"
),
f"- dense embeddings: {report['dense_embeddings_enabled']}",
f"- opening the store (migrations included): {report['migration_seconds']:.3f}s",
(
f"- p50 {timing['p50']:.4f}s · p95 {timing['p95']:.4f}s · max {timing['max']:.4f}s "
f"over {timing['queries']} queries"
),
(
f"- machine: {machine['system']} {machine['release']}, {machine['cpus']} cores, "
f"{machine['threads_per_query']} threads per query, "
f"load {machine['load_average_1_5_15']}"
),
"",
(
"_Latency is wall time per search call on an idle machine with the thread budget "
"the benchmark pins; a run on a loaded machine is not comparable._"
),
"",
]
),
encoding="utf-8",
)
def main() -> None:
parser = argparse.ArgumentParser(description=__doc__)
parser.add_argument("--home", type=Path, default=DEFAULT_HOME)
parser.add_argument("--probes", type=int, default=DEFAULT_PROBES)
parser.add_argument("--out", type=Path, default=Path("bench/reports/SCALE.md"))
parser.add_argument("--json-out", type=Path, default=Path("bench/reports/scale.json"))
args = parser.parse_args()
if args.probes <= 0:
raise SystemExit(f"--probes must be positive, got {args.probes}")
report = measure(args.home, args.probes)
args.json_out.parent.mkdir(parents=True, exist_ok=True)
args.json_out.write_text(json.dumps(report, indent=2, ensure_ascii=False), encoding="utf-8")
write_markdown(report, args.out)
timing = report["latency"]
print(
f"{report['atoms']} atoms, {report['probes']} probes: "
f"p50 {timing['p50']:.4f}s p95 {timing['p95']:.4f}s",
flush=True,
)
if __name__ == "__main__":
main()