ZacharyZhang-NY/omarchy
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Escape commas in the keyboard preselect; gum splits --selected on them

Browse Source
This commit is contained in:
ZacharyZhang-NY committed 2026-10-09 00:52:26 -04:00
1 parent c08a1bc3c2
commit 76b9331d8b
2 files changed
+3 -3
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

install/provisioning/setup-form.sh
+1 -1
View File
@@ -151,7 +151,7 @@ omarchy_prompt_language() {
omarchy_prompt_keyboard() {
local choice status selected=${1:-English (US)}
choice=$(printf '%s\n' "$OMARCHY_KEYBOARD_LAYOUTS" | cut -d'|' -f1 |
gum choose --height 10 --selected "$selected" --header "$(omarchy_text "Select keyboard layout")") && status=0 || status=$?
gum choose --height 10 --selected "${selected//,/\\,}" --header "$(omarchy_text "Select keyboard layout")") && status=0 || status=$?
((status == 0)) || return $status
local selection
test/shell.d/setup-form-test.sh
+2 -2
View File
@@ -170,8 +170,8 @@ grep -qF -- '--selected English (US)' "$GUM_ARGS" || fail "keyboard prompt prese
pass "keyboard prompt maps the chosen label to its keymap"
PROMPT_ARG="Chinese (Simplified, Pinyin)" run_prompt omarchy_prompt_keyboard "0:Chinese (Simplified, Pinyin)"
grep -qF -- '--selected Chinese (Simplified, Pinyin)' "$GUM_ARGS" && [[ $(field keyboard_input_method) == "pinyin" ]] ||
fail "keyboard prompt preselects the layout its caller names"
grep -qF -- '--selected Chinese (Simplified\, Pinyin)' "$GUM_ARGS" && [[ $(field keyboard_input_method) == "pinyin" ]] ||
fail "keyboard prompt preselects the layout its caller names, escaping the comma gum splits --selected on"
pass "keyboard prompt preselects the layout its caller names"
for selection in 'Japanese|jp106|mozc|' 'Japanese (US keyboard)|us|mozc|' 'Korean|us|hangul|kr' 'Chinese (Simplified, Pinyin)|us|pinyin|' 'Chinese (Traditional, Zhuyin)|us|chewing|'; do