Let a received Taildrop file wait to be answered (#7953)

* Let a received Taildrop file wait to be answered A delivery can land hours after it was sent, and the toast announcing it was expiring after five seconds -- so a file that arrived while nobody was at the machine was gone from the screen before anyone could click it open. Critical urgency is what the shell reads as a popup that lives until it is clicked or dismissed, the same thing omarchy-crash-watch uses to keep its click-to-diagnose toast around. The wrapper takes options after the headline and description as well as before, which is how this argument list is built. That path had no test, and it fails quietly rather than loudly: the wrapper appends its own default urgency last, so an urgency it stopped parsing would reach notify-send as `-u critical ... -u low` and the toast would go back to expiring. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-Authored-By: Codex XHigh <noreply@openai.com> * Say it in the commit message, not above the code `-u critical` next to a line that builds a notification says what it does, and the five lines explaining why it is there were a recap of the change rather than something the code could not say. The reasoning stays where it belongs, in the commit that made the change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: David Heinemeier Hansson <david@hey.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-authored-by: Codex XHigh <noreply@openai.com>
2026-08-23 22:12:07 +02:00
parent f4f3d4c71a
commit 7e469f962d
4 changed files with 22 additions and 3 deletions
@@ -59,7 +59,7 @@ claim_path() {
 announce() {
  local path="$1"
  local name="${path##*/}"
-  local args=("Received $name" "Saved to ${dir/#$HOME/~}")
+  local args=("Received $name" "Saved to ${dir/#$HOME/~}" -u critical)

  case "${name,,}" in
  *.png | *.jpg | *.jpeg | *.gif | *.webp | *.avif | *.bmp | *.tif | *.tiff)
@@ -36,7 +36,7 @@ SSH is off until you turn it on with _Setup > Security > SSHD_, which starts the

 [Tailscale](https://tailscale.com/) is a mesh VPN that makes reaching all your computers and servers over the internet simple and secure. Install it with _Install > Service > Tailscale_.

-That gives you a Tailscale panel in the bar, which connects and disconnects the tailnet, switches accounts, and picks an exit node — your own machines and Mullvad regions both show up in the list. It also browses your machines, and that's where Taildrop lives: select a machine and press `s` to send it files, or `c`, `n`, and `d` to copy its IP, name, or full DNS name. The terminal equivalent is `omarchy tailscale send <machine> [file...]`, and files sent to you land in `~/Downloads` automatically.
+That gives you a Tailscale panel in the bar, which connects and disconnects the tailnet, switches accounts, and picks an exit node — your own machines and Mullvad regions both show up in the list. It also browses your machines, and that's where Taildrop lives: select a machine and press `s` to send it files, or `c`, `n`, and `d` to copy its IP, name, or full DNS name. The terminal equivalent is `omarchy tailscale send <machine> [file...]`, and files sent to you land in `~/Downloads` automatically. The notification announcing an arrival waits until you click it open or dismiss it, so a file that turns up while you're away from the machine is still there to answer when you get back.

 Installing it also adds a web app for the Tailscale admin console.

@@ -37,6 +37,20 @@ pass "notification wrapper supports app, glyph, urgency, image, and exec options
 # libnotify action round-trip.
 grep -q -- "-A" "$args_file" && fail "notification wrapper must not register a libnotify action"

+: >"$args_file"
+OMARCHY_TEST_NOTIFY_ARGS="$args_file" PATH="$tmpdir:$ROOT/bin:$PATH" \
+  omarchy-notification-send "Received photo.png" "Saved to ~/Downloads" -u critical -g K
+
+mapfile -t args <"$args_file"
+
+[[ ${args[2]} == "-u" && ${args[3]} == "critical" ]] ||
+  fail "notification wrapper reads an urgency that follows the description" "$(printf '%s ' "${args[@]}")"
+(( $(grep -cFx -- "-u" "$args_file") == 1 )) ||
+  fail "notification wrapper sets the urgency once" "$(printf '%s ' "${args[@]}")"
+[[ ${args[4]} == "--hint=string:omarchy-glyph:K" ]] ||
+  fail "notification wrapper reads a glyph that follows the description" "$(printf '%s ' "${args[@]}")"
+pass "notification wrapper reads options that follow the headline and description"
+
 : >"$args_file"
 OMARCHY_TEST_NOTIFY_ARGS="$args_file" PATH="$tmpdir:$ROOT/bin:$PATH" \
  omarchy-notification-send "Plain" >/dev/null
@@ -52,10 +52,15 @@ notifications=$(<"$WORKDIR/notifications")
  fail "taildrop receive saves incoming files" "$(ls "$downloads")"
 pass "taildrop receive saves incoming files"

-grep -qF -- "Received photo.png Saved to $downloads --image $downloads/photo.png" <<<"$notifications" ||
+grep -qF -- "Received photo.png Saved to $downloads -u critical --image $downloads/photo.png" <<<"$notifications" ||
  fail "taildrop receive previews received images" "$notifications"
 pass "taildrop receive previews received images"

+while IFS= read -r line; do
+  [[ $line == *"-u critical"* ]] || fail "taildrop receive announcements wait to be answered" "$line"
+done <<<"$notifications"
+pass "taildrop receive announcements wait to be answered"
+
 grep -q "^Received notes with space.pdf .* -g " <<<"$notifications" ||
  fail "taildrop receive announces other files with a glyph" "$notifications"
 pass "taildrop receive announces other files with a glyph"