Decode escaped SSIDs after status parsing

This commit is contained in:
David Heinemeier Hansson
2026-07-31 19:08:37 -07:00
parent b64f5e51fb
commit bac31ff892
3 changed files with 32 additions and 2 deletions
+1 -1
View File
@@ -120,7 +120,7 @@ print_verbose() {
link=$(iw dev "$iface" link 2>/dev/null)
if [[ -n $link ]]; then
printf 'ssid\t%s\n' "$(printf '%b' "$(awk '/SSID:/ { sub(/.*SSID: /, ""); print; exit }' <<<"$link")")"
printf 'ssid\t%s\n' "$(awk '/SSID:/ { sub(/.*SSID: /, ""); print; exit }' <<<"$link")"
printf 'signal_dbm\t%s\n' "$(awk '/signal:/ { print $2; exit }' <<<"$link")"
printf 'freq\t%s\n' "$(awk '/freq:/ { print $2; exit }' <<<"$link")"
printf 'bitrate\t%s %s\n' "$(awk '/tx bitrate:/ { print $3; exit }' <<<"$link")" "$(awk '/tx bitrate:/ { print $4; exit }' <<<"$link")"
+22 -1
View File
@@ -90,7 +90,25 @@ function parseBandStatus(raw) {
}
}
function decodeIwSsid(value) {
var raw = String(value || "")
var encoded = ""
for (var i = 0; i < raw.length; i++) {
if (raw[i] === "\\" && raw[i + 1] === "x" && /^[0-9a-f]{2}$/i.test(raw.substring(i + 2, i + 4))) {
encoded += "%" + raw.substring(i + 2, i + 4)
i += 3
} else {
encoded += encodeURIComponent(raw[i])
}
}
try {
return decodeURIComponent(encoded)
} catch (error) {
return raw
}
}
function parseKeyValue(raw) {
var next = {}
@@ -100,7 +118,9 @@ function parseKeyValue(raw) {
if (!line) continue
var idx = line.indexOf("\t")
if (idx === -1) continue
next[line.substring(0, idx)] = line.substring(idx + 1).trim()
var key = line.substring(0, idx)
var value = line.substring(idx + 1)
next[key] = key === "ssid" ? decodeIwSsid(value) : value.trim()
}
return next
}
@@ -319,6 +339,7 @@ if (typeof module !== "undefined") {
bandSectionTitle: bandSectionTitle,
bandTooltip: bandTooltip,
parseBandStatus: parseBandStatus,
decodeIwSsid: decodeIwSsid,
parseKeyValue: parseKeyValue,
throughputState: throughputState,
pingLatencyState: pingLatencyState,
+9
View File
@@ -26,6 +26,15 @@ assertDeepEqual(
{ iface: 'wlan0', rx_bytes: '100', tx_bytes: '50' },
'network parses detail key values'
)
assertEqual(network.decodeIwSsid('Cafe\\xe2\\x80\\x99'), 'Cafe', 'network decodes UTF-8 SSID bytes')
assertEqual(network.decodeIwSsid('\\x20Cafe\\x20'), ' Cafe ', 'network preserves edge spaces in SSIDs')
assertEqual(network.decodeIwSsid('slash\\x5cname'), 'slash\\name', 'network decodes SSID backslashes once')
assertEqual(network.decodeIwSsid('invalid\\xff'), 'invalid\\xff', 'network preserves invalid UTF-8 escapes')
assertDeepEqual(
network.parseKeyValue('ssid\tline\\x0abreak\\x09tab\\x00nul\nsignal_dbm\t-40\n'),
{ ssid: 'line\nbreak\ttab\0nul', signal_dbm: '-40' },
'network decodes control bytes after parsing detail records'
)
assertDeepEqual(
network.throughputState({ prevIface: '', prevSampleTime: 0 }, { iface: 'wlan0', rx_bytes: '100', tx_bytes: '50' }, 10),
{ prevIface: 'wlan0', prevRxBytes: 100, prevTxBytes: 50, prevSampleTime: 10, downloadRate: 0, uploadRate: 0 },