ZacharyZhang-NY/omarchycn
2
2
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases 3 Wiki Activity

Fix Clone Plugin failing with "unknown clone option" (#6942)

Browse Source 
omarchy-plugin-clone only takes the source id as the first argument, but the
menu passed --edit ahead of it, so the id fell through to the unknown-option
branch and every clone from Setup > Plugins failed.

Closes #6913

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
David Heinemeier Hansson
2026-08-15 17:04:04 +02:00
committed by GitHub
co-authored by Claude Opus 5
parent c0a20e2e43
commit ff4e92e63b
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bin/omarchy-menu-plugin
+1 -1
View File
@@ -38,7 +38,7 @@ id=$(cut -f2 <<<"$selection")
if [[ $1 == "clone" ]]; then if [[ $1 == "clone" ]]; then
omarchy-launch-floating-terminal-with-presentation \ omarchy-launch-floating-terminal-with-presentation \
"omarchy-plugin-clone --edit $(printf '%q' "$id")" "omarchy-plugin-clone $(printf '%q' "$id") --edit"
elif [[ $1 == "remove" ]]; then elif [[ $1 == "remove" ]]; then
omarchy-launch-floating-terminal-with-presentation "omarchy-plugin-remove $(printf '%q' "$id")" omarchy-launch-floating-terminal-with-presentation "omarchy-plugin-remove $(printf '%q' "$id")"
else else
test/shell.d/menu-plugin-test.sh
+1 -1
View File
@@ -111,7 +111,7 @@ pick clone "$(printf 'Clock\tomarchy.clock')"
[[ $ROWS == *"Clock"* && $ROWS != *"Weather"* ]] || [[ $ROWS == *"Clock"* && $ROWS != *"Weather"* ]] ||
fail "clone picker offers only built-in plugins" "$ROWS" fail "clone picker offers only built-in plugins" "$ROWS"
pass "clone picker offers built-in plugins" pass "clone picker offers built-in plugins"
[[ $CALLS == *"terminal: omarchy-plugin-clone --edit omarchy.clock"* ]] || [[ $CALLS == *"terminal: omarchy-plugin-clone omarchy.clock --edit"* ]] ||
fail "clone picker delegates cloning and editing to the clone command" "$CALLS" fail "clone picker delegates cloning and editing to the clone command" "$CALLS"
pass "clone picker clones and opens the personal plugin" pass "clone picker clones and opens the personal plugin"