David Heinemeier HanssonandClaude Opus 5
d2e1587ceb
A bar surface is built per monitor, so a widget in the layout is live once per screen — but an IPC target only ever routes to the handler that registered first. `omarchy.indicators refresh` therefore reached a single bar, and since indicators only re-read their state on that signal, the other screens kept showing a stale reminder count, tmux alert, or DND state until the next reload. Clock and system-update refreshes had the same reach. Let the bar resolve every live instance of a widget id and relay the call to all of them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
46 lines
1.9 KiB
QML
46 lines
1.9 KiB
QML
import QtQuick
|
|
import qs.Commons
|
|
|
|
// Base item every bar widget extends. Codifies the three properties the
|
|
// bar host injects into each widget slot:
|
|
// bar - the host Bar instance (foreground/background/run/etc).
|
|
// moduleName - widget's canonical id, used by the host registry to look
|
|
// up settings and to disambiguate inline IPC routes.
|
|
// settings - per-widget overrides read from shell.json's layout entry.
|
|
//
|
|
// Widgets are free to add their own properties, signals, and child items.
|
|
Item {
|
|
id: root
|
|
|
|
property QtObject bar: null
|
|
property string moduleName: ""
|
|
property var settings: ({})
|
|
|
|
// Bar geometry, lifted off the host. Widgets read these constantly to pick
|
|
// between horizontal/vertical layouts; defining them on the base keeps the
|
|
// `bar ? bar.x : fallback` ternary out of every widget body.
|
|
readonly property bool vertical: bar ? bar.vertical : false
|
|
readonly property int barSize: bar ? bar.barSize : Style.bar.sizeHorizontal
|
|
|
|
// Run `method` on every live instance of this widget. An IPC target only
|
|
// ever routes to one handler, but a bar surface exists per monitor, so the
|
|
// instance that owns the target relays the call to its peers — otherwise a
|
|
// refresh would land on a single screen and leave the others stale.
|
|
function broadcast(method) {
|
|
var items = bar && typeof bar.moduleWidgets === "function"
|
|
? bar.moduleWidgets(moduleName) : [root]
|
|
for (var i = 0; i < items.length; i++) {
|
|
if (items[i] && typeof items[i][method] === "function") items[i][method]()
|
|
}
|
|
}
|
|
|
|
// Read a single value from this widget's inline shell.json entry, with a
|
|
// fallback for missing/null values. Every widget that takes user-tunable
|
|
// settings needs this; defining it once on the base keeps the wiring
|
|
// consistent.
|
|
function setting(name, fallback) {
|
|
var value = settings ? settings[name] : undefined
|
|
return value === undefined || value === null ? fallback : value
|
|
}
|
|
}
|