Commit Graph
162 Commits
Author SHA1 Message Date
ZacharyZhang-NY 5ea25c299b T65: round 1 of its review 2026-10-19 19:47:55 -04:00
ZacharyZhang-NY 0a30760453 T65: a window property marks a move from WM_ENTERSIZEMOVE to WM_EXITSIZEMOVE, so a window blurred mid-move, which gpui gives acrylic at once, takes the clear accent again until the move ends 2026-10-19 19:47:55 -04:00
ZacharyZhang-NY 1384ef5dbe T65: on Windows 10 a blurred window's acrylic clears while it moves or sizes, which a user asked for in issue #3, where a drag trailed the pointer by seconds: below build 22000 the main window's procedure takes gpui's clear accent at WM_ENTERSIZEMOVE and its acrylic again at WM_EXITSIZEMOVE; Windows 11 keeps its acrylic 2026-10-19 19:37:10 -04:00
ZacharyZhang-NY d51823988e T63: round 2 of its review passes 2026-10-19 19:31:52 -04:00
ZacharyZhang-NY c07b1075f0 T63: round 1 of its review 2026-10-19 19:28:03 -04:00
ZacharyZhang-NY ca3809b37c T63: a rename's field that closes while it still holds the window's focus gives it to the shown terminal, since a window that goes inactive blurs the field yet keeps the focus there, which left the terminal deaf to keys once the window came back 2026-10-19 19:28:02 -04:00
ZacharyZhang-NY 3085a940ad T63: a double press on a session's row renames it, which a user asked for after 0.1.6: Ely's ListItem::editor, added for this, draws a field in the title's place; Enter keeps the name, Escape drops it, a blur keeps it; the name stands over the program's title in the row, the header and the window's title until renamed again, and an empty one gives the title back; Ely pinned to 7f7a715 2026-10-19 19:19:09 -04:00
ZacharyZhang-NY 76c48dce2e T62: round 1 of its review passes 2026-10-19 19:06:34 -04:00
ZacharyZhang-NY 760f054976 T62: Ely's shirt and back hair run on below the edge she holds, past her highest lift, which a user asked for after 0.1.6, where a hop lifted her off the window and showed a gap under her collar and hands 2026-10-19 19:00:31 -04:00
ZacharyZhang-NY 0aee06dc27 T61: the terminal logs each caret the input method asks for and each move of the caret; on the owner's Windows PC, WeType put the candidate box at the caret in 23 compositions, so the owner closed the jump a user found unreproduced 2026-10-19 18:51:41 -04:00
ZacharyZhang-NY 690d24f943 T60: round 3 of its review passes 2026-10-19 17:58:38 -04:00
ZacharyZhang-NY 508a16f16a T60: round 2 of its review 2026-10-19 17:48:07 -04:00
ZacharyZhang-NY 5d131e51d8 T60: each fallback picker is keyed by its input, not its place, since Ely's combobox keeps its state by id and listens to the input it first met; after a removal moved the inputs, a picker keyed by place wrote another row's family into its new input at the next blur 2026-10-19 17:48:06 -04:00
ZacharyZhang-NY 885aa4bda0 T60: round 1 of its review 2026-10-19 17:38:33 -04:00
ZacharyZhang-NY 5f8ea89838 T60: removing a fallback drops that row's input and the focus, so no input keeps, or saves on Enter, the family removed; gpui's Linux path, which carries a second fallback into the next character, is recorded as the owner chose 2026-10-19 17:38:32 -04:00
ZacharyZhang-NY cb32f00623 T60: fallback fonts, which a user asked for after 0.1.6: font_fallbacks lists installed families the terminal tries in order for a character Font family lacks, through gpui's Font::fallbacks; each must load as the terminal draws it; Settings › Appearance lists them under Family, each a FontPicker with a remove button, then Add fallback 2026-10-19 17:08:54 -04:00
ZacharyZhang-NY 5cba2ebc72 T66: round 3 of its review passes 2026-10-19 17:01:52 -04:00
ZacharyZhang-NY d56c3c824e T66: round 2 of its review 2026-10-19 16:59:47 -04:00
ZacharyZhang-NY 566056257f T66: cmd doubles the backslashes ending a dropped path, since a program's parser reads one before the closing quote as a quote, as C:\ ends, and a path holding !, which cmd expands inside quotes under /v:on, stops the drop 2026-10-19 16:59:47 -04:00
ZacharyZhang-NY ac5e17af76 T66: round 1 of its review 2026-10-19 16:51:52 -04:00
ZacharyZhang-NY 887378ade3 T66: a dropped path stays literal for the session's own shell, as its name says: POSIX shells escape ^ and ~ too, which zsh's extendedglob reads; PowerShell, Windows' default, single-quotes it with its quotes doubled, so $, $( ) and ; stay text; cmd double-quotes it and refuses a %, which it expands inside quotes 2026-10-19 16:51:51 -04:00
ZacharyZhang-NY 545fb46249 T66: files dropped on the terminal type their paths, which a user asked for after 0.1.6, as macOS Terminal does: each escaped for the shell, or quoted on Windows when it holds a space, followed by a space, sent as a paste; a path not in UTF-8 or holding a control character stops the drop; the font code moves from view.rs to fonts.rs, which view.rs needed room for; shot plays a drop with drop@x,y 2026-10-19 16:40:49 -04:00
ZacharyZhang-NY 390f2b6176 T59: round 5 of its review passes; T66 for files dropped on the terminal 2026-10-19 16:29:37 -04:00
ZacharyZhang-NY 0fcefefef0 T59: round 4 of its review 2026-10-19 16:22:50 -04:00
ZacharyZhang-NY 28d761572d T59: the newest line typed is the one of the highest number, not the lowest on the screen, so a prompt drawn at the top over older lines takes its clicks; a press goes no lower than that line's last row or the cursor's 2026-10-19 16:22:50 -04:00
ZacharyZhang-NY 34be6e3521 T59: round 3 of its review 2026-10-19 16:09:11 -04:00
ZacharyZhang-NY 84364ce03e T59: OSC 133 B stamps the line typed after a prompt with a link of its own, numbered by the commands ended, so a shell whose prompt prints nothing, as fish's empty prompt, takes clicks from its first typed cell, and fish's right prompt drawn again at each key keeps the line 2026-10-19 16:09:11 -04:00
ZacharyZhang-NY 9fa68b24a7 T59: a prompt with no cell before the cursor, as fish's empty left prompt beside a marked right one, starts the input at its first row, where the press assumed a cell and panicked 2026-10-19 15:48:53 -04:00
ZacharyZhang-NY 6b9576f998 T59: round 2 of its review; T65 for issue #3 2026-10-19 15:40:51 -04:00
ZacharyZhang-NY e74ea745fe T59: a click goes to a shell that takes clicks only past its prompt's last cell before the cursor, never on a prompt cell, so a click on fish's $ leaves its cursor where it stood 2026-10-19 15:40:51 -04:00
ZacharyZhang-NY 8dc8fbc51c T59: round 1 of its review 2026-10-19 15:34:17 -04:00
ZacharyZhang-NY 0c55d41026 T59: a shell whose prompt says click_events, as fish from 4.1 does, hears the click as an SGR press and moves its own cursor, since fish moves by code point and its redraws drop the wrap flags a count follows; a press let go in another cell, or released while the program tracks the mouse, moves nothing 2026-10-19 15:34:17 -04:00
ZacharyZhang-NY 82cfe91810 T59: a plain click on the line the shell reads moves its cursor there, which a user asked for after 0.1.6, as Ghostty's cursor-click-to-move: while OSC 133 says the shell reads a line, a click that stays in its cell, past the prompt the cursor's line shows, sends Left or Right arrows through the key encoder, one per character, soft wraps joined; never on the alternate screen, under mouse tracking or with a selection 2026-10-19 15:18:17 -04:00
ZacharyZhang-NY 8ef91855cd T57: v0.1.6's evidence in the release rows of tasks/acceptance.md
CI / platforms (windows-latest) (push) Successful in 1m36s
CI / platforms (ubuntu-24.04) (push) Successful in 1m6s
CI / macos (push) Successful in 12m25s
2026-10-19 11:22:14 -04:00
ZacharyZhang-NY a7aecf2085 T57: v0.1.6 published at 8a9941b with T55, T56 and T58: its zip and tarball from their scripts on the owner's PC and its WSL, its disk image signed and notarized by the Release workflow (run 1343), once CI run 1342 passed on macOS, Ubuntu and Windows; each file downloaded back anonymously matches its SHA-256 in the notes
CI / platforms (ubuntu-24.04) (push) Successful in 1m5s
CI / platforms (windows-latest) (push) Successful in 1m41s
CI / macos (push) Successful in 12m5s
2026-10-19 11:21:50 -04:00
ZacharyZhang-NY 8a9941bfd2 T58: the terminal shows a scrollbar over its history, which a user asked for in issue #2 after 0.1.5, since a program that takes the mouse takes the wheel: a thumb along the right edge, in Ely's sizes and colors, stands where the view stands, and a drag moves the view through the history; none shows without history
CI / platforms (windows-latest) (push) Successful in 1m35s
CI / platforms (ubuntu-24.04) (push) Successful in 2m44s
CI / macos (push) Successful in 14m37s
2026-10-19 11:04:48 -04:00
ZacharyZhang-NY 55250f49f5 T56: Settings › Terminal checks for updates, which the owner asked for after 0.1.5: under Ely, a switch, on by default, checks at start and once a day through curl and Gitea's API, and Check now checks at once; the row says what the check found, a newer release brings Download, which opens its page, and one an automatic check finds posts a notification whose press opens it
CI / macos (push) Canceled after 0s
CI / platforms (windows-latest) (push) Canceled after 1m24s
CI / platforms (ubuntu-24.04) (push) Canceled after 1m32s
2026-10-19 10:39:13 -04:00
ZacharyZhang-NY 17e91aafef T55: a drag moves Ely along the edge she stands on, which the owner asked for after 0.1.5: on macOS, Windows and X11 her window follows the pointer's place on the screen, on Wayland her popup opens again where she is let go; she moves by whole points inside the pane, and the settings keep where she stands as ely_left, 140 by default
CI / platforms (ubuntu-24.04) (push) Successful in 1m11s
CI / platforms (windows-latest) (push) Successful in 1m33s
CI / macos (push) Canceled after 11m8s
2026-10-19 10:30:19 -04:00
ZacharyZhang-NY 3759cf8825 T54: reviewed, ticked
CI / platforms (ubuntu-24.04) (push) Successful in 1m19s
CI / platforms (windows-latest) (push) Successful in 1m50s
CI / macos (push) Successful in 11m48s
2026-10-19 03:21:30 -04:00
ZacharyZhang-NY 15153b4aae T54: v0.1.5 published at 0119776, its zip and tarball from their scripts on the owner's PC and its WSL, its disk image signed and notarized by the Release workflow (run 1312), once CI run 1311 passed on macOS, Ubuntu and Windows; each file downloaded back anonymously matches its SHA-256 in the notes
CI / platforms (ubuntu-24.04) (push) Successful in 1m30s
CI / platforms (windows-latest) (push) Successful in 1m32s
CI / macos (push) Successful in 12m26s
2026-10-19 03:14:28 -04:00
ZacharyZhang-NY a153e89d84 T53: reviewed, ticked
CI / macos (push) Canceled after 0s
CI / platforms (windows-latest) (push) Canceled after 1m38s
CI / platforms (ubuntu-24.04) (push) Canceled after 2m5s
2026-10-19 02:55:04 -04:00
ZacharyZhang-NY a6c044f009 T53: Ely's window shows nothing but her, which the owner asked for after a user's 0.1.4 drew a hairline along the top of her box on macOS: her panel turns borderless as it is glued, style mask 0x8081 to 0x80, without the titled frame gpui's popup carries, whose edge macOS draws; a failed glue closes her window, where it stayed open, unplaced, while the log said she did not show
CI / platforms (windows-latest) (push) Successful in 1m32s
CI / platforms (ubuntu-24.04) (push) Successful in 1m39s
CI / macos (push) Canceled after 0s
2026-10-19 02:50:23 -04:00
ZacharyZhang-NY b7377e424e T52: reviewed, ticked
CI / platforms (ubuntu-24.04) (push) Successful in 1m21s
CI / platforms (windows-latest) (push) Successful in 1m32s
CI / macos (push) Canceled after 0s
2026-10-19 02:39:38 -04:00
ZacharyZhang-NY 0eb8fc5c4e T52: a press wakes Ely from her doze, which the owner asked for after 0.1.4, where only a new mood woke her: calm lasts 5 minutes from her mood's start or the last press before she dozes, so after a press she stays awake 5 minutes, then dozes again
CI / platforms (ubuntu-24.04) (push) Successful in 1m29s
CI / platforms (windows-latest) (push) Successful in 1m31s
CI / macos (push) Canceled after 0s
2026-10-19 02:35:13 -04:00
ZacharyZhang-NY dbb19caaf8 T51: reviewed, ticked
CI / platforms (ubuntu-24.04) (push) Successful in 1m20s
CI / platforms (windows-latest) (push) Successful in 1m32s
CI / macos (push) Canceled after 9m33s
2026-10-19 02:32:57 -04:00
ZacharyZhang-NY 15ef5d52d0 T51: Ely stands inside the main window on its pane's bottom edge while her box would not fit above it, which the owner asked for after 0.1.4, where on a window at the screen's top or full screen she stuck between the menu bar and the terminal: each platform measures the room above the pane up to its display's work area, macOS's visibleFrame, Windows' rcWork, X11's _NET_WORKAREA, and on Wayland, which tells a client no place, she stands inside while the window is full screen, maximized or tiled at its top
CI / platforms (windows-latest) (push) Successful in 1m38s
CI / platforms (ubuntu-24.04) (push) Successful in 2m21s
CI / macos (push) Successful in 12m50s
2026-10-19 01:55:59 -04:00
ZacharyZhang-NY 7032285d13 T50: reviewed, ticked
CI / platforms (ubuntu-24.04) (push) Canceled after 30s
CI / macos (push) Canceled after 31s
CI / platforms (windows-latest) (push) Canceled after 44s
2026-10-18 15:19:39 -04:00
ZacharyZhang-NY 5d109790c8 T50: v0.1.4 rebuilt with T48 and T49 at a54f4ff, its three builds from their scripts, the zip on the owner's PC and the tarball in its WSL, the disk image signed and notarized by the Release workflow, each in place of the first; the tag and the release's target moved to a54f4ff, and the notes give the new SHA-256
CI / macos (push) Canceled after 57s
CI / platforms (ubuntu-24.04) (push) Canceled after 1m4s
CI / platforms (windows-latest) (push) Canceled after 1m13s
2026-10-18 15:10:54 -04:00
ZacharyZhang-NY a54f4ff42d T49: reviewed, ticked
CI / macos (push) Canceled after 0s
CI / platforms (ubuntu-24.04) (push) Canceled after 27s
CI / platforms (windows-latest) (push) Canceled after 43s
2026-10-18 14:54:38 -04:00
ZacharyZhang-NY a9be8ab8c4 T49: round 1 fix: a change of mood, though the act stays as inside a wink, and a press each ease her from the pose she was in, where a mood that changed mid-hop dropped her 12 points and an old finish cleared mid-glance snapped her eyes back; her brows ease with her
CI / platforms (ubuntu-24.04) (push) Successful in 1m16s
CI / platforms (windows-latest) (push) Successful in 1m52s
CI / macos (push) Successful in 16m9s
2026-10-18 14:49:34 -04:00