ZacharyZhang-NY/omarchycn
3
4
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 5 Wiki Activity

Match the Windows VM title regardless of the launcher's shell quoting

Browse Source 
The new assertion pinned /title:"Windows VM - Omarchy" with the quote sitting
immediately after the colon. That quote is incidental shell syntax, not the
title the Hyprland rule matches on. Open PR #7902 moves the RDP arguments into
an array, where the same flag reads "/title:Windows VM - Omarchy", so the
assertion would fail for whichever of the two pull requests merged second.

Allow an optional quote after the colon. The assertion still fails if the title
itself drifts, in either direction, which is the coupling it exists to protect.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
David Heinemeier Hansson
2026-08-25 08:45:50 +02:00
co-authored by Claude Opus 5
parent 8bee78bc63
commit 12c350e404
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/shell.d/windows-vm-test.sh
+3 -1
View File
@@ -16,7 +16,9 @@ if rg -q '^ restart: unless-stopped$' "$windows_vm_command"; then
fi
pass "Windows VM does not restart automatically at boot"
rg -q '/title:"Windows VM - Omarchy"' "$windows_vm_command" ||
# Tolerate either shell quoting of the argument -- what must not drift is the
# title itself, since the Hyprland rule below matches on it.
rg -q 'title:"?Windows VM - Omarchy"' "$windows_vm_command" ||
fail "Windows VM launches FreeRDP with its expected title"
rg -q 'class = "\^xfreerdp\$", title = "\^Windows VM - Omarchy\$"' "$windows_vm_rules" ||
fail "Windows VM opacity rule targets its FreeRDP window"